March 2025 - gerrit-log - lists.osmocom.org

[L] Change in docker-playground[master]: nplab-{m3ua,sua}-test: Record pcap of all testsuite run

by pespin

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email ) Change subject: nplab-{m3ua,sua}-test: Record pcap of all testsuite run ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/39770/comment/f497f545_12a… : PS3, Line 8: > maybe note here that tcpdump-{start,stop}.sh were imported from osmo-ttcn3-hacks. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If4ea74c07d5aaca1278811ce8398dff23c386c10 Gerrit-Change-Number: 39770 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 12 Mar 2025 13:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[L] Change in docker-playground[master]: nplab-{m3ua,sua}-test: Record pcap of all testsuite run

by pespin

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by osmith The change is no longer submittable: Code-Review is unsatisfied now. Change subject: nplab-{m3ua,sua}-test: Record pcap of all testsuite run ...................................................................... nplab-{m3ua,sua}-test: Record pcap of all testsuite run Scripts are cherry-picked from osmo-ttcn3-hacks.git/ttcn3-tcpdump-{start,stop}.sh, 8fc1b2152ff7615f610e7a040cb3b5135dfc5351. Change-Id: If4ea74c07d5aaca1278811ce8398dff23c386c10 --- A common/tcpdump-start.sh A common/tcpdump-stop.sh M debian-buster-build/Dockerfile M nplab-m3ua-test/Dockerfile M nplab-m3ua-test/jenkins.sh M nplab-m3ua-test/osmo-stp.cfg A nplab-m3ua-test/test.sh M nplab-sua-test/Dockerfile M nplab-sua-test/jenkins.sh M nplab-sua-test/osmo-stp.cfg A nplab-sua-test/test.sh 11 files changed, 239 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/70/39770/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If4ea74c07d5aaca1278811ce8398dff23c386c10 Gerrit-Change-Number: 39770 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: trau: new function osmo_trau2rtp_ufe()

by pespin

Attention is currently required from: falconia, fixeria, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email ) Change subject: trau: new function osmo_trau2rtp_ufe() ...................................................................... Patch Set 2: (8 comments) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/70624bbd_9a2f4402… : PS2, Line 137: * \param[in] emit_twts001 self-explanatory It may be self explanatory to you, but no to others. Please add something like: "Generate RTP in TW-TS-001 format" or whatever the name of the spec it is. Also some reference to where that spec may be found may be useful. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/fdc67bf4_d40bb9ab… : PS2, Line 249: * \param[in] emit_twts002 self-explanatory Same, not self-explanatory. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/709a0765_7e449ffe… : PS2, Line 260: return -EINVAL; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/2f37b122_7e897240… : PS2, Line 263: return -ENOSPC; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/0e5f26ca_73593e19… : PS2, Line 282: return 0; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/efec54d5_b24b092f… : PS2, Line 299: return 1; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/2355f03b_455a8f19… : PS2, Line 311: return GSM_HR_BYTES_RTP_RFC5993; ufe is left uninitialized here. https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03… : PS2, Line 359: Let's better initialize ufe always if present, to avoid uninitialized memory. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9 Gerrit-Change-Number: 39731 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Mar 2025 12:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 4 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: stream_{cli,srv}: fix copy-paste in API docs

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email ) Change subject: stream_{cli,srv}: fix copy-paste in API docs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I8ec783b8db36a017dc3fe111b0ca0938488ae03d Gerrit-Change-Number: 39775 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Mar 2025 12:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 4 weeks

1
0
0 0

[XL] Change in osmo-asf4-dfu[master]: bl updater app

by Hoernchen

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email ) Change subject: bl updater app ...................................................................... Patch Set 11: (1 comment) File atmel_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8470664b_844aa75… : PS7, Line 9: // do not init usb here: might not be needed. > might be useful to state those cases or some example of it? the original bl would have required a comment that justifies why it attaches to the bus for no reason and hopes the firmware starts fast enough. this behaves as expected, the bootloader just.. bootloads all the things, there is no usb invovled. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 Gerrit-Change-Number: 39434 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 12 Mar 2025 12:19:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

by Hoernchen

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... Patch Set 12: (2 comments) File crc_code.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ca6428e5_5ae9e5d… : PS10, Line 102: // uint32_t length = strtoul(argv[3], NULL, 16); > can this commented out code be removed? I guess every C developer knows that diferent base arguments […] Done File crc_params.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/67c3abd4_39ba744… : PS10, Line 5: // __attribute__((used, section(".crc_par"))) const uint32_t __CRC_End = 0xFFFFFFFF; /* Placeholder */ > why do we have this commented-out code here? is this some earlier attempts? shouldn't it be removed? those still exist in the ld file and might be needed in case the linker, gcc, make, objdump, objcopy, or any other part of this brittle house of cards breaks again and I need anther approach to patch the files. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 12 Mar 2025 12:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

by Hoernchen

Attention is currently required from: Hoernchen, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: add fw update crcstub ...................................................................... add fw update crcstub Adds a crc stub that lives in front of the dfu bl updater app and checks it. The whole process is somewhat complicated to ensure we end up not just with a firmware file that contains the right crc for the right offsets, but the elf file is updated as well, to ensure the result is debuggable as-is. The stub is built as part of the firmware code, and ends up in its own section. Linker script padding and alignment ensures that this works. Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed --- A crc_code.c A crc_params.c M gcc/Makefile M gcc/gcc/same54p20a_dfu.ld M gcc/gcc/same54p20a_flash.ld M gcc/gcc/startup_same54.c M usb_dfu_main.c M usb_flash_main.c M usb_start.c 9 files changed, 246 insertions(+), 104 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/37/39437/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 13 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: pcap-server: Validate rolling over file was successful before writing...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39773?usp=email ) Change subject: pcap-server: Validate rolling over file was successful before writing to it ...................................................................... pcap-server: Validate rolling over file was successful before writing to it If reopening the file fails (eg. disk full), we'd end up with a null conn->wrf pointer there which would segfault in osmo_pcap_wr_file_write_msgb() immediatelly below. Change-Id: I103d3f66bf40c68db1a20a987bc984989c91b447 --- M src/osmo_server_core.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo_server_core.c b/src/osmo_server_core.c index cebc70a..77d916a 100644 --- a/src/osmo_server_core.c +++ b/src/osmo_server_core.c @@ -543,6 +543,13 @@ if (!check_restart_pcap_max_size(conn, msgb_length(msg))) check_restart_pcap_localtime(conn, now); + /* Since the checks above may have closed and re-opened (and could have + * failed), check again whether new wrf is ready... */ + if (!conn->wrf) { + LOGP(DSERVER, LOGL_ERROR, "No file is open. close connection.\n"); + return -1; + } + talloc_steal(conn->wrf, msg); rc = osmo_pcap_wr_file_write_msgb(conn->wrf, msg); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I103d3f66bf40c68db1a20a987bc984989c91b447 Gerrit-Change-Number: 39773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: pcap-server: Avoid closing cli conn if writing to disk fails

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39772?usp=email ) Change subject: pcap-server: Avoid closing cli conn if writing to disk fails ...................................................................... pcap-server: Avoid closing cli conn if writing to disk fails Related: SYS#7374 Change-Id: I06b20a17fae064a74e2acdc4549df400ad9c4930 --- M src/osmo_server_core.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_server_core.c b/src/osmo_server_core.c index 9629423..cebc70a 100644 --- a/src/osmo_server_core.c +++ b/src/osmo_server_core.c @@ -547,8 +547,9 @@ rc = osmo_pcap_wr_file_write_msgb(conn->wrf, msg); if (rc < 0) { LOGP(DSERVER, LOGL_ERROR, "%s: Failed writing to file\n", conn->name); - /* msgb will be freed by caller */ - return -1; + msgb_free(msg); + /* Avoid closing conn. msgb won't be freed by caller */ + return 0; } update_last_write(conn, now); /* msgb is now owned by conn->wrf. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I06b20a17fae064a74e2acdc4549df400ad9c4930 Gerrit-Change-Number: 39772 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: pcap-server: Validate rolling over file was successful before writing...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39773?usp=email ) Change subject: pcap-server: Validate rolling over file was successful before writing to it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I103d3f66bf40c68db1a20a987bc984989c91b447 Gerrit-Change-Number: 39773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Mar 2025 12:10:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025