March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39687?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I0a77ff4c0a880230116a361651c78c77328db989 --- M include/osmocom/hlr/hlr_vty.h M src/hlr.c M src/hlr_vty.c 3 files changed, 0 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/87/39687/1 diff --git a/include/osmocom/hlr/hlr_vty.h b/include/osmocom/hlr/hlr_vty.h index 8601590..10ea8b7 100644 --- a/include/osmocom/hlr/hlr_vty.h +++ b/include/osmocom/hlr/hlr_vty.h @@ -48,7 +48,6 @@ #define A38_COMP128_KEY_LEN 16 #define MILENAGE_KEY_LEN 16 -int hlr_vty_is_config_node(struct vty *vty, int node); int hlr_vty_go_parent(struct vty *vty); void hlr_vty_init(void *hlr_ctx); void dgsm_vty_init(void); diff --git a/src/hlr.c b/src/hlr.c index a900e23..0cfa09a 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -754,7 +754,6 @@ .name = "OsmoHLR", .version = PACKAGE_VERSION, .copyright = vlr_copyright, - .is_config_node = hlr_vty_is_config_node, .go_parent_cb = hlr_vty_go_parent, }; diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 4694c44..18861d2 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -881,18 +881,6 @@ return vty->node; } -int hlr_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - /* add items that are not config */ - case CONFIG_NODE: - return 0; - - default: - return 1; - } -} - void hlr_vty_init(void *hlr_ctx) { cfg_reject_cause_cmd.string = -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I0a77ff4c0a880230116a361651c78c77328db989 Gerrit-Change-Number: 39687 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcu[master]: Drop function declaration for non longer existing function
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39686?usp=email ) Change subject: Drop function declaration for non longer existing function ...................................................................... Drop function declaration for non longer existing function Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I999ac55fca21cf942876bc19c19f0eda2754501b Fixes: 1ec29c7324e69a6f294704fb8eeb093a33085aba --- M src/pcu_vty.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/86/39686/1 diff --git a/src/pcu_vty.h b/src/pcu_vty.h index 45d3227..8178e11 100644 --- a/src/pcu_vty.h +++ b/src/pcu_vty.h @@ -9,9 +9,6 @@ PCU_NODE = _LAST_OSMOVTY_NODE + 1, }; -int pcu_vty_go_parent(struct vty *vty); -int pcu_vty_is_config_node(struct vty *vty, int node); - int pcu_vty_init(); extern struct vty_app_info pcu_vty_info; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I999ac55fca21cf942876bc19c19f0eda2754501b Gerrit-Change-Number: 39686 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ggsn[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39685?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ief57c4ce98055e5063aafc53cb8330d3bd95d323 --- M ggsn/ggsn_vty.c 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/85/39685/1 diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index b0f07fe..534b3d2 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -1124,17 +1124,6 @@ return 0; } -static int ggsn_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case GGSN_NODE: - case APN_NODE: - return 1; - default: - return 0; - } -} - static int ggsn_vty_go_parent(struct vty *vty) { switch (vty->node) { @@ -1174,5 +1163,4 @@ .version = PACKAGE_VERSION, .copyright = ggsn_copyright, .go_parent_cb = ggsn_vty_go_parent, - .is_config_node = ggsn_vty_is_config_node, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ief57c4ce98055e5063aafc53cb8330d3bd95d323 Gerrit-Change-Number: 39685 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/39684?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Id6620095af153781cde926458f54fed5bd51a9e7 --- M src/osmo-msc/msc_main.c 1 file changed, 0 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/84/39684/1 diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 2238e2b..2435029 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -354,29 +354,10 @@ return vty->node; } -static int msc_vty_is_config_node(struct vty *vty, int node) -{ - /* Check if libosmo-sigtran declares the node in - * question as config node */ - if (osmo_ss7_is_config_node(vty, node)) - return 1; - - switch (node) { - /* add items that are not config */ - case SUBSCR_NODE: - case CONFIG_NODE: - return 0; - - default: - return 1; - } -} - static struct vty_app_info msc_vty_info = { .name = "OsmoMSC", .version = PACKAGE_VERSION, .go_parent_cb = msc_vty_go_parent, - .is_config_node = msc_vty_is_config_node, }; #define DEFAULT_M3UA_LOCAL_IP "localhost" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id6620095af153781cde926458f54fed5bd51a9e7 Gerrit-Change-Number: 39684 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-mgw[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39683?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ifdecb35f329c243222bc5d77f0a6d394c9413684 --- M src/osmo-mgw/mgw_main.c 1 file changed, 1 insertion(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/83/39683/1 diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c index 0b66184..96e424f 100644 --- a/src/osmo-mgw/mgw_main.c +++ b/src/osmo-mgw/mgw_main.c @@ -249,17 +249,6 @@ return 0; } -int mgcp_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case CONFIG_NODE: - return 0; - - default: - return 1; - } -} - int mgcp_vty_go_parent(struct vty *vty) { switch (vty->node) { @@ -269,7 +258,7 @@ break; case MGCP_NODE: default: - if (mgcp_vty_is_config_node(vty, vty->node)) + if (vty->node != CONFIG_NODE) vty->node = CONFIG_NODE; else vty->node = ENABLE_NODE; @@ -310,7 +299,6 @@ .name = "OsmoMGW", .version = PACKAGE_VERSION, .go_parent_cb = mgcp_vty_go_parent, - .is_config_node = mgcp_vty_is_config_node, }; static const struct log_info_cat log_categories[] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifdecb35f329c243222bc5d77f0a6d394c9413684 Gerrit-Change-Number: 39683 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39682?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Fixes: 4e934bb546e173ea525d778983cccce8f7c563c0 Change-Id: Idaad5148c7ca486b84bd67ad2ad90b96c3126316 --- M include/osmo-pcap/common.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/82/39682/1 diff --git a/include/osmo-pcap/common.h b/include/osmo-pcap/common.h index 7ac5bb0..5916c48 100644 --- a/include/osmo-pcap/common.h +++ b/include/osmo-pcap/common.h @@ -56,7 +56,6 @@ extern const struct log_info log_info; extern const char *osmopcap_copyright; extern int osmopcap_go_parent(struct vty *vty); -extern int osmopcap_is_config_node(struct vty *vty, int node); /* defined in libpcap's pcap-int.h, which is not public */ #ifndef MAXIMUM_SNAPLEN -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idaad5148c7ca486b84bd67ad2ad90b96c3126316 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sysmon[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/39681?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ib10b939fbec2620b22c739c57aecbf9d45c27898 --- M src/osysmon_main.c 1 file changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/81/39681/1 diff --git a/src/osysmon_main.c b/src/osysmon_main.c index 2d5ebfa..0794630 100644 --- a/src/osysmon_main.c +++ b/src/osysmon_main.c @@ -44,16 +44,6 @@ return vty->node; } -static int osysmon_is_config_node(struct vty *vty, int node) -{ - switch (node) { - /* no non-config-nodes */ - default: - return 1; - } -} - - static struct vty_app_info vty_info = { .name = "osysmon", .copyright = @@ -63,7 +53,6 @@ "There is NO WARRANTY, to the extent permitted by law.\r\n", .version = PACKAGE_VERSION, .go_parent_cb = osysmon_go_parent, - .is_config_node = osysmon_is_config_node, }; struct osysmon_state *g_oss; -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/39681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: Ib10b939fbec2620b22c739c57aecbf9d45c27898 Gerrit-Change-Number: 39681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-cbc[master]: Drop unnecessary static initialization to NULL
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/39680?usp=email ) Change subject: Drop unnecessary static initialization to NULL ...................................................................... Drop unnecessary static initialization to NULL Moreover, this callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I68ed65537eb6f33ef666a79ddef70b46c995e0e7 --- M src/cbc_main.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/80/39680/1 diff --git a/src/cbc_main.c b/src/cbc_main.c index c777ef6..2de8c72 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -147,7 +147,6 @@ .copyright = cbc_copyright, .go_parent_cb = cbc_vty_go_parent, .version = PACKAGE_VERSION, - .is_config_node = NULL, }; static struct { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/39680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I68ed65537eb6f33ef666a79ddef70b46c995e0e7 Gerrit-Change-Number: 39680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39679?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ib0d0079c76a18b09cde6ef3f22dda618ff5fbc98 --- M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7_vty.c M stp/stp_main.c 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/79/39679/1 diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 51c1cbd..66cbfe6 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -354,4 +354,6 @@ void osmo_ss7_vty_init_asp(void *ctx); void osmo_ss7_vty_init_sg(void *ctx); int osmo_ss7_vty_go_parent(struct vty *vty); -int osmo_ss7_is_config_node(struct vty *vty, int node); +int osmo_ss7_is_config_node(struct vty *vty, int node) + OSMO_DEPRECATED("Implicit parent node tracking has replaced the use of this callback. " + "This callback is no longer called, ever, and can be left NULL."); diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 8365db2..f76a69e 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -3042,6 +3042,8 @@ return 0; } +/* This is no longer used. The libosmocore callback was deprecated is not ever called since. + * libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). */ int osmo_ss7_is_config_node(struct vty *vty, int node) { switch (node) { diff --git a/stp/stp_main.c b/stp/stp_main.c index d630032..2d31ef0 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -73,7 +73,6 @@ .copyright = stp_copyright, .version = PACKAGE_VERSION, .go_parent_cb = osmo_ss7_vty_go_parent, - .is_config_node = osmo_ss7_is_config_node, }; static struct { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib0d0079c76a18b09cde6ef3f22dda618ff5fbc98 Gerrit-Change-Number: 39679 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: Drop use of deprecated vty is_config_node() cb
by pespin 04 Mar '25

04 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/39678?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I1bbaa455c018ba9c0943ac3cf1ae5511ebb4b723 --- M CommonLibs/trx_vty.c 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/78/39678/1 diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c index bd1b0ce..9647722 100644 --- a/CommonLibs/trx_vty.c +++ b/CommonLibs/trx_vty.c @@ -781,17 +781,6 @@ return CMD_SUCCESS; } -static int trx_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case TRX_NODE: - case CHAN_NODE: - return 1; - default: - return 0; - } -} - static int trx_vty_go_parent(struct vty *vty) { switch (vty->node) { @@ -829,7 +818,6 @@ .version = PACKAGE_VERSION, .copyright = trx_copyright, .go_parent_cb = trx_vty_go_parent, - .is_config_node = trx_vty_is_config_node, }; struct trx_ctx *vty_trx_ctx_alloc(void *talloc_ctx) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1bbaa455c018ba9c0943ac3cf1ae5511ebb4b723 Gerrit-Change-Number: 39678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0