March 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: es9p_Types_JSON: add decoder/encoder functions for opposite direction
by dexter 05 Mar '25

05 Mar '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39656?usp=email ) Change subject: es9p_Types_JSON: add decoder/encoder functions for opposite direction ...................................................................... es9p_Types_JSON: add decoder/encoder functions for opposite direction We currently only have ES9p encoder/decoder functions to emulate an ES9p server, however, we will need to emulate ES9p clients too Change-Id: Ic7e3390bd09cc9e0c91ca90ac60cdde5d2ce1384 Related: SYS#7339 --- M library/euicc/es9p_Types_JSON.ttcn 1 file changed, 88 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/euicc/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn index 79d5381..601ea8f 100644 --- a/library/euicc/es9p_Types_JSON.ttcn +++ b/library/euicc/es9p_Types_JSON.ttcn @@ -163,6 +163,94 @@ } } with { extension "prototype(fast)" } +/* Converter function to encode an ASN.1 ES9+ request record to its JSON formatted ES9+ representation */ +function enc_RemoteProfileProvisioningRequest_to_JSON(in RemoteProfileProvisioningRequest asn1_pdu_dec, out charstring json_pdu_enc) { + var JSON_ES9p_RemoteProfileProvisioningRequest json_pdu; + + var charstring functionRequesterIdentifier := "TTCN3"; + var charstring functionCallIdentifier := "testsuite"; + + if (ispresent(asn1_pdu_dec.initiateAuthenticationRequest)) { + json_pdu.initiateAuthenticationRequest.header.functionRequesterIdentifier := functionRequesterIdentifier; + json_pdu.initiateAuthenticationRequest.header.functionCallIdentifier := functionCallIdentifier; + json_pdu.initiateAuthenticationRequest.euiccChallenge := encode_base64(asn1_pdu_dec.initiateAuthenticationRequest.euiccChallenge); + json_pdu.initiateAuthenticationRequest.smdpAddress := unichar2char(asn1_pdu_dec.initiateAuthenticationRequest.smdpAddress); + json_pdu.initiateAuthenticationRequest.euiccInfo1 := encode_base64(enc_EUICCInfo1(asn1_pdu_dec.initiateAuthenticationRequest.euiccInfo1)); + json_pdu_enc := oct2char(enc_JSON_ES9p_RemoteProfileProvisioningRequest(json_pdu)); + } else if (ispresent(asn1_pdu_dec.getBoundProfilePackageRequest)) { + json_pdu.getBoundProfilePackageRequest.header.functionRequesterIdentifier := functionRequesterIdentifier; + json_pdu.getBoundProfilePackageRequest.header.functionCallIdentifier := functionCallIdentifier; + json_pdu.getBoundProfilePackageRequest.transactionId := oct2str(asn1_pdu_dec.getBoundProfilePackageRequest.transactionId); + json_pdu.getBoundProfilePackageRequest.prepareDownloadResponse := + encode_base64(enc_PrepareDownloadResponse(asn1_pdu_dec.getBoundProfilePackageRequest.prepareDownloadResponse)); + json_pdu_enc := oct2char(enc_JSON_ES9p_RemoteProfileProvisioningRequest(json_pdu)); + } else if (ispresent(asn1_pdu_dec.authenticateClientRequest)) { + json_pdu.authenticateClientRequest.header.functionRequesterIdentifier := functionRequesterIdentifier; + json_pdu.authenticateClientRequest.header.functionCallIdentifier := functionCallIdentifier; + json_pdu.authenticateClientRequest.transactionId := oct2str(asn1_pdu_dec.authenticateClientRequest.transactionId); + json_pdu.authenticateClientRequest.authenticateServerResponse := + encode_base64(enc_AuthenticateServerResponse(asn1_pdu_dec.authenticateClientRequest.authenticateServerResponse)) + json_pdu_enc := oct2char(enc_JSON_ES9p_RemoteProfileProvisioningRequest(json_pdu)); + } else if (ispresent(asn1_pdu_dec.handleNotification)) { + json_pdu.handleNotification.header.functionRequesterIdentifier := functionRequesterIdentifier; + json_pdu.handleNotification.header.functionCallIdentifier := functionCallIdentifier; + json_pdu.handleNotification.pendingNotification := + encode_base64(enc_PendingNotification(asn1_pdu_dec.handleNotification.pendingNotification)) + json_pdu_enc := oct2char(enc_JSON_ES9p_RemoteProfileProvisioningRequest(json_pdu)); + } else if (ispresent(asn1_pdu_dec.cancelSessionRequestEs9)) { + json_pdu.cancelSessionRequestEs9.header.functionRequesterIdentifier := functionRequesterIdentifier; + json_pdu.cancelSessionRequestEs9.header.functionCallIdentifier := functionCallIdentifier; + json_pdu.cancelSessionRequestEs9.transactionId := oct2str(asn1_pdu_dec.cancelSessionRequestEs9.transactionId); + json_pdu.cancelSessionRequestEs9.cancelSessionResponse := + encode_base64(enc_CancelSessionResponse(asn1_pdu_dec.cancelSessionRequestEs9.cancelSessionResponse)) + json_pdu_enc := oct2char(enc_JSON_ES9p_RemoteProfileProvisioningRequest(json_pdu)); + } else { + setverdict(fail, "encoder path not implemented for JSON ES9+ message"); + } +} with { extension "prototype(fast)" } + +/* Converter function to decode a JSON formatted ES9+ response to its ASN.1 ES9+ record representation */ +function dec_RemoteProfileProvisioningResponse_from_JSON(in charstring json_pdu_enc, out RemoteProfileProvisioningResponse asn1_pdu_dec) { + var JSON_ES9p_RemoteProfileProvisioningResponse json_pdu; + json_pdu := dec_JSON_ES9p_RemoteProfileProvisioningResponse(char2oct(json_pdu_enc)); + + if (ispresent(json_pdu.initiateAuthenticationResponse)) { + if (not match(json_pdu.initiateAuthenticationResponse.header, ts_responseHeader)) { + setverdict(fail, "unsuccessful request"); + } + asn1_pdu_dec := valueof(ts_initiateAuthenticationResponse( + str2oct(json_pdu.initiateAuthenticationResponse.transactionId), + dec_ServerSigned1(decode_base64(json_pdu.initiateAuthenticationResponse.serverSigned1)), + decode_base64(json_pdu.initiateAuthenticationResponse.serverSignature1), + dec_SubjectKeyIdentifier(decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdToBeUsed)), + dec_Certificate(decode_base64(json_pdu.initiateAuthenticationResponse.serverCertificate)))); + } else if (ispresent(json_pdu.getBoundProfilePackageResponse)) { + if (not match(json_pdu.getBoundProfilePackageResponse.header, ts_responseHeader)) { + setverdict(fail, "unsuccessful request"); + } + asn1_pdu_dec := valueof(ts_getBoundProfilePackageResponse( + str2oct(json_pdu.getBoundProfilePackageResponse.transactionId), + dec_BoundProfilePackage(decode_base64(json_pdu.getBoundProfilePackageResponse.boundProfilePackage)))); + } else if (ispresent(json_pdu.authenticateClientResponseEs9)) { + if (not match(json_pdu.authenticateClientResponseEs9.header, ts_responseHeader)) { + setverdict(fail, "unsuccessful request"); + } + asn1_pdu_dec := valueof(ts_authenticateClientResponseEs9( + str2oct(json_pdu.authenticateClientResponseEs9.transactionId), + dec_StoreMetadataRequest(decode_base64(json_pdu.authenticateClientResponseEs9.profileMetadata)), + dec_SmdpSigned2(decode_base64(json_pdu.authenticateClientResponseEs9.smdpSigned2)), + decode_base64(json_pdu.authenticateClientResponseEs9.smdpSignature2), + dec_Certificate(decode_base64(json_pdu.authenticateClientResponseEs9.smdpCertificate)))); + } else if (ispresent(json_pdu.emptyResponse)) { + if (not match(json_pdu.emptyResponse.header, ts_responseHeader)) { + setverdict(fail, "unsuccessful request"); + } + /* Empty response, do nothing? */ + } else { + setverdict(fail, "decoder path not implemented for JSON ES9+ message"); + } +} with { extension "prototype(fast)" } + /* Converter function to encode an ASN.1 ES9+ response record to its JSON formatted ES9+ representation */ function enc_RemoteProfileProvisioningResponse_to_JSON(in RemoteProfileProvisioningResponse asn1_pdu_dec, out charstring json_pdu_enc) { var JSON_ES9p_RemoteProfileProvisioningResponse json_pdu; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic7e3390bd09cc9e0c91ca90ac60cdde5d2ce1384 Gerrit-Change-Number: 39656 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add missing default values
by dexter 05 Mar '25

05 Mar '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39655?usp=email ) Change subject: RSPDefinitions_Templates: add missing default values ...................................................................... RSPDefinitions_Templates: add missing default values The template parameters of some templates lack a reasonable default. Let's add default values to those. Related: SYS#7339 Change-Id: Ia55d17a00462c7c7729eb0d8d24ab0556c4c6918 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 2a7df8b..f717d6a 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -209,6 +209,13 @@ bppEuiccOtpk := omit } +template (present) PendingNotification tr_pendingNotification(template (present) ProfileInstallationResult profileInstallationResult := ?) := { + profileInstallationResult := profileInstallationResult +} +template (value) PendingNotification ts_pendingNotification(template (value) ProfileInstallationResult profileInstallationResult := ts_profileInstallationResult) := { + profileInstallationResult := profileInstallationResult +} + /* GSMA SGP.22, section 2.5.6 */ template (present) ProfileInstallationResultData tr_profileInstallationResultData(template (present) charstring notificationAddress := ?) := { @@ -352,8 +359,8 @@ } } template (value) RemoteProfileProvisioningRequest -ts_authenticateClientRequest(template (value) octetstring transactionId, - template (value) AuthenticateServerResponse authenticateServerResponse) := { +ts_authenticateClientRequest(template (value) octetstring transactionId := 'AABBCC'O, + template (value) AuthenticateServerResponse authenticateServerResponse := ts_authenticateServerResponse) := { authenticateClientRequest := { transactionId := transactionId, authenticateServerResponse := authenticateServerResponse @@ -400,7 +407,7 @@ } } template (value) RemoteProfileProvisioningRequest -ts_handleNotification(template (value) PendingNotification pendingNotification) := { +ts_handleNotification(template (value) PendingNotification pendingNotification := ts_pendingNotification) := { handleNotification := { pendingNotification := pendingNotification } @@ -416,8 +423,8 @@ } } template (value) RemoteProfileProvisioningRequest -ts_cancelSessionRequestEs9(template (value) octetstring transactionId, - template (value) CancelSessionResponse cancelSessionResponse) := { +ts_cancelSessionRequestEs9(template (value) octetstring transactionId := 'ABCDEF'O, + template (value) CancelSessionResponse cancelSessionResponse := ts_cancelSessionResponse) := { cancelSessionRequestEs9 := { transactionId := transactionId, cancelSessionResponse := cancelSessionResponse -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia55d17a00462c7c7729eb0d8d24ab0556c4c6918 Gerrit-Change-Number: 39655 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: es9p_Types_JSON: split headers into separate module
by dexter 05 Mar '25

05 Mar '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39654?usp=email ) Change subject: es9p_Types_JSON: split headers into separate module ...................................................................... es9p_Types_JSON: split headers into separate module The headers used in the JSON binding of ES9+ are also used in ES2+, ES11 and ES12. Let's split the headers into a separate module, so that we can re-use them in other definitions too. Change-Id: I0242c877805003fa67445800960f75ce27752383 Related: SYS#7339 --- M eim/gen_links.sh M library/euicc/es9p_Types_JSON.ttcn A library/euicc/esx_header_Types_JSON.ttcn 3 files changed, 63 insertions(+), 25 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/eim/gen_links.sh b/eim/gen_links.sh index 1996da9..9fa3ac2 100755 --- a/eim/gen_links.sh +++ b/eim/gen_links.sh @@ -36,7 +36,7 @@ FILES+="PKIX1Implicit88_Types.ttcn RSPDefinitions_Templates.ttcn RSPDefinitions_Types.ttcn " FILES+="SGP32Definitions_Templates.ttcn SGP32Definitions_Types.ttcn " FILES+="PKIX1Explicit88_EncDec.cc PKIX1Implicit88_EncDec.cc RSPDefinitions_EncDec.cc SGP32Definitions_EncDec.cc " -FILES+="es9p_Types_JSON.ttcn" +FILES+="es9p_Types_JSON.ttcn esx_header_Types_JSON.ttcn" gen_links $DIR $FILES DIR=../library diff --git a/library/euicc/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn index 5a8587b..79d5381 100644 --- a/library/euicc/es9p_Types_JSON.ttcn +++ b/library/euicc/es9p_Types_JSON.ttcn @@ -10,6 +10,8 @@ module es9p_Types_JSON { +import from esx_header_Types_JSON all; + import from RSPDefinitions all; import from RSPDefinitions_Types all; import from RSPDefinitions_Templates all; @@ -22,30 +24,15 @@ import from PKIX1Implicit88_Templates all; import from PKIX1Implicit88_Types all; - -/* GSMA SGP.22, section 6.5.1.3 */ -type record JSON_ES9p_RequestHeader { - charstring functionRequesterIdentifier, - charstring functionCallIdentifier -}; - -/* GSMA SGP.22, section 6.5.1.4 */ -type record JSON_ES9p_FunctionExecutionStatus { - charstring status -}; -type record JSON_ES9p_ResponseHeader { - JSON_ES9p_FunctionExecutionStatus functionExecutionStatus -}; - /* GSMA SGP.22, section 6.5.2.6 */ type record JSON_ES9p_InitiateAuthenticationRequest { - JSON_ES9p_RequestHeader header, + JSON_ESx_RequestHeader header, charstring euiccChallenge, charstring euiccInfo1, charstring smdpAddress }; type record JSON_ES9p_InitiateAuthenticationResponse { - JSON_ES9p_ResponseHeader header, + JSON_ESx_ResponseHeader header, charstring transactionId, charstring serverSigned1, charstring serverSignature1, @@ -55,24 +42,24 @@ /* GSMA SGP.22, section 6.5.2.7 */ type record JSON_ES9p_GetBoundProfilePackageRequest { - JSON_ES9p_RequestHeader header, + JSON_ESx_RequestHeader header, charstring transactionId, charstring prepareDownloadResponse }; type record JSON_ES9p_GetBoundProfilePackageResponse { - JSON_ES9p_ResponseHeader header, + JSON_ESx_ResponseHeader header, charstring transactionId, charstring boundProfilePackage }; /* GSMA SGP.22, section 6.5.2.8 */ type record JSON_ES9p_AuthenticateClientRequest { - JSON_ES9p_RequestHeader header, + JSON_ESx_RequestHeader header, charstring transactionId, charstring authenticateServerResponse }; type record JSON_ES9p_AuthenticateClientResponseEs9 { - JSON_ES9p_ResponseHeader header, + JSON_ESx_ResponseHeader header, charstring transactionId, charstring profileMetadata, charstring smdpSigned2, @@ -82,20 +69,20 @@ /* GSMA SGP.22, section 6.5.2.9 */ type record JSON_ES9p_HandleNotification { - JSON_ES9p_RequestHeader header, + JSON_ESx_RequestHeader header, charstring pendingNotification }; /* GSMA SGP.22, section 6.5.2.10 */ type record JSON_ES9p_CancelSessionRequestEs9 { - JSON_ES9p_RequestHeader header, + JSON_ESx_RequestHeader header, charstring transactionId, charstring cancelSessionResponse }; /* An empty response that is used when the response only consists of a JSON header */ type record JSON_ES9p_EmptyResponse { - JSON_ES9p_ResponseHeader header + JSON_ESx_ResponseHeader header }; diff --git a/library/euicc/esx_header_Types_JSON.ttcn b/library/euicc/esx_header_Types_JSON.ttcn new file mode 100644 index 0000000..4a4f4ca --- /dev/null +++ b/library/euicc/esx_header_Types_JSON.ttcn @@ -0,0 +1,51 @@ +/* JSON message definitions for ES2+ + * + * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module esx_header_Types_JSON { + +/* GSMA SGP.22, section 6.5.1.3 */ +type record JSON_ESx_RequestHeader { + charstring functionRequesterIdentifier, + charstring functionCallIdentifier +}; + +/* GSMA SGP.22, section 6.5.1.4 */ +type record JSON_ESx_FunctionExecutionStatus { + charstring status +}; +type record JSON_ESx_ResponseHeader { + JSON_ESx_FunctionExecutionStatus functionExecutionStatus +}; + +template (value) JSON_ESx_ResponseHeader +ts_responseHeader := { + functionExecutionStatus := { + status := "Executed-Success" + } +} +template (present) JSON_ESx_ResponseHeader +tr_responseHeader := { + functionExecutionStatus := { + status := ? + } +} + +template (value) JSON_ESx_RequestHeader +ts_requestHeader := { + functionRequesterIdentifier := "TTCN3", + functionCallIdentifier := "testsuite" +} +template (present) JSON_ESx_RequestHeader +tr_requestHeader := { + functionRequesterIdentifier := ?, + functionCallIdentifier := ? +} + +} \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0242c877805003fa67445800960f75ce27752383 Gerrit-Change-Number: 39654 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence...
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email ) Change subject: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, set SLS ...................................................................... Patch Set 2: (1 comment) File src/sccp_sclc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690/comment/2efbfc2d_baaf1… : PS2, Line 38: * I'm not quite sure if the SLS setting is all that's needed for class 3 support? Are we sure about that? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I834e91c1ec337713b0e684cf4fd7de854150bef6 Gerrit-Change-Number: 39690 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 08:28:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: sccp: Apply SLS on locally-originated transmitted Connection-Oriented...
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39689?usp=email ) Change subject: sccp: Apply SLS on locally-originated transmitted Connection-Oriented messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1956acf631867b12b647d14c10057ded20d7fa2f Gerrit-Change-Number: 39689 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 08:27:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Pass ownership of Tx xua_msg down the stack [1/2]
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39396?usp=email ) Change subject: ASP loadsharing: Pass ownership of Tx xua_msg down the stack [1/2] ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I49e718e624da08510a9c3d28bdb360c59f9a65d3 Gerrit-Change-Number: 39396 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 08:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:*
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email ) Change subject: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:* ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I695bd3933a116323db45ab7f45dcf539791139aa Gerrit-Change-Number: 39406 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 08:24:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: Implement AS loadshare, skip unavailable AS/lset when...
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391?usp=email ) Change subject: AS loadsharing: Implement AS loadshare, skip unavailable AS/lset when choosing ...................................................................... Patch Set 10: (1 comment) File src/ss7_combined_linkset.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391/comment/43201acd_ce421… : PS10, Line 36: last_route_roundrobin don't you need to somehow guard against this pointer becoming stale if the route it points to is removed from 'routes' above? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I928fb1ef5db6922f1386a188e3fbf9e70780f25d Gerrit-Change-Number: 39391 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 08:23:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: sccp_user: Fix ASP not restarted after associating a new AS to it
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39676?usp=email ) Change subject: sccp_user: Fix ASP not restarted after associating a new AS to it ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5cccad3347dbea33433028e17571b1c16ecaf719 Gerrit-Change-Number: 39676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 07:48:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: as: Introduce internal ss7_as_add_asp() to avoid unnecessary asp lookup
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39675?usp=email ) Change subject: as: Introduce internal ss7_as_add_asp() to avoid unnecessary asp lookup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id75fde04e39747fd3a7a1b169f7b925e5a8064d9 Gerrit-Change-Number: 39675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 07:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0