February 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: GMM: implement IMEI SV on auth/ciph response

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email ) Change subject: GMM: implement IMEI SV on auth/ciph response ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8b428967a4ce3132a4a63ae10fe610de81c3a29 Gerrit-Change-Number: 39425 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 3: (32 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/aa8a34c5_13703fdb?us… : PS3, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/0643cb63_ca3eb62d?us… : PS3, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f3a39909_c33dd9d1?us… : PS3, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/027afac8_218d2ac9?us… : PS3, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/4f347e26_0852688e?us… : PS3, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c75796a4_ea78b07a?us… : PS3, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/37c3f19d_8a9553dd?us… : PS3, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6bdd6552_17288f3e?us… : PS3, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/888c406a_af9392a6?us… : PS3, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/1055498a_11dcd003?us… : PS3, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/94dbda20_8bf3339b?us… : PS3, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/959307c3_14348149?us… : PS3, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3782d421_fc58feeb?us… : PS3, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3cae54e2_9e96164b?us… : PS3, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/67ad3e66_0f919e03?us… : PS3, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/aa7cd5ff_59f7bd4c?us… : PS3, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/338ff269_5bfb3081?us… : PS3, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f4396d82_68750983?us… : PS3, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2f5491b2_95371b58?us… : PS3, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8c48054a_0c6a7a34?us… : PS3, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/bf79983d_dc0fd1dd?us… : PS3, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f311b37f_7e00e20c?us… : PS3, Line 216: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6f83cce7_6de1b338?us… : PS3, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/473cb8fa_1ddb183e?us… : PS3, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3144ab5e_b3116e65?us… : PS3, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3e753f0e_ddd076e4?us… : PS3, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/82b573ad_5b99fef3?us… : PS3, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/60c8c61d_21d09351?us… : PS3, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/aef33773_cdc0e270?us… : PS3, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/248af589_6a5648c0?us… : PS3, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/621931ce_0218aee1?us… : PS3, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/965d1233_7f3c806b?us… : PS3, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...

by lynxis lazus

Attention is currently required from: neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email ) Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... Patch Set 9: (1 comment) File tests/msc_vlr/msc_vlr_test_gsm_authen.err.err: https://gerrit.osmocom.org/c/osmo-msc/+/38491/comment/fa384734_bc185e5f?usp… : PS9, Line 1: dump.sh: line 5: ./msc_vlr_test_gsm_authen.err: Permission denied > This looks totally unintended.... Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:37:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr: replace strncpy with osmo_strlcpy

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email ) Change subject: libvlr: replace strncpy with osmo_strlcpy ...................................................................... Patch Set 1: (1 comment) File src/libvlr/vlr_auth_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/39565/comment/66b07e70_353ce1d4?usp… : PS1, Line 543: osmo_strlcpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); OSMO_STRLCPY_ARRAY(vsub->imsi, mi_string); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 Gerrit-Change-Number: 39565 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:37:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 4: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/8a423123_a0fb244a?us… : PS4, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f2e11639_7e44b71f?us… : PS4, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ee85e7eb_eb4e3ed9?us… : PS4, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/66aec894_7e7f2a9b?us… : PS4, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/5b588349_f8ea26c7?us… : PS4, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/7e9c9b97_97ee3dd2?us… : PS4, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/67fc3ce3_26cc1717?us… : PS4, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/d2e9afd9_af176260?us… : PS4, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cf35a5d5_a3fcbaca?us… : PS4, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/3d921016_23917243?us… : PS4, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/37c7e3eb_a6c42072?us… : PS4, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cd9b64a0_4c7e8849?us… : PS4, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21558): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ea37619d_a98eb9f5?us… : PS4, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...

by pespin

Attention is currently required from: lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email ) Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... Patch Set 9: Code-Review-1 (1 comment) File tests/msc_vlr/msc_vlr_test_gsm_authen.err.err: https://gerrit.osmocom.org/c/osmo-msc/+/38491/comment/b2709fd3_4db978e3?usp… : PS9, Line 1: dump.sh: line 5: ./msc_vlr_test_gsm_authen.err: Permission denied This looks totally unintended.... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 4: (24 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/bb57cf5d_87f0af0a?us… : PS4, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a841d331_0d57ce20?us… : PS4, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/fd022cec_f5eaf3c3?us… : PS4, Line 1551: else { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/26fbbe17_7ffe4287?us… : PS4, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0fec6145_93762eeb?us… : PS4, Line 1673: if (!foreign_ra && that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9a7ebf17_aebd7d12?us… : PS4, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ffc9c863_d270c054?us… : PS4, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/99d02e1b_10f1a963?us… : PS4, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0bb86375_e7aebba7?us… : PS4, Line 1964: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2724ac7d_0aabe301?us… : PS4, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e50243e4_83a1550e?us… : PS4, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6a4c9647_db60339a?us… : PS4, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1b791a60_c0648f9d?us… : PS4, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/649c6ca8_c53ca757?us… : PS4, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/35ae470f_7048a7e7?us… : PS4, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/21358c47_cad1ca2f?us… : PS4, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5116f786_6f238d73?us… : PS4, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a8565d44_3b08bfc7?us… : PS4, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/002515ec_fd8b4210?us… : PS4, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/02639ec3_4b65e310?us… : PS4, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void) File src/sgsn/mmctx.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3174b32b_4772c105?us… : PS4, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4d650748_31b265ee?us… : PS4, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4958ebaa_38e521d5?us… : PS4, Line 360: [DVLR] = { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/98f9e5c8_671583df?us… : PS4, Line 364: }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:36:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: libvlr: squash libvlr reworks

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39561?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: libvlr: squash libvlr reworks ...................................................................... libvlr: squash libvlr reworks * logging/debug.h: add own debug * add PVLR support * add vlr_ra_update() * internally use RAI instead of LAI Change-Id: I7ef8e10e9553181913c66546c97a71b21fa9ef64 --- M include/osmocom/vlr/Makefile.am A include/osmocom/vlr/debug.h M include/osmocom/vlr/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c 6 files changed, 102 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/61/39561/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ef8e10e9553181913c66546c97a71b21fa9ef64 Gerrit-Change-Number: 39561 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d --- M configure.ac M include/osmocom/Makefile.am A include/osmocom/vlr/Makefile.am A include/osmocom/vlr/vlr.h A include/osmocom/vlr/vlr_sgs.h M src/Makefile.am A src/libvlr/Makefile.am A src/libvlr/vlr.c A src/libvlr/vlr_access_req_fsm.c A src/libvlr/vlr_access_req_fsm.h A src/libvlr/vlr_auth_fsm.c A src/libvlr/vlr_auth_fsm.h A src/libvlr/vlr_core.h A src/libvlr/vlr_logging.c A src/libvlr/vlr_lu_fsm.c A src/libvlr/vlr_lu_fsm.h A src/libvlr/vlr_sgs.c A src/libvlr/vlr_sgs_fsm.c A src/libvlr/vlr_sgs_fsm.h M src/sgsn/Makefile.am M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am 22 files changed, 6,730 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/60/39560/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-msc[master]: vlr: add PS support

by pespin

Attention is currently required from: daniel, lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 8: (1 comment) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/9151b9a6_448cfc64?usp… : PS5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state) > i agree with pau here because it is only one FSM state's onenter action This was not yet addressed... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:28:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025