February 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: erab_fsm: pretty-print U2CM and U2AM during MODIFY Req/Ind

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39555?usp=email ) Change subject: erab_fsm: pretty-print U2CM and U2AM during MODIFY Req/Ind ...................................................................... erab_fsm: pretty-print U2CM and U2AM during MODIFY Req/Ind Change-Id: I2a8bac479bdf8076fdb8b379361aff7b549babcd Related: SYS#7308 --- M src/erab_fsm.erl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index c0fbbae..a941152 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -390,7 +390,7 @@ erab_setup({call, From}, {erab_modify_req, U2CM}, #erab_state{} = S) -> - ?LOG_DEBUG("Rx E-RAB MODIFY Req (U2CM ~p)", [U2CM]), + ?LOG_DEBUG("Rx E-RAB MODIFY Req (U2CM ~p)", [pp(U2CM)]), {next_state, session_modify, S#erab_state{mod_kind = modify_req, from = From, @@ -425,7 +425,7 @@ erab_setup({call, From}, {erab_modify_ind, U2AM}, #erab_state{} = S) -> - ?LOG_DEBUG("Rx E-RAB MODIFY Ind (U2AM ~p)", [U2AM]), + ?LOG_DEBUG("Rx E-RAB MODIFY Ind (U2AM ~p)", [pp(U2AM)]), {next_state, session_modify, S#erab_state{mod_kind = modify_ind, from = From, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2a8bac479bdf8076fdb8b379361aff7b549babcd Gerrit-Change-Number: 39555 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 16:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: tests: add unit test for HRv1 TRAU->RTP

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39559?usp=email ) Change subject: tests: add unit test for HRv1 TRAU->RTP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id2703d313f52fa54465a13f3370ebb6d7d976bbd Gerrit-Change-Number: 39559 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 16:01:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You could maybe add a comment in the _gen.c file with a sample input file, or point to the file you are adding in tests/ in the follow-up commit. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 16:01:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 1: (2 comments) File tests/trau_conv/trau2rtp_gen.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/621ee7da_4d56aade… : PS1, Line 150: inv: fprintf(stderr, "%s line %d: invalid syntax\n", infname, lineno); we usually put goto tags on its own line. https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/7316bc0d_c0b8c9a4… : PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n", we usually put goto tags on its own line. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 16:00:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: ansible/obs-worker: lxc<5: link to upstream issue

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39567?usp=email ) Change subject: ansible/obs-worker: lxc<5: link to upstream issue ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1a575a137c7141d49d974e4d6ffb2472abb64bf Gerrit-Change-Number: 39567 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 15:57:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: ansible: update build5-obsworker ssh key

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39566?usp=email ) Change subject: ansible: update build5-obsworker ssh key ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I70a4e404fef74694ee851345345924ae95319b3e Gerrit-Change-Number: 39566 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 15:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: Routing Area: Remove cells when NSEI becomes unavailable

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email ) Change subject: Routing Area: Remove cells when NSEI becomes unavailable ...................................................................... Abandoned superseeded/included in I2474b19a7471a1dea3c863ddf8372b16180211aa -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9f0386d9eb7f0cabaf0fde45f8e78b4ea28c67c5 Gerrit-Change-Number: 37865 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 12: (4 comments) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/0fdb0a44_fa7f4a49?usp… : PS10, Line 869: /* find all RNCs which are serving this RNC */ > Acknowledged Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/3c8e47ab_9403d5fd?usp… : PS10, Line 878: osmo_rnc_id_name(&rnc->rnc_id), > this indentation may be wrong. Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/119f633d_bbb4a27c?usp… : PS10, Line 883: } else if (!is_ps && !osmo_lai_cmp(&entry->rai.lac, &ra_id->lac)) { > this "else" can be removed in this line, simplifying logic. Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/25943e12_be9f24e8?usp… : PS10, Line 932: return iu_page2(imsi, tmsi, &rai, false); > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 14:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ranap_iu_page_cs2 and ranap_iu_page_ps2 are using the new osmocom osmo_location_area_id or osmo_routing_area_id which also contain the PLMN. Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/iu_client.c 3 files changed, 101 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/38946/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025