February 2025 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by pespin

Attention is currently required from: falconia, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 2: (1 comment) File tests/trau_conv/trau2rtp_gen.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/35de0a72_96abad99… : PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n", > Your forgot this one TBH I think it's even the first time I ever saw a goto tag placed into the same line where C code is, I didn't even think about it being possible (but yeah, from asm PoV it makes sense). It personally created some disruption to me while looking at the code, hence why I shared. If other are fine with having this inline then fine with merging is this way. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 23:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by pespin

Attention is currently required from: laforge, pespin. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 2: (1 comment) File tests/trau_conv/trau2rtp_gen.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/8951e53a_ee05e5f0… : PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n", > we usually put goto tags on its own line. Your forgot this one -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 23:00:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by falconia

Attention is currently required from: laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > You could maybe add a comment in the _gen. […] I was not able to come up with an aesthetically pleasing way to incorporate both TRAU-16k and TRAU-8k input examples into the big header comment at the top of the C file, so I took a different approach: I wrote a separate text file that serves as a mini-manual for the program, covering input and output hex formats and other info I expect to be useful. File tests/trau_conv/trau2rtp_gen.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/12e83726_99a2b3df… : PS1, Line 150: inv: fprintf(stderr, "%s line %d: invalid syntax\n", infname, lineno); > we usually put goto tags on its own line. I made the requested change in Patchset 2. To make it more aesthetically pleasing in the new split-line arrangement, I changed the goto label from `inv:` to `inv_syntax:`, which is also more descriptive. https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/9922f4b6_1b12d113… : PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n", > we usually put goto tags on its own line. In this particular case I really don't want to change it. This goto-reached code block is already out of the way of regular code flow, moved to the end of the function after `exit()`, and when the label is short enough to fit neatly into the space allocated by the leading tab, the style I wrote here is more aesthetically pleasing than the same short label on its own line, followed by `fprintf()` and `exit()` lines. Alternatively, I could change the style if you suggest changing `usage:` to some longer label that would look more natural on a line by itself. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 22:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: tests: add trau2rtp_gen program

by falconia

Attention is currently required from: falconia, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: tests: add trau2rtp_gen program ...................................................................... tests: add trau2rtp_gen program This test program converts TRAU-16k or TRAU-8k frames into RTP payloads, both represented in hex. (Hex representation of RTP payloads follows TW-TS-005 spec; hex representation of TRAU frames is ad hoc.) It can be used as a basis for unit tests, verifying that a given TRAU frame input turns into corresponding RTP output, and it can also be used (in conjuction with additional Themyscira utilities) to turn captured TRAU frame streams into playable audio. Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd --- M .gitignore M tests/Makefile.am A tests/trau_conv/trau2rtp_gen.c A tests/trau_conv/trau2rtp_gen.notes 4 files changed, 342 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/58/39558/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

4 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: increment *_IN_PKT_* counters on exception

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39569?usp=email ) Change subject: s1ap_proxy: increment *_IN_PKT_* counters on exception ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie06e2679673df218da92f07f12ca18c085df299e Gerrit-Change-Number: 39569 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 22:43:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 5: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/1238f249_7c9476c7?us… : PS5, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/9f02ca19_288fda55?us… : PS5, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/46fd05d2_0e18125e?us… : PS5, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/31a61cde_fed7afca?us… : PS5, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ee74b591_a8708167?us… : PS5, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/7823cf6c_dfe4725c?us… : PS5, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cb0c2899_e98cefa0?us… : PS5, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/4ab08d9e_c35fc2c1?us… : PS5, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/813e5550_7a9e0db8?us… : PS5, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/64992965_9edc7c9c?us… : PS5, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f9a6cf47_ec722257?us… : PS5, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/a7c5c1c0_31f04715?us… : PS5, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/7f4a4342_0abfd42f?us… : PS5, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 22:17:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 4: (32 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/52391b8d_92ed7ae0?us… : PS4, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/55fb2ee1_1d8b85bf?us… : PS4, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d326dd31_9b4a7170?us… : PS4, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3994a3dd_33e74d01?us… : PS4, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3f3d8959_6aedfe0a?us… : PS4, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7e30ea63_9bb844cc?us… : PS4, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2518d7b9_b3e1294c?us… : PS4, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f7712610_a462c2e5?us… : PS4, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a1ccc9b4_f7b614ef?us… : PS4, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/604b34d8_452aef6a?us… : PS4, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cb65cf68_a104c3af?us… : PS4, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fed84584_d3253053?us… : PS4, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cb74617c_82d46ab4?us… : PS4, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9ef01375_413214cc?us… : PS4, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/32860735_b6dc89d4?us… : PS4, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ef077dbc_d4354d48?us… : PS4, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/26b9e142_e81786c2?us… : PS4, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c2dd222b_09d9c2ce?us… : PS4, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3b6befe6_e4b7f222?us… : PS4, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/e74bdc89_a1ed9bd6?us… : PS4, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2079eb14_eefb24df?us… : PS4, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/133d6d13_5891c606?us… : PS4, Line 216: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/28d3e5f2_fe2e0e76?us… : PS4, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/386a49c3_344b174b?us… : PS4, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/0aa11f50_d453a0e0?us… : PS4, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b4076c54_38f00909?us… : PS4, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/41f47252_eb22a48e?us… : PS4, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/665ce432_87629047?us… : PS4, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6f9b9090_635e60dd?us… : PS4, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/fa6e04b2_31913578?us… : PS4, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b2d625a4_56772006?us… : PS4, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21577): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/44dd7f87_1fecc707?us… : PS4, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 22:17:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 5: (24 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6279ba86_6e28ed1d?us… : PS5, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/79960cd4_2a39ed06?us… : PS5, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/98e6e96e_f7246662?us… : PS5, Line 1551: else { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/62eb9c7d_ae95c246?us… : PS5, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/762c0d9d_7bcaecd4?us… : PS5, Line 1673: if (!foreign_ra && that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3128b37d_6153c6be?us… : PS5, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/08b67be9_184d7321?us… : PS5, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8aaf18d7_2f2f40d6?us… : PS5, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ebf0a950_f3e63c35?us… : PS5, Line 1964: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3b23a88e_4269e81c?us… : PS5, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1d90c938_e31747ec?us… : PS5, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b5965845_adef4b0b?us… : PS5, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/cdf39cc0_3e051943?us… : PS5, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/93d73898_a67a87d1?us… : PS5, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0f34cf80_37d61140?us… : PS5, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a0c327a8_106b8cf5?us… : PS5, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8e7fd5bf_b48b59bc?us… : PS5, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a40349e1_e9c1714b?us… : PS5, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/76d424fa_40040adf?us… : PS5, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/d82192cf_da4aeba0?us… : PS5, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void) File src/sgsn/mmctx.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b644e20a_8b846289?us… : PS5, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/120d0871_ece19de4?us… : PS5, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1548dde4_4c66d007?us… : PS5, Line 360: [DVLR] = { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21576): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/f48c10e6_ffbb9d91?us… : PS5, Line 364: }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 22:17:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: Assign MME GroupId/Code to remote MMEs

by lynxis lazus

Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email ) Change subject: Assign MME GroupId/Code to remote MMEs ...................................................................... Patch Set 4: (1 comment) File src/sgsn/gtp_mme.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39294/comment/47e680bf_eea80f37?us… : PS3, Line 138: osmo_gummei_cmp > Shouldn't you check `gummei_valid` before invoking `osmo_gummei_cmp()`? Otherwise you're comparing t […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I881aeba904fb6ca815842d36e466a2459ad81913 Gerrit-Change-Number: 39294 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2025 22:14:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: GMM: implement IMEI SV on auth/ciph response

by lynxis lazus

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GMM: implement IMEI SV on auth/ciph response ...................................................................... GMM: implement IMEI SV on auth/ciph response The SGSN is requesting the IMEI SV on an auth/ciphering response. Parse the answer of the MS/UE. Change-Id: Ia8b428967a4ce3132a4a63ae10fe610de81c3a29 --- M src/sgsn/gprs_gmm.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/25/39425/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8b428967a4ce3132a4a63ae10fe610de81c3a29 Gerrit-Change-Number: 39425 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025