February 2025 - gerrit-log - lists.osmocom.org

[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email ) Change subject: drivers/dahdi: fix always true cond ...................................................................... Patch Set 2: (1 comment) File drivers/dahdi/xpp/xbus-core.c: https://gerrit.osmocom.org/c/dahdi-linux/+/39593/comment/f5b3909f_0288e098?… : PS1, Line 116: if (xbus->label) { > Yes, from the commit message: […] "\*(xbus->label)" in the case of an array is the same as "\*(&xbus->label[0]))", which in turs is the same as "xbus->label[0]". Please somebody else confirm. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:43:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in dahdi-linux[master]: gitreview: new file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39596?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gitreview: new file ...................................................................... gitreview: new file Change-Id: I4699c2101254aa3b2b2aee8fceafcc6c21dcef4c --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, approved diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..3256ebc --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=dahdi-linux -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I4699c2101254aa3b2b2aee8fceafcc6c21dcef4c Gerrit-Change-Number: 39596 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in dahdi-linux[master]: gitreview: new file

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39596?usp=email ) Change subject: gitreview: new file ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I4699c2101254aa3b2b2aee8fceafcc6c21dcef4c Gerrit-Change-Number: 39596 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:42:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... drivers/dahdi: fix MAX redefine Fix for this error with linux v6.11-rc2: CC [M] oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_channel.o wctdm24xxp/base.c: In function 'wait_access': wctdm24xxp/base.c:1504: error: "MAX" redefined [-Werror] 1504 | #define MAX 10 /* attempts */ | In file included from /linux/include/linux/kernel.h:28, from wctdm24xxp/base.c:41: /linux/include/linux/minmax.h:330: note: this is the location of the previous definition 330 | #define MAX(a,b) __cmp(max,a,b) Related: linux 1a251f52 ("minmax: make generic MIN() and MAX() macros available everywhere") Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c --- M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wctdm24xxp/base.c 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/drivers/dahdi/wcaxx-base.c b/drivers/dahdi/wcaxx-base.c index d3d0777..a54188d 100644 --- a/drivers/dahdi/wcaxx-base.c +++ b/drivers/dahdi/wcaxx-base.c @@ -1050,16 +1050,16 @@ unsigned char data = 0; int count = 0; - #define MAX 10 /* attempts */ + #define MAX_ATTEMPTS 10 /* Wait for indirect access */ - while (count++ < MAX) { + while (count++ < MAX_ATTEMPTS) { data = wcaxx_getreg(wc, mod, I_STATUS); if (!data) return 0; } - if (count > (MAX-1)) { + if (count > (MAX_ATTEMPTS - 1)) { dev_notice(&wc->xb.pdev->dev, " ##### Loop error (%02x) #####\n", data); } diff --git a/drivers/dahdi/wctdm24xxp/base.c b/drivers/dahdi/wctdm24xxp/base.c index 9725d3c..5de4ae8 100644 --- a/drivers/dahdi/wctdm24xxp/base.c +++ b/drivers/dahdi/wctdm24xxp/base.c @@ -1501,16 +1501,16 @@ unsigned char data = 0; int count = 0; - #define MAX 10 /* attempts */ + #define MAX_ATTEMPTS 10 /* Wait for indirect access */ - while (count++ < MAX) { + while (count++ < MAX_ATTEMPTS) { data = wctdm_getreg(wc, mod, I_STATUS); if (!data) return 0; } - if (count > (MAX-1)) { + if (count > (MAX_ATTEMPTS - 1)) { dev_notice(&wc->vb.pdev->dev, " ##### Loop error (%02x) #####\n", data); } -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:41:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... Patch Set 2: Verified+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/dahdi-linux/+/39591/comment/2dd58951_e9d32558?… : PS1, Line 9: current linux master: > please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. […] Done -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:41:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

4 months, 2 weeks

1
0
0 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/wct4xxp: fix inline not at beginning

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39592?usp=email ) Change subject: drivers/dahdi/wct4xxp: fix inline not at beginning ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS1: > please mention specifically the version like x.y.z-rcXX that introduced this in the changelog. […] sorry, but for this patch and the following it is not obvious where this comes from. I could do a git bisect... but that doesn't seem like a good use of time, right? I've adjusted the previous patch where it is clear where this was introduced. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ic77d94271e7844ea2e06ccd001156d90f321367e Gerrit-Change-Number: 39592 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond

by osmith

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email to look at the new patch set (#2). Change subject: drivers/dahdi: fix always true cond ...................................................................... drivers/dahdi: fix always true cond Remove these checks as they are not useful. For example, wc->xb gets allocated together with wc. With these removed, the code behaves the same as before. Fix for these warnings with current linux master: wcte43x-base.c: In function 't43x_init_one': wcte43x-base.c:3517:13: warning: the comparison will always evaluate as 'true' for the address of 'xb' will never be NULL [-Waddress] 3517 | if (&wc->xb) | ^ wcte43x-base.c:141:21: note: 'xb' declared here 141 | struct wcxb xb; | ^~ xpp/xbus-core.c: In function 'xbus_check_unique': xpp/xbus-core.c:116:13: warning: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Waddress] 116 | if (xbus->label && *(xbus->label)) { | ^~~~ etc. Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/dahdi_dynamic_ethmf.c M drivers/dahdi/wcte13xp-base.c M drivers/dahdi/wcte43x-base.c M drivers/dahdi/xpp/xbus-core.c 5 files changed, 7 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/93/39593/2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin Change subject: drivers/dahdi: fix MAX redefine ...................................................................... drivers/dahdi: fix MAX redefine Fix for this error with linux v6.11-rc2: CC [M] oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_channel.o wctdm24xxp/base.c: In function 'wait_access': wctdm24xxp/base.c:1504: error: "MAX" redefined [-Werror] 1504 | #define MAX 10 /* attempts */ | In file included from /linux/include/linux/kernel.h:28, from wctdm24xxp/base.c:41: /linux/include/linux/minmax.h:330: note: this is the location of the previous definition 330 | #define MAX(a,b) __cmp(max,a,b) Related: linux 1a251f52 ("minmax: make generic MIN() and MAX() macros available everywhere") Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c --- M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wctdm24xxp/base.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/91/39591/2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email ) Change subject: drivers/dahdi: fix always true cond ...................................................................... Patch Set 1: (1 comment) File drivers/dahdi/xpp/xbus-core.c: https://gerrit.osmocom.org/c/dahdi-linux/+/39593/comment/df787733_4a17f57e?… : PS1, Line 116: if (xbus->label) { > are you sure about this one? Looks like you are removing a check againstbeing len(xbus->label)>0 her […] Yes, from the commit message: ``` xpp/xbus-core.c: In function 'xbus_check_unique': xpp/xbus-core.c:116:13: warning: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Waddress] 116 | if (xbus->label && *(xbus->label)) { | ^~~~ ``` If the length should be checked, it would need to be e.g. xbus->label[0]. I'm not sure if the author intended that. By just removing the check we get the same behavior as before and get rid of the build failure. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:37:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025