February 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: laforge, neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 15: (6 comments) This change is ready for review. File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/71694afe_973202a2?usp… : PS13, Line 900: %d RN > (then again this looks like multiple matches are possible) […] Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/5f486587_01b5bca3?usp… : PS13, Line 909: LOGPIUC(log_level, ", for IMSI %s\n", imsi); > please avoid LOGPC, because for gsm_tap_log it rips apart log lines to multiple gsmtap packages. […] Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/3ee6ee43_9380816b?usp… : PS13, Line 938: } > if (paged) break? break is fine. See above. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/0637b079_767a53b3?usp… : PS13, Line 943: LOGL_INFO > this previously was LOGL_ERROR and the _cs2 also does ERROR. […] Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/58277522_59653763?usp… : PS13, Line 945: sprintf(log_msg, "Paged %d RNCs", paged); > snprintf() Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/f4ac9b70_5b47bfa5?usp… : PS13, Line 954: LOGPIUC(log_level, ", for IMSI %s\n", imsi); > avoid LOGPC Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 15:31:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: laforge, neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 14: (1 comment) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/bcdef960_c69444e8?usp… : PS13, Line 914: int ranap_iu_page_ps2(const char *imsi, const uint32_t *ptmsi, const struct osmo_routing_area_id *rai) > In the header. I don't see a reason, why to put it into the .c file. […] will add it to the header. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 15:14:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Code-Review+1 by neels, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ranap_iu_page_cs2 and ranap_iu_page_ps2 are using the newer osmocom osmo_location_area_id or osmo_routing_area_id which also contain the PLMN. Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/iu_client.c 3 files changed, 93 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/38946/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: iu_client: add a new event NEW_AREA

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: iu_client: add a new event NEW_AREA ...................................................................... iu_client: add a new event NEW_AREA When the IU client learns a new LAC/RAC or the LAC/RAC has moved from one RNC to another RNC, inform the user via an event. Allows the SGSN to track RACs which uses Iu. Change-Id: I8b1b8c58bf72b00e2705ca87a89a91481bac3470 --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/iu_client.c 3 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/38947/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8b1b8c58bf72b00e2705ca87a89a91481bac3470 Gerrit-Change-Number: 38947 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email ) Change subject: drivers/dahdi: fix always true cond ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 15:11:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: laforge, neels. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 13: (7 comments) Patchset: PS13: > in the end, after CR, i notice that this is the iu_client. […] yes I know, but I didn't want to have another major rewrite of code atm. Fixing the current code to be good enough here. File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/8f379dce_eb85152a?usp… : PS13, Line 842: LOGL_ERROR > (marking: this was ERROR) yes, but I think error is a little bit harsh, only when a client isn't reachable. Both cs and ps will use now INFO https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/877860a6_2df692d1?usp… : PS13, Line 869: int ranap_iu_page_cs2(const char *imsi, const uint32_t *tmsi, const struct osmo_location_area_id *lai) > it would be great to have an API doc explaining how version 2 behaves differently I added a comment, but still not describing what's the difference. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/eebd1808_d0f25791?usp… : PS13, Line 879: exact > "exactly one" […] I think this is possible for hnbs and not forbidden. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c6dd3724_1eda2718?usp… : PS13, Line 883: if (!osmo_lai_cmp(&entry->rai.lac, lai)) { > (early exit: 'if (osmo_lai_cmp(.. […] What do you mean? I think it is ok, to break here. We tx a paging request to a single RNC about this LAC. So breaking this inner llist_for_each is correct. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c6232366_a5f9bdbd?usp… : PS13, Line 893: } > if it's exactly one, then it seems that this loop could also get an 'if (paged) break;' ? No, we need to tx a page request to a RNC at most once. But we don't want to exit, after paging a single RNC. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/624dc0c8_117fb834?usp… : PS13, Line 914: int ranap_iu_page_ps2(const char *imsi, const uint32_t *ptmsi, const struct osmo_routing_area_id *rai) > api doc In the header. I don't see a reason, why to put it into the .c file. If it's in the header, IDEs can parse it and use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Feb 2025 15:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 6: (24 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/daf1629a_0c97d3e7?us… : PS6, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/14e63a18_f5007796?us… : PS6, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4db19c2b_b562aaf5?us… : PS6, Line 1551: else { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c6166ac4_639f7622?us… : PS6, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/91fda4e7_f00d3999?us… : PS6, Line 1673: if (!foreign_ra && that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/14896aeb_5552aaf0?us… : PS6, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/78f4295e_c001709f?us… : PS6, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6b78ede5_501da541?us… : PS6, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9297f0df_64449487?us… : PS6, Line 1964: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0f34db6b_7a21275b?us… : PS6, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/da8258bf_f56f855c?us… : PS6, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b6d1c058_0e98bd27?us… : PS6, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e5d51136_a8976f8b?us… : PS6, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a655e1eb_1bcfa0c4?us… : PS6, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9d4ff373_76ac1739?us… : PS6, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/13e136e2_cd5b5e2c?us… : PS6, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e8ca730d_8e66b097?us… : PS6, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/d3cf1fa1_da0674a3?us… : PS6, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4f6de339_e5488365?us… : PS6, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/fa284522_9eb93561?us… : PS6, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void) File src/sgsn/mmctx.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5f83ef30_acf92318?us… : PS6, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/33ec51e9_b1cad3fb?us… : PS6, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/398fe2fa_8ca38a34?us… : PS6, Line 360: [DVLR] = { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21624): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/01002ba7_22591023?us… : PS6, Line 364: }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Feb 2025 14:44:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 5: (32 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/243f8a2c_91e584a9?us… : PS5, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/29b3e3a1_ddc77c54?us… : PS5, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/34786e2b_3ef5d6d6?us… : PS5, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7b552900_0a5b1f18?us… : PS5, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c72fb538_dc962426?us… : PS5, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/af1eb04c_7f2ac166?us… : PS5, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a6d51b24_60db80f9?us… : PS5, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3af5a618_f78830ad?us… : PS5, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d7654f7d_7612867f?us… : PS5, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d9e5c379_a20de30d?us… : PS5, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f2ad7b45_e1290bc7?us… : PS5, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/032253ba_2732a45e?us… : PS5, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ce18777c_898eb5cb?us… : PS5, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/70628b62_d854c73b?us… : PS5, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/63048c43_313cbec8?us… : PS5, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c2d32d19_22177dcf?us… : PS5, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/332a5631_95ac8845?us… : PS5, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/62899804_53a8e029?us… : PS5, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2cfe38da_40a3a249?us… : PS5, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/74a505c9_54320281?us… : PS5, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/208027ac_caa3de45?us… : PS5, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8edb144e_4ea66591?us… : PS5, Line 216: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/94cd8a6d_0470a524?us… : PS5, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/69a877d1_07b64548?us… : PS5, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/52930bda_8f244ebd?us… : PS5, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/89bc25ba_40fc87cf?us… : PS5, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/07824013_dbc8e70b?us… : PS5, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/371f4d2b_4ede774f?us… : PS5, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7af5295b_f2f6825e?us… : PS5, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/845150d6_28bdb5c9?us… : PS5, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/37c09fa5_24febf87?us… : PS5, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21623): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/0ba28c27_0cf666d9?us… : PS5, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Feb 2025 14:43:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 6: (13 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f7593b3a_c7177fb1?us… : PS6, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/baf15dc9_9090b35a?us… : PS6, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/3ddb7030_2c44f861?us… : PS6, Line 2627: } else { else is not generally useful after a break or return File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/921a0a2c_7af9b803?us… : PS6, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/1cc25d06_01a0179d?us… : PS6, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/abd40d52_a80d1de4?us… : PS6, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/3070cd27_895bfec2?us… : PS6, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ecf0a7a9_9cbc375b?us… : PS6, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/0c42630f_d892bc29?us… : PS6, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f1b92a21_f81b59c6?us… : PS6, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/2165e908_55f3d944?us… : PS6, Line 1139: // break; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/69b82159_3e638fbe?us… : PS6, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21621): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/6413e35a_dcce7166?us… : PS6, Line 1388: if (rc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Feb 2025 14:43:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d --- M configure.ac M include/osmocom/Makefile.am A include/osmocom/vlr/Makefile.am A include/osmocom/vlr/vlr.h A include/osmocom/vlr/vlr_sgs.h M src/Makefile.am A src/libvlr/Makefile.am A src/libvlr/vlr.c A src/libvlr/vlr_access_req_fsm.c A src/libvlr/vlr_access_req_fsm.h A src/libvlr/vlr_auth_fsm.c A src/libvlr/vlr_auth_fsm.h A src/libvlr/vlr_core.h A src/libvlr/vlr_logging.c A src/libvlr/vlr_lu_fsm.c A src/libvlr/vlr_lu_fsm.h A src/libvlr/vlr_sgs.c A src/libvlr/vlr_sgs_fsm.c A src/libvlr/vlr_sgs_fsm.h M src/sgsn/Makefile.am M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am 22 files changed, 6,731 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/60/39560/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025