November 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... build-system: depend on libosmo-asn1-tcap To support tcap based loadsharing, tcap must be decoded. Co-authored-by: Daniel Willmann <dwillmann(a)sysmocom.de> Related: SYS#5423 Change-Id: Ib485f786217166635377f931ab894e43a0680634 --- M configure.ac M contrib/jenkins.sh M libosmo-sigtran.pc.in M src/Makefile.am 4 files changed, 29 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/41307/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 8: (3 comments) File src/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/f3f4af85_d7ade… : PS8, Line 13: ss7_as_loadshare_tcap_vty.h \ > tcap_loadshare_vty.{c,h}? […] No, I have static inline functions which no-ops, when the feature is not used. IMHO: this keeps the code cleaner, because it reduces the amount of #ifdef/#endif in the code. File src/ss7_as_loadshare_tcap_vty.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/db119fe6_56cdf… : PS8, Line 6: #ifdef WITH_TCAP_LOADSHARING > Drop this, simply only include the header when ifdef BUILD_WITH_TCAP_LOADSHARING No, I like to have static inlines instead if the feature isn't enabled. File src/ss7_as_loadshare_tcap_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/0f115d86_b02b5… : PS8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME", > are we using the same ordering in other vty command? looks weird ot have "as", then "tcap-ranges" an […] @dwillmann@sysmocom.de? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Add rate counters for loadshare-tcap
by lynxis lazus 10 Nov '25

10 Nov '25

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email ) Change subject: Add rate counters for loadshare-tcap ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: @laforge@gnumonks.org @osmith@sysmocom.de what is the right way to handle it? If we have no rate counters for the non-tcap builds, do we run into problems when generating the manuals? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id67704991feacf54e3123f76e9506dd323b2498b Gerrit-Change-Number: 41310 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:30:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: (16 comments) File src/ss7_as_loadshare_tcap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4c39a77e_48ad4… : PS8, Line 138: ssn ^= ((pc >> 24) & 0xff); > A point code is 13 bits in ITU iirc, you seem to be dropping 5 bits here. […] Wikipedia says it's 14 bits for ITU. I've reserved 24 bits here for the point code (even we don't do ANSI). We don't drop any bits here. XOR the high 8 bits of PC with the SSN. In case this is a WILDCARD. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/80b1e111_674e0… : PS8, Line 273: /** Traffic from the TCAP ASP -> AS -> osmo-stp, only used to update transaction tracking > I wonder whether this step is mandatory or should be enabled depending on setup? Yes it is. If TCAP is enabled on the ASP, it must track both, Rx and Tx. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/5f0d23f4_c6c54… : PS8, Line 380: static int sent_back_utds(struct osmo_ss7_as *as, > Please add a description for this function, I'm not getting what's its purpose. It sends back an SCCP/UTDS back to the origin https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/90047b54_6af95… : PS8, Line 487: /* decode SCCP and convert to a SUA/xUA representation */ > I think you have similar code logic in one of the above functions, you may want to see if it makes s […] I don't really see the gain from move the code back into an own function with a lot of pointers. It complicates the code for a minimal gain of code de-duplication. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d94640e6_2c112… : PS8, Line 560: sent_back_utds(as, xua, sua, SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE); > You may want to look at whether it makes more sense to send a routing failure: […] An UTDS was requested. I don't know enough of SCCP. But the feature request explicit requeseted an UTDS. I don't know why we never sent back an UTDS before. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6e8e96e1_d79ae… : PS8, Line 607: * @return 0 on success > EPROTONOSUPPORT is not documented here. In case, I'd drop EPROTONOSUPPORT and return asp instead. There is a difference between (rc = EPROTONOSUPPORT) and (rc = 0 && asp == NULL.) PROTONOSUPPORTED will do a regular AS loadsharing. While rc = 0; asp = NULL will drop the message. (Because an UTDS is already sent to the origin). https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ed73b488_7cf0a… : PS8, Line 921: /** Called when the ASP is going down or free'd > Then you are currently calling it fromthe wrong place apparently. Why? File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6244559b_27aaa… : PS8, Line 39: #include "ss7_as_loadshare_tcap.h" > #ifdef WITH_TCAP_LOADSHARING No https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/bb387f15_ffbf2… : PS8, Line 158: tcap_disable(as); > #ifdef WITH_TCAP_LOADSHARING No, not needed. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3f6f022b_d1a5b… : PS8, Line 165: "traffic-mode (loadshare|loadshare-tcap) [bindings] [sls] [opc-sls] [opc-shift] [<0-2>]", > IMHO loadshare-tcap feature should have a separate command to enable/disable it. […] traffic-mode loadshare-tcap is an extension to the general loadshare. @dwillmann@sysmocom.de @laforge@osmocom.org I took this over from your origin work. Maybe you have an opinion on it. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3cf2e9b7_cd913… : PS8, Line 186: vty_out(vty, "tcap loadsharing is not supported in this build.\n"); This is wrong, will fix it in v2 File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/08f4fd96_cfca5… : PS8, Line 96: bool enabled; > is this really needed? Does it make sense to have tcap loadsharing enabled in only some ASPs of the […] Not all ASP of an AS has it enabled. Only when the IPA/TCAP is called, it is enabled for this particular ASP. File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c71f3567_91895… : PS8, Line 1344: tcap_asp_down(asp); > nooo way you are calling this here. […] Where do you think it belongs exactly? I'm not used to this code base. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/bbfce463_87102… : PS8, Line 1435: /*! Received an unknown packet on asp > Unrelated to this commit, please submit another one. Will look into it. File src/tcap_transaction_tracking.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/9436428f_999a0… : PS8, Line 122: LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Creating tcap cache, entry (own) pc/ssn/tid %u/%u/%u -> %u/%u/%u\n", > we always want to log PC in both numeric and configured format. See osmo_ss7_pointcode_print_buf(). Ack File stp/stp_main.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d28158a7_3d5de… : PS8, Line 52: void *talloc_asn1_ctx; > Why is this needed? Need to check it again, if it is still required. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:29:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: sync_obs_projects: fix for OSC 1.12.1
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email ) Change subject: OBS: sync_obs_projects: fix for OSC 1.12.1 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: What a weird behavior. Did you investigate why they suddenly require a git repository now? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a Gerrit-Change-Number: 41393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:14:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: This test does not cover (nor require) any API from libosmo-sigtran. It's a binary that links against libosmo-asn1-tcap and tests the API of libosmo-asn1-tcap. This is why it's weird to have such a test here: it just does not belong here. > It ensures the library works correctly. We had issues in the past with linking again asn1 libraries. What kind of issues do we catch by having the test here that we would not be able to catch if we move it to libosmo-asn1-tcap.git? For the linker there's no difference where the test binary is... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:12:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: (4 comments) File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4fad13b2_58f54… : PS8, Line 6: #include <osmocom/core/hashtable.h> > #ifdef WITH_TCAP_LOADSHARING Does the include hurt? I would try to prevent cluttering #ifdefs everywhere. File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7db15e8e_cb951… : PS8, Line 545: case OSMO_SS7_AS_TMOD_LOADSHARE: > #ifdef WITH_TCAP_LOADSHARING […] This is fine. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c09cd7a6_106d8… : PS8, Line 634: > extra line not needed. Acknowledged File src/ss7_as_loadshare_tcap.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/048f1c72_28021… : PS8, Line 14: #ifdef WITH_TCAP_LOADSHARING > YOu can remove this, simply don't even include it if not requested by configure... No, I want to keep it here because of the #else branch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:10:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: (1 comment) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/69918ed6_5a0c9… : PS8, Line 30: void *talloc_asn1_ctx; > Because the library needs it. Will check it again, if it is still required. The asn1 library changed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:07:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: (10 comments) Patchset: PS8: @pespin: I like to keep most of the #ifdef / #endif out of the code. The header file already takes care if the feature isn't enabled. Why do you want to have the #ifdef everywhere in the code? The header file transform it into no-ops. File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/b57d649e_3fcad… : PS8, Line 30: void *talloc_asn1_ctx; > why is this added? Because the library needs it. File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/cc96cf5f_86b02… : PS8, Line 315: /* update TCAP Transaction Tracking (Rx) */ > #ifdef WITH_TCAP_LOADSHARING no, not needed. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ccabd2eb_642d9… : PS8, Line 316: ss7_asp_tcap_rx_sccp(as, asp, opc, dpc, msg); > This function naming is a bit misleading since it's not even known whether there's TCAP in the msg.. […] I want to keep the code changes to the other files minimal. What would you suggest instead? https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/140bbf84_334c5… : PS8, Line 360: case IPAC_PROTO_OSMO: > #ifdef WITH_TCAP_LOADSHARING I could move it further upwards. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/349533d8_c8e32… : PS8, Line 368: if (hh_ext->proto == IPAC_PROTO_EXT_TCAP_ROUTING) { > (probably a switch case here will turn out cleaner together with the ifdef. […] yes, I can use switch/case there. File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/763c4907_f6e3e… : PS8, Line 50: #include "ss7_as_loadshare_tcap.h" > #ifdef WITH_TCAP_LOADSHARINGActually, I don't see this header being used in this file. […] I prefer the style how it is currently. It reduces the usage of #ifdef in the common code. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/125b9129_31648… : PS8, Line 343: if (!xua) > This looks unrelated to this commit? Seems you want to add another commit describing this. Ack. File tests/tcap/tcap_transaction_tracking_test.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6c74d55e_52a73… : PS6, Line 19: typedef void (* tcap_trxn_track_test_func_t)(void); > space prohibited after that '*' (ctx:BxW) fixed https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7aa05f39_9a42b… : PS6, Line 19: typedef void (* tcap_trxn_track_test_func_t)(void); > do not add new typedefs Won't fix. I think it's fine here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by lynxis lazus 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Agreeing with Pau. Unit tests for TCAP codec should be in libosmo-asn1-tcap.git. […] It ensures the library works correctly. We had issues in the past with linking again asn1 libraries. I don't oppose against adding unit tests to asn1-tcap, but keeping this simple test here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 16:51:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025