November 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by daniel 11 Nov '25

11 Nov '25

daniel has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Abandoned Abandoned in favour of https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmo-asn1-tcap[master]: Add test to ensure parsing works
by Jenkins Builder 11 Nov '25

11 Nov '25

Jenkins Builder has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email ) Change subject: Add test to ensure parsing works ...................................................................... Patch Set 1: (2 comments) File tests/parse/tcap_parse_test.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/f9c1d2c5_7fa… : PS1, Line 20: static int write_stream(const void *buffer, size_t size, void *key) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/68e893ad_885… : PS1, Line 37: if (rc.code != RC_OK) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0 Gerrit-Change-Number: 41394 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 11 Nov 2025 08:40:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-asn1-tcap[master]: Add test to ensure parsing works
by daniel 11 Nov '25

11 Nov '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email ) Change subject: Add test to ensure parsing works ...................................................................... Add test to ensure parsing works Related: SYS#5423 Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0 --- M Makefile.am M configure.ac A tests/Makefile.am A tests/parse/Makefile.am A tests/parse/tcap_parse_test.c A tests/parse/tcap_parse_test.ok A tests/testsuite.at 7 files changed, 135 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/94/41394/1 diff --git a/Makefile.am b/Makefile.am index 9e311a6..c165099 100644 --- a/Makefile.am +++ b/Makefile.am @@ -8,7 +8,7 @@ echo $(VERSION) > $(distdir)/.tarball-version INCLUDES = $(all_includes) -I$(top_srcdir)/include/osmocom/tcap -SUBDIRS = src include +SUBDIRS = src tests include pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmo-asn1-tcap.pc diff --git a/configure.ac b/configure.ac index 8e18a0f..5d66205 100644 --- a/configure.ac +++ b/configure.ac @@ -5,6 +5,7 @@ AC_CONFIG_AUX_DIR([.]) AM_INIT_AUTOMAKE([dist-bzip2 subdir-objects]) +AC_CONFIG_TESTDIR(tests) dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) @@ -66,6 +67,8 @@ AC_OUTPUT( libosmo-asn1-tcap.pc src/Makefile + tests/Makefile + tests/parse/Makefile include/Makefile include/osmocom/Makefile include/osmocom/tcap/Makefile diff --git a/tests/Makefile.am b/tests/Makefile.am new file mode 100644 index 0000000..ce671d7 --- /dev/null +++ b/tests/Makefile.am @@ -0,0 +1,40 @@ +SUBDIRS = parse + +# The `:;' works around a Bash 3.2 bug when the output is not writeable. +$(srcdir)/package.m4: $(top_srcdir)/configure.ac + :;{ \ + echo '# Signature of the current package.' && \ + echo 'm4_define([AT_PACKAGE_NAME],' && \ + echo ' [$(PACKAGE_NAME)])' && \ + echo 'm4_define([AT_PACKAGE_TARNAME],' && \ + echo ' [$(PACKAGE_TARNAME)])' && \ + echo 'm4_define([AT_PACKAGE_VERSION],' && \ + echo ' [$(PACKAGE_VERSION)])' && \ + echo 'm4_define([AT_PACKAGE_STRING],' && \ + echo ' [$(PACKAGE_STRING)])' && \ + echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \ + echo ' [$(PACKAGE_BUGREPORT)])'; \ + echo 'm4_define([AT_PACKAGE_URL],' && \ + echo ' [$(PACKAGE_URL)])'; \ + } >'$(srcdir)/package.m4' + +EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) +TESTSUITE = $(srcdir)/testsuite +DISTCLEANFILES = atconfig + +check-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) + +installcheck-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ + $(TESTSUITEFLAGS) + +clean-local: + test ! -f '$(TESTSUITE)' || \ + $(SHELL) '$(TESTSUITE)' --clean + +AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te +AUTOTEST = $(AUTOM4TE) --language=autotest +$(TESTSUITE): $(srcdir)/testsuite.at $(srcdir)/package.m4 + $(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at + mv $@.tmp $@ diff --git a/tests/parse/Makefile.am b/tests/parse/Makefile.am new file mode 100644 index 0000000..d464e2a --- /dev/null +++ b/tests/parse/Makefile.am @@ -0,0 +1,15 @@ +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src +AM_CFLAGS = -Wall +AM_LDFLAGS = -static -no-install + +LDADD = $(top_builddir)/src/libosmo-asn1-tcap.la + +check_PROGRAMS = \ + tcap_parse_test \ + $(NULL) + +EXTRA_DIST = \ + tcap_parse_test.ok \ + $(NULL) + +tcap_parse_test_SOURCES = tcap_parse_test.c diff --git a/tests/parse/tcap_parse_test.c b/tests/parse/tcap_parse_test.c new file mode 100644 index 0000000..9e70bac --- /dev/null +++ b/tests/parse/tcap_parse_test.c @@ -0,0 +1,60 @@ +/* TCAP parsing tests */ +#include <complex.h> +#include <stdio.h> +#include <stddef.h> +#include <stdint.h> + +#include <osmocom/tcap/asn_codecs.h> +#include <osmocom/tcap/constr_TYPE.h> +#include <osmocom/tcap/OCTET_STRING.h> +#include <osmocom/tcap/ber_decoder.h> + +#include <osmocom/tcap/asn_internal.h> +#include <osmocom/tcap/TCAP_TCMessage.h> +#include <osmocom/tcap/TCAP_OrigTransactionID.h> +#include <stdlib.h> + + +static const unsigned char pkt1[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03}; + +static int write_stream(const void *buffer, size_t size, void *key) { + uint8_t *buf = (uint8_t *)buffer; + for (int i = 0; i < size; i++) + printf("%02X ", buf[i]); + printf("\n"); + return 0; +} + +int main(int argc, char **argv) +{ + asn_dec_rval_t rc; + struct TCAP_TCMessage *tcapmsg; + tcapmsg = calloc(1, sizeof(*tcapmsg)); + + printf("Basic TCAP decode testing.\n"); + + rc = ber_decode(0, &asn_DEF_TCAP_TCMessage, (void **)&tcapmsg, pkt1, sizeof(pkt1)); + if (rc.code != RC_OK) { + printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed); + } + asn_fprint(stdout, &asn_DEF_TCAP_TCMessage, tcapmsg); + ASN_STRUCT_FREE(asn_DEF_TCAP_TCMessage, tcapmsg); + + + uint8_t buf[] = {0x00, 0x01, 0x02, 0x03}; + + struct TCAP_TCMessage msg = { + .present = TCAP_TCMessage_PR_begin, + .choice.begin = { + .otid = { + .buf = buf, + .size = 4, + }, + }, + }; + + der_encode(&asn_DEF_TCAP_TCMessage, &msg, write_stream, NULL); + + printf("All tests passed.\n"); + return 0; +} diff --git a/tests/parse/tcap_parse_test.ok b/tests/parse/tcap_parse_test.ok new file mode 100644 index 0000000..6c44530 --- /dev/null +++ b/tests/parse/tcap_parse_test.ok @@ -0,0 +1,8 @@ +Basic TCAP decode testing. +Begin ::= { + otid: 00 01 02 03 +} +62 06 +48 04 +00 01 02 03 +All tests passed. diff --git a/tests/testsuite.at b/tests/testsuite.at new file mode 100644 index 0000000..8c9ce79 --- /dev/null +++ b/tests/testsuite.at @@ -0,0 +1,8 @@ +AT_INIT +AT_BANNER([Regression tests.]) + +AT_SETUP([parse]) +AT_KEYWORDS([parse]) +cat $abs_srcdir/parse/tcap_parse_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/parse/tcap_parse_test], [], [expout], [ignore]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0 Gerrit-Change-Number: 41394 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Add rate counters for loadshare-tcap
by osmith 11 Nov '25

11 Nov '25

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email ) Change subject: Add rate counters for loadshare-tcap ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > When generating the manuals it's also the matrix job where we also enable tcap, so they should show […] ack, you made it so in https://gerrit.osmocom.org/c/osmo-ci/+/41388 that manuals only get built when tcap is enabled: ``` combination_filter: > (WITH_TCAP == "1" && WITH_MANUALS == "1") || (WITH_TCAP == "0" && WITH_MANUALS == "0") ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id67704991feacf54e3123f76e9506dd323b2498b Gerrit-Change-Number: 41310 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 11 Nov 2025 07:12:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: OBS: sync_obs_projects: fix for OSC 1.12.1
by osmith 11 Nov '25

11 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email ) Change subject: OBS: sync_obs_projects: fix for OSC 1.12.1 ...................................................................... OBS: sync_obs_projects: fix for OSC 1.12.1 Since the Docker image used by sync_obs_projects was changed from Debian 12 to 13, several "osc" commands have in their output: fatal: not a git repository (or any of the parent directories): .git Work around this by switching to the temp directory and initializing a git repository there, with an "origin" remote that osc also expects to exist. Fixes: 6ac535b8 ("OBS: set default distro to debian 13") Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a --- M scripts/obs/sync_obs_projects.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index d494ed4..a82a47c 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -334,6 +334,12 @@ os.makedirs(lib.config.path_temp, exist_ok=True) + # OSC 1.12.1 from Debian Trixie fails if the current working dir isn't a + # git repository or is missing an "origin" remote + os.chdir(lib.config.path_temp) + lib.run_cmd(["git", "init"]) + lib.run_cmd(["git", "remote", "add", "origin", "."]) + # Get destination OBS projects lib.osc.set_apiurl(lib.args.to_apiurl, None) dest_projects = lib.osc.get_projects() -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a Gerrit-Change-Number: 41393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: sync_obs_projects: fix for OSC 1.12.1
by osmith 11 Nov '25

11 Nov '25

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email ) Change subject: OBS: sync_obs_projects: fix for OSC 1.12.1 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > What a weird behavior. […] yes. apparently they are moving the OBS sources from their custom versioning protocol to git (https://en.opensuse.org/openSUSE:OBS_to_Git - e.g. https://src.opensuse.org/llyyr/neovim - I guess we probably want to adapt that too at some point but it will need a lot of reworking probably on our part), and have added a lot of git-related code to osc. I didn't find a way to restore the previous behavior, this seemed the simplest solution without spending a lot of time on it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1236a065e2998fb46343df3968f7bb4dabeea55a Gerrit-Change-Number: 41393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Nov 2025 06:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Add rate counters for loadshare-tcap
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email ) Change subject: Add rate counters for loadshare-tcap ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > @laforge@gnumonks.org @osmith@sysmocom. […] When generating the manuals it's also the matrix job where we also enable tcap, so they should show up there. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id67704991feacf54e3123f76e9506dd323b2498b Gerrit-Change-Number: 41310 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 18:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 9: Code-Review-1 (11 comments) Patchset: PS8: > @pespin: I like to keep most of the #ifdef / #endif out of the code. […] I don't want to be looking at functions which turn to be noops 99% of the setups while reading at the code. And the amount of places where the tcap functionaltities need to be hooked is so small I don't see a problem with having some extra ifdefs in the few places where the calls are done. that also helps by a simple grep ENABLE_TCAP figuring out all the places where tcap related features are hooked. File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/8ec02608_e29c8… : PS8, Line 30: void *talloc_asn1_ctx; > Will check it again, if it is still required. The asn1 library changed. If it is required, do you mind explaining why? Doesn't seem obvious to me. File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/f08d589b_c5964… : PS8, Line 316: ss7_asp_tcap_rx_sccp(as, asp, opc, dpc, msg); > I want to keep the code changes to the other files minimal. […] To start with, I'd prefix it with tcap_* tbh. I can also have a look whether this is the best place to lookup the content. File src/ss7_as_loadshare_tcap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/02c34788_99b16… : PS8, Line 138: ssn ^= ((pc >> 24) & 0xff); > Wikipedia says it's 14 bits for ITU. […] 3+8+3=14 indeed, I counted wrong from the top of my head :D https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/349aace2_4a47a… : PS8, Line 273: /** Traffic from the TCAP ASP -> AS -> osmo-stp, only used to update transaction tracking > Yes it is. If TCAP is enabled on the ASP, it must track both, Rx and Tx. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/f5e0cd0c_b7bd1… : PS8, Line 380: static int sent_back_utds(struct osmo_ss7_as *as, > It sends back an SCCP/UTDS back to the origin I need to investigate about this: * The meanding of sending that UTDS thing I don't know about * Whether ROUTE-FAIL.ind would be enough * Whether the sending back up the stack would require some sort of async queue like ROUTE-FAIL.ind to avoid sending a primtiive to the user while it's busy sending the previous request primitive. Also, some spec reference here would be nice. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/a1dbbab8_4ca39… : PS8, Line 487: /* decode SCCP and convert to a SUA/xUA representation */ > I don't really see the gain from move the code back into an own function with a lot of pointers. […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/0b32957c_ff879… : PS8, Line 560: sent_back_utds(as, xua, sua, SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE); > An UTDS was requested. I don't know enough of SCCP. […] I need to investigate about this: * The meanding of sending that UTDS thing I don't know about * Whether ROUTE-FAIL.ind would be enough * Whether the sending back up the stack would require some sort of async queue like ROUTE-FAIL.ind to avoid sending a primtiive to the user while it's busy sending the previous request primitive. Also, some spec reference here would be nice. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/bff75e23_5ec77… : PS8, Line 607: * @return 0 on success > There is a difference between (rc = EPROTONOSUPPORT) and (rc = 0 && asp == NULL.) […] afaiu this should only return the asp, no need to return an rc? File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/9b30ad68_34e55… : PS8, Line 96: bool enabled; > Not all ASP of an AS has it enabled. […] Does that make sense? why would somebody want to have TCAP routing enabled on some and not all of the ASPs serving an AS? File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/04268b90_8a906… : PS8, Line 1344: tcap_asp_down(asp); > Where do you think it belongs exactly? I'm not used to this code base. I can have a look. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 18:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 7: Code-Review-2 (1 comment) Patchset: PS6: > This test does not cover (nor require) any API from libosmo-sigtran. […] I confirm my agreement with fixeria, this commit doesn't belong here and I vote against merging it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 18:22:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email ) Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 18:21:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025