September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: l1sap: move struct osmo_rlp_frame_decoded to the if-scope

by fixeria

Attention is currently required from: falconia, fixeria. Hello Jenkins Builder, falconia, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by falconia, Verified+1 by Jenkins Builder Change subject: l1sap: move struct osmo_rlp_frame_decoded to the if-scope ...................................................................... l1sap: move struct osmo_rlp_frame_decoded to the if-scope Change-Id: Ide99b35192246b0f7b2a4f31281e2d84984a9795 --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/15/38315/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide99b35192246b0f7b2a4f31281e2d84984a9795 Gerrit-Change-Number: 38315 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 3 weeks

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: set E2 bit correctly for TCH/F4.8 NT

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email ) Change subject: csd_v110: set E2 bit correctly for TCH/F4.8 NT ...................................................................... Patch Set 2: Code-Review+1 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e0ad58aad3361b3a2b0a47113bd065587636730 Gerrit-Change-Number: 38304 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 20:06:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 3 weeks

1
0
0 0

[S] Change in osmo-bts[master]: l1sap: prevent buffer overflow in l1sap_rtp_rx_cb()

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38313?usp=email ) Change subject: l1sap: prevent buffer overflow in l1sap_rtp_rx_cb() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I214070ecf7458202922475505a8747950bedf930 Gerrit-Change-Number: 38313 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 20:06:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 3 weeks

1
0
0 0

[M] Change in osmo-bts[master]: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind()

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email ) Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > > Why not instead keep the call to csd_v110_rtp_decode() where it is [...] > > I think we will need to pass TDMA Fn to `csd_v110_rtp_decode()` too, in order to ensure the correct ordering of the RLP frame halves for TCH/F4.8 NT. We loose bits E1/E2/E3 when calling `csd_v110_rtp_decode()` (they're not part of the modified Um V.110 frames), and thus we cannot ensure the alignment after that... Do you have a better idea? I do have a better idea, and I am going to produce a series of patches implementing it. Please give me a little more time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idca6807b1e49b89072683b9f00ff4e7cee44cf33 Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 20:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 3 weeks

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: set E2 bit correctly for TCH/F4.8 NT

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email ) Change subject: csd_v110: set E2 bit correctly for TCH/F4.8 NT ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > I can give this patch a try and send you a PCAP. […] As indicated in OS#6578 ticket, this patch is ready to come out of WIP. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e0ad58aad3361b3a2b0a47113bd065587636730 Gerrit-Change-Number: 38304 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 19:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 3 weeks

1
0
0 0

[M] Change in osmo-bts[master]: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind()

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email ) Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Why not instead keep the call to csd_v110_rtp_decode() where it is [...] I think we will need to pass TDMA Fn to `csd_v110_rtp_decode()` too, in order to ensure the correct ordering of the RLP frame halves for TCH/F4.8 NT. We loose bits E1/E2/E3 when calling `csd_v110_rtp_decode()` (they're not part of the modified Um V.110 frames), and thus we cannot ensure the alignment after that... Do you have a better idea? In `l1sap_tch_rts_ind()` you have an option to put TCH.req back to the queue if it does not align with the requested TDMA Fn, so that it can be dequeued and transmitted next time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idca6807b1e49b89072683b9f00ff4e7cee44cf33 Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 19:10:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>

8 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bts[master]: l1sap: move struct osmo_rlp_frame_decoded to the if-scope

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email ) Change subject: l1sap: move struct osmo_rlp_frame_decoded to the if-scope ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide99b35192246b0f7b2a4f31281e2d84984a9795 Gerrit-Change-Number: 38315 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:38:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 3 weeks

1
0
0 0

[M] Change in osmo-bts[master]: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind()

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email ) Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I don't like the approach of moving the call to `csd_v110_rtp_decode()` from where it is now - you are then having to do more memory moves than were necessary before. Why not instead keep the call to `csd_v110_rtp_decode()` where it is, and only move the call to `gsmtap_csd_rlp_process()`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idca6807b1e49b89072683b9f00ff4e7cee44cf33 Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

8 months, 3 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: tlv/cosmetic: improve import of osmocom functions

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38288?usp=email ) Change subject: tlv/cosmetic: improve import of osmocom functions ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/python/pyosmocom/+/38288/comment/cb33eb5d_9c0c… : PS1, Line 9: We can import osmocom and then reference > Of course we can do that, but what exactly does this improve? […] yes, there is such a conflict and I've asked @pmaier to mention this already in my feedback https://gerrit.osmocom.org/c/python/pyosmocom/+/38288/comments/744d81f2_da2… AFAICT, pmaier split this out from a larger patch I originally created. I didn't have an explanation as it was not a separate patch. This must also be merged *before* tagging 0.0.5 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I6ce3cffbce9b276de7b223d88268d35cf2706d6a Gerrit-Change-Number: 38288 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 17:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: osmocom.construct.Asn1DerInteger

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email ) Change subject: osmocom.construct.Asn1DerInteger ...................................................................... osmocom.construct.Asn1DerInteger This is a 'construct' type which can be used for encoding/decoding integer values according to ASN.1 DER encoding rules. Related: SYS#7094 Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac --- M src/osmocom/construct.py M tests/test_construct.py 2 files changed, 73 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 7c0f034..5a78246 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -600,6 +600,19 @@ stream_write(stream, data, length, path) return obj +class Asn1DerInteger(Construct): + """A signed integer value using ASN.1 DER encoding rules (see also ITU-T X.690 8.3)""" + def _parse(self, stream, context, path): + data = stream_read_entire(stream, path) + return int.from_bytes(data, byteorder='big', signed=True) + + def _build(self, obj, stream, context, path): + if not isinstance(obj, integertypes): + raise IntegerError(f"value {obj} is not an integer", path=path) + val = obj.to_bytes(int_bytes_required(obj, signed=True), byteorder='big', signed=True) + stream_write(stream, val, len(val), path) + return obj + # merged definitions of 24.008 + 23.040 TypeOfNumber = Enum(BitsInteger(3), unknown=0, international=1, national=2, network_specific=3, short_code=4, alphanumeric=5, abbreviated=6, reserved_for_extension=7) diff --git a/tests/test_construct.py b/tests/test_construct.py index c2aeece..ba4f8f4 100755 --- a/tests/test_construct.py +++ b/tests/test_construct.py @@ -114,6 +114,66 @@ self.assertEqual(re_enc, enc) +class TestAsn1DerInteger(unittest.TestCase): + + tests = [ + # positive numbers + ( b'\x00', 0 ), + ( b'\x01', 1 ), + ( b'\x02', 2 ), + ( b'\x7f', 127 ), + ( b'\x00\x80', 128 ), + ( b'\x00\x81', 129 ), + ( b'\x00\xfe', 254 ), + ( b'\x01\x00', 256 ), + ( b'\x01\x01', 257 ), + ( b'\x7f\xff', 32767 ), + ( b'\x00\x80\x00', 32768 ), + ( b'\x00\x80\x01', 32769 ), + ( b'\x00\xff\xfe', 65534 ), + ( b'\x00\xff\xff', 65535 ), + ( b'\x01\x00\x00', 65536 ), + + # negative numbers + ( b'\x00', -0 ), + ( b'\xff', -1 ), + ( b'\xfe', -2 ), + ( b'\x81', -127 ), + ( b'\x80', -128 ), + ( b'\xff\x7f', -129 ), + ( b'\xff\x02', -254 ), + ( b'\xff\x00', -256 ), + ( b'\xfe\xff', -257 ), + ( b'\x80\x01', -32767 ), + ( b'\x80\x00', -32768 ), + ( b'\xff\x7f\xff', -32769 ), + ( b'\xff\x00\x02', -65534 ), + ( b'\xff\x00\x01', -65535 ), + ( b'\xff\x00\x00', -65536 ), + ] + + def test_encode(self): + adi = Asn1DerInteger() + + # Verfiy with chosen numbers + for t in self.tests: + self.assertEqual(t[0], adi.build(t[1])) + + # Verify that ITU-T X.690 8.3.2 is always complied with (for standard two's + # complement that should always be the case) + for i in range(-100000,100000): + res = adi.build(i) + if len(res) > 1: + self.assertFalse(int(res[0]) == 0xff and int(res[1]) & 0x80 == 0x80) + self.assertFalse(int(res[0]) == 0x00 and int(res[1]) & 0x80 == 0x00) + + def test_decode(self): + adi = Asn1DerInteger() + + # Verfiy with chosen numbers + for t in self.tests: + self.assertEqual(t[1], adi.parse(t[0])) + if __name__ == "__main__": unittest.main() -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac Gerrit-Change-Number: 38272 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

8 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024