Attention is currently required from: falconia. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email ) Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2:

Why not instead keep the call to csd_v110_rtp_decode() where it is [...]

I think we will need to pass TDMA Fn to `csd_v110_rtp_decode()` too, in order to ensure the correct ordering of the RLP frame halves for TCH/F4.8 NT. We loose bits E1/E2/E3 when calling `csd_v110_rtp_decode()` (they're not part of the modified Um V.110 frames), and thus we cannot ensure the alignment after that... Do you have a better idea? In `l1sap_tch_rts_ind()` you have an option to put TCH.req back to the queue if it does not align with the requested TDMA Fn, so that it can be dequeued and transmitted next time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idca6807b1e49b89072683b9f00ff4e7cee44cf33 Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon@freecalypso.org> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 19:10:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon@freecalypso.org>