Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email ) Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I don't like the approach of moving the call to `csd_v110_rtp_decode()` from where it is now - you are then having to do more memory moves than were necessary before. Why not instead keep the call to `csd_v110_rtp_decode()` where it is, and only move the call to `gsmtap_csd_rlp_process()`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idca6807b1e49b89072683b9f00ff4e7cee44cf33 Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon@freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No