August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: Increase S1AP setup timeout

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37927?usp=email ) Change subject: s1gw: Increase S1AP setup timeout ...................................................................... s1gw: Increase S1AP setup timeout The existing timer is too tight, specially when running tons of components concurrently. Change-Id: I99d554bf0dd0f4c1dbd801663c1801f3725df09f --- M s1gw/ConnHdlr.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/37927/1 diff --git a/s1gw/ConnHdlr.ttcn b/s1gw/ConnHdlr.ttcn index 408b315..e4cff0c 100644 --- a/s1gw/ConnHdlr.ttcn +++ b/s1gw/ConnHdlr.ttcn @@ -167,7 +167,7 @@ } } -function f_ConnHdlr_setup(Global_ENB_ID genb_id) runs on ConnHdlr { +function f_ConnHdlr_setup(Global_ENB_ID genb_id, float Tval := 5.0) runs on ConnHdlr { var S1AP_PDU pdu; timer T; @@ -182,7 +182,7 @@ f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_SetupReq(genb_id, supported_tas_dummy, v32)); - T.start(1.0); + T.start(Tval); alt { [] S1AP_CONN.receive(S1APSRV_Event:S1APSRV_EVENT_CONN_UP) { repeat; } [] S1AP_CONN.receive(tr_S1AP_SetupReq) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I99d554bf0dd0f4c1dbd801663c1801f3725df09f Gerrit-Change-Number: 37927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: Make components alive

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37928?usp=email ) Change subject: s1gw: Make components alive ...................................................................... s1gw: Make components alive This helps avoiding getting errors during test tear down. TC_conn_term_mme_unavail needs to be modified since the port is kept alive after it is stopped, so test needs to be adapted. Change-Id: I538e31bf14836f81a6e3c0b844f9f70f1eaccb59 --- M s1gw/S1GW_Tests.ttcn 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/37928/1 diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 5e2433e..1f4bb71 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -61,7 +61,7 @@ local_port := 36412 }; - vc_S1APSRV := S1AP_Server_CT.create("S1APSRV-" & testcasename()); + vc_S1APSRV := S1AP_Server_CT.create("S1APSRV-" & testcasename()) alive; vc_S1APSRV.start(S1AP_Server.main(cpars)); } @@ -69,7 +69,7 @@ runs on test_CT return ConnHdlr { var ConnHdlr vc_conn; - vc_conn := ConnHdlr.create("ConnHdlr-" & testcasename()); + vc_conn := ConnHdlr.create("ConnHdlr-" & testcasename()) alive; if (vc_S1APSRV.running) { connect(vc_conn:S1AP_CONN, vc_S1APSRV:S1AP_CLIENT); connect(vc_conn:S1AP_PROC, vc_S1APSRV:S1AP_PROC); @@ -157,9 +157,6 @@ var ConnHdlr vc_conn; f_init(); - f_init_s1ap_srv(); - vc_S1APSRV.stop; - vc_S1APSRV.done; vc_conn := f_ConnHdlr_spawn(refers(f_TC_conn_term_mme_unavail), pars); vc_conn.done; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I538e31bf14836f81a6e3c0b844f9f70f1eaccb59 Gerrit-Change-Number: 37928 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: Validate S1SetupResp is forwarded fine MME->ENB

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37915?usp=email ) Change subject: s1gw: Validate S1SetupResp is forwarded fine MME->ENB ...................................................................... s1gw: Validate S1SetupResp is forwarded fine MME->ENB Change-Id: I6d9b060eb81269c7cb76e007f669c5b9ead97158 --- M library/s1ap/S1AP_Templates.ttcn M s1gw/ConnHdlr.ttcn 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 64167ec..05ab63b 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -81,6 +81,24 @@ } /* 9.1.8.5 S1 SETUP RESPONSE */ +template (value) ServedGUMMEIsItem +ts_S1AP_ServedGUMMEIsItem(template (value) ServedPLMNs servedPLMNs, + template (value) ServedGroupIDs servedGroupIDs, + template (value) ServedMMECs servedMMECs) := { + servedPLMNs := servedPLMNs, + servedGroupIDs := servedGroupIDs, + servedMMECs := servedMMECs, + iE_Extensions := omit +} +template (present) ServedGUMMEIsItem +tr_S1AP_ServedGUMMEIsItem(template (present) ServedPLMNs servedPLMNs := ?, + template (present) ServedGroupIDs servedGroupIDs := ?, + template (present) ServedMMECs servedMMECs := ?) := { + servedPLMNs := servedPLMNs, + servedGroupIDs := servedGroupIDs, + servedMMECs := servedMMECs, + iE_Extensions := * +} template (value) S1AP_PDU ts_S1AP_SetupResp(template (value) ServedGUMMEIs served_gummeis, template (value) RelativeMMECapacity rel_mme_capacity) := { diff --git a/s1gw/ConnHdlr.ttcn b/s1gw/ConnHdlr.ttcn index 4b906c2..408b315 100644 --- a/s1gw/ConnHdlr.ttcn +++ b/s1gw/ConnHdlr.ttcn @@ -186,7 +186,16 @@ alt { [] S1AP_CONN.receive(S1APSRV_Event:S1APSRV_EVENT_CONN_UP) { repeat; } [] S1AP_CONN.receive(tr_S1AP_SetupReq) { - setverdict(pass); + var template (value) PLMNidentity plmn_id := '00f110'O; + var template (value) MME_Group_ID mme_group_id := '0011'O; + var template (value) MME_Code mme_code := '55'O; + var template (value) ServedGUMMEIsItem gummei := ts_S1AP_ServedGUMMEIsItem( + { plmn_id }, + { mme_group_id }, + { mme_code } + ); + f_ConnHdlr_tx_s1ap_from_mme(ts_S1AP_SetupResp({ gummei }, 1)); + f_ConnHdlr_rx_s1ap_from_mme(pdu, tr_S1AP_SetupResp({ gummei }, 1)); T.stop; } [] S1AP_CONN.receive(S1AP_PDU:?) -> value pdu { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d9b060eb81269c7cb76e007f669c5b9ead97158 Gerrit-Change-Number: 37915 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in pysim[master]: contrib: script to generate "update" commands from diff of fsdumps

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37926?usp=email ) Change subject: contrib: script to generate "update" commands from diff of fsdumps ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I08897cd353093575f98c68580afbc68b6f2f878f Gerrit-Change-Number: 37926 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Aug 2024 08:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[S] Change in pysim[master]: pySim.apdu_source.stdin_hex

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 1: (2 comments) File pySim/apdu_source/stdin_hex.py: https://gerrit.osmocom.org/c/pysim/+/37925/comment/a93a18d6_ed1e14ef?usp=em… : PS1, Line 35: command = None : response = None Unneeded assignments? https://gerrit.osmocom.org/c/pysim/+/37925/comment/6b207f0b_9bd335c8?usp=em… : PS1, Line 41: raise StopIteration How do we get here? IIUC, only an exception can break out the loop, like a `KeyboardInterrupt`. But you're not catching exceptions here, so I am not sure if this code is reachable at all. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 08:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

10 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: Validate S1SetupResp is forwarded fine MME->ENB

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37915?usp=email ) Change subject: s1gw: Validate S1SetupResp is forwarded fine MME->ENB ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d9b060eb81269c7cb76e007f669c5b9ead97158 Gerrit-Change-Number: 37915 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 08:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: pySim.esim.saip: Add missing entry for 'rfm' to class4petype

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37859?usp=email ) Change subject: pySim.esim.saip: Add missing entry for 'rfm' to class4petype ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5fec2b026fc6a1197fc1e18d880ea6d10fd4a611 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 07:56:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[S] Change in pysim[master]: ara_m: use class byte of current lchan

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email ) Change subject: ara_m: use class byte of current lchan ...................................................................... Patch Set 7: Code-Review-1 (1 comment) Patchset: PS6: > This is interesting. I have looked up MANAGE CHANNEL in ETSI TS 102.221. […] Ok, I was mistaken (was recalling this from memory). MANAGE CHANNEL is not affected. However, TS 102 221 Table 10.5 states several other instructions that must have CLA=80 and hence do not support logical channels: TERMINAL PROFILE, TERMINAL RESPONSE, FETCH, ENVELOPE and SUSPEND UICC. Rel 17 now also has EXCHANGE CAPABILITIES and MANAGE LSI, but we don't support those yet. Other specs may at least in theory also have similar constraaints in the table defining their CLA bytes. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 07:20:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in pysim[master]: contrib: script to generate "update" commands from diff of fsdumps

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37926?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: contrib: script to generate "update" commands from diff of fsdumps ...................................................................... contrib: script to generate "update" commands from diff of fsdumps Change-Id: I08897cd353093575f98c68580afbc68b6f2f878f --- A contrib/fsdump-diff-apply.py 1 file changed, 169 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/26/37926/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I08897cd353093575f98c68580afbc68b6f2f878f Gerrit-Change-Number: 37926 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org>

10 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Add initial PFCP support emulating UPF

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email ) Change subject: s1gw: Add initial PFCP support emulating UPF ...................................................................... Patch Set 2: (3 comments) File s1gw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/d90492f3_1e30… : PS2, Line 185: float Tval := 5.0 > Because sometimes the timeouts were too tight, specially when creating tons of sessions where then a […] I see, but this function is all about the S1AP Setup. This particular message does not trigger any PFCP procedures; the PDUs are passed as-is. This is why I am wondering why and whether it really belongs to this patch logically. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/c559db86_1ce8… : PS2, Line 269: do_repeat := true > only once, but since it's an activate, it has to be a repeat otherwise when code goes into whatever […] Ah, I see. Indeed, we need to `repeat` then. File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/4d10e572_b9f1… : PS2, Line 81: id) alive > TBH I don't think it's worth spending time in splitting this ... On the one hand, yes. One the other, I oftentimes feel puzzled when I track some change in git-blame and end up with a patch doing something else and changing things by the way. In such case neither the commit name nor the description tells you *why*. > id: I'm simply refactoring code since anyway i need to add a lot of infra when adding the pfcp side. This is just moving `testcasename()` from within the function to the caller. Does the PFCP related logic require to pass custom `id` here? I don't think so. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 Gerrit-Change-Number: 37920 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 04:46:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024