Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 1: (2 comments) File pySim/apdu_source/stdin_hex.py: https://gerrit.osmocom.org/c/pysim/+/37925/comment/a93a18d6_ed1e14ef?usp=ema... : PS1, Line 35: command = None : response = None Unneeded assignments? https://gerrit.osmocom.org/c/pysim/+/37925/comment/6b207f0b_9bd335c8?usp=ema... : PS1, Line 41: raise StopIteration How do we get here? IIUC, only an exception can break out the loop, like a `KeyboardInterrupt`. But you're not catching exceptions here, so I am not sure if this code is reachable at all. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 08:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No