Attention is currently required from: dexter, laforge.

View Change

2 comments:

• File pySim/apdu_source/stdin_hex.py:

  • Patch Set #1, Line 35:

    command = None
            response = None
    

    Unneeded assignments?

  • Patch Set #1, Line 41: raise StopIteration

    How do we get here? IIUC, only an exception can break out the loop, like a `KeyboardInterrupt`. But you're not catching exceptions here, so I am not sure if this code is reachable at all.

To view, visit change 37925. To unsubscribe, or for help writing mail filters, visit settings.