August 2024 - gerrit-log - lists.osmocom.org

[M] Change in libgtpnl[master]: fix clang build

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email ) Change subject: fix clang build ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I345579a8ea989c5a21797a17f34629472fbd3525 Gerrit-Change-Number: 37929 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 09:54:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[M] Change in libgtpnl[master]: fix clang build

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email ) Change subject: fix clang build ...................................................................... fix clang build Clang needs the configure patch that exists in most of our repos + visibility, because clang says warning: attribute declaration must precede definition [-Wignored-attributes] and the .so has no exports. Change-Id: I345579a8ea989c5a21797a17f34629472fbd3525 --- M configure.ac M src/genl.c M src/gtp-genl.c M src/gtp-rtnl.c M src/gtp.c 5 files changed, 41 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/29/37929/1 diff --git a/configure.ac b/configure.ac index 1628bc8..90e4dce 100644 --- a/configure.ac +++ b/configure.ac @@ -35,6 +35,12 @@ AC_EXEEXT AC_DISABLE_STATIC LT_INIT + +dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang +AS_CASE(["$LD"],[*clang*], + [AS_CASE(["${host_os}"], + [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])]) + CHECK_GCC_FVISIBILITY case "$host" in *-*-linux* | *-*-uclinux*) ;; diff --git a/src/genl.c b/src/genl.c index 5d8b9af..572bed9 100644 --- a/src/genl.c +++ b/src/genl.c @@ -32,6 +32,7 @@ #include "internal.h" +EXPORT_SYMBOL(genl_nlmsg_build_hdr); struct nlmsghdr * genl_nlmsg_build_hdr(char *buf, uint16_t type, uint16_t flags, uint32_t seq, uint8_t cmd) @@ -50,7 +51,6 @@ return nlh; } -EXPORT_SYMBOL(genl_nlmsg_build_hdr); static int genl_ctrl_validate_cb(const struct nlattr *attr, void *data) { @@ -87,6 +87,7 @@ return MNL_CB_OK; } +EXPORT_SYMBOL(genl_socket_open); struct mnl_socket *genl_socket_open(void) { struct mnl_socket *nl; @@ -104,14 +105,14 @@ return nl; } -EXPORT_SYMBOL(genl_socket_open); +EXPORT_SYMBOL(genl_socket_close); void genl_socket_close(struct mnl_socket *nl) { mnl_socket_close(nl); } -EXPORT_SYMBOL(genl_socket_close); +EXPORT_SYMBOL(genl_socket_talk); int genl_socket_talk(struct mnl_socket *nl, struct nlmsghdr *nlh, uint32_t seq, int (*cb)(const struct nlmsghdr *nlh, void *data), void *data) @@ -135,7 +136,6 @@ return ret; } -EXPORT_SYMBOL(genl_socket_talk); static struct nlmsghdr * genl_nlmsg_build_lookup(char *buf, const char *subsys_name) @@ -158,6 +158,7 @@ return nlh; } +EXPORT_SYMBOL(genl_lookup_family); int genl_lookup_family(struct mnl_socket *nl, const char *family) { int32_t genl_id; @@ -171,4 +172,3 @@ return genl_id; } -EXPORT_SYMBOL(genl_lookup_family); diff --git a/src/gtp-genl.c b/src/gtp-genl.c index 33a78d8..ef8dfc0 100644 --- a/src/gtp-genl.c +++ b/src/gtp-genl.c @@ -96,6 +96,7 @@ } } +EXPORT_SYMBOL(gtp_add_tunnel); int gtp_add_tunnel(int genl_id, struct mnl_socket *nl, struct gtp_tunnel *t) { struct nlmsghdr *nlh; @@ -119,8 +120,8 @@ return 0; } -EXPORT_SYMBOL(gtp_add_tunnel); +EXPORT_SYMBOL(gtp_del_tunnel); int gtp_del_tunnel(int genl_id, struct mnl_socket *nl, struct gtp_tunnel *t) { char buf[MNL_SOCKET_BUFFER_SIZE]; @@ -138,7 +139,6 @@ return 0; } -EXPORT_SYMBOL(gtp_del_tunnel); struct gtp_pdp { uint32_t ifidx; @@ -270,6 +270,7 @@ return MNL_CB_OK; } +EXPORT_SYMBOL(gtp_list_tunnel); int gtp_list_tunnel(int genl_id, struct mnl_socket *nl) { char buf[MNL_SOCKET_BUFFER_SIZE]; @@ -286,4 +287,3 @@ return 0; } -EXPORT_SYMBOL(gtp_list_tunnel); diff --git a/src/gtp-rtnl.c b/src/gtp-rtnl.c index 1dfd125..6baa5a6 100644 --- a/src/gtp-rtnl.c +++ b/src/gtp-rtnl.c @@ -138,18 +138,19 @@ return gtp_dev_talk(nlh, seq); } +EXPORT_SYMBOL(gtp_dev_create); int gtp_dev_create(int dest_ns, const char *gtp_ifname, int fd0, int fd1) { return _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_GGSN); } -EXPORT_SYMBOL(gtp_dev_create); +EXPORT_SYMBOL(gtp_dev_create_sgsn); int gtp_dev_create_sgsn(int dest_ns, const char *gtp_ifname, int fd0, int fd1) { return _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_SGSN); } -EXPORT_SYMBOL(gtp_dev_create_sgsn); +EXPORT_SYMBOL(gtp_dev_destroy); int gtp_dev_destroy(const char *gtp_ifname) { char buf[MNL_SOCKET_BUFFER_SIZE]; @@ -166,8 +167,8 @@ return gtp_dev_talk(nlh, seq); } -EXPORT_SYMBOL(gtp_dev_destroy); +EXPORT_SYMBOL(gtp_dev_config); int gtp_dev_config(const char *ifname, struct in_addr *dst, uint32_t prefix) { struct mnl_socket *nl; @@ -211,4 +212,3 @@ return ret; } -EXPORT_SYMBOL(gtp_dev_config); diff --git a/src/gtp.c b/src/gtp.c index af216f7..8f12b5d 100644 --- a/src/gtp.c +++ b/src/gtp.c @@ -27,6 +27,7 @@ #include "internal.h" +EXPORT_SYMBOL(gtp_tunnel_alloc); struct gtp_tunnel *gtp_tunnel_alloc(void) { struct gtp_tunnel *t; @@ -38,152 +39,151 @@ t->ifns = -1; return t; } -EXPORT_SYMBOL(gtp_tunnel_alloc); +EXPORT_SYMBOL(gtp_tunnel_free); void gtp_tunnel_free(struct gtp_tunnel *t) { free(t); } -EXPORT_SYMBOL(gtp_tunnel_free); +EXPORT_SYMBOL(gtp_tunnel_set_ifns); void gtp_tunnel_set_ifns(struct gtp_tunnel *t, int ifns) { t->ifns = ifns; t->flags |= GTP_TUN_IFNS; } -EXPORT_SYMBOL(gtp_tunnel_set_ifns); +EXPORT_SYMBOL(gtp_tunnel_set_ifidx); void gtp_tunnel_set_ifidx(struct gtp_tunnel *t, uint32_t ifidx) { t->ifidx = ifidx; t->flags |= GTP_TUN_IFIDX; } -EXPORT_SYMBOL(gtp_tunnel_set_ifidx); +EXPORT_SYMBOL(gtp_tunnel_set_family); void gtp_tunnel_set_family(struct gtp_tunnel *t, uint16_t family) { t->ms_addr.family = family; t->flags |= GTP_TUN_FAMILY; } -EXPORT_SYMBOL(gtp_tunnel_set_family); +EXPORT_SYMBOL(gtp_tunnel_set_ms_ip4); void gtp_tunnel_set_ms_ip4(struct gtp_tunnel *t, struct in_addr *ms_addr) { t->ms_addr.family = AF_INET; t->ms_addr.ip4 = *ms_addr; t->flags |= GTP_TUN_FAMILY | GTP_TUN_MS_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_ms_ip4); +EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip4); void gtp_tunnel_set_sgsn_ip4(struct gtp_tunnel *t, struct in_addr *sgsn_addr) { t->sgsn_addr.family = AF_INET; t->sgsn_addr.ip4 = *sgsn_addr; t->flags |= GTP_TUN_SGSN_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip4); +EXPORT_SYMBOL(gtp_tunnel_set_ms_ip6); void gtp_tunnel_set_ms_ip6(struct gtp_tunnel *t, const struct in6_addr *ms_addr) { t->ms_addr.family = AF_INET6; t->ms_addr.ip6 = *ms_addr; t->flags |= GTP_TUN_FAMILY | GTP_TUN_MS_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_ms_ip6); +EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip6); void gtp_tunnel_set_sgsn_ip6(struct gtp_tunnel *t, const struct in6_addr *sgsn_addr) { t->sgsn_addr.family = AF_INET6; t->sgsn_addr.ip6 = *sgsn_addr; t->flags |= GTP_TUN_SGSN_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip6); +EXPORT_SYMBOL(gtp_tunnel_set_version); void gtp_tunnel_set_version(struct gtp_tunnel *t, uint32_t version) { t->gtp_version = version; t->flags |= GTP_TUN_VERSION; } -EXPORT_SYMBOL(gtp_tunnel_set_version); +EXPORT_SYMBOL(gtp_tunnel_set_tid); void gtp_tunnel_set_tid(struct gtp_tunnel *t, uint64_t tid) { t->u.v0.tid = tid; t->flags |= GTP_TUN_V0_TID; } -EXPORT_SYMBOL(gtp_tunnel_set_tid); +EXPORT_SYMBOL(gtp_tunnel_set_flowid); void gtp_tunnel_set_flowid(struct gtp_tunnel *t, uint16_t flowid) { t->u.v0.flowid = flowid; t->flags |= GTP_TUN_V0_FLOWID; } -EXPORT_SYMBOL(gtp_tunnel_set_flowid); +EXPORT_SYMBOL(gtp_tunnel_set_i_tei); void gtp_tunnel_set_i_tei(struct gtp_tunnel *t, uint32_t i_tei) { t->u.v1.i_tei = i_tei; t->flags |= GTP_TUN_V1_I_TEI; } -EXPORT_SYMBOL(gtp_tunnel_set_i_tei); +EXPORT_SYMBOL(gtp_tunnel_set_o_tei); void gtp_tunnel_set_o_tei(struct gtp_tunnel *t, uint32_t o_tei) { t->u.v1.o_tei = o_tei; t->flags |= GTP_TUN_V1_O_TEI; } -EXPORT_SYMBOL(gtp_tunnel_set_o_tei); +EXPORT_SYMBOL(gtp_tunnel_get_ifns); const int gtp_tunnel_get_ifns(struct gtp_tunnel *t) { return t->ifns; } -EXPORT_SYMBOL(gtp_tunnel_get_ifns); +EXPORT_SYMBOL(gtp_tunnel_get_ifidx); const uint32_t gtp_tunnel_get_ifidx(struct gtp_tunnel *t) { return t->ifidx; } -EXPORT_SYMBOL(gtp_tunnel_get_ifidx); +EXPORT_SYMBOL(gtp_tunnel_get_ms_ip4); const struct in_addr *gtp_tunnel_get_ms_ip4(struct gtp_tunnel *t) { return &t->ms_addr.ip4; } -EXPORT_SYMBOL(gtp_tunnel_get_ms_ip4); +EXPORT_SYMBOL(gtp_tunnel_get_sgsn_ip4); const struct in_addr *gtp_tunnel_get_sgsn_ip4(struct gtp_tunnel *t) { return &t->sgsn_addr.ip4; } -EXPORT_SYMBOL(gtp_tunnel_get_sgsn_ip4); +EXPORT_SYMBOL(gtp_tunnel_get_version); int gtp_tunnel_get_version(struct gtp_tunnel *t) { return t->gtp_version; } -EXPORT_SYMBOL(gtp_tunnel_get_version); +EXPORT_SYMBOL(gtp_tunnel_get_tid); uint64_t gtp_tunnel_get_tid(struct gtp_tunnel *t) { return t->u.v0.tid; } -EXPORT_SYMBOL(gtp_tunnel_get_tid); +EXPORT_SYMBOL(gtp_tunnel_get_flowid); uint16_t gtp_tunnel_get_flowid(struct gtp_tunnel *t) { return t->u.v0.flowid; } -EXPORT_SYMBOL(gtp_tunnel_get_flowid); +EXPORT_SYMBOL(gtp_tunnel_get_i_tei); uint32_t gtp_tunnel_get_i_tei(struct gtp_tunnel *t) { return t->u.v1.i_tei; } -EXPORT_SYMBOL(gtp_tunnel_get_i_tei); +EXPORT_SYMBOL(gtp_tunnel_get_o_tei); uint32_t gtp_tunnel_get_o_tei(struct gtp_tunnel *t) { return t->u.v1.o_tei; } -EXPORT_SYMBOL(gtp_tunnel_get_o_tei); -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I345579a8ea989c5a21797a17f34629472fbd3525 Gerrit-Change-Number: 37929 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: src/core/socket.c: Fix close of negative fd in system_supports_inet6()

by lynxis lazus

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37894?usp=email ) Change subject: src/core/socket.c: Fix close of negative fd in system_supports_inet6() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iedd0f74688cacd8dbe4b46b2c7e03a6c2f56fbbf Gerrit-Change-Number: 37894 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Aug 2024 16:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: filesystem: fix double space in docstring

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37916?usp=email ) Change subject: filesystem: fix double space in docstring ...................................................................... filesystem: fix double space in docstring Change-Id: I69ef171ac2dd2e2717404b1f3b10f986af419f6e --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 805983b..35af140 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1333,7 +1333,7 @@ @cmd2.with_argparser(del_data_parser) def do_delete_data(self, opts): - """Delete data for a given tag in a BER-TLV EF""" + """Delete data for a given tag in a BER-TLV EF""" (data, _sw) = self._cmd.lchan.set_data(opts.tag, None) if data: self._cmd.poutput(data) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I69ef171ac2dd2e2717404b1f3b10f986af419f6e Gerrit-Change-Number: 37916 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: filesystem: fix double space in docstring

by dexter

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37916?usp=email ) Change subject: filesystem: fix double space in docstring ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I69ef171ac2dd2e2717404b1f3b10f986af419f6e Gerrit-Change-Number: 37916 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 12:03:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: Abort and reply call with error if unable to establish PFCP...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email ) Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ...................................................................... erab_fsm: Abort and reply call with error if unable to establish PFCP sess Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 --- M src/erab_fsm.erl 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index 544f5ab..ae17a6e 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -170,11 +170,17 @@ %% state SESSION_ESTABLISH :: PFCP session establishment -session_establish(enter, OldState, S) -> +session_establish(enter, OldState, #erab_state{from = From} = S) -> ?LOG_DEBUG("State change: ~p -> ~p", [OldState, ?FUNCTION_NAME]), - ok = session_establish_req(S), - {next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout - [{state_timeout, ?ERAB_T_SESSION_ESTABLISH, ?FUNCTION_NAME}]}; + case session_establish_req(S) of + ok -> + {next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout + [{state_timeout, ?ERAB_T_SESSION_ESTABLISH, ?FUNCTION_NAME}]}; + {error, Reason} -> + {stop_and_reply, + {shutdown, Reason}, + {reply, From, {error, Reason}}} + end; session_establish(state_timeout, _Timeout, #erab_state{from = From}) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 Gerrit-Change-Number: 37923 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Add initial PFCP support emulating UPF

by pespin

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: s1gw: Add initial PFCP support emulating UPF ...................................................................... s1gw: Add initial PFCP support emulating UPF Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 --- M library/PFCP_Emulation.ttcn M s1gw/ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M s1gw/gen_links.sh M s1gw/osmo-s1gw.config M s1gw/regen_makefile.sh 6 files changed, 144 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/37920/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 Gerrit-Change-Number: 37920 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: Abort and reply call with error if unable to establish PFCP...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email ) Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/5cf30d3c_c0d8… : PS1, Line 181: timeout > well, in hear clearly the error is not a timeout, but some error with reason=Reason. […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 Gerrit-Change-Number: 37923 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 10:54:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Add initial PFCP support emulating UPF

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email ) Change subject: s1gw: Add initial PFCP support emulating UPF ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File s1gw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/ad923407_ccd1… : PS4, Line 247: var PDU_PFCP rx; unused -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 Gerrit-Change-Number: 37920 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 10:52:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: Make components alive

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37928?usp=email ) Change subject: s1gw: Make components alive ...................................................................... s1gw: Make components alive This helps avoiding getting errors during test tear down. TC_conn_term_mme_unavail needs to be modified since the port is kept alive after it is stopped, so test needs to be adapted. Change-Id: I538e31bf14836f81a6e3c0b844f9f70f1eaccb59 --- M s1gw/S1GW_Tests.ttcn 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 5e2433e..1f4bb71 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -61,7 +61,7 @@ local_port := 36412 }; - vc_S1APSRV := S1AP_Server_CT.create("S1APSRV-" & testcasename()); + vc_S1APSRV := S1AP_Server_CT.create("S1APSRV-" & testcasename()) alive; vc_S1APSRV.start(S1AP_Server.main(cpars)); } @@ -69,7 +69,7 @@ runs on test_CT return ConnHdlr { var ConnHdlr vc_conn; - vc_conn := ConnHdlr.create("ConnHdlr-" & testcasename()); + vc_conn := ConnHdlr.create("ConnHdlr-" & testcasename()) alive; if (vc_S1APSRV.running) { connect(vc_conn:S1AP_CONN, vc_S1APSRV:S1AP_CLIENT); connect(vc_conn:S1AP_PROC, vc_S1APSRV:S1AP_PROC); @@ -157,9 +157,6 @@ var ConnHdlr vc_conn; f_init(); - f_init_s1ap_srv(); - vc_S1APSRV.stop; - vc_S1APSRV.done; vc_conn := f_ConnHdlr_spawn(refers(f_TC_conn_term_mme_unavail), pars); vc_conn.done; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I538e31bf14836f81a6e3c0b844f9f70f1eaccb59 Gerrit-Change-Number: 37928 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024