August 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: erab_fsm: Abort and reply call with error if unable to establish PFCP...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email ) Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ...................................................................... Patch Set 1: (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/b294973f_390a… : PS1, Line 176: next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout > Yes, that sounded weird to me at the time when you said so. […] Ok, I see you have also changed the loop transition to `keep_state` in the `pfcp_peer` (Ic17c1c7210ab4ae0ddc840a5ffd13b7cdda243c9). I gave it a try and indeed it's working as expected: the peer re-tries association. This is weird, because I spent quite some time debugging and figuring out why state timeout does not work, e.g. here: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265. Maybe it was a bug of older Erlang/OTP version, or this problem occurs only under some conditions. I would keep it as-is for now, until we know more about this problem. Strictly speaking, changing from `next_state` to `keep_state` is not needed to get things done in this patch. You're just doing this by the way since you're touching the related code path, but this is clearly not a must in this case. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/763ea469_5e49… : PS1, Line 179: {stop_and_reply, (cosmetic) Also, please move the case body to the next line for consistency with the existing code (like done above). ``` {error, Reason} -> {stop_and_reply, ... ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 Gerrit-Change-Number: 37923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2024 04:21:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Add initial PFCP support emulating UPF

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email ) Change subject: s1gw: Add initial PFCP support emulating UPF ...................................................................... Patch Set 2: (3 comments) File s1gw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/4ed63c0f_28b1… : PS2, Line 185: float Tval := 5.0 > This looks unrelated. […] Because sometimes the timeouts were too tight, specially when creating tons of sessions where then also ttcn3 has to answer to them. It is also easier to debug if some time is left between the error and the tear down, one can see in the pcap the seconds clearly. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/c6fef19a_49d0… : PS2, Line 269: do_repeat := true > Do we normally expect receiving the Assoc Setup Req more than once? […] only once, but since it's an activate, it has to be a repeat otherwise when code goes into whatever alt, if this message is received then it will skip the alt unexpectedly. File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/a28d2780_1654… : PS2, Line 81: id) alive > These changes looks unrelated to me: […] alive: I can put it into another patch id: I'm simply refactoring code since anyway i need to add a lot of infra when adding the pfcp side. TBH I don't think it's worth spending time in splitting this at this time of the development of this testsuite where lots of stuff is still missing and may change / be rewritten when more features are added. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 Gerrit-Change-Number: 37920 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 22:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_proxy: Allow handling EXIT signal

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37921?usp=email ) Change subject: sctp_proxy: Allow handling EXIT signal ...................................................................... sctp_proxy: Allow handling EXIT signal The gen_statem in sctp_proxy.erl has code to handle EXIT signal of children in connected() state, but it lacks enabling receival of the EXIT signal. gen_statem don't have the trap enabled by default. Change-Id: I3dcad7450be8883736eb6f2ea1460add3b83e01b --- M src/sctp_proxy.erl 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 1d8d305..3ebabbd 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -75,6 +75,7 @@ %% ------------------------------------------------------------------ init([Aid, MmeAddr, MmePort]) -> + process_flag(trap_exit, true), {ok, connecting, #{enb_aid => Aid, mme_addr => MmeAddr, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3dcad7450be8883736eb6f2ea1460add3b83e01b Gerrit-Change-Number: 37921 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: Error if requested to create session without being associated

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37922?usp=email ) Change subject: pfcp_peer: Error if requested to create session without being associated ...................................................................... pfcp_peer: Error if requested to create session without being associated Change-Id: I1634151afbba198f492e7ce0181f6a70f96ebe85 --- M src/pfcp_peer.erl 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index ba8f8a9..44956da 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -229,6 +229,11 @@ [{reply, From, {ok, SEID}}]}; handle_event(_State, + {call, From}, {session_establish_req, _SEID, _PDRs, _FARs}, + #peer_state{} = S) -> + {keep_state, S, [{reply, From, {error, not_connected}}]}; + +handle_event(_State, info, {'DOWN', Ref, process, Pid, _Reason}, #peer_state{} = S0) -> S1 = registry_del({Pid, Ref}, S0), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1634151afbba198f492e7ce0181f6a70f96ebe85 Gerrit-Change-Number: 37922 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: Retry PFCP assiciation towards UPF instead of exiting

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37907?usp=email ) Change subject: pfcp_peer: Retry PFCP assiciation towards UPF instead of exiting ...................................................................... pfcp_peer: Retry PFCP assiciation towards UPF instead of exiting Otherwise the osmo-s1gw program stops if the UPF is not available at the time. Change-Id: Ic17c1c7210ab4ae0ddc840a5ffd13b7cdda243c9 --- M src/pfcp_peer.erl 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index dc36c1f..ba8f8a9 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -155,12 +155,13 @@ ?LOG_INFO("State change: ~p -> ~p", [OldState, ?FUNCTION_NAME]), %% Tx PFCP Association Setup {ok, S1} = send_assoc_setup(S0), - {next_state, connecting, S1, - [{state_timeout, 2_000, assoc_setup_timeout}]}; + {keep_state, S1, [{state_timeout, 2_000, assoc_setup_timeout}]}; %% Handle Association Setup timeout -connecting(state_timeout, assoc_setup_timeout, _S) -> - {stop, {shutdown, assoc_setup_timeout}}; +connecting(state_timeout, assoc_setup_timeout, S) -> + % Re-start sending PFCP Association Setup above: + ?LOG_NOTICE("PFCP Association Setup timeout, UPF may be down, retrying..."), + {repeat_state, S}; %% Handle incoming PFCP PDU(s) connecting(info, {udp, Sock, _FromIp, _FromPort, Data}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37907?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic17c1c7210ab4ae0ddc840a5ffd13b7cdda243c9 Gerrit-Change-Number: 37907 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: Error if requested to create session without being associated

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37922?usp=email ) Change subject: pfcp_peer: Error if requested to create session without being associated ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1634151afbba198f492e7ce0181f6a70f96ebe85 Gerrit-Change-Number: 37922 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 22:39:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: Abort and reply call with error if unable to establish PFCP...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email ) Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ...................................................................... Patch Set 1: (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/f9aca4d2_09a2… : PS1, Line 176: next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout > Why are you removing the loop transition? I think I already explained somewhere that the `state_time […] Yes, that sounded weird to me at the time when you said so. I recall you said that, but that's not the behavior I was seeing when running the ttcn3 tests last week (easily reproducible). I can tell you the timeout is triggering with "keep_state". Furtermore, reading the documentation clearly stated that using "keep_state" is a shortener for "next_state, <current_state>". https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/42305c6f_ac61… : PS1, Line 181: timeout > How do you know that it's specifically a timeout? well, in hear clearly the error is not a timeout, but some error with reason=Reason. So yes, I can maybe better return "{error, Reason}" here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 Gerrit-Change-Number: 37923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 22:39:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: Abort and reply call with error if unable to establish PFCP...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email ) Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/f2d4cf4c_2094… : PS1, Line 176: next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout Why are you removing the loop transition? I think I already explained somewhere that the `state_timeout` is ignored when doing `keep_state`, so the `next_state` here for a reason (as the comment explains). https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/87f60f97_8810… : PS1, Line 181: timeout How do you know that it's specifically a timeout? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If23881205b995e76647289d5e6c1c85d02f93b47 Gerrit-Change-Number: 37923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 18:24:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: Error if requested to create session without being associated

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37922?usp=email ) Change subject: pfcp_peer: Error if requested to create session without being associated ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: We should probably delay starting the `sctp_proxy` until the PFCP association is set up. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1634151afbba198f492e7ce0181f6a70f96ebe85 Gerrit-Change-Number: 37922 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 18:14:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_proxy: Allow handling EXIT signal

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37921?usp=email ) Change subject: sctp_proxy: Allow handling EXIT signal ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3dcad7450be8883736eb6f2ea1460add3b83e01b Gerrit-Change-Number: 37921 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Aug 2024 18:11:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024