August 2024 - gerrit-log - lists.osmocom.org

[S] Change in simtrace2[master]: README.md: Add note to avoid using a VM

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/simtrace2/+/37934?usp=email ) Change subject: README.md: Add note to avoid using a VM ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/37934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I59602e6a05600fa3e100e17c10e48977391361e3 Gerrit-Change-Number: 37934 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:26:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in osmo-hnbgw[master]: fixup: initialize g_hnbp_ctr_id = 0

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37880?usp=email ) Change subject: fixup: initialize g_hnbp_ctr_id = 0 ...................................................................... Abandoned not needed; language spec mandates zero-init -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I353e026d6e3d2c3c8b13a0ca8bd4c09609632b84 Gerrit-Change-Number: 37880 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

10 months, 1 week

1
0
0 0

[M] Change in libosmocore[master]: After writing VTY config, run sync() in a different thread

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > My main concern is a global sync is not what we need. […] so, do we simply remove sync() ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:24:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: Add initial PFCP support emulating UPF

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email ) Change subject: s1gw: Add initial PFCP support emulating UPF ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File s1gw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920/comment/87ae4f9d_59a8… : PS4, Line 247: var PDU_PFCP rx; > unused Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2b135e113d2568092e90ac9b6c5f651ab30f5d0 Gerrit-Change-Number: 37920 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:24:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: pySim.esim.saip: Add missing entry for 'rfm' to class4petype

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37859?usp=email ) Change subject: pySim.esim.saip: Add missing entry for 'rfm' to class4petype ...................................................................... pySim.esim.saip: Add missing entry for 'rfm' to class4petype Change-Id: I5fec2b026fc6a1197fc1e18d880ea6d10fd4a611 --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index d6614bc..dc67970 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -450,7 +450,7 @@ 'akaParameter': ProfileElementAKA, # TODO: cdmaParameter 'securityDomain': ProfileElementSD, - # TODO: rfm + 'rfm': ProfileElementRFM, # TODO: application # TODO: nonStandard 'end': ProfileElementEnd, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5fec2b026fc6a1197fc1e18d880ea6d10fd4a611 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

10 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: src/core/socket.c: Fix close of negative fd in system_supports_inet6()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37894?usp=email ) Change subject: src/core/socket.c: Fix close of negative fd in system_supports_inet6() ...................................................................... src/core/socket.c: Fix close of negative fd in system_supports_inet6() *** CID 413596: Error handling issues (NEGATIVE_RETURNS) /source-Osmocom/libosmocore/src/core/socket.c: 293 in system_supports_inet6() 287 if (cached_val < 0) { 288 int rc = socket(AF_INET6, SOCK_DGRAM, IPPROTO_UDP); 289 if (rc < 0 && errno == EAFNOSUPPORT) { 290 cached_val = 0; 291 } else { 292 cached_val = 1; >>> CID 413596: Error handling issues (NEGATIVE_RETURNS) >>> "rc" is passed to a parameter that cannot be negative. 293 close(rc); 294 } 295 } 296 return cached_val == 1; 297 } 298 Change-Id: Iedd0f74688cacd8dbe4b46b2c7e03a6c2f56fbbf Fixes: Change-Id I5690a25af98089e3a8a092cb91dfc969720abdc0 Closes: CID#413596 --- M src/core/socket.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/socket.c b/src/core/socket.c index da20981..90cf4ca 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -288,7 +288,7 @@ int rc = socket(AF_INET6, SOCK_DGRAM, IPPROTO_UDP); if (rc < 0 && errno == EAFNOSUPPORT) { cached_val = 0; - } else { + } else if (rc >= 0) { cached_val = 1; close(rc); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iedd0f74688cacd8dbe4b46b2c7e03a6c2f56fbbf Gerrit-Change-Number: 37894 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in libgtpnl[master]: fix clang build

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email ) Change subject: fix clang build ...................................................................... fix clang build Clang needs the configure patch that exists in most of our repos + visibility, because clang says warning: attribute declaration must precede definition [-Wignored-attributes] and the .so has no exports. Change-Id: I345579a8ea989c5a21797a17f34629472fbd3525 --- M configure.ac M src/genl.c M src/gtp-genl.c M src/gtp-rtnl.c M src/gtp.c 5 files changed, 41 insertions(+), 35 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/configure.ac b/configure.ac index 1628bc8..90e4dce 100644 --- a/configure.ac +++ b/configure.ac @@ -35,6 +35,12 @@ AC_EXEEXT AC_DISABLE_STATIC LT_INIT + +dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang +AS_CASE(["$LD"],[*clang*], + [AS_CASE(["${host_os}"], + [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])]) + CHECK_GCC_FVISIBILITY case "$host" in *-*-linux* | *-*-uclinux*) ;; diff --git a/src/genl.c b/src/genl.c index 5d8b9af..572bed9 100644 --- a/src/genl.c +++ b/src/genl.c @@ -32,6 +32,7 @@ #include "internal.h" +EXPORT_SYMBOL(genl_nlmsg_build_hdr); struct nlmsghdr * genl_nlmsg_build_hdr(char *buf, uint16_t type, uint16_t flags, uint32_t seq, uint8_t cmd) @@ -50,7 +51,6 @@ return nlh; } -EXPORT_SYMBOL(genl_nlmsg_build_hdr); static int genl_ctrl_validate_cb(const struct nlattr *attr, void *data) { @@ -87,6 +87,7 @@ return MNL_CB_OK; } +EXPORT_SYMBOL(genl_socket_open); struct mnl_socket *genl_socket_open(void) { struct mnl_socket *nl; @@ -104,14 +105,14 @@ return nl; } -EXPORT_SYMBOL(genl_socket_open); +EXPORT_SYMBOL(genl_socket_close); void genl_socket_close(struct mnl_socket *nl) { mnl_socket_close(nl); } -EXPORT_SYMBOL(genl_socket_close); +EXPORT_SYMBOL(genl_socket_talk); int genl_socket_talk(struct mnl_socket *nl, struct nlmsghdr *nlh, uint32_t seq, int (*cb)(const struct nlmsghdr *nlh, void *data), void *data) @@ -135,7 +136,6 @@ return ret; } -EXPORT_SYMBOL(genl_socket_talk); static struct nlmsghdr * genl_nlmsg_build_lookup(char *buf, const char *subsys_name) @@ -158,6 +158,7 @@ return nlh; } +EXPORT_SYMBOL(genl_lookup_family); int genl_lookup_family(struct mnl_socket *nl, const char *family) { int32_t genl_id; @@ -171,4 +172,3 @@ return genl_id; } -EXPORT_SYMBOL(genl_lookup_family); diff --git a/src/gtp-genl.c b/src/gtp-genl.c index 33a78d8..ef8dfc0 100644 --- a/src/gtp-genl.c +++ b/src/gtp-genl.c @@ -96,6 +96,7 @@ } } +EXPORT_SYMBOL(gtp_add_tunnel); int gtp_add_tunnel(int genl_id, struct mnl_socket *nl, struct gtp_tunnel *t) { struct nlmsghdr *nlh; @@ -119,8 +120,8 @@ return 0; } -EXPORT_SYMBOL(gtp_add_tunnel); +EXPORT_SYMBOL(gtp_del_tunnel); int gtp_del_tunnel(int genl_id, struct mnl_socket *nl, struct gtp_tunnel *t) { char buf[MNL_SOCKET_BUFFER_SIZE]; @@ -138,7 +139,6 @@ return 0; } -EXPORT_SYMBOL(gtp_del_tunnel); struct gtp_pdp { uint32_t ifidx; @@ -270,6 +270,7 @@ return MNL_CB_OK; } +EXPORT_SYMBOL(gtp_list_tunnel); int gtp_list_tunnel(int genl_id, struct mnl_socket *nl) { char buf[MNL_SOCKET_BUFFER_SIZE]; @@ -286,4 +287,3 @@ return 0; } -EXPORT_SYMBOL(gtp_list_tunnel); diff --git a/src/gtp-rtnl.c b/src/gtp-rtnl.c index 1dfd125..6baa5a6 100644 --- a/src/gtp-rtnl.c +++ b/src/gtp-rtnl.c @@ -138,18 +138,19 @@ return gtp_dev_talk(nlh, seq); } +EXPORT_SYMBOL(gtp_dev_create); int gtp_dev_create(int dest_ns, const char *gtp_ifname, int fd0, int fd1) { return _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_GGSN); } -EXPORT_SYMBOL(gtp_dev_create); +EXPORT_SYMBOL(gtp_dev_create_sgsn); int gtp_dev_create_sgsn(int dest_ns, const char *gtp_ifname, int fd0, int fd1) { return _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_SGSN); } -EXPORT_SYMBOL(gtp_dev_create_sgsn); +EXPORT_SYMBOL(gtp_dev_destroy); int gtp_dev_destroy(const char *gtp_ifname) { char buf[MNL_SOCKET_BUFFER_SIZE]; @@ -166,8 +167,8 @@ return gtp_dev_talk(nlh, seq); } -EXPORT_SYMBOL(gtp_dev_destroy); +EXPORT_SYMBOL(gtp_dev_config); int gtp_dev_config(const char *ifname, struct in_addr *dst, uint32_t prefix) { struct mnl_socket *nl; @@ -211,4 +212,3 @@ return ret; } -EXPORT_SYMBOL(gtp_dev_config); diff --git a/src/gtp.c b/src/gtp.c index af216f7..8f12b5d 100644 --- a/src/gtp.c +++ b/src/gtp.c @@ -27,6 +27,7 @@ #include "internal.h" +EXPORT_SYMBOL(gtp_tunnel_alloc); struct gtp_tunnel *gtp_tunnel_alloc(void) { struct gtp_tunnel *t; @@ -38,152 +39,151 @@ t->ifns = -1; return t; } -EXPORT_SYMBOL(gtp_tunnel_alloc); +EXPORT_SYMBOL(gtp_tunnel_free); void gtp_tunnel_free(struct gtp_tunnel *t) { free(t); } -EXPORT_SYMBOL(gtp_tunnel_free); +EXPORT_SYMBOL(gtp_tunnel_set_ifns); void gtp_tunnel_set_ifns(struct gtp_tunnel *t, int ifns) { t->ifns = ifns; t->flags |= GTP_TUN_IFNS; } -EXPORT_SYMBOL(gtp_tunnel_set_ifns); +EXPORT_SYMBOL(gtp_tunnel_set_ifidx); void gtp_tunnel_set_ifidx(struct gtp_tunnel *t, uint32_t ifidx) { t->ifidx = ifidx; t->flags |= GTP_TUN_IFIDX; } -EXPORT_SYMBOL(gtp_tunnel_set_ifidx); +EXPORT_SYMBOL(gtp_tunnel_set_family); void gtp_tunnel_set_family(struct gtp_tunnel *t, uint16_t family) { t->ms_addr.family = family; t->flags |= GTP_TUN_FAMILY; } -EXPORT_SYMBOL(gtp_tunnel_set_family); +EXPORT_SYMBOL(gtp_tunnel_set_ms_ip4); void gtp_tunnel_set_ms_ip4(struct gtp_tunnel *t, struct in_addr *ms_addr) { t->ms_addr.family = AF_INET; t->ms_addr.ip4 = *ms_addr; t->flags |= GTP_TUN_FAMILY | GTP_TUN_MS_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_ms_ip4); +EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip4); void gtp_tunnel_set_sgsn_ip4(struct gtp_tunnel *t, struct in_addr *sgsn_addr) { t->sgsn_addr.family = AF_INET; t->sgsn_addr.ip4 = *sgsn_addr; t->flags |= GTP_TUN_SGSN_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip4); +EXPORT_SYMBOL(gtp_tunnel_set_ms_ip6); void gtp_tunnel_set_ms_ip6(struct gtp_tunnel *t, const struct in6_addr *ms_addr) { t->ms_addr.family = AF_INET6; t->ms_addr.ip6 = *ms_addr; t->flags |= GTP_TUN_FAMILY | GTP_TUN_MS_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_ms_ip6); +EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip6); void gtp_tunnel_set_sgsn_ip6(struct gtp_tunnel *t, const struct in6_addr *sgsn_addr) { t->sgsn_addr.family = AF_INET6; t->sgsn_addr.ip6 = *sgsn_addr; t->flags |= GTP_TUN_SGSN_ADDR; } -EXPORT_SYMBOL(gtp_tunnel_set_sgsn_ip6); +EXPORT_SYMBOL(gtp_tunnel_set_version); void gtp_tunnel_set_version(struct gtp_tunnel *t, uint32_t version) { t->gtp_version = version; t->flags |= GTP_TUN_VERSION; } -EXPORT_SYMBOL(gtp_tunnel_set_version); +EXPORT_SYMBOL(gtp_tunnel_set_tid); void gtp_tunnel_set_tid(struct gtp_tunnel *t, uint64_t tid) { t->u.v0.tid = tid; t->flags |= GTP_TUN_V0_TID; } -EXPORT_SYMBOL(gtp_tunnel_set_tid); +EXPORT_SYMBOL(gtp_tunnel_set_flowid); void gtp_tunnel_set_flowid(struct gtp_tunnel *t, uint16_t flowid) { t->u.v0.flowid = flowid; t->flags |= GTP_TUN_V0_FLOWID; } -EXPORT_SYMBOL(gtp_tunnel_set_flowid); +EXPORT_SYMBOL(gtp_tunnel_set_i_tei); void gtp_tunnel_set_i_tei(struct gtp_tunnel *t, uint32_t i_tei) { t->u.v1.i_tei = i_tei; t->flags |= GTP_TUN_V1_I_TEI; } -EXPORT_SYMBOL(gtp_tunnel_set_i_tei); +EXPORT_SYMBOL(gtp_tunnel_set_o_tei); void gtp_tunnel_set_o_tei(struct gtp_tunnel *t, uint32_t o_tei) { t->u.v1.o_tei = o_tei; t->flags |= GTP_TUN_V1_O_TEI; } -EXPORT_SYMBOL(gtp_tunnel_set_o_tei); +EXPORT_SYMBOL(gtp_tunnel_get_ifns); const int gtp_tunnel_get_ifns(struct gtp_tunnel *t) { return t->ifns; } -EXPORT_SYMBOL(gtp_tunnel_get_ifns); +EXPORT_SYMBOL(gtp_tunnel_get_ifidx); const uint32_t gtp_tunnel_get_ifidx(struct gtp_tunnel *t) { return t->ifidx; } -EXPORT_SYMBOL(gtp_tunnel_get_ifidx); +EXPORT_SYMBOL(gtp_tunnel_get_ms_ip4); const struct in_addr *gtp_tunnel_get_ms_ip4(struct gtp_tunnel *t) { return &t->ms_addr.ip4; } -EXPORT_SYMBOL(gtp_tunnel_get_ms_ip4); +EXPORT_SYMBOL(gtp_tunnel_get_sgsn_ip4); const struct in_addr *gtp_tunnel_get_sgsn_ip4(struct gtp_tunnel *t) { return &t->sgsn_addr.ip4; } -EXPORT_SYMBOL(gtp_tunnel_get_sgsn_ip4); +EXPORT_SYMBOL(gtp_tunnel_get_version); int gtp_tunnel_get_version(struct gtp_tunnel *t) { return t->gtp_version; } -EXPORT_SYMBOL(gtp_tunnel_get_version); +EXPORT_SYMBOL(gtp_tunnel_get_tid); uint64_t gtp_tunnel_get_tid(struct gtp_tunnel *t) { return t->u.v0.tid; } -EXPORT_SYMBOL(gtp_tunnel_get_tid); +EXPORT_SYMBOL(gtp_tunnel_get_flowid); uint16_t gtp_tunnel_get_flowid(struct gtp_tunnel *t) { return t->u.v0.flowid; } -EXPORT_SYMBOL(gtp_tunnel_get_flowid); +EXPORT_SYMBOL(gtp_tunnel_get_i_tei); uint32_t gtp_tunnel_get_i_tei(struct gtp_tunnel *t) { return t->u.v1.i_tei; } -EXPORT_SYMBOL(gtp_tunnel_get_i_tei); +EXPORT_SYMBOL(gtp_tunnel_get_o_tei); uint32_t gtp_tunnel_get_o_tei(struct gtp_tunnel *t) { return t->u.v1.o_tei; } -EXPORT_SYMBOL(gtp_tunnel_get_o_tei); -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I345579a8ea989c5a21797a17f34629472fbd3525 Gerrit-Change-Number: 37929 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 1 week

1
0
0 0

[M] Change in libgtpnl[master]: fix clang build

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email ) Change subject: fix clang build ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/37929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I345579a8ea989c5a21797a17f34629472fbd3525 Gerrit-Change-Number: 37929 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[M] Change in pysim[master]: pySim-shell: rework startup procedure and introduce headless mode

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37932?usp=email ) Change subject: pySim-shell: rework startup procedure and introduce headless mode ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I would prefer something like --nointeractive or --noprompt over --headless, but I guess those are small details. What do you think? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37932?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I07ecb27b37e2573629981a0d032cc95cd156be7e Gerrit-Change-Number: 37932 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

10 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: scp: fix key length in dek_encrypt and dek_decrypt

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37931?usp=email ) Change subject: scp: fix key length in dek_encrypt and dek_decrypt ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/37931/comment/8c4baa08_496bc272?usp=em… : PS1, Line 9: When creating the DES cipher object with DES.new, we use the property : card_keys.dek. This property may hold a 16 byte key, but DES uses : an 8 byte key. Pycryptodome does not automatically ignore excess key : bytes. Instead it throws an exception. This means we need to make sure : to supply only the first 8 bytes of card_keys.dek did you check the spec and determie that this truncation is required/intended? IF yes, it would be great to add a comment with the spec reference to the code [optionally also the commit log]. Thanks. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92e0dc6a6196b532bd8b53fca7b9e78070d6903f Gerrit-Change-Number: 37931 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

10 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024