Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37931?usp=email )

Change subject: scp: fix key length in dek_encrypt and dek_decrypt ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/37931/comment/8c4baa08_496bc272?usp=ema... : PS1, Line 9: When creating the DES cipher object with DES.new, we use the property : card_keys.dek. This property may hold a 16 byte key, but DES uses : an 8 byte key. Pycryptodome does not automatically ignore excess key : bytes. Instead it throws an exception. This means we need to make sure : to supply only the first 8 bytes of card_keys.dek did you check the spec and determie that this truncation is required/intended? IF yes, it would be great to add a comment with the spec reference to the code [optionally also the commit log]. Thanks.