Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/36941?usp=email )
Change subject: contrib/systemd: run as osmocom user
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/36941?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I13529cd8c6ca94c43a9a81e2ea60bafc3f189ab4
Gerrit-Change-Number: 36941
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 May 2024 10:15:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/36941?usp=email )
Change subject: contrib/systemd: run as osmocom user
......................................................................
Patch Set 3:
(1 comment)
File contrib/systemd/osmo-gbproxy.service:
https://gerrit.osmocom.org/c/osmo-gbproxy/+/36941/comment/2503b40f_71122397
PS3, Line 16: AmbientCapabilities=CAP_NET_RAW
From https://osmocom.org/issues/4107#note-3:
> osmo-gbproxy requires CAP_NET_RAW if IPPROTO_GTP sockets are required for FR/GRE/IP
--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/36941?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I13529cd8c6ca94c43a9a81e2ea60bafc3f189ab4
Gerrit-Change-Number: 36941
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 May 2024 08:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36943?usp=email )
Change subject: contrib/systemd: use StateDirectory
......................................................................
contrib/systemd: use StateDirectory
Adjust the systemd service to be more similar to other Osmocom
projects, by using StateDirectory. This directory gets created by
systemd, so remove the ExecStartPre=/usr/bin/mkdir line.
Related: https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html
Change-Id: I83c7749ca1277b71e25c41b4dc943e83608bd442
---
M contrib/systemd/osmo-epdg.service
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
neels: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/contrib/systemd/osmo-epdg.service b/contrib/systemd/osmo-epdg.service
index 48ced12..40318c1 100644
--- a/contrib/systemd/osmo-epdg.service
+++ b/contrib/systemd/osmo-epdg.service
@@ -6,10 +6,10 @@
[Service]
Type=simple
Restart=always
-WorkingDirectory=/var/lib/osmo-epdg
+StateDirectory=osmo-epdg
+WorkingDirectory=%S/osmo-epdg
Environment="ERL_FLAGS=-config /etc/osmocom/osmo-epdg.config"
ExecStartPre=-/usr/bin/ip link del gtp0
-ExecStartPre=/usr/bin/mkdir -p /var/lib/osmo-epdg
ExecStart=/usr/bin/osmo-epdg
RestartSec=2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36943?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I83c7749ca1277b71e25c41b4dc943e83608bd442
Gerrit-Change-Number: 36943
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: neels.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email )
Change subject: tests: adjust to osmotestconfig no copytree change
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> .
given that this is a long abandoned code base I'll just keep this patch as-is
--
To view, visit https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice759b2205308ffb827293256eb1c0de9ac67edd
Gerrit-Change-Number: 36940
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 May 2024 07:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
