Attention is currently required from: osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email )
Change subject: tests: adjust to osmotestconfig no copytree change
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> (could also create another example with a name like osmo-bsc-nat-no-bscscfg. […]
.
--
To view, visit https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice759b2205308ffb827293256eb1c0de9ac67edd
Gerrit-Change-Number: 36940
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 May 2024 20:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email )
Change subject: tests: adjust to osmotestconfig no copytree change
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
(could also create another example with a name like osmo-bsc-nat-no-bscscfg.cfg)
--
To view, visit https://gerrit.osmocom.org/c/openbsc/+/36940?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice759b2205308ffb827293256eb1c0de9ac67edd
Gerrit-Change-Number: 36940
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 May 2024 20:39:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )
Change subject: libmsc: add timer X36 for delaying LU connections
......................................................................
Patch Set 6:
(1 comment)
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/b04ee8be_af87e94e
PS6, Line 186: msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING);
> imho the "msc_a_put_lu_deferred" name is a bit misleading, since it's not always deferred.
msc_a_put_lu_maybe_deferred()
msc_a_put_lu_possibly_deferred()
msc_a_put_lu_now_or_later()
the function exists for deferring, so would be nice if the reader sees that instantly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 May 2024 20:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email )
Change subject: libmsc: reset the LU delay timer (X36) on MO/MT SMS
......................................................................
Patch Set 3:
(1 comment)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36865/comment/fc0cba11_88eb13fe
PS3, Line 1089: msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING);
if the MS has 3 SMS waiting, is it possible that this cuts off the conn after the first SMS is done, and before SMS 2 and 3 have happened?
(hehe, with this patch, a LU with a pending SMS will release faster than one without an SMS... by far the most LU will be periodic without any SMS pending, so this optimization is pretty marginal in practice, right? I wonder if we should maybe reduce the complexity and not add this patch?)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80
Gerrit-Change-Number: 36865
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 May 2024 20:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, nt2mku.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/da5e0525_5189138f
PS2, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a.
> cosmetic: the usual line length limit for COMMIT_MSG is 72 chars, so please add line break(s).
Done
File tests/gsm0408/gsm0408_test.err:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/940828fa_76ff90fc
PS7, Line 4:
@fixeria I see you added a test that expects 3a to be omitted.
Is this 3a omission according to 3GPP specs? -- if yes, disregard my other comments, but take care to check whether all the osmo-msc tests still pass with this.
Or is it a workaround for a specific weird device? -- if yes, then let's make the behavior optional, like in my comments.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 7
Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 May 2024 20:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: nt2mku.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Let's ensure test stability:
Our ttcn3 tests and possibly clients of libosmocore in regression tests expect specific PDUs in specific scenarios. If we change the implicit behavior, then tests may fall on their faces.
So, I would much prefer if this feature is optional.
i.e. add something like:
```
int gsm48_encode_bearer_cap2(struct msgb *msg, int lv_only, bool with_3a,
const struct gsm_mncc_bearer_cap *bcap);
```
Then the behavior does not change for clients out there,
and callers can switch to the new behavior in a controlled way.
(I would then later encourage that you add a config option to osmo-msc to choose between old and new behavior, so users can decide whether to include 3a or not. maybe like this?
```
msc
gsm-bearer-cap (default|support-legacy)
```
where 'default' means what current master does;
and 'support-legacy' means this patch's behavior.)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 7
Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Comment-Date: Tue, 28 May 2024 20:13:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36944?usp=email )
Change subject: contrib/systemd: run as osmocom user
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6c8f3b316f13d497a15fcb4fe904fe0628ee2d13
Gerrit-Change-Number: 36944
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 May 2024 14:56:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
