May 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...

by nt2mku

Attention is currently required from: falconia, fixeria, neels. nt2mku has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > > I always thought that including the Bearer Capability IE in MO SETUP for a voice call allows to ne […] So I've just tested to completely omit the Bearer Capability IE in outgoing MT setup and it looks good with Phase 1 & Phase 2 GSM, and a Smartphone so far. Osmo-MSC: `src/libmsc/gsm_04_08_cc.c` function `gsm48_cc_tx_setup()` Added: `if(trans->bearer_cap.transfer != GSM48_BCAP_ITCAP_SPEECH)` `gsm48_encode_bearer_cap(msg, 0, &bearer_cap);` The codec negotiation still succeeds, the logging shows in case of smartphone to phase 1 GSM call: `<0001> msc_a.c:2086 trans(CC:INITIATED ... :CM_SERVICE_REQ ... codecs: ... MS={AMR:octet-align=1#112,GSM-EFR#110,GSM-HR-08#111,GSM#3} bss={GSM#3,GSM-EFR#110,AMR:octet-align=1#112} RAN={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111})` `<0001> gsm_04_08_cc.c:1186 trans(CC:CALL_RECEIVED ... :PAGING_RESP ... codecs: ... MS={GSM#3} bss={GSM#3,GSM-EFR#110,AMR:octet-align=1#112} RAN={AMR:octet-align=1#112,GSM-EFR#110,GSM#3,GSM-HR-08#111})` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 7 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 May 2024 22:39:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...

by falconia

Attention is currently required from: fixeria, neels, nt2mku. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 7: (3 comments) Patchset: PS7: > Though, we may still want this patch to be merged, I am mostly neutral on this part (if others are in agreement with the principal idea, I would need to take a closer look at the actual patch), but: > since it's making encoding of the MO SETUP more in-line with 3GPP TS 24.008. It is not - see my other comment. PS7: > I always thought that including the Bearer Capability IE in MO SETUP for a voice call allows to negotiate the resulting voice codec, and the called MS can include an alternative Bearer Capability IE in MO CALL CONFIRMED message, but this does not seem to be the case No, it is not the case. The speech version list is defined in the MS->network direction only; if a network sends it in the other direction, that behavior is a bug in itself. While the spec does not directly tell network-side to not do it, it does say that the MS *shall* ignore these bits on receipt. Of course there may be broken MS that do something with these bits other than ignore them (if received from network which "shouldn't ever happen"), but having the MSC send them in the hope of "negotiation" can only make things worse (on those hypothetical broken MS), never better. >and only applies to data calls? Even with data calls it isn't negotiation per se: the MS needs to know that it is a data call and not speech, and the exact type of data call is set by the source. File tests/gsm0408/gsm0408_test.err: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/bd043b16_cd9ce168 PS7, Line 4: > According to 3GPP TS 24.008, section 10.5.4.5.1, octet 3a etc. shall be included only if the mobile station supports CTM text telephony or if it supports at least one speech version for GERAN other than V1 (FR or HR). Except that this language (with "shall") does not actually appear anywhere in the spec, or at least I don't see it. If you see it in the spec, can you please cite the exact spec version, PDF page number and location on the page of this supposed wording? In the MS to network direction, the spec merely allows the MS both options, and tells the network how to decode both. Old MS, those that predate EFR, will only send the short form, but newer MS will typically transmit the long form even if you configure them (AT%SPVER) to disable the newer codecs. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 7 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 May 2024 22:36:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_gsup_mt_sms_lu_delay for X36 (LU delay) timer

by fixeria

Attention is currently required from: laforge, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36772?usp=email ) Change subject: msc: add TC_gsup_mt_sms_lu_delay for X36 (LU delay) timer ...................................................................... Patch Set 4: (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36772/comment/4184c468_dc3e… PS1, Line 3307: f_sleep(0.5); > maybe add a comment here describing this is an explicit sleep to actually test the feature Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74fa174ea649adb2112c8e471c0e339a2197a08d Gerrit-Change-Number: 36772 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 May 2024 21:42:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-msc[master]: libmsc: reset the LU delay timer (X36) on MO/MT SMS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email ) Change subject: libmsc: reset the LU delay timer (X36) on MO/MT SMS ...................................................................... libmsc: reset the LU delay timer (X36) on MO/MT SMS We don't want to delay the BSSAP/RANAP connection release any longer than it takes to submit or deliver an SMS. Thus, whenever a new SMS transaction is being allocated, drop the LU token. Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80 Related: osmo-ttcn3-hacks.git I74fa174ea649adb2112c8e471c0e339a2197a08d Related: SYS#6913 --- M src/libmsc/gsm_04_11.c 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index aa87a19..cbacb43 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -1081,6 +1081,13 @@ else msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SMS); } + + /* If we're re-using the existing LU connection, drop the LU token. + * The idea behind this timer is explained in msc_a_put_use_lu(). */ + if (osmo_timer_pending(&msc_a->lu_delay_timer)) { + osmo_timer_del(&msc_a->lu_delay_timer); + msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); + } } /* Init both SMC and SMR state machines */ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80 Gerrit-Change-Number: 36865 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[M] Change in osmo-msc[master]: libmsc: add timer X36 for delaying LU connections

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add timer X36 for delaying LU connections ...................................................................... libmsc: add timer X36 for delaying LU connections The idea is to allow re-using the radio channel that was used for Location Updating to deliver MT SMS over GSUP. This is achieved by delaying release of a BSSAP/RANAP connection and thus delaying the release of the radio channel. The delay can be configured using new timer X36 (default 0 ms), separately for GERAN and UTRAN. Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Related: osmo-ttcn3-hacks.git I74fa174ea649adb2112c8e471c0e339a2197a08d Related: SYS#6913 --- M include/osmocom/msc/msc_a.h M src/libmsc/msc_a.c M src/libmsc/ran_infra.c 3 files changed, 65 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/include/osmocom/msc/msc_a.h b/include/osmocom/msc/msc_a.h index 4099d4c..a5b624c 100644 --- a/include/osmocom/msc/msc_a.h +++ b/include/osmocom/msc/msc_a.h @@ -144,6 +144,9 @@ struct osmo_use_count use_count; struct osmo_use_count_entry use_count_buf[8]; int32_t max_total_use_count; + + /* Used for scheduling X36 (additional delay for LU connections) */ + struct osmo_timer_list lu_delay_timer; }; osmo_static_assert(offsetof(struct msc_a, c) == 0, msc_role_common_first_member_of_msc_a); diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index db1d998..bff5e67 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -155,6 +155,44 @@ } } +static void lu_delay_timer_cb(void *data) +{ + struct msc_a *msc_a = (struct msc_a *)data; + msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); +} + +static void msc_a_put_lu_deferred(struct msc_a *msc_a) +{ + unsigned long Tval; + + /* The idea behind timer X36 is to allow re-using the radio channel that was used for + * Location Updating to deliver MT SMS over GSUP. This is achieved by delaying + * release of a BSSAP/RANAP connection and thus delaying the release of the radio + * channel. The delay can be configured separately for GERAN and UTRAN. */ + switch (msc_a->c.ran->type) { + case OSMO_RAT_GERAN_A: + Tval = osmo_tdef_get(msc_tdefs_geran, -36, OSMO_TDEF_MS, 0); + break; + case OSMO_RAT_UTRAN_IU: + Tval = osmo_tdef_get(msc_tdefs_utran, -36, OSMO_TDEF_MS, 0); + break; + default: + Tval = 0; + break; + } + + if (Tval == 0) { + /* no delay, put LU token immediately */ + msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); + return; + } + + LOG_MSC_A(msc_a, LOGL_INFO, "Keeping LU token for +%lu ms\n", Tval); + osmo_timer_schedule(&msc_a->lu_delay_timer, + Tval / 1000, /* seconds */ + Tval % 1000 * 1000); /* microseconds */ +} + static void evaluate_acceptance_outcome(struct osmo_fsm_inst *fi, bool conn_accepted) { struct msc_a *msc_a = fi->priv; @@ -180,7 +218,7 @@ osmo_signal_dispatch(SS_SUBSCR, S_SUBSCR_ATTACHED, msc_a_vsub(msc_a)); if (msc_a->complete_layer3_type == COMPLETE_LAYER3_LU) - msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); + msc_a_put_lu_deferred(msc_a); if (conn_accepted && msc_a->complete_layer3_type == COMPLETE_LAYER3_CM_RE_ESTABLISH_REQ) { /* Trigger new Assignment to recommence the voice call. A little dance here because normally we verify @@ -1011,6 +1049,8 @@ /* Invalidate the active conn in VLR subscriber state, if any. */ if (vsub && vsub->msc_conn_ref == msc_a) vsub->msc_conn_ref = NULL; + + osmo_timer_del(&msc_a->lu_delay_timer); } const struct value_string msc_a_fsm_event_names[] = { @@ -1225,6 +1265,7 @@ osmo_use_count_make_static_entries(&msc_a->use_count, msc_a->use_count_buf, ARRAY_SIZE(msc_a->use_count_buf)); /* Start timeout for first state */ msc_a_state_chg_always(msc_a, MSC_A_ST_VALIDATE_L3); + osmo_timer_setup(&msc_a->lu_delay_timer, &lu_delay_timer_cb, msc_a); return msc_a; } diff --git a/src/libmsc/ran_infra.c b/src/libmsc/ran_infra.c index 6a17840..79de7d2 100644 --- a/src/libmsc/ran_infra.c +++ b/src/libmsc/ran_infra.c @@ -44,6 +44,9 @@ { .T = -2, .default_val = 30, .desc = "RAN connection release sanity timeout" }, \ { .T = -3, .default_val = 10, .desc = "Timeout to find a target BSS after Handover Required" }, \ { .T = -4, .default_val = 10, .desc = "Paging response timeout" }, \ + { .T = -36, .default_val = 0, .unit = OSMO_TDEF_MS, \ + .desc = "Delay connection release after LU. Useful to optimize an SMSC to dispatch " \ + "pending messages within the initial connection." }, \ struct osmo_tdef msc_tdefs_geran[] = { RAN_TDEFS -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-msc[master]: libmsc: reset the LU delay timer (X36) on MO/MT SMS

by fixeria

Attention is currently required from: laforge, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email ) Change subject: libmsc: reset the LU delay timer (X36) on MO/MT SMS ...................................................................... Patch Set 3: (1 comment) File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/36865/comment/5b5b77c8_63a84c67 PS3, Line 1089: msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); > if the MS has 3 SMS waiting, is it possible that this cuts off the conn after the first SMS is done, and before SMS 2 and 3 have happened? No, there exists `MMTS` flag to prevent this, which is indicating that the network has More Messages (MT RPDUs) To Send. Grep for `MSC_A_USE_SMS_MMTS` and/or check out 3GPP TS 24.011. > (hehe, with this patch, a LU with a pending SMS will release faster than one without an SMS... by far the most LU will be periodic without any SMS pending, so this optimization is pretty marginal in practice, right? I wonder if we should maybe reduce the complexity and not add this patch?) First of all, this was specifically requested by the customer. I don't see much complexity here, and I think it's still makes sense to merge this patch. As I said, not delaying periodic LU connections can be implemented later. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80 Gerrit-Change-Number: 36865 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 May 2024 21:31:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...

by fixeria

Attention is currently required from: falconia, neels, nt2mku. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 7: (4 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/4c5a9250_1ed48960 PS2, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a. > Done Not addressed. Patchset: PS7: > In my opinion, this patch is trying to solve the wrong problem, or trying to solve the problem in th […] @falcon@freecalypso.org thanks for your analysis! What you suggest sounds like the most reasonable approach to be implemented on the network side (`MT SETUP`). Though, we may still want this patch to be merged, since it's making encoding of the `MO SETUP` more in-line with 3GPP TS 24.008. PS7: > Let's ensure test stability: […] If we go for the Mychaela's proposal, then there would be no need to add new API nor any config parameters. I always thought that including the `Bearer Capability IE` in MO SETUP for a voice call allows to negotiate the resulting voice codec, and the called MS can include an alternative `Bearer Capability IE` in `MO CALL CONFIRMED` message, but this does not seem to be the case and only applies to data calls? File tests/gsm0408/gsm0408_test.err: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/6878a6c1_2fc16610 PS7, Line 4: > @fixeria I see you added a test that expects 3a to be omitted. For the record, we're talking about this commit: ``` commit 95fc8ea0564e0e146ea672f0a884e262461f6c2a Author: Vadim Yanitskiy Date: Sun Jul 3 05:41:02 2022 +0700 gsm0408_test: add a testcase for gsm48_decode_bearer_cap() ``` There was a follow-up commit by Mychaela Falconia fixing parsing (but not encoding): ``` commit 605c9e63bb0db9c86bde06fd504d25e0969b0130 Author: Mychaela Falconia Date: Sun Jul 3 05:15:30 2022 +0700 gsm48_ie: fix parsing of Bearer capability IE without octet 3a ``` > Is this 3a omission according to 3GPP specs? Yes, it's a valid encoding as explained in 3GPP TS 24.008, which is mentioned here several times (both in COMMIT_MSG and code). Let me quote it here again: ``` /* According to 3GPP TS 24.008, section 10.5.4.5.1, octet 3a etc. shall be included only if the mobile station supports CTM text telephony or if it supports at least one speech version for GERAN other than V1 (FR or HR). */ ``` Note that the two commits I mentioned here are addressing the MO BCap decoding problem on the network side, while the present patch is addressing MT BCap decoding problem on the MS side. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 7 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Comment-Date: Tue, 28 May 2024 21:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-gbproxy[master]: debian/osmo-gbproxy.init: delete

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/36942?usp=email ) Change subject: debian/osmo-gbproxy.init: delete ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/36942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I890b1ee9c201f09dcef968482c0bc5ed65ea7def Gerrit-Change-Number: 36942 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 May 2024 20:45:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: contrib/systemd: run as osmocom user

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36944?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6c8f3b316f13d497a15fcb4fe904fe0628ee2d13 Gerrit-Change-Number: 36944 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 May 2024 20:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-epdg[master]: contrib/systemd: use StateDirectory

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36943?usp=email ) Change subject: contrib/systemd: use StateDirectory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83c7749ca1277b71e25c41b4dc943e83608bd442 Gerrit-Change-Number: 36943 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 May 2024 20:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024