May 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[for-1.8]: ipa: Use pseudo-random number for SLS in IPA->M3UA direction

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36883?usp=email ) Change subject: ipa: Use pseudo-random number for SLS in IPA->M3UA direction ...................................................................... ipa: Use pseudo-random number for SLS in IPA->M3UA direction In Change-Id Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 we introduced code that would make the LSB of the file descriptor be used as SLS when passing packets from IPA in M3UA direction. This did however not achieve sufficient entropy in real-world use cases. In this change, we change over to allocating a pseudo-random SLS to each IPA connection at the time it is established; We then assign that SLS to each packet received on that IPA connection. Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733 Related: SYS#6543 Closes: SYS#6802 --- M src/osmo_ss7_asp.c M stp/stp_main.c 2 files changed, 32 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/36883/1 diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index e1c197c..b017510 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -906,7 +906,9 @@ } msg->dst = asp; rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); - return ipa_rx_msg(asp, msg, ofd->fd & 0xf); + /* we simply use the lower 4 bits of the asp_id, which is initialized to a pseudo-random value upon + * connect */ + return ipa_rx_msg(asp, msg, asp->asp_id & 0xf); } /* netif code tells us we can read something from the socket */ @@ -996,6 +998,12 @@ if (asp->cfg.proto != OSMO_SS7_ASP_PROT_IPA) { rc = ss7_asp_apply_peer_primary_address(asp); rc = ss7_asp_apply_primary_address(asp); + } else { + if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) { + /* we use the lower 4 bits of the asp_id feld as SLS; let's initialize it here from a + * pseudo-random value */ + asp->asp_id = rand() & 0xf; + } } if (asp->lm && asp->lm->prim_cb) { diff --git a/stp/stp_main.c b/stp/stp_main.c index 01d1865..d630032 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -213,6 +213,8 @@ { int rc; + srand(time(NULL)); + tall_stp_ctx = talloc_named_const(NULL, 1, "osmo-stp"); msgb_talloc_ctx_init(tall_stp_ctx, 0); osmo_init_logging2(tall_stp_ctx, &log_info); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: for-1.8 Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733 Gerrit-Change-Number: 36883 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email ) Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Why are you removing the log context lines? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507 Gerrit-Change-Number: 36861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 09:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ci[master]: jobs/ttcn3: update ttcn3-ggsn-test-kernel

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36882?usp=email ) Change subject: jobs/ttcn3: update ttcn3-ggsn-test-kernel ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3d2f26ca87f79365f4a407376b5c3c0145f729a6 Gerrit-Change-Number: 36882 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 09:41:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ci[master]: jobs/ttcn3: update ttcn3-ggsn-test-kernel

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36882?usp=email ) Change subject: jobs/ttcn3: update ttcn3-ggsn-test-kernel ...................................................................... jobs/ttcn3: update ttcn3-ggsn-test-kernel Remove ttcn3-ggsn-test-kernel-pablo-gtp, as the IPv6 GTP patches have been merged. Add ttcn3-ggsn-test-kernel-net-next and ttcn3-ggsn-test-kernel-torvalds instead, which run the master/nightly version of osmo-ggsn against HEAD of the kernel trees in netdev/net-next and torvalds/linux. Change-Id: I3d2f26ca87f79365f4a407376b5c3c0145f729a6 --- M jobs/ttcn3-testsuites.yml 1 file changed, 41 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/82/36882/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 6780f74..d7646f5 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -32,16 +32,24 @@ timer: H 04 * * * description: | Test osmo-ggsn master with the Debian kernel. - - ttcn3-ggsn-test-kernel-pablo-gtp: + - ttcn3-ggsn-test-kernel-net-next: timer: H 04 * * * # Cache the linux source tree in the workspace of one node wipe_workspace: false + node: ttcn3-ggsn-test-kernel-git description: | - Test osmo-ggsn master with the Linux kernel built from main of - <a href="https://git.kernel.org/pub/scm/linux/kernel/git/pablo/gtp.git/">pablo/gtp.git</a>. - <br> - This is a temporary job, to be removed once the IPv6 related GTP - patches are upstreamed (OS#1952). + Test osmo-ggsn master with the Linux kernel built from master of + <a href="https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/"> + net-next.git</a>. + - ttcn3-ggsn-test-kernel-torvalds: + timer: H 04 * * * + # Cache the linux source tree in the workspace of one node + wipe_workspace: false + node: ttcn3-ggsn-test-kernel-git + description: | + Test osmo-ggsn master with the Linux kernel built from master of + <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/"> + torvalds/linux.git</a>. - ttcn3-ggsn-test-kernel-latest: timer: H 04 * * * description: | @@ -266,15 +274,24 @@ # Run against debian's kernel export KERNEL_TEST=1 ;; - ttcn3-ggsn-test-kernel-pablo-gtp) + ttcn3-ggsn-test-kernel-net-next) DIR="ttcn3-ggsn-test" export IMAGE_SUFFIX="master" export KERNEL_TEST=1 export KERNEL_BUILD=1 - export KERNEL_URL="https://git.kernel.org/pub/scm/linux/kernel/git/pablo/gtp.git" - export KERNEL_REMOTE_NAME="pablo-gtp" + export KERNEL_URL="https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git" + export KERNEL_REMOTE_NAME="net-next" export KERNEL_BRANCH="main" ;; + ttcn3-ggsn-test-kernel-torvalds) + DIR="ttcn3-ggsn-test" + export IMAGE_SUFFIX="master" + export KERNEL_TEST=1 + export KERNEL_BUILD=1 + export KERNEL_URL="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" + export KERNEL_REMOTE_NAME="torvalds" + export KERNEL_BRANCH="master" + ;; ttcn3-ggsn-test-kernel-latest) DIR="ttcn3-ggsn-test" export IMAGE_SUFFIX="latest" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3d2f26ca87f79365f4a407376b5c3c0145f729a6 Gerrit-Change-Number: 36882 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email ) Change subject: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting ...................................................................... SGP32Definitions_Templates: cosmetic: fix sourcecode formatting Related: SYS#6824 Change-Id: I0940109b2c2d0021406cbcbfdabb048b76b2e7da --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 20 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index e87cb49..e1ca093 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -522,7 +522,7 @@ seqNumber := ?, euiccResult := { { - enableResult := ? + enableResult := ? } } }, @@ -539,7 +539,7 @@ seqNumber := 123, euiccResult := { { - enableResult := 0 + enableResult := 0 } } }, @@ -556,7 +556,7 @@ seqNumber := ?, euiccResult := { { - disableResult := ? + disableResult := ? } } }, @@ -573,7 +573,7 @@ seqNumber := 123, euiccResult := { { - disableResult := 0 + disableResult := 0 } } }, @@ -590,7 +590,7 @@ seqNumber := ?, euiccResult := { { - deleteResult := ? + deleteResult := ? } } }, @@ -607,7 +607,7 @@ seqNumber := 123, euiccResult := { { - deleteResult := 0 + deleteResult := 0 } } }, @@ -624,10 +624,10 @@ seqNumber := ?, euiccResult := { { - disableResult := ? + disableResult := ? }, { - deleteResult := ? + deleteResult := ? } } }, @@ -644,10 +644,10 @@ seqNumber := 123, euiccResult := { { - disableResult := 0 + disableResult := 0 }, { - deleteResult := 0 + deleteResult := 0 } } }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0940109b2c2d0021406cbcbfdabb048b76b2e7da Gerrit-Change-Number: 36880 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add templates for missing PSMOs

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36881?usp=email ) Change subject: SGP32Definitions_Templates: add templates for missing PSMOs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I354ca5f45a6157e1e40596547388147daf60b95f Gerrit-Change-Number: 36881 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 09:27:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email ) Change subject: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0940109b2c2d0021406cbcbfdabb048b76b2e7da Gerrit-Change-Number: 36880 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 09:27:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email ) Change subject: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0940109b2c2d0021406cbcbfdabb048b76b2e7da Gerrit-Change-Number: 36880 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 09:26:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36879?usp=email ) Change subject: trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26205e8672cb2849ea79bd6206c1eff1172bd9d9 Gerrit-Change-Number: 36879 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 09:26:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email ) Change subject: SGP32Definitions_Templates: cosmetic: fix sourcecode formatting ...................................................................... SGP32Definitions_Templates: cosmetic: fix sourcecode formatting Related: SYS#6824 Change-Id: I0940109b2c2d0021406cbcbfdabb048b76b2e7da --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 20 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/36880/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index e87cb49..e1ca093 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -522,7 +522,7 @@ seqNumber := ?, euiccResult := { { - enableResult := ? + enableResult := ? } } }, @@ -539,7 +539,7 @@ seqNumber := 123, euiccResult := { { - enableResult := 0 + enableResult := 0 } } }, @@ -556,7 +556,7 @@ seqNumber := ?, euiccResult := { { - disableResult := ? + disableResult := ? } } }, @@ -573,7 +573,7 @@ seqNumber := 123, euiccResult := { { - disableResult := 0 + disableResult := 0 } } }, @@ -590,7 +590,7 @@ seqNumber := ?, euiccResult := { { - deleteResult := ? + deleteResult := ? } } }, @@ -607,7 +607,7 @@ seqNumber := 123, euiccResult := { { - deleteResult := 0 + deleteResult := 0 } } }, @@ -624,10 +624,10 @@ seqNumber := ?, euiccResult := { { - disableResult := ? + disableResult := ? }, { - deleteResult := ? + deleteResult := ? } } }, @@ -644,10 +644,10 @@ seqNumber := 123, euiccResult := { { - disableResult := 0 + disableResult := 0 }, { - deleteResult := 0 + deleteResult := 0 } } }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0940109b2c2d0021406cbcbfdabb048b76b2e7da Gerrit-Change-Number: 36880 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024