May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-e1d[master]: ctl: When setting Sa bits, other bits must remain set to '1'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36691?usp=email ) Change subject: ctl: When setting Sa bits, other bits must remain set to '1' ...................................................................... ctl: When setting Sa bits, other bits must remain set to '1' Some of the other bits will be used 'as-is'. For instance the bit 0 (MSB) will be copied from this if operating in nocrc4 mode. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Id482c6a114e7bf051d157e81038f015e9d26fa99 --- M src/ctl.c 1 file changed, 22 insertions(+), 5 deletions(-) Approvals: jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ctl.c b/src/ctl.c index 331f2ad..e63589b 100644 --- a/src/ctl.c +++ b/src/ctl.c @@ -452,11 +452,14 @@ return 0; } - line->ts0.tx_frame = ((sa_bits & 0x80) >> 7) | /* Bit 7 -> Sa8 */ - ((sa_bits & 0x40) >> 5) | /* Bit 6 -> Sa7 */ - ((sa_bits & 0x01) << 2) | /* Bit 0 -> Sa6 */ - ((sa_bits & 0x20) >> 2) | /* Bit 5 -> Sa5 */ - (sa_bits & 0x10); /* Bit 4 -> Sa4 */ + line->ts0.tx_frame = ( + ((sa_bits & 0x80) >> 7) | /* Bit 7 -> Sa8 */ + ((sa_bits & 0x40) >> 5) | /* Bit 6 -> Sa7 */ + ((sa_bits & 0x01) << 2) | /* Bit 0 -> Sa6 */ + ((sa_bits & 0x20) >> 2) | /* Bit 5 -> Sa5 */ + (sa_bits & 0x10) | /* Bit 4 -> Sa4 */ + 0xe0 + ); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id482c6a114e7bf051d157e81038f015e9d26fa99 Gerrit-Change-Number: 36691 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-e1d[master]: iCE1usb: Transmit AIS events to clients

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36690?usp=email ) Change subject: iCE1usb: Transmit AIS events to clients ...................................................................... iCE1usb: Transmit AIS events to clients Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I4a35a2ab2537cbc9ecec381ab5078c1b08067925 --- M src/usb.c 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/usb.c b/src/usb.c index e4ba6c0..bb1a294 100644 --- a/src/usb.c +++ b/src/usb.c @@ -420,6 +420,18 @@ } } + if ((errcnt->flags & ICE1USB_ERR_F_AIS) != (last->flags & ICE1USB_ERR_F_AIS)) { + LOGPLI(line, DE1D, LOGL_ERROR, "AIS (BLUE) %s\n", + errcnt->flags & ICE1USB_ERR_F_AIS ? "PRESENT" : "ABSENT"); + if (errcnt->flags & ICE1USB_ERR_F_AIS) { + osmo_e1dp_server_event(line->intf->e1d->srv, E1DP_EVT_AIS_ON, + line->intf->id, line->id, 0, NULL, 0); + } else { + osmo_e1dp_server_event(line->intf->e1d->srv, E1DP_EVT_AIS_OFF, + line->intf->id, line->id, 0, NULL, 0); + } + } + if ((errcnt->flags & ICE1USB_ERR_F_RAI) != (last->flags & ICE1USB_ERR_F_RAI)) { LOGPLI(line, DE1D, LOGL_ERROR, "Remote Alarm (YELLOW) %s\n", errcnt->flags & ICE1USB_ERR_F_RAI ? "PRESENT" : "ABSENT"); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a35a2ab2537cbc9ecec381ab5078c1b08067925 Gerrit-Change-Number: 36690 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-e1d[master]: ctl: When setting Sa bits, other bits must remain set to '1'

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36691?usp=email ) Change subject: ctl: When setting Sa bits, other bits must remain set to '1' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id482c6a114e7bf051d157e81038f015e9d26fa99 Gerrit-Change-Number: 36691 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 06 May 2024 18:44:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-e1d[master]: iCE1usb: Transmit AIS events to clients

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36690?usp=email ) Change subject: iCE1usb: Transmit AIS events to clients ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a35a2ab2537cbc9ecec381ab5078c1b08067925 Gerrit-Change-Number: 36690 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 06 May 2024 18:44:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-e1d[master]: iCE1usb: Transmit LOS events to clients

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36689?usp=email ) Change subject: iCE1usb: Transmit LOS events to clients ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8822d24c25f8ba0bb70e9f717ca04dbf0e656e71 Gerrit-Change-Number: 36689 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 06 May 2024 18:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-e1d[master]: Update ice1usb_proto.h

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36688?usp=email ) Change subject: Update ice1usb_proto.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8e041b3d94723eba9d3d30b9f03815d46dacf995 Gerrit-Change-Number: 36688 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 06 May 2024 18:43:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-e1d[master]: iCE1usb: Add support to configure CRC4 mode for TX/RX

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email ) Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb Gerrit-Change-Number: 36653 Gerrit-PatchSet: 3 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 06 May 2024 18:43:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: gmm: mmctx_timer_stop(): warn about timer not running

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36699?usp=email ) Change subject: gmm: mmctx_timer_stop(): warn about timer not running ...................................................................... gmm: mmctx_timer_stop(): warn about timer not running This turns errors like: DMM ERROR MM(262420000000038/e2ff704e) Stopping MM timer 3350 but 0 is running into warnings with a more accurate reason: DMM NOTICE MM(262420000000037/e2ff704e) Stopping *inactive* MM timer 3350 Change-Id: I56ecad9d8f1049974b0896f6d0e7fc61580155ec --- M src/sgsn/gprs_gmm.c 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified tnt: Looks good to me, but someone else must approve diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 768b321..653c425 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -111,9 +111,14 @@ static void mmctx_timer_stop(struct sgsn_mm_ctx *mm, unsigned int T) { - if (mm->T != T) + if (!osmo_timer_pending(&mm->timer)) { + LOGMMCTXP(LOGL_NOTICE, mm, "Stopping *inactive* MM timer %u\n", T); + return; + } + if (mm->T != T) { LOGMMCTXP(LOGL_ERROR, mm, "Stopping MM timer %u but " "%u is running\n", T, mm->T); + } osmo_timer_del(&mm->timer); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I56ecad9d8f1049974b0896f6d0e7fc61580155ec Gerrit-Change-Number: 36699 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: gmm: cosmetic: fix preprocessor macro formatting

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36698?usp=email ) Change subject: gmm: cosmetic: fix preprocessor macro formatting ...................................................................... gmm: cosmetic: fix preprocessor macro formatting Change-Id: I77171d65db23794d8fd9872e0cc4d6f3b50dda0d --- M src/sgsn/gprs_gmm.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: tnt: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index c3f5cd3..768b321 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1391,11 +1391,11 @@ /* only in case SGSN offered new P-TMSI */ LOGMMCTXP(LOGL_INFO, mmctx, "-> GMM ATTACH COMPLETE\n"); - #ifdef BUILD_IU +#ifdef BUILD_IU if (mmctx->iu.ue_ctx) { ranap_iu_tx_release(mmctx->iu.ue_ctx, NULL); } - #endif +#endif mmctx_timer_stop(mmctx, 3350); mmctx->t3350_mode = GMM_T3350_MODE_NONE; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I77171d65db23794d8fd9872e0cc4d6f3b50dda0d Gerrit-Change-Number: 36698 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: gmm: mmctx_timer_stop(): warn about timer not running

by laforge

Attention is currently required from: fixeria, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36699?usp=email ) Change subject: gmm: mmctx_timer_stop(): warn about timer not running ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I56ecad9d8f1049974b0896f6d0e7fc61580155ec Gerrit-Change-Number: 36699 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 May 2024 18:42:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024