April 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/gerrit,master: osmo-hnbgw: add nftables var

by laforge

Attention is currently required from: fixeria, neels, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36528?usp=email ) Change subject: jobs/gerrit,master: osmo-hnbgw: add nftables var ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9828b70708dbe466c37df6ffb87b04362f14c71c Gerrit-Change-Number: 36528 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:44:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-msc[master]: fixup for re-est: do not succeed on acceptance fail

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email ) Change subject: fixup for re-est: do not succeed on acceptance fail ...................................................................... fixup for re-est: do not succeed on acceptance fail Fix a bug introduced in commit implement CM Re-Establish for voice calls ae98b97382285420ba81549bc874b9fea5e7daa9 Neels Hofmeyr <neels(a)hofmeyr.de> Thu Jul 29 22:40:59 2021 +0200 I6fa37d6ca9fcb1637742b40e37b68d67664c9b60 We should only succeed when conn_accepted == true! Related: SYS#5130 Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc --- M src/libmsc/msc_a.c 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 70d9bf7..db1d998 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -182,7 +182,7 @@ if (msc_a->complete_layer3_type == COMPLETE_LAYER3_LU) msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); - if (msc_a->complete_layer3_type == COMPLETE_LAYER3_CM_RE_ESTABLISH_REQ) { + if (conn_accepted && msc_a->complete_layer3_type == COMPLETE_LAYER3_CM_RE_ESTABLISH_REQ) { /* Trigger new Assignment to recommence the voice call. A little dance here because normally we verify * that no CC trans is already active. */ struct gsm_trans *cc_trans = msc_a->cc.active_trans; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc Gerrit-Change-Number: 36520 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-msc[master]: fixup for re-est: do not succeed on acceptance fail

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email ) Change subject: fixup for re-est: do not succeed on acceptance fail ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc Gerrit-Change-Number: 36520 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:43:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in pysim[master]: esim.es2p: Permit ApiParamInteger to be an actual integer

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email ) Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... esim.es2p: Permit ApiParamInteger to be an actual integer Usually, the specifications say that the integer type is actually transmitted as a JSON string type. However, it seems some implementations do return a native JSON integer type. Let's be tolerant in that regard. Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f --- M pySim/esim/es2p.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/esim/es2p.py b/pySim/esim/es2p.py index 32d1ef8..af45b0b 100644 --- a/pySim/esim/es2p.py +++ b/pySim/esim/es2p.py @@ -86,6 +86,8 @@ @classmethod def verify_encoded(cls, data): + if isinstance(data, int): + return if not data.isdecimal(): raise ValueError('integer (%s) contains non-decimal characters' % data) assert str(int(data)) == data -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in pysim[master]: esim.esp2: Allow HTTP methods other than POST

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36508?usp=email ) Change subject: esim.esp2: Allow HTTP methods other than POST ...................................................................... esim.esp2: Allow HTTP methods other than POST While all official/standardized ES2+ API functions use POST, there are some vendor-specific extensions using different HTTP methods. Be flexible enough to allow derived classes to easily specify other methods. Change-Id: I4b1a0dc7e6662485397c7708933bf16e5ed56e10 --- M pySim/esim/es2p.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/esim/es2p.py b/pySim/esim/es2p.py index af45b0b..fa21d2c 100644 --- a/pySim/esim/es2p.py +++ b/pySim/esim/es2p.py @@ -261,6 +261,8 @@ output_mandatory = [] # expected HTTP status code of the response expected_http_status = 200 + # the HTTP method used (GET, OPTIONS, HEAD, POST, PUT, PATCH or DELETE) + http_method = 'POST' def __init__(self, url_prefix: str, func_req_id: str, session): self.url_prefix = url_prefix @@ -326,7 +328,7 @@ } logger.debug("HTTP REQ %s - '%s'" % (url, encoded)) - response = self.session.post(url, data=encoded, headers=headers, timeout=timeout) + response = self.session.request(self.http_method, url, data=encoded, headers=headers, timeout=timeout) logger.debug("HTTP RSP-STS: [%u] hdr: %s" % (response.status_code, response.headers)) logger.debug("HTTP RSP: %s" % (response.content)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b1a0dc7e6662485397c7708933bf16e5ed56e10 Gerrit-Change-Number: 36508 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in pysim[master]: esim.esp2: Allow HTTP methods other than POST

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36508?usp=email ) Change subject: esim.esp2: Allow HTTP methods other than POST ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b1a0dc7e6662485397c7708933bf16e5ed56e10 Gerrit-Change-Number: 36508 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:42:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in pysim[master]: esim.es2p: Permit ApiParamInteger to be an actual integer

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email ) Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in pysim[master]: esim.es2p: Permit ApiParamInteger to be an actual integer

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email ) Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Maybe this is already done somewhere, but if not: it would probably be a good idea to explicitly tur […] The function is typically used for input validation. ApiParamBase.decode() method first calls verify_encoded(), then _decode(), then verify_decoded(). So verify_decoded is just made a bit more input tolerant. The output type of the overall ApiParamBase.decode() is always an int. For encoding: the encode() method returns str(data) and hence always a string, as you request -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:42:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: counters: Distinguish between normal and abnormal release cause

by iedemam

Attention is currently required from: laforge. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email ) Change subject: counters: Distinguish between normal and abnormal release cause ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idd2f845b7db448064b693ac1efdc8db006a47a11 Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use iddentical LAC/RAC/SAC values

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36525?usp=email ) Change subject: hnbgw: Use iddentical LAC/RAC/SAC values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4d82dc350c072e3528097d850304514adf65340 Gerrit-Change-Number: 36525 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:36:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024