Attention is currently required from: iedemam.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email )
Change subject: counters: Distinguish between normal and abnormal release cause
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Idd2f845b7db448064b693ac1efdc8db006a47a11
Gerrit-Change-Number: 36498
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Comment-Date: Fri, 05 Apr 2024 11:19:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36526?usp=email )
Change subject: hnbgw: Implement validation of [some] counters
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36526/comment/e826428c_ea06…
PS1, Line 1531: const charstring hnb0_ctr_prefix := "TTCN3.hnb.001-01-L2342-R0-S55-C1.";
sounds like this should be formed from LAC/etc. from g_pars? Maybe through a private function.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36526?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib0e2dd23802b18f4bd417150d0b62954b1d459a4
Gerrit-Change-Number: 36526
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 04 Apr 2024 11:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524?usp=email )
Change subject: hnbgw: Test normal and abnormal RAB release
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524/comment/6d24c2e4_3681…
PS1, Line 1534: vc_conn := f_start_handler_with_pars(refers(f_tc_rab_release), t_pars(8, rab_rel_cause := ts_RanapCause_radio_conn_lost));
line too long, split to one param per line.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7b57d4f9bd39820829ae9d52ae6e2f098e75de71
Gerrit-Change-Number: 36524
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 04 Apr 2024 11:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email )
Change subject: hnbgw: Make RAB release cause configurable
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522/comment/d1492f44_b12b…
PS1, Line 1057: integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_om_intervention) := {
This would be far easier to read if it was in its own line...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie072dafbc3378739d41411632e33a8a1ec1ed572
Gerrit-Change-Number: 36522
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 04 Apr 2024 11:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email )
Change subject: fixup for re-est: do not succeed on acceptance fail
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/75f1c51f_e5e2f42d
PS1, Line 18: Related: SYS#5130
> never seen this header pointing at a commit hash before. "Fixes:" is about issue numbers. […]
This is super usual in projects such as linux kernel, see:
git log | grep "^Fixes: "
This is useful to programatically find fixes for a commit you are eg. cherry-picking into another (stable) branch.
I tend to use it when I'm fixing some bug and the patch causing it is known.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc
Gerrit-Change-Number: 36520
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Apr 2024 11:03:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment