March 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-epdg[master]: epdg_diameter_swm: Convert Tx calls to casts

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36337?usp=email ) Change subject: epdg_diameter_swm: Convert Tx calls to casts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36337?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Id42ba265ffde735c0a68a45555d11ef2dad56cfd Gerrit-Change-Number: 36337 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 17:28:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: epdg_diameter_swm: Rename gen_server events to easily identify direction

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36336?usp=email ) Change subject: epdg_diameter_swm: Rename gen_server events to easily identify direction ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36336?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I97fcd93839271ee9961dd31f335c7b1e8f0423be Gerrit-Change-Number: 36336 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 17:28:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: Rename code paths Tx/Rx of Diameter Swm DER/DEA

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36333?usp=email ) Change subject: Rename code paths Tx/Rx of Diameter Swm DER/DEA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I4f4219ab04dce4ca7aac3a0410ac94a41080949f Gerrit-Change-Number: 36333 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 17:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: epdg_diameter_swm: Look up epdg_ue_fsm process each time it needs to ...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36332?usp=email ) Change subject: epdg_diameter_swm: Look up epdg_ue_fsm process each time it needs to be accessed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iacdba6570bfa286d03542733911b01e3a16e9706 Gerrit-Change-Number: 36332 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 17:28:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmo-abis[master]: e1line_dump_vty(): dump keepalive state and params

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email ) Change subject: e1line_dump_vty(): dump keepalive state and params ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3 Gerrit-Change-Number: 36342 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 17:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: epdg_diameter_swm: Rename gen_server events to easily identify direction

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36336?usp=email ) Change subject: epdg_diameter_swm: Rename gen_server events to easily identify direction ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36336?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I97fcd93839271ee9961dd31f335c7b1e8f0423be Gerrit-Change-Number: 36336 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 16:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmo-abis[master]: e1line_dump_vty(): dump keepalive state and params

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email ) Change subject: e1line_dump_vty(): dump keepalive state and params ...................................................................... e1line_dump_vty(): dump keepalive state and params There is currently no obvious way to know if the keepalive is enabled and which parameters are in use. Executing 'show running-config' command in the VTY would not always reveal the current configuration, because it tends to omit parameters with default values. Let's print the keepalive state and params in the output of the 'show e1_line' command. Below is a few examples: ! keepalive is disabled OsmoBSC# show e1_line E1 Line Number 0, Name , Driver ipa Keepalive: disabled IPA Keepalive: disabled ! TCP Keepalive is enabled (default) OsmoBSC# show e1_line E1 Line Number 0, Name , Driver ipa Keepalive: enabled Number of probes: (driver's default) Idle timeout: (driver's default) Probe interval: (driver's default) IPA Keepalive: disabled ! TCP and IPA keepalive enabled (custom params) OsmoBSC# show e1_line E1 Line Number 0, Name , Driver ipa Keepalive: enabled Number of probes: 2 Idle timeout: 1s Probe interval: 3s IPA Keepalive: enabled Interval: 2s Timeout: 10s Note that in the case of TCP keepalive with default parameters we cannot retrieve the actual defaults because that would be a layering violation. Thus we say "(driver's default)". Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3 Related: OS#6375, SYS#6801 --- M src/e1_input_vty.c 1 file changed, 95 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/36342/1 diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c index ca45f93..b1898dd 100644 --- a/src/e1_input_vty.c +++ b/src/e1_input_vty.c @@ -457,12 +457,59 @@ return CMD_SUCCESS; } +static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line *line) +{ + if (line->keepalive_num_probes == 0) { + vty_out(vty, "Keepalive: disabled%s", VTY_NEWLINE); + return; + } + + vty_out(vty, "Keepalive: enabled%s", VTY_NEWLINE); + + vty_out(vty, " Number of probes: "); + if (line->keepalive_num_probes != E1INP_USE_DEFAULT) + vty_out(vty, "%d", line->keepalive_num_probes); + else + vty_out(vty, "(driver's default)"); + vty_out(vty, "%s", VTY_NEWLINE); + + vty_out(vty, " Idle timeout: "); + if (line->keepalive_idle_timeout != E1INP_USE_DEFAULT) + vty_out(vty, "%ds", line->keepalive_idle_timeout); + else + vty_out(vty, "(driver's default)"); + vty_out(vty, "%s", VTY_NEWLINE); + + vty_out(vty, " Probe interval: "); + if (line->keepalive_probe_interval != E1INP_USE_DEFAULT) + vty_out(vty, "%ds", line->keepalive_probe_interval); + else + vty_out(vty, "(driver's default)"); + vty_out(vty, "%s", VTY_NEWLINE); +} + +static void e1line_ipa_ka_dump_vty(struct vty *vty, const struct e1inp_line *line) +{ + if (line->ipa_kap == NULL) { + vty_out(vty, "IPA Keepalive: disabled%s", VTY_NEWLINE); + return; + } + + vty_out(vty, "IPA Keepalive: enabled%s", VTY_NEWLINE); + vty_out(vty, " Interval: %us%s", line->ipa_kap->interval, VTY_NEWLINE); + vty_out(vty, " Timeout: %us%s", line->ipa_kap->wait_for_resp, VTY_NEWLINE); +} + static void e1line_dump_vty(struct vty *vty, struct e1inp_line *line, int stats) { vty_out(vty, "E1 Line Number %u, Name %s, Driver %s%s", line->num, line->name ? line->name : "", line->driver->name, VTY_NEWLINE); + if (line->driver->has_keepalive) + e1line_ka_dump_vty(vty, line); + if (!strcmp(line->driver->name, "ipa")) + e1line_ipa_ka_dump_vty(vty, line); if (line->pcap_file) vty_out(vty, "PCAP %s%s", line->pcap_file, VTY_NEWLINE); if (line->driver->vty_show) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3 Gerrit-Change-Number: 36342 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email ) Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/8f67c267_3d95cea1 PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied. Now it is copied. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 Gerrit-Change-Number: 36324 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 18 Mar 2024 16:46:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: epdg_ue_fsm: Properly define type of field in record

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email ) Change subject: epdg_ue_fsm: Properly define type of field in record ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2 Gerrit-Change-Number: 36341 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2024 16:43:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library: add templates for L1CTL_{DATA,TRAFFIC}_CONF

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254?usp=email ) Change subject: library: add templates for L1CTL_{DATA,TRAFFIC}_CONF ...................................................................... library: add templates for L1CTL_{DATA,TRAFFIC}_CONF Change-Id: I914555ac8bf2784c14e1b5564b116221ecc7b539 --- M library/L1CTL_Types.ttcn 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 7571b4f..b977a7d 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -836,6 +836,64 @@ } }; + /* for sending and matching L1CTL_DATA_CONF */ + template (value) L1ctlMessage + ts_L1CTL_DATA_CONF(template (value) RslChannelNr chan_nr, + template (value) RslLinkId link_id, + template (value) GsmBandArfcn arfcn, + template (value) GsmFrameNumber fn) := { + header := ts_L1ctlHeader(L1CTL_DATA_CONF), + ul_info := omit, + dl_info := { + chan_nr := chan_nr, + link_id := link_id, + arfcn := arfcn, + frame_nr := fn, + rx_level := 0, + snr := 0, + num_biterr := 0, + fire_crc := 0 + }, + payload := omit + }; + template L1ctlMessage + tr_L1CTL_DATA_CONF(template (present) RslChannelNr chan_nr, + template (present) RslLinkId link_id := ?, + template (present) GsmBandArfcn arfcn := ?, + template (present) GsmFrameNumber fn := ?) := { + header := tr_L1ctlHeader(L1CTL_DATA_CONF), + ul_info := omit, + dl_info := { + chan_nr := chan_nr, + link_id := link_id, + arfcn := arfcn, + frame_nr := fn, + rx_level := ?, + snr := ?, + num_biterr := ?, + fire_crc := ? + }, + payload := omit + }; + + /* for sending and matching L1CTL_TRAFFIC_CONF */ + template (value) L1ctlMessage + ts_L1CTL_TRAFFIC_CONF(template (value) RslChannelNr chan_nr, + template (value) RslLinkId link_id, + template (value) GsmBandArfcn arfcn, + template (value) GsmFrameNumber fn) + modifies ts_L1CTL_DATA_CONF := { + header := ts_L1ctlHeader(L1CTL_TRAFFIC_CONF) + }; + template L1ctlMessage + tr_L1CTL_TRAFFIC_CONF(template (present) RslChannelNr chan_nr, + template (present) RslLinkId link_id := ?, + template (present) GsmBandArfcn arfcn := ?, + template (present) GsmFrameNumber fn := ?) + modifies tr_L1CTL_DATA_CONF := { + header := tr_L1ctlHeader(L1CTL_TRAFFIC_CONF) + }; + /* for matching against incoming TRAFFIC_IND */ template L1ctlMessage tr_L1CTL_TRAFFIC_IND(template (present) RslChannelNr chan_nr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I914555ac8bf2784c14e1b5564b116221ecc7b539 Gerrit-Change-Number: 36254 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024