March 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: osmo-bts-virtual: Port over to osmo_io

by jolly

Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email ) Change subject: osmo-bts-virtual: Port over to osmo_io ...................................................................... Patch Set 2: (2 comments) File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/25c52194_5fba2e99 PS2, Line 105: else if (rc == 0) > This is not `read()`, but `send()` code path. […] Ok, I commented the wrong file. File src/osmo-bts-virtual/virtual_um.c: https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/bef71d62_ac23a7ae PS2, Line 53: (rc == 0) I meant this file when I said: If the socket dies, not handling of rc <= 0 will result in an infinite loop of read events. This is UDP socket can it die? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c Gerrit-Change-Number: 36317 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 12:56:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: debian: initial layer23 packaging

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36349?usp=email ) Change subject: debian: initial layer23 packaging ...................................................................... debian: initial layer23 packaging Related: OS#6409 Change-Id: I3713201233e13fca5ea4e0b8c4df913c787965f5 --- A debian/changelog A debian/compat A debian/control A debian/copyright A debian/osmocom-bb.install A debian/rules A debian/source/format 7 files changed, 76 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Verified Hoernchen: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog new file mode 100644 index 0000000..2335d18 --- /dev/null +++ b/debian/changelog @@ -0,0 +1,5 @@ +osmocom-bb (0.1.0) unstable; urgency=medium + + * Initial debian packaging for layer23 + + -- Oliver Smith <osmith(a)sysmocom.de> Mon, 19 Mar 2024 11:38:22 +0100 diff --git a/debian/compat b/debian/compat new file mode 100644 index 0000000..f599e28 --- /dev/null +++ b/debian/compat @@ -0,0 +1 @@ +10 diff --git a/debian/control b/debian/control new file mode 100644 index 0000000..c90b6a7 --- /dev/null +++ b/debian/control @@ -0,0 +1,29 @@ +Source: osmocom-bb +Section: net +Priority: optional +Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> +Build-Depends: debhelper (>= 10), + dh-autoreconf, + autotools-dev, + autoconf, + automake, + libtool, + pkg-config, + libosmocore-dev (>= 1.5.0), + libosmo-csn1-dev, + libosmo-gprs-gmm-dev, + libosmo-gprs-llc-dev, + libosmo-gprs-rlcmac-dev, + libosmo-gprs-sm-dev, + libosmo-gprs-sndcp-dev, + libosmogapk-dev +Standards-Version: 4.1.4 +Vcs-Browser: https://gitea.osmocom.org/phone-side/osmocom-bb +Vcs-Git: https://gerrit.osmocom.org/osmocom-bb +Homepage: https://osmocom.org/projects/baseband/wiki + +Package: osmocom-bb-layer23 +Architecture: any +Multi-Arch: foreign +Depends: ${misc:Depends}, ${shlibs:Depends} +Description: MS-side implementation of L2 and L3 GSM protocols diff --git a/debian/copyright b/debian/copyright new file mode 100644 index 0000000..c9ee2c1 --- /dev/null +++ b/debian/copyright @@ -0,0 +1,23 @@ +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Upstream-Name: osmocom-bb +Source: https://gitea.osmocom.org/phone-side/osmocom-bb + +Files: * +License: GPL-2.0+ + +License: GPL-2.0+ + This package is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 2 of the License, or + (at your option) any later version. + . + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + . + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. + . + On Debian systems, the complete text of the GNU General + Public License version 2 can be found in "/usr/share/common-licenses/GPL-2". diff --git a/debian/osmocom-bb.install b/debian/osmocom-bb.install new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/debian/osmocom-bb.install diff --git a/debian/rules b/debian/rules new file mode 100755 index 0000000..8dd0df8 --- /dev/null +++ b/debian/rules @@ -0,0 +1,7 @@ +#!/usr/bin/make -f + +%: + dh $@ -D src/host/layer23 --with-autoreconf + +override_dh_auto_configure: + dh_auto_configure -D src/host/layer23 -- --with-gapk-io diff --git a/debian/source/format b/debian/source/format new file mode 100644 index 0000000..89ae9db --- /dev/null +++ b/debian/source/format @@ -0,0 +1 @@ +3.0 (native) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3713201233e13fca5ea4e0b8c4df913c787965f5 Gerrit-Change-Number: 36349 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add gapk, osmocom-bb

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36351?usp=email ) Change subject: OBS: add gapk, osmocom-bb ...................................................................... OBS: add gapk, osmocom-bb Related: OS#6409 Depends: osmocom-bb I3713201233e13fca5ea4e0b8c4df913c787965f5 Depends: gapk I8e9d42fc332c5d426b9074c6bc58bc6efe037fea Change-Id: Ifd84479f97fe17de35a5f409c8fabadd3bf5c272 --- M scripts/obs/lib/config.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index ce2917e..b4e23a0 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -47,6 +47,7 @@ projects_osmocom = [ "erlang/osmo_dia2gsup", "erlang/osmo-epdg", + "gapk", "libasn1c", "libgtpnl", "libosmo-abis", @@ -83,6 +84,7 @@ "osmo-trx", "osmo-uecups", "osmo-upf", + "osmocom-bb", "python/osmo-python-tests", "rtl-sdr", "simtrace2", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifd84479f97fe17de35a5f409c8fabadd3bf5c272 Gerrit-Change-Number: 36351 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: build for debian 12: gapk, osmocom-bb

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36350?usp=email ) Change subject: jobs/gerrit: build for debian 12: gapk, osmocom-bb ...................................................................... jobs/gerrit: build for debian 12: gapk, osmocom-bb Related: OS#6409 Change-Id: Ib48d90af734e627aa4760af6423481970626d501 --- M jobs/gerrit-verifications.yml 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 936c49c..78c25cf 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -338,7 +338,7 @@ "$DOCKER_IMG" {timeout_cmd} /build/contrib/jenkins.sh - osmocom-bb: - pipeline_binpkgs: "" + pipeline_binpkgs: "debian:12" - osmo-tetra: pipeline_binpkgs: "" @@ -366,7 +366,7 @@ pipeline_binpkgs: "" - gapk: - pipeline_binpkgs: "" + pipeline_binpkgs: "debian:12" - osmo-uecups -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib48d90af734e627aa4760af6423481970626d501 Gerrit-Change-Number: 36350 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: WIP

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36353?usp=email ) Change subject: WIP ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I262de7280763791348848fbc52d0ea3ac096d23a Gerrit-Change-Number: 36353 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: WIP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36353?usp=email ) Change subject: WIP ...................................................................... WIP Change-Id: I262de7280763791348848fbc52d0ea3ac096d23a --- M pgw/PGW_Tests.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/36353/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index ae65c4f..937f2ae 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -604,6 +604,7 @@ avp := f_DIAMETER_get_avp(rx_gy, c_AVP_Code_DCC_NONE_CC_Request_Number); req_num := valueof(avp.avp_data.avp_DCC_NONE_CC_Request_Number); + log("PESPIN: Tx tx_dia res_code: ", g_pars.gy.cca_res_code); if (g_pars.gy.cca_res_code != cca_res_code_success) { tx_dia := ts_DIA_Gy_CCA(rx_gy.hop_by_hop_id, rx_gy.end_to_end_id, sess_id, g_pars.gy.cca_res_code, req_type, req_num); @@ -614,6 +615,7 @@ tx_dia := ts_DIA_Gy_CCA(rx_gy.hop_by_hop_id, rx_gy.end_to_end_id, sess_id, g_pars.gy.cca_res_code, req_type, req_num); } + log("PESPIN: Tx tx_dia: ", tx_dia); return tx_dia; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I262de7280763791348848fbc52d0ea3ac096d23a Gerrit-Change-Number: 36353 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Introduce test TC_gy_ccr_update_rejected

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36352?usp=email ) Change subject: pgw: Introduce test TC_gy_ccr_update_rejected ...................................................................... pgw: Introduce test TC_gy_ccr_update_rejected Related: SYS#6845 Change-Id: Ie58ae2a5e870b183fa1c56c90c94f5eee56386e0 --- M pgw/PGW_Tests.ttcn 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/36352/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 997c42d..ae65c4f 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -1079,6 +1079,37 @@ vc_conn.done; } +/* Test Gy CCR rejected with CCA Result-Code DIAMETER_AUTHORIZATION_REJECTED (5003) */ +private function f_TC_gy_ccr_update_rejected() runs on PGW_Session_CT { + var default d; + + f_s5s8_create_session(); + + /* We should receive an update even if no traffic is sent: */ + as_DIA_Gy_CCR(UPDATE_REQUEST); + + g_pars.gy.cca_res_code := DIAMETER_AUTHORIZATION_REJECTED; + + as_DIA_Gy_CCR(UPDATE_REQUEST); + + f_sleep(3.0); + + /* TODO: test here: + * f_ping4() fails + * f_delete_session() returns Request_rejected + */ + + setverdict(pass); +} +testcase TC_gy_ccr_update_rejected() runs on PGW_Test_CT { + var PGW_Session_CT vc_conn; + var SessionPars pars := valueof(t_SessionPars('001010123456789'H, "tun23")); + pars.gy.validity_time := 3; /* Grant access for 3 seconds, needs to be re-validated afterwards */ + f_init(); + vc_conn := f_start_handler(refers(f_TC_gy_ccr_update_rejected), pars); + vc_conn.done; +} + /* create a session, expect it to succeed */ private function f_TC_s2b_createSession_v4_noapco() runs on PGW_Session_CT { var template (omit) APCO apco := omit; @@ -1125,6 +1156,7 @@ execute( TC_createSession_deleteSession() ); execute( TC_deleteSession_unknown() ); execute( TC_gy_charging_cc_time() ); + execute( TC_gy_ccr_update_rejected() ); execute( TC_s2b_createSession_v4_noapco() ); execute( TC_s2b_createSession_v4_apco() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie58ae2a5e870b183fa1c56c90c94f5eee56386e0 Gerrit-Change-Number: 36352 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add gapk, osmocom-bb

by Hoernchen

Attention is currently required from: osmith. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36351?usp=email ) Change subject: OBS: add gapk, osmocom-bb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifd84479f97fe17de35a5f409c8fabadd3bf5c272 Gerrit-Change-Number: 36351 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 12:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add gapk, osmocom-bb

by pespin

Attention is currently required from: Hoernchen, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36351?usp=email ) Change subject: OBS: add gapk, osmocom-bb ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifd84479f97fe17de35a5f409c8fabadd3bf5c272 Gerrit-Change-Number: 36351 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 12:23:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: build for debian 12: gapk, osmocom-bb

by Hoernchen

Attention is currently required from: osmith, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36350?usp=email ) Change subject: jobs/gerrit: build for debian 12: gapk, osmocom-bb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib48d90af734e627aa4760af6423481970626d501 Gerrit-Change-Number: 36350 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 12:09:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024