March 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: gtp/gtp_internal.h: new file

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email ) Change subject: gtp/gtp_internal.h: new file ...................................................................... Patch Set 1: (1 comment) File gtp/gtp_internal.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/36068/comment/e1c5d1ef_64a4f4b3 PS1, Line 3: int gtp_echo_resp(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : int gtp_echo_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : int gtp_echo_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, void *pack, unsigned len); : : int gtp_unsup_req(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : int fd, void *pack, unsigned len); : int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer, : void *pack, unsigned len); : : int gtp_create_pdp_resp(struct gsn_t *gsn, int version, : struct pdp_t *pdp, uint8_t cause); : : int gtp_create_pdp_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : : int gtp_create_pdp_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : void *pack, unsigned len); : : int gtp_update_pdp_req(struct gsn_t *gsn, int version, void *cbp, : struct in_addr *inetaddr, struct pdp_t *pdp); : : int gtp_delete_pdp_req(struct gsn_t *gsn, int version, void *cbp, : struct pdp_t *pdp); : : int gtp_delete_pdp_resp(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len, : struct pdp_t *pdp, struct pdp_t *linked_pdp, : uint8_t cause, int teardown); : : int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : : int gtp_delete_pdp_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : void *pack, unsigned len); why do those gtp_* symbols need to be non-static and declared in any header file at all? It looks to me like they are defined in gtp.c and the only user is in gtp.c itself?a -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 Gerrit-Change-Number: 36068 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:32:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgw: Add our usual SIGABRT, SIGUSR1 signal handlers

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36355?usp=email ) Change subject: mgw: Add our usual SIGABRT, SIGUSR1 signal handlers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36355?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idc35444d2b8a0bc52c267b468dfa3c1b59f9187a Gerrit-Change-Number: 36355 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:31:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*

by pespin

Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email ) Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/7bd7ce73_efa9a6dd PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied. > I did a rather exhaustive study and could not find any osmocoom code that would rely on the existing […] I think the cb was not copied as a performance reason, since lots of code doesn't use cb at all. I personally think it's fine keeping the old behavior. You may want to add a copy_full() API which also copies the cb and other stuff. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 Gerrit-Change-Number: 36324 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gsn_internal.h: new file

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email ) Change subject: gtp/gsn_internal.h: new file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1 Gerrit-Change-Number: 36067 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:29:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli.c: Handle read / recvfrom error and close connection

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email ) Change subject: stream_cli.c: Handle read / recvfrom error and close connection ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15 Gerrit-Change-Number: 36354 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:28:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email ) Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also ...................................................................... osmo_io_uring: Run check of tests/osmo_io with io_uring also Related: OS#5751 Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 --- M configure.ac M debian/rules M tests/Makefile.am M tests/testsuite.at 4 files changed, 26 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve; Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 29a9570..6c7126f 100644 --- a/configure.ac +++ b/configure.ac @@ -282,6 +282,11 @@ [ENABLE_SCTP_TESTS=$enableval], [ENABLE_SCTP_TESTS="yes"]) AM_CONDITIONAL(ENABLE_SCTP_TESTS, test x"$ENABLE_SCTP_TESTS" = x"yes") +AC_ARG_ENABLE([uring-tests], [AS_HELP_STRING([--disable-uring-tests], [Do not run io_uring tests])], + [ENABLE_URING_TESTS=$enableval], [ENABLE_URING_TESTS="yes"]) +AM_CONDITIONAL(ENABLE_URING_TESTS, test x"$ENABLE_URING_TESTS" = x"yes") +AC_SUBST(ENABLE_URING_TESTS) + AC_ARG_ENABLE(plugin, [AS_HELP_STRING( [--disable-plugin], diff --git a/debian/rules b/debian/rules index f0105b4..db97497 100755 --- a/debian/rules +++ b/debian/rules @@ -30,6 +30,7 @@ set -x && \ CONFIGURE_FLAGS=" \ --disable-sctp-tests \ + --disable-uring-tests \ --enable-static \ --enable-systemd-logging \ "; \ diff --git a/tests/Makefile.am b/tests/Makefile.am index 7c109a1..8b1731d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -737,12 +737,12 @@ check-local: atconfig $(TESTSUITE) [ -e /proc/cpuinfo ] && cat /proc/cpuinfo - $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) + $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) $(MAKE) $(AM_MAKEFLAGS) ext-tests installcheck-local: atconfig $(TESTSUITE) $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ - $(TESTSUITEFLAGS) + $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) clean-local: test ! -f '$(TESTSUITE)' || \ diff --git a/tests/testsuite.at b/tests/testsuite.at index 4a0af0d..9ff64ac 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -530,6 +530,14 @@ AT_CHECK([$abs_top_builddir/tests/osmo_io/osmo_io_test], [0], [expout], [experr]) AT_CLEANUP +AT_SETUP([osmo_io (uring)]) +AT_KEYWORDS([osmo_io (uring)]) +AT_SKIP_IF([ test "$ENABLE_URING" != "yes" || test "$ENABLE_URING_TESTS" != "yes" ]) +cat $abs_srcdir/osmo_io/osmo_io_test.ok > expout +cat $abs_srcdir/osmo_io/osmo_io_test.err > experr +AT_CHECK([LIBOSMO_IO_BACKEND=IO_URING $abs_top_builddir/tests/osmo_io/osmo_io_test], [0], [expout], [experr]) +AT_CLEANUP + AT_SETUP([soft_uart]) AT_KEYWORDS([soft_uart]) cat $abs_srcdir/soft_uart/soft_uart_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also

by laforge

Attention is currently required from: jolly, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email ) Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 12:28:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-mgw[master]: cosmetic: make linter happy

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36369?usp=email ) Change subject: cosmetic: make linter happy ...................................................................... cosmetic: make linter happy Change-Id: Iec8404061588b848f9e597bf4112d6df9597de95 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/69/36369/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 2fd62ae..bdf516e 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1051,7 +1051,7 @@ size_t addr_len; LOGP(DRTP, LOGL_DEBUG, - "sending %i bytes length packet to %s:%u ...\n", len, + "sending %d bytes length packet to %s:%u ...\n", len, osmo_sockaddr_ntop(&addr->u.sa, ipbuf), osmo_sockaddr_port(&addr->u.sa)); @@ -1487,7 +1487,7 @@ OSMO_ASSERT(endp); msg = msgb_alloc_c(endp->trunk, RTP_BUF_SIZE, "RTP-rx"); - proto = (fd == &conn_src->end.rtp)? MGCP_PROTO_RTP : MGCP_PROTO_RTCP; + proto = (fd == &conn_src->end.rtp) ? MGCP_PROTO_RTP : MGCP_PROTO_RTCP; ret = recvfrom(fd->fd, msgb_data(msg), msg->data_len, 0, (struct sockaddr *)&addr.u.sa, &slen); @@ -1604,11 +1604,11 @@ NULL, 0, OSMO_SOCK_F_BIND | OSMO_SOCK_F_DSCP(dscp) | OSMO_SOCK_F_PRIO(prio)); if (rc < 0) { - LOGP(DRTP, LOGL_ERROR, "failed to bind UDP port (%s:%i).\n", + LOGP(DRTP, LOGL_ERROR, "failed to bind UDP port (%s:%d).\n", source_addr, port); return -1; } - LOGP(DRTP, LOGL_DEBUG, "created socket + bound UDP port (%s:%i).\n", source_addr, port); + LOGP(DRTP, LOGL_DEBUG, "created socket + bound UDP port (%s:%d).\n", source_addr, port); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iec8404061588b848f9e597bf4112d6df9597de95 Gerrit-Change-Number: 36369 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[L] Change in osmo-mgw[master]: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io

by laforge

Attention is currently required from: dexter, laforge, neels, pespin. Hello Jenkins Builder, dexter, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io ...................................................................... Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io Converting from osmo_fd to osmo_io allows us to switch to the new io_uring backend and benefit from related performance benefits. In a benchmark running 200 concurrent bi-directional voice calls with GSM-EFR codec, I am observing: * the code before this patch uses 40..42% of a single core on a Ryzen 5950X at 200 calls (=> 200 endpoints with each two connections) * no increase in CPU utilization before/after this patch, i.e. the osmo_io overhead for the osmo_fd backend is insignificant compared to the direct osmo_fd mode before * an almost exactly 50% reduction of CPU utilization when running the same osmo-mgw build with LIBOSMO_IO_BACKEND=IO_URING - top shows 19..21% for the same workload instead of 40..42% with the OSMO_FD default backend. * An increase of about 4 Megabytes in both RSS and VIRT size when enabling the OSMO_IO backend. This is likely the memory-mapped rings. No memory leakage is observed when using either of the backends. Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a --- M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_network.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_iuup.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_osmux.c 6 files changed, 225 insertions(+), 165 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/63/36363/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a Gerrit-Change-Number: 36363 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Introduce test TC_gy_ccr_update_rejected

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36352?usp=email ) Change subject: pgw: Introduce test TC_gy_ccr_update_rejected ...................................................................... pgw: Introduce test TC_gy_ccr_update_rejected This test currently fails because open5gs-smfd is not triggering the tear down in smf_gy_handle_cca_update_request(). Related: SYS#6845 Change-Id: Ie58ae2a5e870b183fa1c56c90c94f5eee56386e0 --- M pgw/PGW_Tests.ttcn M pgw/expected-results.xml 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 997c42d..3c4bef2 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -1079,6 +1079,34 @@ vc_conn.done; } +/* Test Gy CCR rejected with CCA Result-Code DIAMETER_AUTHORIZATION_REJECTED (5003) */ +private function f_TC_gy_ccr_update_rejected() runs on PGW_Session_CT { + var default d; + + f_s5s8_create_session(); + + /* We should receive an update even if no traffic is sent: */ + as_DIA_Gy_CCR(UPDATE_REQUEST); + + /* Answer next CCR[Update] with CCA Reject: */ + g_pars.gy.cca_res_code := DIAMETER_AUTHORIZATION_REJECTED; + as_DIA_Gy_CCR(UPDATE_REQUEST); + + /* Expect PGW to tear down the connection as a result: */ + as_DIA_Gx_CCR(TERMINATION_REQUEST); + as_DIA_Gy_CCR(TERMINATION_REQUEST); + + setverdict(pass); +} +testcase TC_gy_ccr_update_rejected() runs on PGW_Test_CT { + var PGW_Session_CT vc_conn; + var SessionPars pars := valueof(t_SessionPars('001010123456789'H, "tun23")); + pars.gy.validity_time := 3; /* Grant access for 3 seconds, needs to be re-validated afterwards */ + f_init(); + vc_conn := f_start_handler(refers(f_TC_gy_ccr_update_rejected), pars); + vc_conn.done; +} + /* create a session, expect it to succeed */ private function f_TC_s2b_createSession_v4_noapco() runs on PGW_Session_CT { var template (omit) APCO apco := omit; @@ -1125,6 +1153,7 @@ execute( TC_createSession_deleteSession() ); execute( TC_deleteSession_unknown() ); execute( TC_gy_charging_cc_time() ); + execute( TC_gy_ccr_update_rejected() ); execute( TC_s2b_createSession_v4_noapco() ); execute( TC_s2b_createSession_v4_apco() ); } diff --git a/pgw/expected-results.xml b/pgw/expected-results.xml index 20c073b..913f669 100644 --- a/pgw/expected-results.xml +++ b/pgw/expected-results.xml @@ -7,6 +7,7 @@ <testcase classname='PGW_Tests' name='TC_createSession_deleteSession' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_deleteSession_unknown' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_gy_charging_cc_time' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_gy_ccr_update_rejected' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_s2b_createSession_v4_noapco' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_s2b_createSession_v4_apco' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie58ae2a5e870b183fa1c56c90c94f5eee56386e0 Gerrit-Change-Number: 36352 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024