Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email )
Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-hnbgw/hnbgw_hnbap.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/003819c1_d73da41f
PS3, Line 213: char imsi[16];
> we probably have defined for this 16?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b
Gerrit-Change-Number: 36481
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Mar 2024 11:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()
......................................................................
HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()
Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b
---
M src/osmo-hnbgw/hnbgw_hnbap.c
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/81/36481/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b
Gerrit-Change-Number: 36481
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36491?usp=email )
Change subject: Introduce asterisk-master docker image
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File asterisk-master/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/36491/comment/7836af88_0c1…
PS1, Line 42: RUN git
btw, particularly with large git repos it might be sufficient to do a shallow clone here, as we don't really care about the history during build. Not saying it must be done here, just sharing an idea.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36491?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iaa3816f8ceefac8956e61e15f79ed708dec55238
Gerrit-Change-Number: 36491
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Mar 2024 10:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment