March 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: docs: Enable AUTOBRIEF feauture in doxygen

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36290?usp=email ) Change subject: docs: Enable AUTOBRIEF feauture in doxygen ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I751036baa9a2b30d94a2a302c7072a5487d2c26e Gerrit-Change-Number: 36290 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 11:41:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: Makefile.am: Fix dependency: rebuild doxygen on src/include changes

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36289?usp=email ) Change subject: Makefile.am: Fix dependency: rebuild doxygen on src/include changes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id28f0927d01f82ceb969fb7c758cb391b86631c1 Gerrit-Change-Number: 36289 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 11:41:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring tests on specific nodes

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36272?usp=email ) Change subject: jobs/ttcn3: run io_uring tests on specific nodes ...................................................................... jobs/ttcn3: run io_uring tests on specific nodes io_uring_queue_init fails on some of the jenkins nodes running the TTCN3 testsuites with io_uring. It seems that the kernel is too old on these nodes. Run the testsuites only on jenkins nodes with the new ttcn3-io_uring label, which have a recent kernel. Related: OS#6357 Change-Id: If917806f9056fdf99863f4132f44659b2bfd44c3 --- M jobs/ttcn3-testsuites.yml 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 9497238..71bcb81 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -207,16 +207,22 @@ # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) - ttcn3-bsc-test-io_uring: timer: H 11 * * * + node: ttcn3-io_uring - ttcn3-msc-test-io_uring: timer: H 11 * * * + node: ttcn3-io_uring - ttcn3-hnbgw-test-io_uring: timer: H 11 * * * + node: ttcn3-io_uring - ttcn3-gbproxy-test-io_uring: timer: H 11 * * * + node: ttcn3-io_uring - ttcn3-sgsn-test-io_uring: timer: H 11 * * * + node: ttcn3-io_uring - ttcn3-stp-test-io_uring: timer: H 11 * * * + node: ttcn3-io_uring - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If917806f9056fdf99863f4132f44659b2bfd44c3 Gerrit-Change-Number: 36272 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring tests on specific nodes

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36272?usp=email ) Change subject: jobs/ttcn3: run io_uring tests on specific nodes ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > which nodes specifically? hard to investigate without details. […] I have updated OS#6357 and I'm investigating why it doesn't work on host2-deb11build-ansible in OS#6405. I'm merging this patch now, since this is the current jenkins job configuration we are running. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If917806f9056fdf99863f4132f44659b2bfd44c3 Gerrit-Change-Number: 36272 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 09:42:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: docs: Don't export internal structs declared in src files

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36296?usp=email ) Change subject: docs: Don't export internal structs declared in src files ...................................................................... docs: Don't export internal structs declared in src files Change-Id: I5db8ce90c1e1e393195c9a146ba617ab980a9390 --- M Doxyfile.in 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/96/36296/1 diff --git a/Doxyfile.in b/Doxyfile.in index 001a085..bdd70e3 100644 --- a/Doxyfile.in +++ b/Doxyfile.in @@ -334,7 +334,7 @@ # defined locally in source files will be included in the documentation. # If set to NO only classes defined in header files are included. -EXTRACT_LOCAL_CLASSES = YES +EXTRACT_LOCAL_CLASSES = NO # This flag is only useful for Objective-C code. When set to YES local # methods, which are defined in the implementation section but not in -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5db8ce90c1e1e393195c9a146ba617ab980a9390 Gerrit-Change-Number: 36296 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in libosmo-netif[master]: docs: Split Stream Server and Stream Client into separate groups

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36297?usp=email ) Change subject: docs: Split Stream Server and Stream Client into separate groups ...................................................................... docs: Split Stream Server and Stream Client into separate groups This provides us with proper logical separation between client and server in the documentation. Change-Id: I9e037fedaecb78396f435577b1652284b4951ded --- M include/osmocom/netif/stream.h M include/osmocom/netif/stream_private.h M src/stream.c M src/stream_cli.c M src/stream_srv.c 5 files changed, 110 insertions(+), 104 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/97/36297/1 diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 96633d6..1d97530 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -6,16 +6,7 @@ #include <osmocom/core/msgb.h> -/*! \defgroup stream Osmocom Stream Server/Client - * @{ - * - * This code is intended to abstract any use of stream-type sockets, - * such as TCP and SCTP. It offers both server and client side - * implementations, fully integrated with the libosmocore select loop - * abstraction. - * - * \file stream.h - */ +/*! \file stream.h */ /*! \brief Access SCTP flags from the msgb control buffer */ #define OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION 0x80 /* sctp_recvmsg() flags=MSG_NOTIFICATION, msgb_data() contains "union sctp_notification*" */ @@ -26,6 +17,48 @@ /*! \brief Access the SCTP Stream ID from the msgb control buffer */ #define msgb_sctp_stream(msg) (msg)->cb[4] +/*! \defgroup stream_srv Osmocom Stream Server + * @{ + * + * This code is intended to abstract any server-side use of stream-type sockets, such as TCP and SCTP. + * + * The Osmocom stream socket helper is an abstraction layer for connected SOCK_STREAM/SOCK_SEQPACKET sockets. + * It encapsulates common functionality like binding, accepting client connections, etc. + * + * osmo_stream_srv can operate in two different modes: + * 1. The legacy mode using osmo_fd (from libosmocore) + * 2. The modern (2023) mode using osmo_io (from libosmocore) + * + * For any new applications, you definitely should use the modern mode, as it provides you with a higher + * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. + * + * The two main objects are osmo_stream_srv_link (main server accept()ing incoming connections) and + * osmo_stream_srv (a single given connection from a remote client). + * + * A typical stream_srv usage would look like this: + * + * * create new osmo_stream_srv_link using osmo_stream_srv_link_create() + * * call osmo_stream_srv_link_set_addr() to set local bind address/port + * * call osmo_stream_srv_link_set_accept_cb() to register the accept call-back + * * optionally call further osmo_stream_srv_link_set_*() functions + * * call osmo_stream_srv_link_open() to create socket and start listening + * + * Whenever a client connects to your listening socket, the connection will now be automatically accept()ed + * and the registered accept_cb call-back called. From within that accept_cb, you then + * * call osmo_stream_srv_create() to create a osmo_stream_srv for that specific connection + * * call osmo_stream_srv_set_read_cb() to register the read call-back for incoming data + * * call osmo_stream_srv_set_closed_cb() to register the closed call-back + * * call osmo_stream_srv_set_data() to associate opaque application-layer state + * + * Whenever data from a client arrives on a connection, your registered read_cb will be called together + * with a message buffer containing the received data. Ownership of the message buffer is transferred + * into the call-back, i.e. in your application. It's your responsibility to eventually msgb_free() + * it after usage. + * + * Whenever your application wants to transmit something to a given connection, it uses the + * osmo_stream_srv_send() function. + */ + /*! \brief Osmocom Stream Server Link: A server socket listening/accepting */ struct osmo_stream_srv_link; @@ -89,6 +122,40 @@ void osmo_stream_srv_clear_tx_queue(struct osmo_stream_srv *conn); +/*! @} */ + +/*! \defgroup stream_cli Osmocom Stream Client + * @{ + * + * This code is intended to abstract any client use of stream-type sockets, such as TCP and SCTP + * + * An osmo_stream_cli represents a client implementation of a SOCK_STREAM or SOCK_SEQPACKET socket. It + * contains all the common logic like non-blocking outbound connect to a remote server, re-connecting after + * disconnect or connect failure, etc. + * + * osmo_stream_cli can operate in two different modes: + * 1. The legacy mode using osmo_fd (from libosmocore) + * 2. The modern (2023) mode using osmo_io_fd (from libosmocore) + * + * For any new applications, you definitely should use the modern mode, as it provides you with a higher + * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. + * + * A typical usage of osmo_stream_cli would look as follows: + * + * * call osmo_stream_cli_create() to create a new osmo_stream_cli + * * call osmo_stream_cli_set_addr() / osmo_stream_cli_set_port() to specify the remote address/port to connect to + * * optionally call further functions of the osmo_stream_cli_set_*() family + * * call osmo_stream_cli_set_connect_cb() to register the call-back called on completion of outbound connect() + * * call osmo_stream_cli_set_read_cb2() to register the call-back called when incoming data has been read + * * call osmo_stream_cli_open() to open the connection (start outbound connect process) + * + * Once the connection is established, your connect_cb is called to notify you. + * + * You may send data to the connection using osmo_tream_cli_send(). + * + * Any received inbound data on the connection is reported vie the read_cb. + */ + /*! \brief Osmocom Stream Client: Single client connection */ struct osmo_stream_cli; diff --git a/include/osmocom/netif/stream_private.h b/include/osmocom/netif/stream_private.h index 106b017..dc7506d 100644 --- a/include/osmocom/netif/stream_private.h +++ b/include/osmocom/netif/stream_private.h @@ -21,9 +21,7 @@ #define OSMO_STREAM_MAX_ADDRS 1 #endif -/*! \addtogroup stream - * @{ - */ +/*! \cond private */ enum osmo_stream_mode { OSMO_STREAM_MODE_UNKNOWN, @@ -41,4 +39,4 @@ int stream_iofd_sctp_send_msgb(struct osmo_io_fd *iofd, struct msgb *msg, int sendmsg_flags); int stream_iofd_sctp_recvmsg_trailer(struct osmo_io_fd *iofd, struct msgb *msg, int ret, const struct msghdr *msgh); -/*! @} */ +/*! \endcond */ diff --git a/src/stream.c b/src/stream.c index a6bf7e8..f8cbed6 100644 --- a/src/stream.c +++ b/src/stream.c @@ -51,14 +51,7 @@ #include <osmocom/netif/sctp.h> - -/*! \addtogroup stream - * @{ - */ - -/*! \file stream.c - * \brief Osmocom stream socket helpers - */ +/*! \cond private */ #ifdef HAVE_LIBSCTP @@ -344,5 +337,4 @@ } #endif - -/*! @} */ +/*! \endccond */ diff --git a/src/stream_cli.c b/src/stream_cli.c index ed81932..ca60e25 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -51,41 +51,7 @@ #include <osmocom/netif/sctp.h> - -/*! \addtogroup stream - * @{ - */ - -/*! \file stream_cli.c - * Osmocom stream socket helpers (client side) - * - * An osmo_stream_cli represents a client implementation of a SOCK_STREAM or SOCK_SEQPACKET socket. It - * contains all the common logic like non-blocking outbound connect to a remote server, re-connecting after - * disconnect or connect failure, etc. - * - * osmo_stream_cli can operate in two different modes: - * 1. The legacy mode using osmo_fd (from libosmocore) - * 2. The modern (2023) mode using osmo_io_fd (from libosmocore) - * - * For any new applications, you definitely should use the modern mode, as it provides you with a higher - * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. - * - * A typical usage of osmo_stream_cli would look as follows: - * - * * call osmo_stream_cli_create() to create a new osmo_stream_cli - * * call osmo_stream_cli_set_addr() / osmo_stream_cli_set_port() to specify the remote address/port to connect to - * * optionally call further functions of the osmo_stream_cli_set_*() family - * * call osmo_stream_cli_set_connect_cb() to register the call-back called on completion of outbound connect() - * * call osmo_stream_cli_set_read_cb2() to register the call-back called when incoming data has been read - * * call osmo_stream_cli_open() to open the connection (start outbound connect process) - * - * Once the connection is established, your connect_cb is called to notify you. - * - * You may send data to the connection using osmo_tream_cli_send(). - * - * Any received inbound data on the connection is reported vie the read_cb. - * - */ +/*! \file stream_cli.c */ #define LOGSCLI(cli, level, fmt, args...) \ LOGP(DLINP, level, "CLICONN(%s,%s){%s} " fmt, \ @@ -151,6 +117,10 @@ void osmo_stream_cli_close(struct osmo_stream_cli *cli); +/*! \addtogroup stream_cli + * @{ + */ + /*! Re-connect an Osmocom Stream Client. * If re-connection is enabled for this client * (which is the case unless negative timeout was explicitly set via osmo_stream_cli_set_reconnect_timeout() call), diff --git a/src/stream_srv.c b/src/stream_srv.c index 8837105..3220b9e 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -52,51 +52,7 @@ #include <osmocom/netif/sctp.h> - -/*! \addtogroup stream - * @{ - */ - -/*! \file stream_srv.c - * Osmocom stream socket helpers (server side) - * - * The Osmocom stream socket helper is an abstraction layer for connected SOCK_STREAM/SOCK_SEQPACKET sockets. - * It encapsulates common functionality like binding, accepting client connections, etc. - * - * osmo_stream_srv can operate in two different modes: - * 1. The legacy mode using osmo_fd (from libosmocore) - * 2. The modern (2023) mode using osmo_io (from libosmocore) - * - * For any new applications, you definitely should use the modern mode, as it provides you with a higher - * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. - * - * The two main objects are osmo_stream_srv_link (main server accept()ing incoming connections) and - * osmo_stream_srv (a single given connection from a remote client). - * - * A typical stream_srv usage would look like this: - * - * * create new osmo_stream_srv_link using osmo_stream_srv_link_create() - * * call osmo_stream_srv_link_set_addr() to set local bind address/port - * * call osmo_stream_srv_link_set_accept_cb() to register the accept call-back - * * optionally call further osmo_stream_srv_link_set_*() functions - * * call osmo_stream_srv_link_open() to create socket and start listening - * - * Whenever a client connects to your listening socket, the connection will now be automatically accept()ed - * and the registered accept_cb call-back called. From within that accept_cb, you then - * * call osmo_stream_srv_create() to create a osmo_stream_srv for that specific connection - * * call osmo_stream_srv_set_read_cb() to register the read call-back for incoming data - * * call osmo_stream_srv_set_closed_cb() to register the closed call-back - * * call osmo_stream_srv_set_data() to associate opaque application-layer state - * - * Whenever data from a client arrives on a connection, your registered read_cb will be called together - * with a message buffer containing the received data. Ownership of the message buffer is transferred - * into the call-back, i.e. in your application. It's your responsibility to eventually msgb_free() - * it after usage. - * - * Whenever your application wants to transmit something to a given connection, it uses the - * osmo_stream_srv_send() function. - * - */ +/*! \file stream_srv.c */ #define LOGSLNK(link, level, fmt, args...) \ LOGP(DLINP, level, "SRV(%s,%s) " fmt, \ @@ -207,6 +163,10 @@ return ret; } +/*! \addtogroup stream_srv + * @{ + */ + /*! Create an Osmocom Stream Server Link. * A Stream Server Link is the listen()+accept() "parent" to individual connections from remote clients. * \param[in] ctx talloc allocation context @@ -623,6 +583,8 @@ return 0; } +/*! @} */ + #define OSMO_STREAM_SRV_F_FLUSH_DESTROY (1 << 0) struct osmo_stream_srv { @@ -642,6 +604,10 @@ int flags; }; +/*! \addtogroup stream_srv + * @{ + */ + static void stream_srv_iofd_read_cb(struct osmo_io_fd *iofd, int res, struct msgb *msg) { struct osmo_stream_srv *conn = osmo_iofd_get_data(iofd); @@ -827,6 +793,7 @@ return rc; } + /*! Create a legacy osmo_fd mode Stream Server inside the specified link. * * This is the function an application traditionally calls from within the -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e037fedaecb78396f435577b1652284b4951ded Gerrit-Change-Number: 36297 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: docs: Use \defgroup and avoid repeated boilerplate text

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email ) Change subject: docs: Use \defgroup and avoid repeated boilerplate text ...................................................................... Patch Set 2: (1 comment) File src/stream.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15129): https://gerrit.osmocom.org/c/libosmo-netif/+/36291/comment/5c27ef7c_103e39e1 PS2, Line 55: /*! \addtogroup stream trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I1196c3b035f495c5dbaa4d47ce3f79a08d0727f2 Gerrit-Change-Number: 36291 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 09:04:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: Makefile.am: Fix dependency: rebuild doxygen on src/include changes

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/36289?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Makefile.am: Fix dependency: rebuild doxygen on src/include changes ...................................................................... Makefile.am: Fix dependency: rebuild doxygen on src/include changes Change-Id: Id28f0927d01f82ceb969fb7c758cb391b86631c1 --- M Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/89/36289/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id28f0927d01f82ceb969fb7c758cb391b86631c1 Gerrit-Change-Number: 36289 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I noticed that when I compared the output from osmo-smdpp to the output from productive SMDP+ servers. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 08:34:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId ...................................................................... osmo-smdpp: fix generation of transactionId The hex string of the generated transactionId contains lowercase hex digits. However SGP.22 explicitly spcifies to use uppercase hex digits when using JSON fromatted messages. See section 6.5.2.6 for example. Related: SYS#6720 Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 --- M osmo-smdpp.py 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/36295/1 diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 582b222..1f4311d 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -239,7 +239,7 @@ # Generate a TransactionID which is used to identify the ongoing RSP session. The TransactionID # SHALL be unique within the scope and lifetime of each SM-DP+. - transactionId = uuid.uuid4().hex + transactionId = uuid.uuid4().hex.upper() assert not transactionId in self.rss # Generate a serverChallenge for eUICC authentication attached to the ongoing RSP session. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024