Attention is currently required from: lynxis lazus, osmith.
Hello Jenkins Builder, lynxis lazus, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod
......................................................................
ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod
This way osmo-epdg doesn't need to create the gtp tun device, and it can
be pre-created and configured by other tools, like gtp-link from
libgtpnl.git.
Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684
---
M osmo-epdg-master/Dockerfile
M ttcn3-epdg-test/jenkins.sh
M ttcn3-epdg-test/osmo-epdg.config
A ttcn3-epdg-test/osmo-epdg.sh
4 files changed, 47 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/35994/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684
Gerrit-Change-Number: 35994
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: lynxis lazus, osmith.
Hello Jenkins Builder, lynxis lazus, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Use new 'pre-create tundev' feature from gtp_u_kmod
......................................................................
Use new 'pre-create tundev' feature from gtp_u_kmod
This way osmo-epdg doesn't need to create the gtp tun device, and it can
be pre-created and configured by other tools, like gtp-link from
libgtpnl.git.
Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e
---
M Makefile
M config/sys.config
M rebar.lock
3 files changed, 43 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/93/35993/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e
Gerrit-Change-Number: 35993
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith, pablo.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email )
Change subject: gtp-link: add IPv6 support
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/d04ef330_51b701cd
PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN
> Dual stack is support for both inner MS IP address and outer GTP IP address. […]
@pablo@gnumonks.org, regarding "2) dual stack outer GTP address", you are mentioning there how to configure the *remote* outer address. However, I'm talking about the *local* (bind) outer address, that is, where the peer will send traffic to us through UDP/GTP-u. Those are so far configured by gtp-link binary, and hardcoded to ANY_ADDRESS.
What If I want to, lets say bind to IPv4 address A.B.C.D and IPV6 address ::Z, and then announce those in CreateSessionReq/Resp in GTPv{1,2}C?
AFAIU I need to create 2 gtp tun devices, binding one to A.B.C.D and one to ::Z.
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pablo <pablo(a)gnumonks.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pablo <pablo(a)gnumonks.org>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pablo <pablo(a)gnumonks.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
pablo has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email )
Change subject: gtp-link: add IPv6 support
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/026227a1_8f28a014
PS1, Line 12: ./gtp-link add gtp0 ip # IPv4 GGSN
> It would be great that while doing this we take into account that we will want to specify an outer I […]
Yes, it is possible to extend this to specify the listener address.
How should I process? Does this require a new patch version? If so, how can I submit it to this Gerrit change?
https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/91d144f7_00135eaa
PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN
> Also, afaiu it should be possible to have one tunnel bind to both an IPv4 and an IPv6 address, and d […]
Dual stack is support for both inner MS IP address and outer GTP IP address.
1) Dual stack example for inner address:
gtp-tunnel add gtp0 v0 1 10.141.10.2 b010::11
gtp-tunnel add gtp0 v0 1 a010:: b010::11
2) Dual stack example for outer GTP address (this requires two GTP devices, one gtp0 for IPv4 and one gtp1 for IPv6)
gtp-tunnel add gtp0 v1 1 1 10.141.10.2 192.168.10.11
gtp-tunnel add gtp1 v1 1 1 10.141.10.2 a010:: b010::10
... and it is possible to combine both, dual stack in inner MS IP address and outer GTP IP address.
File tools/gtp-link.c:
https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/3d011949_89537c74
PS1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2);
> I'd welcome if we could rename this fd1 and fd2 to fd0 and fd1u to name which proto are they used fo […]
I'm fine with that readibility cleanup
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pablo <pablo(a)gnumonks.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:39:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, pablo.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email )
Change subject: gtp: provide interface to set family
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libgtpnl/+/35987/comment/fcee2076_2e91b009
PS2, Line 9: Kernel now supports for TID/I_TEI to be used in both IPv4 and IPv6 GTP
> Probably the kernel patch kernels to clarify this: […]
Ah I think I previously confused IPv4/Ipv6 *outer* support with *inner* support here, sorry.
>And a GTP can only listen to one single address at the same time, either IPv4 or IPv6.
So this means, If one wants to implement a GSN node which can be accessed both through IPv4 and IPv6 in UDP/GTP-U (*outer*, not *inner*), then 2 gtp tun devices need to be created right? One for IPv4 and one for IPv6.
Eg. When sending a GTPv2C CreateSessionReq, the GSN node can specify both an IPv4 and an IPv6 address where it can be reached (in FQDN IE). Similar stuff in the CreateSessionResp back.
Similar stuff in GTpv1C with "GSN Address" IEs.
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I584d3997ffb89cd430dfda9615a4ce0ce517ab2a
Gerrit-Change-Number: 35987
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: pablo <pablo(a)gnumonks.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pablo <pablo(a)gnumonks.org>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pablo <pablo(a)gnumonks.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
pablo has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email )
Change subject: gtp: provide interface to set family
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libgtpnl/+/35987/comment/c66d4f48_89ff8d1b
PS2, Line 9: Kernel now supports for TID/I_TEI to be used in both IPv4 and IPv6 GTP
> IIUC you mean here that we now use different local TEI pools for IPv4 and IPv6 (which makes sense, s […]
Probably the kernel patch kernels to clarify this:
gtp: identify tunnel via GTP version + TEID + family
This allows to define a GTP tunnel for dual stack MS/UE with both IPv4
and IPv6 addresses while using the same TEID via two PDP context
objects.
Still not complete description though.
You have to specify the gtp device too, so this:
[ GTP device, GTP version, TID/I_TEID, family ]
there is a 1:1 mapping between the local listener address and the GTP device. And a GTP can only listen to one single address at the same time, either IPv4 or IPv6.
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I584d3997ffb89cd430dfda9615a4ce0ce517ab2a
Gerrit-Change-Number: 35987
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pablo <pablo(a)gnumonks.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email )
Change subject: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod
......................................................................
ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod
This way osmo-epdg doesn't need to create the gtp tun device, and it can
be pre-created and configured by other tools, like gtp-link from
libgtpnl.git.
Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684
---
M osmo-epdg-master/Dockerfile
M ttcn3-epdg-test/jenkins.sh
M ttcn3-epdg-test/osmo-epdg.config
A ttcn3-epdg-test/osmo-epdg.sh
4 files changed, 47 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/35994/1
diff --git a/osmo-epdg-master/Dockerfile b/osmo-epdg-master/Dockerfile
index a5e9b14..a73279b 100644
--- a/osmo-epdg-master/Dockerfile
+++ b/osmo-epdg-master/Dockerfile
@@ -4,6 +4,15 @@
# Arguments used after FROM must be specified again
ARG DISTRO
+# $distro-erlang switched to user build, but we need to install more stuff beforehand:
+USER root
+RUN apt-get update && \
+ apt-get install -y --no-install-recommends \
+ iproute2 \
+ libgtpnl-tools && \
+ apt-get clean
+USER build
+
WORKDIR /tmp
ARG OSMO_EPDG_BRANCH="master"
diff --git a/ttcn3-epdg-test/jenkins.sh b/ttcn3-epdg-test/jenkins.sh
index eb596dc..0241be0 100755
--- a/ttcn3-epdg-test/jenkins.sh
+++ b/ttcn3-epdg-test/jenkins.sh
@@ -15,6 +15,7 @@
mkdir $VOL_BASE_DIR/epdg
cp osmo-epdg.config $VOL_BASE_DIR/epdg/
+cp osmo-epdg.sh $VOL_BASE_DIR/epdg/
network_create
network_replace_subnet_in_configs
@@ -29,7 +30,11 @@
-v $VOL_BASE_DIR/epdg:/data \
--name ${BUILD_TAG}-epdg -d \
$DOCKER_ARGS \
- $REPO_USER/osmo-epdg-$IMAGE_SUFFIX
+ $REPO_USER/osmo-epdg-$IMAGE_SUFFIX \
+ /bin/sh -c "/data/osmo-epdg.sh >/data/osmo-epdg.log 2>&1"
+
+# Give some time to osmo-epdg to be fully started; it's a bit slow...
+sleep 2
echo Starting container with EPDG testsuite
docker run --rm \
diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config
index 6c65172..abcd864 100644
--- a/ttcn3-epdg-test/osmo-epdg.config
+++ b/ttcn3-epdg-test/osmo-epdg.config
@@ -43,12 +43,14 @@
%% gtp_u_kmod config
%% ===========================================
{gtp_u_kmod, [
- {sockets, [{grx, [%% ip: IP Address assigned at the tunnel:
- {ip, {172,18,10,20}},
- %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND):
- freebind,
- % Create gtp tundev with role SGSN:
- {role, sgsn}
+ %% gtp0: Iface name, also used to identify the process handling the tunnel.
+ {sockets, [{gtp0, [{create_mode, nocreate},
+ %% ip: IP Address assigned at the tunnel:
+ {ip, {172,18,10,20}},
+ %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND):
+ freebind,
+ % Create gtp tundev with role SGSN:
+ {role, sgsn}
]
}]
}
diff --git a/ttcn3-epdg-test/osmo-epdg.sh b/ttcn3-epdg-test/osmo-epdg.sh
new file mode 100755
index 0000000..2b58ff9
--- /dev/null
+++ b/ttcn3-epdg-test/osmo-epdg.sh
@@ -0,0 +1,11 @@
+#!/bin/bash
+set +e
+set -x
+
+gtp-link add gtp0 &
+MYPID=$!
+echo "gtp-link pid ${MYPID}"
+sleep 1
+kill ${MYPID}
+
+ERL_FLAGS='-config /data/osmo-epdg.config' /tmp/osmo-epdg/_build/default/bin/osmo-epdg
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684
Gerrit-Change-Number: 35994
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email )
Change subject: Use new 'pre-create tundev' feature from gtp_u_kmod
......................................................................
Use new 'pre-create tundev' feature from gtp_u_kmod
This way osmo-epdg doesn't need to create the gtp tun device, and it can
be pre-created and configured by other tools, like gtp-link from
libgtpnl.git.
Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e
---
M Makefile
M config/sys.config
M rebar.lock
3 files changed, 43 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/93/35993/1
diff --git a/Makefile b/Makefile
index 0470458..286a2dc 100644
--- a/Makefile
+++ b/Makefile
@@ -23,3 +23,16 @@
else
rm -f src/diameter_*.erl
endif
+
+# Path to libgtpnl's "gtp-link" binary:
+GTP_LINK=gtp-link
+# Matching the one defined in config/sys.config:
+NETDEV=gtp0
+
+run-test:
+ echo -n 'module gtp +p' | sudo tee /sys/kernel/debug/dynamic_debug/control
+ sudo ip link del $(NETDEV) || true
+ sleep 1
+ sudo sh -c "$(GTP_LINK) add $(NETDEV) & MYPID=\$$! ; echo "PID=\$${MYPID}" ; sleep 1; kill \$${MYPID} ;"
+ sudo rebar3 shell --config ./config/sys.config || true
+ echo -n 'module gtp -p' | sudo tee /sys/kernel/debug/dynamic_debug/control
diff --git a/config/sys.config b/config/sys.config
index 660aded..3d12e15 100755
--- a/config/sys.config
+++ b/config/sys.config
@@ -41,21 +41,22 @@
%% gtp_u_kmod config
%% ===========================================
{gtp_u_kmod, [
- %% grx: Name used to log by the module.
- {sockets, [{grx, [%% ip: IP Address assigned at the tunnel, used as local GTP-U IP Address.
- {ip, {127,0,0,2}},
- %% Create the tun socket on a given netns:
- %%{netns, "mynetns"},
- %% Bind tun socket to a particular interface (SO_BINDTODEVICE):
- %%{netdev, "grx"},
- %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND):
- freebind,
- % Create gtp tundev with role SGSN:
- {role, sgsn}%,
- %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%,
- % %%{netdev, "upstream"}
- % ]
- %}
+ %% gtp0: Iface name, also used to identify the process handling the tunnel.
+ {sockets, [{gtp0, [{create_mode, nocreate},
+ %% ip: IP Address assigned at the tunnel, used as local GTP-U IP Address.
+ {ip, {127,0,0,2}},
+ %% Create the tun socket on a given netns:
+ %%{netns, "mynetns"},
+ %% Bind tun socket to a particular interface (SO_BINDTODEVICE):
+ %%{netdev, "grx"},
+ %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND):
+ freebind,
+ % Create gtp tundev with role SGSN:
+ {role, sgsn}%,
+ %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%,
+ % %%{netdev, "upstream"}
+ % ]
+ %}
]
}]
}
diff --git a/rebar.lock b/rebar.lock
index 4eefe8e..0237efa 100644
--- a/rebar.lock
+++ b/rebar.lock
@@ -19,7 +19,7 @@
{<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1},
{<<"gtp_u_kmod">>,
{git,"https://github.com/osmocom/gtp_u_kmod",
- {ref,"1dc27ed724403026431f51dd4c3f882499a036b0"}},
+ {ref,"b3656ebb11528a2db3171dbf94f1a8bf0d6ffd00"}},
0},
{<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0},
{<<"lager">>,
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e
Gerrit-Change-Number: 35993
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: lynxis lazus, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email )
Change subject: epdg: Validate assigned PDP Address and APN
......................................................................
Patch Set 1:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977/comment/0211b5ce_d099…
PS1, Line 608: tr_GSUP_IE_PDP_ADDRESS(tr_GSUP_PDP_Address_IPv4(f_inet_addr(g_pars.ue_ip))),
> I guess IPv6 is not relevant here?
It is, but we are not supporting it yet.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I440a7379c6dab5448d4c57c498ad9d086d0c456b
Gerrit-Change-Number: 35977
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 15 Feb 2024 16:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email )
Change subject: Add QEMU tests
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File tests/qemu/README.md:
https://gerrit.osmocom.org/c/libgtpnl/+/35991/comment/a197b132_d21ca267
PS4, Line 2:
Maybe a line here briefly explaining what the tests actually do. Which scenario network setup do they run, etc.
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415
Gerrit-Change-Number: 35991
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Feb 2024 16:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment