Attention is currently required from: pablo, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email )
Change subject: gtp-link: add IPv6 support
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/2dd28a4a_13420c9f
PS1, Line 12: ./gtp-link add gtp0 ip # IPv4 GGSN
> Yes, it is possible to extend this to specify the listener address. […]
I've submitted your patch here: https://gerrit.osmocom.org/c/libgtpnl/+/35997/1
Submitting patches to gerrit:
https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Add-gerrit…
If a patch has the same Change-Id at the bottom (as added with the commit-msg hook mentioned in the wiki), the previous patch gets updated with the new version.
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pablo <pablo(a)gnumonks.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pablo <pablo(a)gnumonks.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 14:47:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pablo <pablo(a)gnumonks.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, osmith, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: Add QEMU tests
......................................................................
Add QEMU tests
Add tests to ensure libgtpnl + kernel driver work as expected.
Right now a kernel needs to be built from source, using Pablo's tree:
https://git.kernel.org/pub/scm/linux/kernel/git/pablo/gtp.git/
Make sure to enable:
CONFIG_GTP=y
CONFIG_NET_NS=y
CONFIG_VETH=y
$ cp bzImage tests/qemu/_linux
$ ./configure --enable-qemu-tests
$ make
$ make check
Once patches are upstreamed, it will be possible to use a pre-built
kernel from jenkins with: make -C tests qemu-download-kernel
Related: OS#1952
Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415
---
M .gitignore
M Makefile.am
M configure.ac
A tests/Makefile.am
A tests/qemu/00_test_functions.sh
A tests/qemu/01_ms_ip4_sgsn_ip4.sh
A tests/qemu/02_ms_ip4_sgsn_ip6.sh
A tests/qemu/03_ms_ip6_sgsn_ip4.sh
A tests/qemu/04_ms_ip6_sgsn_ip6.sh
A tests/qemu/README.md
A tests/qemu/check-depends.sh
A tests/qemu/initrd-build.sh
A tests/qemu/initrd-init.sh
A tests/qemu/run-qemu.sh
14 files changed, 447 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/91/35991/5
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415
Gerrit-Change-Number: 35991
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email )
Change subject: VTY: rename 'sctp-role' to 'transport-role', add an alias
......................................................................
Patch Set 2:
(1 comment)
File tests/vty/ss7_asp_test.vty:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35978/comment/1aaab25f_0ac3392f
PS2, Line 425: role sg
: transport-role ser
i think this again illustrates the danger of such changes: user loads an older config file with sctp-role, re-saves it and it gets translated to transport-role. Now he cannot use the config file anymore with older software versions for no good reason.
It's a fundamental problem. I'm not saying it must be solved now. Just expressing my displeasure about it :/
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iab6c898181d79a5ed2bea767ee90e55bc3af16a5
Gerrit-Change-Number: 35978
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 12:52:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP)
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/ddb13431_e8b5dcbb
PS4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp);
> It's not specific about this API, but in general when having developed stuff for libosmo-sccp I have […]
I understand where pespin is coming from (and agree I made too much public initially). However, I think in this specific case it is not a problem to add this new function. It does not expose any structure details, it is merely an accessor function returning a value. Let's stop spending time discussing about it.
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/6a20520d_c86e2387
PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc,
> My understanding is that for current ticket only osmo-stp is needed. […]
agreeing fully with pespin.
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/f5fe9e33_6908a2bf
PS1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb
> (re-opening the thread, since this was not addressed yet) […]
yes, all of this is going away once the netif-stream osmo-io SCTP patches is merged. No need to rework it now.
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/4fc14395_a23feaea
PS4, Line 133: #define PROTO_MUX(proto, trans_proto) \
> I still think this should be changed to avoid doing assumptions about size and max value of trans_pr […]
if we do it like it's done here, there should be a static_assert, as I mentioned. If we do it without that shift+mask, no static_assert needed.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d
Gerrit-Change-Number: 35796
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 12:50:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: return CMD_WARNING if osmo_ss7_xua_server_create() fails
......................................................................
return CMD_WARNING if osmo_ss7_xua_server_create() fails
Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082
Related: SYS#5424
---
M src/osmo_ss7_vty.c
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 836b3fd..33e6e56 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -491,7 +491,7 @@
if (!xs) {
xs = osmo_ss7_xua_server_create(inst, proto, port, NULL);
if (!xs)
- return CMD_SUCCESS;
+ return CMD_WARNING;
/* Drop first dummy address created automatically by _create(): */
osmo_ss7_xua_server_set_local_hosts(xs, NULL, 0);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082
Gerrit-Change-Number: 35968
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged