February 2024 - gerrit-log - lists.osmocom.org

[S] Change in libgtpnl[master]: gtp-tunnel: display i_tei in help

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35990?usp=email ) Change subject: gtp-tunnel: display i_tei in help ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I0aa78e654f23a2b6588ac8e1e5508e798caad1a7 Gerrit-Change-Number: 35990 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:44:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp-genl: display gtp device in listing

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35989?usp=email ) Change subject: gtp-genl: display gtp device in listing ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35989?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I888723a8318c04772f7d22a042e69fa6e9ef2239 Gerrit-Change-Number: 35989 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libgtpnl[master]: gtp: add flags to gtp_tunnel object

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35988?usp=email ) Change subject: gtp: add flags to gtp_tunnel object ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35988?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I66677ab2d4de2c459ed9987c465fce6f059d6d93 Gerrit-Change-Number: 35988 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp: provide interface to set family

by laforge

Attention is currently required from: osmith, pablo. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email ) Change subject: gtp: provide interface to set family ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I584d3997ffb89cd430dfda9615a4ce0ce517ab2a Gerrit-Change-Number: 35987 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: pablo <pablo(a)gnumonks.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pablo <pablo(a)gnumonks.org> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:43:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp-link: set IPv6 socket only

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35986?usp=email ) Change subject: gtp-link: set IPv6 socket only ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I887a107657059adeb14ae425576ae7ea9018f762 Gerrit-Change-Number: 35986 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:42:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libgtpnl[master]: gtp-link: add IPv6 support

by laforge

Attention is currently required from: osmith, pablo, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email ) Change subject: gtp-link: add IPv6 support ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/2de81325_439ca80f PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN > I have extended the gtp-link stub to allow to take an optional listener address to show that this is […] out of scope for this current project/task, but for @pespin@sysmocom.de benefit: There was some brainstorming about de-coupling the 1:1 mapping between UDP socket and net-device in https://osmocom.org/issues/6103 File tools/gtp-link.c: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/2f149c20_41fae29d PS1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2); > I'm fine with that readibility cleanup Done -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9 Gerrit-Change-Number: 35985 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pablo <pablo(a)gnumonks.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pablo <pablo(a)gnumonks.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: Use new 'pre-create tundev' feature from gtp_u_kmod

by osmith

Attention is currently required from: lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email ) Change subject: Use new 'pre-create tundev' feature from gtp_u_kmod ...................................................................... Patch Set 3: (2 comments) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993/comment/e08caa03_0db1… PS3, Line 32: run-test: how about moving all commands to a separate shell script, and running that with sudo? https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993/comment/a4024a46_3577… PS3, Line 39: sudo killall $(GTP_LINK) || true kill only the specific GTP_LINK instance that was started, by using the pid? (if you move everything into a shell script, it runs inside the same shell and you could use the MYPID variable) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e Gerrit-Change-Number: 35993 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 16 Feb 2024 10:04:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod

by osmith

Attention is currently required from: lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email ) Change subject: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod ...................................................................... Patch Set 3: (3 comments) File osmo-epdg-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/35994/comment/b8c89cc0_a41… PS3, Line 14: USER build How about we use current master of libgtpnl-tools from git instead? since typically we want to ensure that current master of everything works nicely together, and so we could use/test newer features added to the libgtpnl tools (like binding to specific IP addresses what you proposed) without waiting for a new release. If you agree, two ways we could do it: * build it from source here * add the nightly repository here and install it from there. IMHO the "# Add osmocom latest repo, should we ever require packages from there" block from debian-bookworm-erlang can be removed, the only other container using this image is osmo_dia2gsup-master and it doesn't install packages from osmocom:latest (and if it did, I also think it would make more sense to use master/nightly) File ttcn3-epdg-test/osmo-epdg.sh: https://gerrit.osmocom.org/c/docker-playground/+/35994/comment/c94daa12_a64… PS3, Line 1: #!/bin/bash This script gets executed with /bin/sh in ttcn3-epdg-test/jenkins.sh, so I'd change it to #!/bin/sh here as well to avoid confusion. https://gerrit.osmocom.org/c/docker-playground/+/35994/comment/c8f58923_52f… PS3, Line 9: # gtp-link needs to be kept running in order for osmo-epdg to be able to set up PDP contexts... remove the unused/commented out lines with MYPID, and add the comment on top of the gtp-link line instead? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 16 Feb 2024 09:56:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Validate assigned PDP Address and APN

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email ) Change subject: epdg: Validate assigned PDP Address and APN ...................................................................... epdg: Validate assigned PDP Address and APN Change-Id: I440a7379c6dab5448d4c57c498ad9d086d0c456b --- M epdg/EPDG_Tests.ttcn M library/GSUP_Templates.ttcn 2 files changed, 20 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 89a85f1..2ad1b32 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -605,8 +605,8 @@ /* Expect a positive response back to the translator; */ var template (present) GSUP_IEs pdp_info := { tr_GSUP_IE_PDP_CONTEXT_ID(?), - tr_GSUP_IE_PDP_ADDRESS(?), - tr_GSUP_IE_APN(?), + tr_GSUP_IE_PDP_ADDRESS(tr_GSUP_PDP_Address_IPv4(f_inet_addr(g_pars.ue_ip))), + tr_GSUP_IE_APN(f_enc_dns_hostname(g_pars.apn)), tr_GSUP_IE_PDP_QOS(?), tr_GSUP_IE_Charging_Characteristics(?) }; diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 05b8295..10c682c 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -69,6 +69,15 @@ } template (value) GSUP_PDP_Address ts_EuaIPv4Dyn := ts_GSUP_PDP_Address_IPv4(omit); +template (present) GSUP_PDP_Address tr_GSUP_PDP_Address_IPv4(template OCT4 ip_addr) := { + ipv4 := { + spare := ?, + pdp_typeorg := '0001'B, + pdp_typenum := '21'O, + ipv4_address := ip_addr + } +} + template GSUP_IE ts_GSUP_IE_AuthTuple2G(octetstring rand, octetstring sres, octetstring kc) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I440a7379c6dab5448d4c57c498ad9d086d0c456b Gerrit-Change-Number: 35977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Validate assigned PDP Address and APN

by pespin

Attention is currently required from: lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email ) Change subject: epdg: Validate assigned PDP Address and APN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I440a7379c6dab5448d4c57c498ad9d086d0c456b Gerrit-Change-Number: 35977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 16 Feb 2024 00:22:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024