February 2024 - gerrit-log - lists.osmocom.org

[L] Change in libgtpnl[master]: Add QEMU tests

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email ) Change subject: Add QEMU tests ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35991/comment/849ac8af_c95a6ec5 PS3, Line 14: Make sure to enable: > Sounds like a README file somewhere (which I don't see in the list of modified files in this commit) […] Done -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415 Gerrit-Change-Number: 35991 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:59:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[L] Change in libgtpnl[master]: Add QEMU tests

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add QEMU tests ...................................................................... Add QEMU tests Add tests to ensure libgtpnl + kernel driver work as expected. Right now a kernel needs to be built from source, using Pablo's tree: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/gtp.git/ Make sure to enable: CONFIG_GTP=y CONFIG_NET_NS=y CONFIG_VETH=y $ cp bzImage tests/qemu/_linux $ ./configure --enable-qemu-tests $ make $ make check Once patches are upstreamed, it will be possible to use a pre-built kernel from jenkins with: make -C tests qemu-download-kernel Related: OS#1952 Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415 --- M .gitignore M Makefile.am M configure.ac A tests/Makefile.am A tests/qemu/00_test_functions.sh A tests/qemu/01_ms_ip4_sgsn_ip4.sh A tests/qemu/02_ms_ip4_sgsn_ip6.sh A tests/qemu/03_ms_ip6_sgsn_ip4.sh A tests/qemu/04_ms_ip6_sgsn_ip6.sh A tests/qemu/README.md A tests/qemu/check-depends.sh A tests/qemu/initrd-build.sh A tests/qemu/initrd-init.sh A tests/qemu/run-qemu.sh 14 files changed, 443 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/91/35991/4 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415 Gerrit-Change-Number: 35991 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test/fragment.config: add NET_NS, VETH

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35992?usp=email ) Change subject: ttcn3-ggsn-test/fragment.config: add NET_NS, VETH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6e893b64718f853b8595de36c090a1326db34419 Gerrit-Change-Number: 35992 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:14:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[L] Change in libgtpnl[master]: Add QEMU tests

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email ) Change subject: Add QEMU tests ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35991/comment/8d395162_1702a178 PS3, Line 14: Make sure to enable: Sounds like a README file somewhere (which I don't see in the list of modified files in this commit) would be welcome. -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ibf75514b866fffb11e90529e4705f126b23d7415 Gerrit-Change-Number: 35991 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:14:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp-tunnel: display i_tei in help

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35990?usp=email ) Change subject: gtp-tunnel: display i_tei in help ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I0aa78e654f23a2b6588ac8e1e5508e798caad1a7 Gerrit-Change-Number: 35990 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:12:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp-genl: display gtp device in listing

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35989?usp=email ) Change subject: gtp-genl: display gtp device in listing ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35989?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I888723a8318c04772f7d22a042e69fa6e9ef2239 Gerrit-Change-Number: 35989 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:12:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libgtpnl[master]: gtp: add flags to gtp_tunnel object

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35988?usp=email ) Change subject: gtp: add flags to gtp_tunnel object ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35988?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I66677ab2d4de2c459ed9987c465fce6f059d6d93 Gerrit-Change-Number: 35988 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:11:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp: provide interface to set family

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email ) Change subject: gtp: provide interface to set family ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35987/comment/cd48c380_8cedbf65 PS2, Line 9: Kernel now supports for TID/I_TEI to be used in both IPv4 and IPv6 GTP IIUC you mean here that we now use different local TEI pools for IPv4 and IPv6 (which makes sense, since the the IP addresses will be different given the family is different), and hence one now needs to specify from which family (pool) the TEI is identified. So in theory one would have to pass a tuple <local_IPaddr, TEID> to fully identify the tunnel, but since we have 1 local IP address per family then passing the famlily is enough. Am I correct? -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I584d3997ffb89cd430dfda9615a4ce0ce517ab2a Gerrit-Change-Number: 35987 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 15:10:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp-link: set IPv6 socket only

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35986?usp=email ) Change subject: gtp-link: set IPv6 socket only ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I887a107657059adeb14ae425576ae7ea9018f762 Gerrit-Change-Number: 35986 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 14:59:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libgtpnl[master]: gtp-link: add IPv6 support

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email ) Change subject: gtp-link: add IPv6 support ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/e664e1e3_44694f55 PS1, Line 12: ./gtp-link add gtp0 ip # IPv4 GGSN It would be great that while doing this we take into account that we will want to specify an outer IPv4/IPv6 address instead of currently used ANY_ADDR. https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/fefd0643_efc751d8 PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN Also, afaiu it should be possible to have one tunnel bind to both an IPv4 and an IPv6 address, and depending on the IP address provided by the peer, use one or another when sharing messages. (see GTPv1C/GTPv2C where it's possible to signal both an IPv4 and IPv6 address to the peer). File tools/gtp-link.c: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/ddd91078_734aef7d PS1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2); I'd welcome if we could rename this fd1 and fd2 to fd0 and fd1u to name which proto are they used for (no need to do it in this same patch). -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9 Gerrit-Change-Number: 35985 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 14:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024