pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36092?usp=email )
Change subject: GSUP_Emulation: Update internal tables to allow 256 sessions
......................................................................
GSUP_Emulation: Update internal tables to allow 256 sessions
Other Emulations like GTPv2 and DIAMETER already support that number of
sessions. Increase it to the same number in GSUP_Emulation to allow
handling a high amount of concurrent sessions while testing ePDG.
Change-Id: I9ce650140fc372debc85b603a20bbe9ea165c972
---
M library/GSUP_Emulation.ttcn
1 file changed, 15 insertions(+), 3 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/library/GSUP_Emulation.ttcn b/library/GSUP_Emulation.ttcn
index 5e15d06..4f7e5d6 100644
--- a/library/GSUP_Emulation.ttcn
+++ b/library/GSUP_Emulation.ttcn
@@ -60,11 +60,10 @@
/* GSUP port to the per-connection clients */
port GSUP_Conn_PT GSUP_CLIENT;
- /* use 16 as this is also the number of SCCP connections that SCCP_Emulation can handle */
- var ConnectionData GsupImsiTable[16];
+ var ConnectionData GsupImsiTable[256];
/* pending expected incoming connections */
- var ExpectData GsupExpectTable[16];
+ var ExpectData GsupExpectTable[256];
/* procedure based port to register for incoming connections */
port GSUPEM_PROC_PT GSUP_PROC;
};
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36092?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9ce650140fc372debc85b603a20bbe9ea165c972
Gerrit-Change-Number: 36092
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria, laforge, lynxis lazus, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email )
Change subject: epdg: Add tests to validate concurrent connections
......................................................................
Patch Set 2:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/becfbb46_fe21…
PS2, Line 797: -> sender vc_conn
> `vc_conn` is not used after assignment, so `-> sender vc_conn` can be dropped? […]
Definetly we don't want vc_conn_list[i] there, since in "sender X", X is an output param.
I actually left the sender part on purpose so that it is easier for anybody adding new tests to figure out how to pass a message back to the specific vc_conn.
It doesn't really harm anyway.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 28 Feb 2024 18:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge, lynxis lazus, osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email )
Change subject: epdg: Add tests to validate concurrent connections
......................................................................
Patch Set 2:
(3 comments)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/ce89f84e_fda6…
PS1, Line 747:
> maybe put the several deleted lines in an extra patch?
Ack, this would make the patch a bit easier to read.
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/3c4b4f56_f10d…
PS2, Line 797: -> sender vc_conn
`vc_conn` is not used after assignment, so `-> sender vc_conn` can be dropped?
Maybe we want `from vc_conn_list[i]` instead?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/fc17a3ba_6ac2…
PS2, Line 805: -> sender vc_conn
Likewise here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 28 Feb 2024 18:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36109?usp=email )
Change subject: s2b: Spawn process for each received packet
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36109?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I460b382aedbc10b06d846131b4cd838e30668df4
Gerrit-Change-Number: 36109
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Feb 2024 18:01:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment