February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: ggsn_tests: fix typo

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36110?usp=email ) Change subject: ggsn_tests: fix typo ...................................................................... ggsn_tests: fix typo Change-Id: Iefd1bfead68878553cbfd0f34ea8aaa4bdd40a41 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index c949dc9..32d4a1d 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -328,7 +328,7 @@ }; [] T_default.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - "pinpong T_default timeout"); + "pingpong T_default timeout"); }; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefd1bfead68878553cbfd0f34ea8aaa4bdd40a41 Gerrit-Change-Number: 36110 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn_tests: f_wait_icmp4: don't shutdown on error

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36111?usp=email ) Change subject: ggsn_tests: f_wait_icmp4: don't shutdown on error ...................................................................... ggsn_tests: f_wait_icmp4: don't shutdown on error Use setverdict(fail, …) instead of shutting down the test. Otherwise we don't close the PDP context. This fixes TC_pdp6_act_deact failing if it runs after a failed TC_pdp4_act_update_teid. Change-Id: Ib31481e79fc81983ae0c36f0512c6b7dba3f28a8 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 32d4a1d..6a61177 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1171,8 +1171,7 @@ } } [] GTPU.receive(tr_GTPU_GPDU(g_peer_u, ?)) -> value ud { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - "Received wrong local TEID"); + setverdict(fail, "Received wrong local TEID"); } [] GTPU.receive { setverdict(fail); } [] T_default.timeout { setverdict(fail); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib31481e79fc81983ae0c36f0512c6b7dba3f28a8 Gerrit-Change-Number: 36111 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn_tests: f_wait_icmp4: don't shutdown on error

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36111?usp=email ) Change subject: ggsn_tests: f_wait_icmp4: don't shutdown on error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib31481e79fc81983ae0c36f0512c6b7dba3f28a8 Gerrit-Change-Number: 36111 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Feb 2024 07:22:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn_tests: fix typo

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36110?usp=email ) Change subject: ggsn_tests: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefd1bfead68878553cbfd0f34ea8aaa4bdd40a41 Gerrit-Change-Number: 36110 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Feb 2024 07:21:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Add tests to validate concurrent connections

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email ) Change subject: epdg: Add tests to validate concurrent connections ...................................................................... Patch Set 5: (1 comment) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/42067ac2_20f6… PS2, Line 797: -> sender vc_conn > AH I see what you mean. […] Works better after I added some f_sleep(0.1) to spread a bit the load over time, otherwise it's too much for ttcn3 to handle, specially since I'm emulating PGW and HSS, which means lots of Diameter traffic in and out. erlang seems to be doing fine, but its procedures time out because ttcn3 takes too many seconds. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7 Gerrit-Change-Number: 36093 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 28 Feb 2024 20:26:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Add tests to validate concurrent connections

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus, osmith. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: epdg: Add tests to validate concurrent connections ...................................................................... epdg: Add tests to validate concurrent connections Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7 --- M epdg/EPDG_Tests.ttcn 1 file changed, 91 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/36093/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7 Gerrit-Change-Number: 36093 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: ipa: Use pseudo-random number for SLS in IPA->M3UA direction

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email ) Change subject: ipa: Use pseudo-random number for SLS in IPA->M3UA direction ...................................................................... Patch Set 2: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/36115/comment/f9bc5b21_70e98547 PS2, Line 990: asp->asp_id = rand() & 0xf; > asp_id is used in the SCTP/M3UA case. It is not used in the IPA/TCP case at all. I see you are "using" it here. So iiuc you mean you are actually storing this rand value here because this field is not really used for other stuff? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733 Gerrit-Change-Number: 36115 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 28 Feb 2024 20:18:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: ipa: Use pseudo-random number for SLS in IPA->M3UA direction

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email ) Change subject: ipa: Use pseudo-random number for SLS in IPA->M3UA direction ...................................................................... Patch Set 2: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/36115/comment/790cf47c_d097db79 PS2, Line 990: asp->asp_id = rand() & 0xf; > asp_id is not used in the SCTP/M3UA case? asp_id is used in the SCTP/M3UA case. It is not used in the IPA/TCP case at all. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733 Gerrit-Change-Number: 36115 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 20:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: epdg_ue_fsm.erl: Log unexpected event

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36120?usp=email ) Change subject: epdg_ue_fsm.erl: Log unexpected event ...................................................................... epdg_ue_fsm.erl: Log unexpected event Change-Id: If5a9298296df07555e79fd61e1f7b948b9a1dd15 --- M src/epdg_ue_fsm.erl 1 file changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/20/36120/1 diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl index 94f2a39..291df26 100644 --- a/src/epdg_ue_fsm.erl +++ b/src/epdg_ue_fsm.erl @@ -267,12 +267,12 @@ Data1 = Data#ue_fsm_data{tear_down_gsup_needed = false}, {next_state, state_wait_swm_session_termination_answer, Data1, [{reply,From,ok}]}; -state_authenticated({call, From}, _Whatever, Data) -> - lager:error("ue_fsm state_authenticated: Unexpected call event, ~p~n", [Data]), +state_authenticated({call, From}, Event, Data) -> + lager:error("ue_fsm state_authenticated: Unexpected call event ~p, ~p~n", [Event, Data]), {keep_state, Data, [{reply,From,ok}]}; -state_authenticated(cast, _Whatever, Data) -> - lager:error("ue_fsm state_authenticated: Unexpected cast event, ~p~n", [Data]), +state_authenticated(cast, Event, Data) -> + lager:error("ue_fsm state_authenticated: Unexpected cast event ~p, ~p~n", [Event, Data]), {keep_state, Data}. state_wait_create_session_resp(enter, _OldState, Data) -> @@ -334,12 +334,12 @@ Data1 = Data#ue_fsm_data{tun_pdp_ctx = undefined, tear_down_gsup_needed = false}, {next_state, state_wait_swm_session_termination_answer, Data1, [{reply,From,ok}]}; -state_active({call, From}, _Whatever, Data) -> - lager:error("ue_fsm state_active: Unexpected call event, ~p~n", [Data]), +state_active({call, From}, Event, Data) -> + lager:error("ue_fsm state_active: Unexpected call event ~p, ~p~n", [Event, Data]), {keep_state, Data, [{reply,From,ok}]}; -state_active(cast, _Whatever, Data) -> - lager:error("ue_fsm state_active: Unexpected cast event, ~p~n", [Data]), +state_active(cast, Event, Data) -> + lager:error("ue_fsm state_active: Unexpected cast event ~p, ~p~n", [Event, Data]), {keep_state, Data}. state_wait_delete_session_resp(enter, _OldState, Data) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: If5a9298296df07555e79fd61e1f7b948b9a1dd15 Gerrit-Change-Number: 36120 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: fix regression in sctp-proto / transport-proto

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36114?usp=email ) Change subject: fix regression in sctp-proto / transport-proto ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > FYI: I reported https://osmocom.org/issues/6380. […] if you get around doing it quickly, thanks. I'll be unable to do it before thursday afternoon. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36114?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic666b62948880445e030c637298d4e369b4c7e8e Gerrit-Change-Number: 36114 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 20:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024