November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email ) Change subject: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies ...................................................................... obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies Seems like this was forgotten when 24.04 was enabled on OBS Related: SYS#7208 Change-Id: I16db5251659798446e34f71f2878614500aae193 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 6458090..e0e2af2 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -10,9 +10,11 @@ latest/xUbuntu_21.04 latest/xUbuntu_22.04 latest/xUbuntu_23.04 +latest/xUbuntu_24.04 nightly/CentOS_8 nightly/Debian_11 nightly/Debian_12 nightly/Raspbian_11 nightly/xUbuntu_23.04 +nightly/xUbuntu_24.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I16db5251659798446e34f71f2878614500aae193 Gerrit-Change-Number: 38980 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email ) Change subject: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I16db5251659798446e34f71f2878614500aae193 Gerrit-Change-Number: 38980 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Nov 2024 11:47:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email ) Change subject: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I16db5251659798446e34f71f2878614500aae193 Gerrit-Change-Number: 38980 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 29 Nov 2024 11:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email ) Change subject: obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies ...................................................................... obs-mirror: Keep archive of Ubuntu 24.04 latest/nightlies Seems like this was forgotten when 24.04 was enabled on OBS Related: SYS#7208 Change-Id: I16db5251659798446e34f71f2878614500aae193 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/38980/1 diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 6458090..e0e2af2 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -10,9 +10,11 @@ latest/xUbuntu_21.04 latest/xUbuntu_22.04 latest/xUbuntu_23.04 +latest/xUbuntu_24.04 nightly/CentOS_8 nightly/Debian_11 nightly/Debian_12 nightly/Raspbian_11 nightly/xUbuntu_23.04 +nightly/xUbuntu_24.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I16db5251659798446e34f71f2878614500aae193 Gerrit-Change-Number: 38980 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: abis: Fix reusing link->conn while it is being destroyed

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38978?usp=email ) Change subject: abis: Fix reusing link->conn while it is being destroyed ...................................................................... abis: Fix reusing link->conn while it is being destroyed Call to osmo_stream_cli_destroy() may end up triggering disconnect_cb(), and we don't want to attempt doing more stuff with that conn when that happens (we were even trying to reconnect() it...). Avoid it by marking the pointer as NULL immediatelly before calling e1inp_sign_link_destroy(). Change-Id: I56605766af974d86610d0958f4b82e6e4ff94502 --- M src/cbsp_link.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/cbsp_link.c b/src/cbsp_link.c index 07fbadd..6b355df 100644 --- a/src/cbsp_link.c +++ b/src/cbsp_link.c @@ -102,6 +102,8 @@ static int cbc_cbsp_link_cli_disconnect_cb(struct osmo_stream_cli *conn) { struct cbc_cbsp_link *link = osmo_stream_cli_get_data(conn); + if (!link->conn) /* conn is being destroyed by us, we called osmo_stream_cli_destroy() */ + return 0; LOGPCC(link, LOGL_NOTICE, "Disconnected.\n"); LOGPCC(link, LOGL_NOTICE, "Reconnecting...\n"); osmo_stream_cli_reconnect(conn); @@ -364,10 +366,11 @@ return; if (link->is_client) { - osmo_stream_cli_destroy(link->cli_conn); + struct osmo_stream_cli *cli_conn = link->cli_conn; + link->cli_conn = NULL; + osmo_stream_cli_destroy(cli_conn); if (link->peer) link->peer->link.cbsp = NULL; - link->cli_conn = NULL; if (link->fi) osmo_fsm_inst_dispatch(link->fi, CBSP_LINK_E_CMD_CLOSE, NULL); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I56605766af974d86610d0958f4b82e6e4ff94502 Gerrit-Change-Number: 38978 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: abis: Fix reusing link->conn while it is being destroyed

by fixeria

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38978?usp=email ) Change subject: abis: Fix reusing link->conn while it is being destroyed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I56605766af974d86610d0958f4b82e6e4ff94502 Gerrit-Change-Number: 38978 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Nov 2024 10:59:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: cbsp_link: Log unexpected return error codes

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email ) Change subject: cbsp_link: Log unexpected return error codes ...................................................................... cbsp_link: Log unexpected return error codes This easies spotting the cause of close/destroy code paths. Change-Id: Ibfd9a33798ba88e2332c00ed90709e38bb2222d7 --- M src/cbsp_link.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/cbsp_link.c b/src/cbsp_link.c index 2c31455..07fbadd 100644 --- a/src/cbsp_link.c +++ b/src/cbsp_link.c @@ -121,6 +121,7 @@ /* message de-segmentation */ rc = osmo_cbsp_recv_buffered(conn, ofd->fd, &msg, &link->rx_msg); if (rc <= 0) { + LOGPCC(link, LOGL_NOTICE, "osmo_cbsp_recv_buffered() ret %d\n", rc); if (rc == -EAGAIN || rc == -EINTR) { /* more data needs to be read */ return 0; @@ -205,6 +206,7 @@ /* message de-segmentation */ rc = osmo_cbsp_recv_buffered(conn, ofd->fd, &msg, &link->rx_msg); if (rc <= 0) { + LOGPCC(link, LOGL_NOTICE, "osmo_cbsp_recv_buffered() ret %d\n", rc); if (rc == -EAGAIN || rc == -EINTR) { /* more data needs to be read */ return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ibfd9a33798ba88e2332c00ed90709e38bb2222d7 Gerrit-Change-Number: 38977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: cbsp_link: Log unexpected return error codes

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email ) Change subject: cbsp_link: Log unexpected return error codes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ibfd9a33798ba88e2332c00ed90709e38bb2222d7 Gerrit-Change-Number: 38977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 29 Nov 2024 10:55:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in libosmo-abis[master]: e1_input: Guard against crash by users calling reentrant e1inp_sign_l...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38969?usp=email ) Change subject: e1_input: Guard against crash by users calling reentrant e1inp_sign_link_destroy() ...................................................................... e1_input: Guard against crash by users calling reentrant e1inp_sign_link_destroy() Related: osmo-bsc.git Change-Id Ice71b3143f167482e4a23759012b58e9ee13bfc0 Related: osmo-bts.git Change-Id Ibc06cdc2d2cd2028b7676fa0c3211ae251cca587 Change-Id: Ib761cece68f1d809e27194bc5cc2eb15ad2ae4eb --- M src/e1_input.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/e1_input.c b/src/e1_input.c index 76adbd9..066a572 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -810,7 +810,17 @@ { struct msgb *msg; - llist_del(&link->list); + /* Catch upper layers behaving wrongly, calling e1inp_sign_link_destroy() + * and then during the driver->close() callback below ending up calling + * this function again deeper in the call stack in the same code path. */ + if (llist_empty(&link->list)) { + LOGP(DLINP, LOGL_ERROR, "Fix your application, " + "caught reentrant e1inp_sign_link_destroy(%p)!\n", link); + return; + } + /* Use llist_del_init() to catch double destroy above: */ + llist_del_init(&link->list); + while (!llist_empty(&link->tx_list)) { msg = msgb_dequeue(&link->tx_list); msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib761cece68f1d809e27194bc5cc2eb15ad2ae4eb Gerrit-Change-Number: 38969 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: e1_input: Fix e1i_ts pointing to old line after line_clone

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38965?usp=email ) Change subject: e1_input: Fix e1i_ts pointing to old line after line_clone ...................................................................... e1_input: Fix e1i_ts pointing to old line after line_clone Change-Id: I8f8e1fd67a63b46d59f433ad01bb2ab880cdf910 --- M src/e1_input.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/e1_input.c b/src/e1_input.c index 145fccf..76adbd9 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -675,6 +675,10 @@ OSMO_ASSERT(clone->sock_path); } + /* Update TS to point to the cloned line: */ + for (unsigned int i = 0; i < line->num_ts; i++) + clone->ts[i].line = clone; + /* * Rate counters and driver data are shared between clones. These are pointers * to dynamic memory so we use reference counting to avoid a double-free (see OS#3137). -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8f8e1fd67a63b46d59f433ad01bb2ab880cdf910 Gerrit-Change-Number: 38965 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024