November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: stream_cli: steal talloc ctx upon delaying free to avoid use after free

by laforge

Attention is currently required from: daniel, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38975?usp=email ) Change subject: stream_cli: steal talloc ctx upon delaying free to avoid use after free ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id7625558d4b1343d621fb51406fa7f841db864ee Gerrit-Change-Number: 38975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 17:04:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS

by pespin

Attention is currently required from: dexter, fixeria, laforge. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email ) Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3fbf5430db8b8ea29efb147bd162706990453fc5 Gerrit-Change-Number: 38957 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:56:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bts[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email ) Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bb8d0ec5e8d4b9f822f94249a75d8dc477144a3 Gerrit-Change-Number: 38958 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:55:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: .gitignore: Add *~

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38973?usp=email ) Change subject: .gitignore: Add *~ ...................................................................... .gitignore: Add *~ This allows getting rid of further files like install-sh~. Change-Id: Iad7ce44a2ecd90116376a458cc40f355d3883c53 --- M .gitignore 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 1872058..7f8336d 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ *.a *.lo *.la +*~ .deps Makefile Makefile.in @@ -20,7 +21,6 @@ install-sh missing stamp-h1 -configure~ # libtool ltmain.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Iad7ce44a2ecd90116376a458cc40f355d3883c53 Gerrit-Change-Number: 38973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS

by dexter

Attention is currently required from: dexter, fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS We receive a TXT indication that contains the PCU_VERSION from the PCU when the connection to the PCU is established. This message contains a BTS number, which is always 0. This is a hard coded value that does not refer to a specific BTS object. Also it is not logical to inform a specific BTS object about the PCU version. This information should be directed to the connecting process as a whole. However, we use this TXT indication to trigger certain initialization processes on the BTS object we manage inside the BSC process. Unfortunately the BSC is currently using the BTS Number in the TXT indication to resolve the BTS object. This is not correct, instead the BSC should iterate of over all BTS objects and trigger the initializations for each BTS object that has a BSC co-located PCU. This change does not have any dependencies, it just corrects the behavior of the BSC on initialization. Related: OS#6507 Change-Id: I3fbf5430db8b8ea29efb147bd162706990453fc5 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 33 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/38957/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3fbf5430db8b8ea29efb147bd162706990453fc5 Gerrit-Change-Number: 38957 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bts[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS

by dexter

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS We receive a TXT indication that contains the PCU_VERSION from the PCU when the connection to the PCU is established. This message contains a BTS number, which is always 0. This is a hard coded value that does not refer to a specific BTS object. Also it is not logical to inform a specific BTS object about the PCU version. This information should be directed to the connecting process as a whole. However, we use this TXT indication to trigger certain initialization processes on the BTS object we manage inside the BTS process (currently this is only 1 bts, but this may change in the future). So instead of using the BTS in the TXT indication, we should iterate of over all BTS objects and trigger the initializations for each of the BTS objects. This change does not have any dependencies, nor does it change the current behavior of osmo-bts. It just cleans up the logic, so that it works by intension and not just by chance. Related: OS#6507 Change-Id: I1bb8d0ec5e8d4b9f822f94249a75d8dc477144a3 --- M src/common/pcu_sock.c 1 file changed, 37 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/58/38958/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bb8d0ec5e8d4b9f822f94249a75d8dc477144a3 Gerrit-Change-Number: 38958 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bts[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email ) Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... Patch Set 3: (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/38958/comment/4dccb93e_12ad1baa?usp… : PS1, Line 947: #define ENSURE_BTS_OBJECT() \ > I prefer having the bts pointer param as an inout param. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bb8d0ec5e8d4b9f822f94249a75d8dc477144a3 Gerrit-Change-Number: 38958 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: cbsp_link: Log unexpected return error codes

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email ) Change subject: cbsp_link: Log unexpected return error codes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ibfd9a33798ba88e2332c00ed90709e38bb2222d7 Gerrit-Change-Number: 38977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:39:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: .gitignore: Add *~

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38973?usp=email ) Change subject: .gitignore: Add *~ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Iad7ce44a2ecd90116376a458cc40f355d3883c53 Gerrit-Change-Number: 38973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: e1_input: Fix e1i_ts pointing to old line after line_clone

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38965?usp=email ) Change subject: e1_input: Fix e1i_ts pointing to old line after line_clone ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8f8e1fd67a63b46d59f433ad01bb2ab880cdf910 Gerrit-Change-Number: 38965 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:15:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024