November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: stream_cli: steal talloc ctx upon delaying free to avoid use after free

by fixeria

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38975?usp=email ) Change subject: stream_cli: steal talloc ctx upon delaying free to avoid use after free ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id7625558d4b1343d621fb51406fa7f841db864ee Gerrit-Change-Number: 38975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:14:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-ci[master]: jobs/osmocom-release-android-apks: new job

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38974?usp=email ) Change subject: jobs/osmocom-release-android-apks: new job ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iab3472c8bf24a35c5f602b03a29510542e2c3d58 Gerrit-Change-Number: 38974 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:14:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in libosmo-abis[master]: e1_input: Guard against crash by users calling reentrant e1inp_sign_l...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38969?usp=email ) Change subject: e1_input: Guard against crash by users calling reentrant e1inp_sign_link_destroy() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib761cece68f1d809e27194bc5cc2eb15ad2ae4eb Gerrit-Change-Number: 38969 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:13:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: e1_input: Fix e1i_ts pointing to old line after line_clone

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38965?usp=email ) Change subject: e1_input: Fix e1i_ts pointing to old line after line_clone ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8f8e1fd67a63b46d59f433ad01bb2ab880cdf910 Gerrit-Change-Number: 38965 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:12:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: ipaccess: Convert BTS OML & RSL link to use stream_cli

by fixeria

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email ) Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/1ac455ee_94691beb… : PS1, Line 545: osmo_stream_cli_send > because osmo_stream_cli_send() returns void. Oh, I see now. Didn't notice this. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35c214fbe930c695a1475d8b4bc3dc44dff83eea Gerrit-Change-Number: 38927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:10:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: ipaccess: Convert BTS OML & RSL link to use stream_cli

by pespin

Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email ) Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli ...................................................................... Patch Set 1: (3 comments) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/8e40abe4_ece65fd8… : PS1, Line 494: OSMO_ASSERT(cli); > If you dive into the code you'd like to put even more asserts! […] Done https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/653f7f9f_0f0e862f… : PS1, Line 545: osmo_stream_cli_send > because osmo_stream_cli_send() returns void. […] Done https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/89e44a92_c1c4486d… : PS1, Line 992: err: : return -1; > Yes, but I prefer having all error paths easily visible this way. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35c214fbe930c695a1475d8b4bc3dc44dff83eea Gerrit-Change-Number: 38927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 16:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: ipaccess: Convert BTS OML & RSL link to use stream_cli

by pespin

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli ...................................................................... ipaccess: Convert BTS OML & RSL link to use stream_cli This in turn allows running BTS Abis interfaces through io-uring backend, which should provide performance improvements when used. Related: SYS#7063 Related: OS#5756 Depends: libosmo-netif.git Change-Id I952938474fa2780bf3c906cbdffb2d024b03c1b7 Depends: libosmocore.git Change-Id 8bcfe62521a977a05b2498efe906d6db6e2be4e8 Change-Id: I35c214fbe930c695a1475d8b4bc3dc44dff83eea --- M TODO-RELEASE M libosmoabis.pc.in M src/Makefile.am M src/input/ipaccess.c 4 files changed, 354 insertions(+), 148 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/27/38927/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35c214fbe930c695a1475d8b4bc3dc44dff83eea Gerrit-Change-Number: 38927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: ipaccess: Convert BTS OML & RSL link to use stream_cli

by pespin

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email ) Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli ...................................................................... Patch Set 1: (6 comments) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/bb9f384d_156b5e3a… : PS1, Line 494: OSMO_ASSERT(cli); > Why are you so assert()ive? ;) […] If you dive into the code you'd like to put even more asserts! After work on the BSC side I think I indeed can remove this one, will do. https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/bc454569_45f14ee9… : PS1, Line 545: osmo_stream_cli_send > Why not returning `rc` of this function? because osmo_stream_cli_send() returns void. YES, I KNOW, BIG FAIL!!!!! Remember this case next time you see a new API added returning void 😊 I'm also thinking about creating a osmo_stream_cli_send2() which returns int, and deprectate the other one. That can be done later on though. For osmo_fd backend that was not much of a problem (because we were not checking for a max queue size at the time), but for osmo_io backend it can fail when reaching max length of its internal queue... https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/184dcdbb_cf82fb52… : PS1, Line 928: *msgb_put(nmsg2, 1) = IPAC_MSGT_ID_ACK; > `msgb_v_put(nmsg2, IPAC_MSGT_ID_ACK)` Done https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/08dd7de2_d0209970… : PS1, Line 944: uint8_t *data = msgb_l2(msg); > `const`? Done https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/e67b92cd_7ef2b5a0… : PS1, Line 992: err: : return -1; > `goto`s can be replaced with `return -1`? Yes, but I prefer having all error paths easily visible this way. https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/b122a1da_85c99e60… : PS1, Line 1014: e1i_ts->line > `s/e1i_ts->line/line/` Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I35c214fbe930c695a1475d8b4bc3dc44dff83eea Gerrit-Change-Number: 38927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Nov 2024 15:59:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: stream_cli: Explicitly ignore return code of stream_cli_close

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38979?usp=email ) Change subject: stream_cli: Explicitly ignore return code of stream_cli_close ...................................................................... stream_cli: Explicitly ignore return code of stream_cli_close Make coverity happy. We don't really case about th return code of the stream_cli_close() function in the code path, since the return value is only used internally/privately in the object and there's no further access/use of the object after calling it in osmo_stream_cli_close(). Take the chance to update syntax of one return code check to match more similarly other return checks of the same function. Related: Coverity CID#435092 Change-Id: Ia6c9e3ca3af08b386f017460b0a0210ed756a929 --- M src/stream_cli.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/79/38979/1 diff --git a/src/stream_cli.c b/src/stream_cli.c index 43877d3..85ede60 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -219,7 +219,7 @@ * abstraction and close the socket */ void osmo_stream_cli_close(struct osmo_stream_cli *cli) { - stream_cli_close(cli); + (void)stream_cli_close(cli); } /*! Re-connect an Osmocom Stream Client. @@ -967,7 +967,7 @@ return; LOGSCLI(cli, LOGL_DEBUG, "destroy()\n"); - OSMO_ASSERT(!stream_cli_close(cli)); + OSMO_ASSERT(stream_cli_close(cli) == false); osmo_timer_del(&cli->timer); msgb_queue_free(&cli->tx_queue); cli->tx_queue_count = 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia6c9e3ca3af08b386f017460b0a0210ed756a929 Gerrit-Change-Number: 38979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: cbsp_link: Log unexpected return error codes

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email ) Change subject: cbsp_link: Log unexpected return error codes ...................................................................... cbsp_link: Log unexpected return error codes This easies spotting the cause of close/destroy code paths. Change-Id: Ibfd9a33798ba88e2332c00ed90709e38bb2222d7 --- M src/cbsp_link.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/77/38977/1 diff --git a/src/cbsp_link.c b/src/cbsp_link.c index 2c31455..07fbadd 100644 --- a/src/cbsp_link.c +++ b/src/cbsp_link.c @@ -121,6 +121,7 @@ /* message de-segmentation */ rc = osmo_cbsp_recv_buffered(conn, ofd->fd, &msg, &link->rx_msg); if (rc <= 0) { + LOGPCC(link, LOGL_NOTICE, "osmo_cbsp_recv_buffered() ret %d\n", rc); if (rc == -EAGAIN || rc == -EINTR) { /* more data needs to be read */ return 0; @@ -205,6 +206,7 @@ /* message de-segmentation */ rc = osmo_cbsp_recv_buffered(conn, ofd->fd, &msg, &link->rx_msg); if (rc <= 0) { + LOGPCC(link, LOGL_NOTICE, "osmo_cbsp_recv_buffered() ret %d\n", rc); if (rc == -EAGAIN || rc == -EINTR) { /* more data needs to be read */ return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/38977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ibfd9a33798ba88e2332c00ed90709e38bb2222d7 Gerrit-Change-Number: 38977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024