November 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Merge TC_ps_rab_assignment_* testcases

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38595?usp=email ) Change subject: hnbgw: Merge TC_ps_rab_assignment_* testcases ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfc3a7d74494bd78d8cfb4efa535ab4cd1b07cae Gerrit-Change-Number: 38595 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 01:05:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell: add new commandline option "--pure"

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38608?usp=email ) Change subject: pySim-shell: add new commandline option "--pure" ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/38608/comment/246ec135_3cd2807c?usp=em… : PS1, Line 7: pure > Maybe call it "--blank-card" or "--skip-card-init"? Yeah, I'm also not happy with the --pure name. "--skip-card-init" sounds even better than the "--raw" that cam to my mind. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d8a57de201fe7ad7cbcbc6f72969ea8521e821d Gerrit-Change-Number: 38608 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 01:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim-shell: fix reset command for no-profile mode

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38607?usp=email ) Change subject: pySim-shell: fix reset command for no-profile mode ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: might make sense to add a generic javacard to the pysim-tester? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I27bf9fdb131d8bdeba07f4dfd2b76b38f9bfdd17 Gerrit-Change-Number: 38607 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 01:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim-shell: allow checking of APDU responses

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38606?usp=email ) Change subject: pySim-shell: allow checking of APDU responses ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/38606/comment/779749ff_82b079bb?usp=em… : PS1, Line 13: itsself itself -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I97bbcdf37bdcf00ad50a875b96940c211de7073d Gerrit-Change-Number: 38606 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 01:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: global_platform/scp: mapdu may be undeclared

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38605?usp=email ) Change subject: global_platform/scp: mapdu may be undeclared ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic7089a69dffd7313572c5b3e5953200be5925766 Gerrit-Change-Number: 38605 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 01:01:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell-test: improve global platform tests

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38604?usp=email ) Change subject: pySim-shell-test: improve global platform tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idff40b414a249e532df1bdce2a8deb9b0cb9718f Gerrit-Change-Number: 38604 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 01:01:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: commands: fix typo

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38599?usp=email ) Change subject: commands: fix typo ...................................................................... commands: fix typo Change-Id: I4103b7474063a26f09666361aef72abcd35bc12d --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index 5c5933a..61e2554 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -617,7 +617,7 @@ return self.send_apdu_checksw(self.cla_byte + '44000002' + fid) def create_file(self, payload: Hexstr) -> ResTuple: - """Execute CREEATE FILE command as per TS 102 222 Section 6.3""" + """Execute CREATE FILE command as per TS 102 222 Section 6.3""" return self.send_apdu_checksw(self.cla_byte + 'e00000%02x%s' % (len(payload)//2, payload)) def resize_file(self, payload: Hexstr) -> ResTuple: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4103b7474063a26f09666361aef72abcd35bc12d Gerrit-Change-Number: 38599 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: commands: fix double space character in apidoc

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38601?usp=email ) Change subject: commands: fix double space character in apidoc ...................................................................... commands: fix double space character in apidoc Change-Id: Id0dbe4578fd212bc240aac80e1e416cb57e92cc7 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index 61e2554..03f0935 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -136,7 +136,7 @@ p2 : string (in hex) ISO 7116 Parameter 2 byte cmd_cosntr : defining how to generate binary APDU command data cmd_data : command data passed to cmd_constr - resp_cosntr : defining how to decode binary APDU response data + resp_cosntr : defining how to decode binary APDU response data apply_lchan : apply the currently selected lchan to the CLA byte before sending Returns: Tuple of (decoded_data, sw) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id0dbe4578fd212bc240aac80e1e416cb57e92cc7 Gerrit-Change-Number: 38601 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: global_platform/scp: fix typo

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38600?usp=email ) Change subject: global_platform/scp: fix typo ...................................................................... global_platform/scp: fix typo Change-Id: Ib26d983c6a80419326de812af2781c5e710dbcfc --- M pySim/global_platform/scp.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/pySim/global_platform/scp.py b/pySim/global_platform/scp.py index d2c72b3..2cf8b63 100644 --- a/pySim/global_platform/scp.py +++ b/pySim/global_platform/scp.py @@ -474,7 +474,7 @@ return self.wrap_cmd_apdu(header + self.host_cryptogram, skip_cenc=True) def _wrap_cmd_apdu(self, apdu: bytes, skip_cenc: bool = False) -> bytes: - """Wrap Command APDU for SCP02: calculate MAC and encrypt.""" + """Wrap Command APDU for SCP03: calculate MAC and encrypt.""" cla = apdu[0] ins = apdu[1] p1 = apdu[2] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib26d983c6a80419326de812af2781c5e710dbcfc Gerrit-Change-Number: 38600 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

7 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: commands: fix apidoc (wrong order of parameters)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38602?usp=email ) Change subject: commands: fix apidoc (wrong order of parameters) ...................................................................... commands: fix apidoc (wrong order of parameters) Change-Id: I4d17c71c7f992ecd795dd214d34f2e094c0a5b53 --- M pySim/commands.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index 03f0935..0173f70 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -110,9 +110,9 @@ Args: pdu : string of hexadecimal characters (ex. "A0A40000023F00") - apply_lchan : apply the currently selected lchan to the CLA byte before sending sw : string of 4 hexadecimal characters (ex. "9000"). The user may mask out certain - digits using a '?' to add some ambiguity if needed. + digits using a '?' to add some ambiguity if needed. + apply_lchan : apply the currently selected lchan to the CLA byte before sending Returns: tuple(data, sw), where data : string (in hex) of returned data (ex. "074F4EFFFF") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4d17c71c7f992ecd795dd214d34f2e094c0a5b53 Gerrit-Change-Number: 38602 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

7 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024