November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim-shell: fix reset command for no-profile mode

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38607?usp=email ) Change subject: pySim-shell: fix reset command for no-profile mode ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > might make sense to add a generic javacard to the pysim-tester? I think we should do that to make sure the T=1 keeps working. In any case, we should add a test where we start with --skip-card-init (follow up patch) and then try an APDU and a reset and then we use the "equip" command to see if we can level up to the full featured mode. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I27bf9fdb131d8bdeba07f4dfd2b76b38f9bfdd17 Gerrit-Change-Number: 38607 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell: add new commandline option "--skip-card-init"

by dexter

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38608?usp=email ) Change subject: pySim-shell: add new commandline option "--skip-card-init" ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/38608/comment/77ae2e2c_64e7fbae?usp=em… : PS1, Line 7: pure > Yeah, I'm also not happy with the --pure name. […] (There are only two hard things in Computer Science: cache invalidation and naming things.) - thanks. File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/38608/comment/bf902e78_4a0b26cc?usp=em… : PS1, Line 171: > ws Done https://gerrit.osmocom.org/c/pysim/+/38608/comment/b8e5e657_ffe69a6b?usp=em… : PS1, Line 171: > ws Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d8a57de201fe7ad7cbcbc6f72969ea8521e821d Gerrit-Change-Number: 38608 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell_test/utils: print logfile on all types of errors

by dexter

Attention is currently required from: dexter, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38603?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell_test/utils: print logfile on all types of errors ...................................................................... pySim-shell_test/utils: print logfile on all types of errors When pySim-shell has problems starting up, it exits with an error code. This is detected by the testsuite, but it also causes an early exit, so that the log file content are not printed. Change-Id: Ic0f34eda32a7c557810abcb05a84e343741fdb8a --- M tests/pySim-shell_test/utils.py 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/03/38603/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic0f34eda32a7c557810abcb05a84e343741fdb8a Gerrit-Change-Number: 38603 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Tear down SCCP conn from CN under normal conditions

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38597?usp=email ) Change subject: hnbgw: Tear down SCCP conn from CN under normal conditions ...................................................................... hnbgw: Tear down SCCP conn from CN under normal conditions Specs mention that under normal conditions the CN is the one expected to tear down the SCCP underlaying connection upon recieving Iu-ReleaseComplete. Change-Id: I920cabcb63ca352db0ed06e4c35dade52bae5399 --- M hnbgw/ConnHdlr.ttcn M library/SCCP_Templates.ttcn 2 files changed, 19 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 1b053d0..13c8d4c 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -72,6 +72,7 @@ import from L3_Common all; import from SCCPasp_Types all; +import from SCCP_Templates all; /*********************************************************************** * code running inside per-UE ConnHdlr @@ -444,19 +445,6 @@ /* expect to receive it on the Iu side */ rx := f_bssap_expect(exp_rx); - - /* expect disconnect on the Iu side */ - T.start; - alt { - [] BSSAP.receive(tr_MSC_CONN_PRIM_DISC_IND) { - setverdict(pass); - } - [] T.timeout { - setverdict(fail, "Timeout waiting for Iu disconnect"); - return rx; - } - - } return rx; } @@ -545,13 +533,13 @@ /* HNB <- CN: Iu-ReleaseCmd, HNB -> CN: Iu-ReleaseCompl */ function f_cn_iu_release_procedure(boolean mgcp_teardown := false, boolean pfcp_teardown := false) runs on ConnHdlr { var RANAP_PDU tx; - timer T := 5.0; + timer T; tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); f_iu2iuh(tx); if (mgcp_teardown) { - T.start; + T.start(5.0); alt { [] as_mgcp_dlcx() {} [] T.timeout { @@ -570,6 +558,21 @@ tx := valueof(ts_RANAP_IuReleaseComplete()); f_iuh2iu_disconnect(tx, RUA_IEs.Cause:{radioNetwork:=normal}); + + /* Once CN receives Iu-ReleaseComplete, it tears down the SCCP conn under Iu: */ + BSSAP.send(ts_MSC_CONN_PRIM_DISC_REQ(sccp_par_reason_end_user_originated)); + /* There's no signalling from lower layers regarding when RLC is + * received, hence only make sure the IUT is not sending an RLSD on its own + * after a timeout, which would mean it didn't process our RLSD */ + T.start(2.0); + alt { + [] BSSAP.receive(tr_MSC_CONN_PRIM_DISC_IND) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected RLSD to our RLSD"); + } + [] T.timeout { + setverdict(pass); + } + } } /* Reply to a received CRCX with an OK (or the reply configured in cpars), using the given parameters. diff --git a/library/SCCP_Templates.ttcn b/library/SCCP_Templates.ttcn index 40a6156..f36dc5a 100644 --- a/library/SCCP_Templates.ttcn +++ b/library/SCCP_Templates.ttcn @@ -15,6 +15,7 @@ import from SCCPasp_Types all; import from SCCP_Emulation all; +const integer sccp_par_reason_end_user_originated := 0; /* End user originated */ const integer sccp_par_reason_end_user_failure := 2; /* End user failure */ /* construct a SCCP_PAR_Address with just SSN and no PC or GT */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I920cabcb63ca352db0ed06e4c35dade52bae5399 Gerrit-Change-Number: 38597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Merge TC_ps_rab_assignment_* testcases

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38595?usp=email ) Change subject: hnbgw: Merge TC_ps_rab_assignment_* testcases ...................................................................... hnbgw: Merge TC_ps_rab_assignment_* testcases Change-Id: Ibfc3a7d74494bd78d8cfb4efa535ab4cd1b07cae --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 17 insertions(+), 43 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index e89a07f..c422ba2 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1383,15 +1383,17 @@ f_shutdown_helper(); } -friend function f_tc_ps_rab_assignment_with_pfcp(charstring id) runs on ConnHdlr { +friend function f_tc_ps_rab_assignment(charstring id) runs on ConnHdlr { var RANAP_PDU tx; - var PDU_PFCP m; - f_pfcp_wait_assoc_setup_req(); + + if (g_pars.pfcp_pars.pfcp_enabled) { + f_pfcp_wait_assoc_setup_req(); + } tx := f_build_initial_ue(g_pars); f_iuh2iu_connect(tx); - f_create_rab_ps_with_pfcp(); + f_create_rab_ps(); f_sleep(2.0); tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); @@ -1399,46 +1401,23 @@ tx := valueof(ts_RANAP_IuReleaseComplete()); f_iuh2iu(tx); - m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.up_f_seid.seid)); - PFCP.send(ts_PFCP_Session_Del_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid)); - /* ask PFCPEM to *not* route PDUs with this specific SEID to us */ - f_PFCPEM_unsubscribe_seid(c_SEID1); + if (g_pars.pfcp_pars.pfcp_enabled) { + var PDU_PFCP m; + m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.up_f_seid.seid)); + PFCP.send(ts_PFCP_Session_Del_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid)); + /* ask PFCPEM to *not* route PDUs with this specific SEID to us */ + f_PFCPEM_unsubscribe_seid(c_SEID1); + } } -testcase TC_ps_rab_assignment_with_pfcp() runs on test_CT { +testcase TC_ps_rab_assignment() runs on test_CT { var ConnHdlr vc_conn; g_num_hnbs := 1; f_init(); f_init_pfcp(testcasename()); f_sleep(1.0); - vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_with_pfcp), f_TestHdlrParams(7, ps_domain := true)); - vc_conn.done; - - f_shutdown_helper(); -} - -friend function f_tc_ps_rab_assignment_without_pfcp(charstring id) runs on ConnHdlr { - var RANAP_PDU tx; - tx := f_build_initial_ue(g_pars); - f_iuh2iu_connect(tx); - - f_create_rab_ps_without_pfcp(); - f_sleep(2.0); - - tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); - f_iu2iuh(tx); - tx := valueof(ts_RANAP_IuReleaseComplete()); - f_iuh2iu(tx); -} - -testcase TC_ps_rab_assignment_without_pfcp() runs on test_CT { - var ConnHdlr vc_conn; - f_init(); - f_init_pfcp(testcasename()); - f_sleep(1.0); - - vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_without_pfcp), f_TestHdlrParams(7, ps_domain := true)); + vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment), f_TestHdlrParams(7, ps_domain := true)); vc_conn.done; f_shutdown_helper(); @@ -2344,12 +2323,7 @@ execute(TC_ranap_cs_creq_cref()); execute(TC_ranap_ps_creq_cref()); execute(TC_cs_iu_release_req_rua_disconnect()); - - if (mp_enable_pfcp_tests) { - execute(TC_ps_rab_assignment_with_pfcp()); - } else { - execute(TC_ps_rab_assignment_without_pfcp()); - } + execute(TC_ps_rab_assignment()); execute( TC_mscpool_L3Compl_on_1_cnlink() ); execute( TC_mscpool_L3Complete_by_imsi_round_robin() ); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index a7f5021..7bbcdec 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -25,7 +25,7 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_cs_creq_cref' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_creq_cref' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_cs_iu_release_req_rua_disconnect' time='MASKED'/> - <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_without_pfcp' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_0_round_robin' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfc3a7d74494bd78d8cfb4efa535ab4cd1b07cae Gerrit-Change-Number: 38595 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Move normal condition Iu Release procedure to helper function

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38596?usp=email ) Change subject: hnbgw: Move normal condition Iu Release procedure to helper function ...................................................................... hnbgw: Move normal condition Iu Release procedure to helper function Change-Id: I5dc7923b78d1b98fea1f71aa6e39c41f70b1f3e6 --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 38 insertions(+), 51 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 47dbd21..1b053d0 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -542,6 +542,36 @@ return valueof(ts_RANAP_RabAssResp(rab_sml)); } +/* HNB <- CN: Iu-ReleaseCmd, HNB -> CN: Iu-ReleaseCompl */ +function f_cn_iu_release_procedure(boolean mgcp_teardown := false, boolean pfcp_teardown := false) runs on ConnHdlr { + var RANAP_PDU tx; + timer T := 5.0; + + tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); + f_iu2iuh(tx); + + if (mgcp_teardown) { + T.start; + alt { + [] as_mgcp_dlcx() {} + [] T.timeout { + setverdict(fail, "Timeout waiting for DLCX"); + } + } + T.stop; + } + if (pfcp_teardown) { + var PDU_PFCP m; + m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.up_f_seid.seid)); + PFCP.send(ts_PFCP_Session_Del_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid)); + /* ask PFCPEM to *not* route PDUs with this specific SEID to us */ + f_PFCPEM_unsubscribe_seid(c_SEID1); + } + + tx := valueof(ts_RANAP_IuReleaseComplete()); + f_iuh2iu_disconnect(tx, RUA_IEs.Cause:{radioNetwork:=normal}); +} + /* Reply to a received CRCX with an OK (or the reply configured in cpars), using the given parameters. * Return true when an OK reply was sent, false otherwise. * Count occurrence of Osmux, include Osmux parameters in the reply if necessary. */ diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index c422ba2..c917816 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1007,21 +1007,7 @@ }; f_statsd_expect(expect); - /* Send Iu Release */ - tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); - f_iu2iuh(tx); - - T.start; - alt { - [] as_mgcp_dlcx() {} - [] T.timeout { - setverdict(fail, "Timeout waiting for DLCX"); - } - } - T.stop - - tx := valueof(ts_RANAP_IuReleaseComplete()); - f_iuh2iu(tx); + f_cn_iu_release_procedure(mgcp_teardown := true); } testcase TC_rab_assignment() runs on test_CT { @@ -1198,12 +1184,7 @@ } } - /* Send Iu Release */ - tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); - f_iu2iuh(tx); - - tx := valueof(ts_RANAP_IuReleaseComplete()); - f_iuh2iu(tx); + f_cn_iu_release_procedure(); } testcase TC_rab_assign_mgcp_to() runs on test_CT { @@ -1273,12 +1254,12 @@ /* HNB->MSC: InitialUE */ f_iuh2iu_connect(f_build_initial_ue(g_pars)); + g_pars.rab_rel_cause := valueof(ts_RanapCause_radio_conn_release); + /* HNB->MSC: Request CN to start Iu-Release procedure: */ - f_iuh2iu(ts_RANAP_IuReleaseRequest(ts_RanapCause_radio_conn_release)); + f_iuh2iu(ts_RANAP_IuReleaseRequest(g_pars.rab_rel_cause)); /* HNB<-MSC: CN starts Iu-Release procedure: */ - f_iu2iuh(ts_RANAP_IuReleaseCommand(ts_RanapCause_radio_conn_release)); - /* HNB->MSC: RUA disconnect */ - f_iuh2iu_disconnect(ts_RANAP_IuReleaseComplete, RUA_IEs.Cause:{misc:=processing_overload}); + f_cn_iu_release_procedure(); } testcase TC_ranap_cs_mo_disconnect() runs on test_CT { var ConnHdlr vc_conn; @@ -1396,18 +1377,7 @@ f_create_rab_ps(); f_sleep(2.0); - tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); - f_iu2iuh(tx); - tx := valueof(ts_RANAP_IuReleaseComplete()); - f_iuh2iu(tx); - - if (g_pars.pfcp_pars.pfcp_enabled) { - var PDU_PFCP m; - m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.up_f_seid.seid)); - PFCP.send(ts_PFCP_Session_Del_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid)); - /* ask PFCPEM to *not* route PDUs with this specific SEID to us */ - f_PFCPEM_unsubscribe_seid(c_SEID1); - } + f_cn_iu_release_procedure(pfcp_teardown := g_pars.pfcp_pars.pfcp_enabled); } testcase TC_ps_rab_assignment() runs on test_CT { @@ -2247,20 +2217,7 @@ f_bssap_expect(tx); /* Send Iu Release */ - tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause)); - f_iu2iuh(tx); - - T.start; - alt { - [] as_mgcp_dlcx() {} - [] T.timeout { - setverdict(fail, "Timeout waiting for DLCX"); - } - } - T.stop; - - tx := valueof(ts_RANAP_IuReleaseComplete()); - f_iuh2iu(tx); + f_cn_iu_release_procedure(mgcp_teardown := true); } testcase TC_second_rab_assignment() runs on test_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5dc7923b78d1b98fea1f71aa6e39c41f70b1f3e6 Gerrit-Change-Number: 38596 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell_test/utils: print logfile on all types of errors

by Jenkins Builder

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38603?usp=email ) Change subject: pySim-shell_test/utils: print logfile on all types of errors ...................................................................... Patch Set 2: (1 comment) File tests/pySim-shell_test/utils.py: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19577): https://gerrit.osmocom.org/c/pysim/+/38603/comment/8d9ee5dd_d4fc7f36?usp=em… : PS2, Line 295: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic0f34eda32a7c557810abcb05a84e343741fdb8a Gerrit-Change-Number: 38603 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 09:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell_test/utils: print logfile on all types of errors

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38603?usp=email ) Change subject: pySim-shell_test/utils: print logfile on all types of errors ...................................................................... Patch Set 2: (1 comment) File tests/pySim-shell_test/utils.py: https://gerrit.osmocom.org/c/pysim/+/38603/comment/cbcb9730_14fc311f?usp=em… : PS1, Line 282: rc > `rc` no longer exists, you meant `py_sim_shell_rc`? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic0f34eda32a7c557810abcb05a84e343741fdb8a Gerrit-Change-Number: 38603 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2024 09:45:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell_test/utils: print logfile on all types of errors

by dexter

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38603?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified-1 by Jenkins Builder Change subject: pySim-shell_test/utils: print logfile on all types of errors ...................................................................... pySim-shell_test/utils: print logfile on all types of errors When pySim-shell has problems starting up, it exits with an error code. This is detected by the testsuite, but it also causes an early exit, so that the log file content are not printed. Change-Id: Ic0f34eda32a7c557810abcb05a84e343741fdb8a --- M tests/pySim-shell_test/utils.py 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/03/38603/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic0f34eda32a7c557810abcb05a84e343741fdb8a Gerrit-Change-Number: 38603 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: enable ttcn3-s1gw-test-latest

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38611?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: enable ttcn3-s1gw-test-latest ...................................................................... jobs/ttcn3-testsuites-testenv: enable ttcn3-s1gw-test-latest Related: SYS#6772 Change-Id: I177ce0038fb019a69acb9cbef895759e6ee89842 --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 8fb7e36..fa58381 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -239,7 +239,6 @@ testsuite: s1gw args: -b osmocom:latest timer: H 12 * * * - disabled: true # disable until > 0.1.x release - ttcn3-ggsn-test-latest: # ~15 min testsuite: ggsn -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I177ce0038fb019a69acb9cbef895759e6ee89842 Gerrit-Change-Number: 38611 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024