Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38389?usp=email )
Change subject: ss7 vty: Limit qos-class range to 0-7
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38389?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I541723e4551977cb2b7afcac01e3bfee070e7bac
Gerrit-Change-Number: 38389
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Oct 2024 08:32:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38388?usp=email )
Change subject: ss7 vty: Validate qos-class number being passed to 'update route'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38388?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ib81499d5ac692e1de463efe931381bbb68fd1131
Gerrit-Change-Number: 38388
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Oct 2024 08:32:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email )
Change subject: _testenv: Avoid running make check when building IUT
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I prefer running with "make check" actually, but fine with me to disable it for now. This should be user-configurable, I'll add something like a .testenvrc.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1b5dd0947a1bd937775a74bceb88dcf3bbcf914b
Gerrit-Change-Number: 38393
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Oct 2024 08:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38423?usp=email )
Change subject: debian/copyright: add gsup_client under GPLv2+
......................................................................
debian/copyright: add gsup_client under GPLv2+
Change-Id: Idddcd6356af76987bf57ecd21096299cb2ba896f
---
M debian/copyright
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/23/38423/1
diff --git a/debian/copyright b/debian/copyright
index 374c9a2..b66ed88 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -6,6 +6,10 @@
Copyright: 2016-2022 Sysmocom s. f. m. c. GmbH <info(a)sysmocom.de>
License: AGPL-3+
+Files: src/gsupclient/*
+Copyright: 2014-2016,2019 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+License: GPL-2+
+
License: AGPL-3+
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as published by
@@ -19,3 +23,17 @@
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+License: GPL-2+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38423?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Idddcd6356af76987bf57ecd21096299cb2ba896f
Gerrit-Change-Number: 38423
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38422?usp=email )
Change subject: gsupclient: add missing SPDX line
......................................................................
gsupclient: add missing SPDX line
SPDX is a spec to describe the license of a file
in a machine readable format.
Change-Id: Iaded691cc0eb2f5dd85efd1915ddef1a747fe518
---
M src/gsupclient/cni_peer_id.c
M src/gsupclient/gsup_client.c
M src/gsupclient/gsup_req.c
3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/22/38422/1
diff --git a/src/gsupclient/cni_peer_id.c b/src/gsupclient/cni_peer_id.c
index ab36959..c4a31b6 100644
--- a/src/gsupclient/cni_peer_id.c
+++ b/src/gsupclient/cni_peer_id.c
@@ -2,6 +2,8 @@
*
* All Rights Reserved
*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
diff --git a/src/gsupclient/gsup_client.c b/src/gsupclient/gsup_client.c
index 4041366..3329361 100644
--- a/src/gsupclient/gsup_client.c
+++ b/src/gsupclient/gsup_client.c
@@ -6,6 +6,8 @@
* Author: Jacob Erlbeck
* Author: Neels Hofmeyr
*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
diff --git a/src/gsupclient/gsup_req.c b/src/gsupclient/gsup_req.c
index 2e7caf1..bde002e 100644
--- a/src/gsupclient/gsup_req.c
+++ b/src/gsupclient/gsup_req.c
@@ -2,6 +2,8 @@
*
* All Rights Reserved
*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38422?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaded691cc0eb2f5dd85efd1915ddef1a747fe518
Gerrit-Change-Number: 38422
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, lynxis lazus.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: gsupclient: Introduce gsup_client_mux
......................................................................
gsupclient: Introduce gsup_client_mux
GSUP supports different message classes (e.g. SMS, USSD, Subscriber management),
within a daemon, the messages are usually handled in different parts of it.
The gsup client mux allow to place callbacks for the different message class.
This code original comes from the osmo-msc code and is here
re-licensed under the GPLv2.
Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f
---
M include/Makefile.am
A include/osmocom/gsupclient/gsup_client_mux.h
M src/gsupclient/Makefile.am
A src/gsupclient/gsup_client_mux.c
4 files changed, 252 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/12/38112/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f
Gerrit-Change-Number: 38112
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38420?usp=email )
Change subject: rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode for NT CSD
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@laforge@osmocom.org IMO, this patch warrants a patch release. However, I would delay this a bit as we'll likely see more CSD related fixes from myself and @falcon@freecalypso.org.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38420?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I793ab4dc25fa852eade6f7a3b67ae961ceb7a093
Gerrit-Change-Number: 38420
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 13 Oct 2024 17:40:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No