October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type
by pespin 14 Oct '24

14 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38416?usp=email ) Change subject: SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9301e7a37d96c3f93e77f7618d6c13dfa1fbe46b Gerrit-Change-Number: 38416 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 13:36:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSGP_ConnHdlr.ttcn: Service Request: expect a CommonId when stopping...
by pespin 14 Oct '24

14 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38415?usp=email ) Change subject: BSSGP_ConnHdlr.ttcn: Service Request: expect a CommonId when stopping on SecurityCommand Complete ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie81c5eb01eb695d0399770b8a7feb9b4549148b3 Gerrit-Change-Number: 38415 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 13:36:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman: restart_count in container_name
by osmith 14 Oct '24

14 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38425?usp=email ) Change subject: testenv: podman: restart_count in container_name ...................................................................... testenv: podman: restart_count in container_name When running testsuites with multiple configurations in a row, as it is the case with the ttcn3-ggsn jobs in jenkins, the podman container gets restarted whenever switching to the next config. Use a different name for each container by appending a restart count. This should fix that podman sometimes didn't fully shutdown the container yet and complains that the container name is already in use. This happens even though we use "podman kill" and "podman wait" on the previous container. When checking later, the container is really gone and the same name can be used, it seems that it just needs some more time to shutdown in some cases. Fix for: > Error: error creating container storage: the container name > "testenv-ggsn_tests-osmo_ggsn_-osmocom-nightly-20241012-0752-2eb85125" is > already in use by "8b7ea42371a922ffbf4e966b853124b98cd25c9905ae443fefb4115a103d7779". > You have to remove that container to be able to reuse that name.: that name is already in use Related: https://github.com/containers/podman/issues/2553 Related: https://jenkins.osmocom.org/jenkins/job/ttcn3-ggsn-test/2674/console Change-Id: Ia791be2fee69765293ce7a7a058319c92bb92714 --- M _testenv/testenv/podman.py 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/38425/1 diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index bd1e8d8..683f468 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -20,6 +20,7 @@ apt_dir_var_lib = None feed_watchdog_process = None run_shell_on_stop = False +restart_count = 0 def image_exists(): @@ -190,7 +191,8 @@ testdir_topdir = testenv.testdir.testdir_topdir osmo_dev_dir = testenv.osmo_dev.get_osmo_dev_dir() - container_name = testenv.testdir.prefix + container_name = f"{testenv.testdir.prefix}-{restart_count}" + # Custom seccomp profile that allows io_uring seccomp = os.path.join(testenv.data_dir, "podman/seccomp.json") @@ -287,6 +289,7 @@ def stop(restart=False): global container_name global run_shell_on_stop + global restart_count if not is_running(): return @@ -316,4 +319,5 @@ container_name = None if restart: + restart_count += 1 start() -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia791be2fee69765293ce7a7a058319c92bb92714 Gerrit-Change-Number: 38425 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ggsn[master]: gtp: allow packets with E-bit set
by osmith 14 Oct '24

14 Oct '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38383?usp=email ) Change subject: gtp: allow packets with E-bit set ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/38383/comment/8ac75fa7_10cc00a1?us… : PS1, Line 17: Related: OS#6223 > I think this needs some spec analysis of what the expected behaviour is when packets with unknown/un […] I've looked into it some more: 3GPP TS 29.060 § 6 towards the end explains when comprehension is required or not, it depends on bits 7 and 8 of the Extension Header Type. If comprehension is required, but the recipient doesn't understand it, it is supposed to: * send a response with cause "unknown mandatory extension header" * send a Supported Extension Headers Notification * log an error So I guess the right thing to do would be: * accept packets with the E-bit set * iterate over all extension headers * look at the comprehension bits, and if no comprehension is required then ignore the extension header * otherwise reject the packet with the steps listed above @laforge@gnumonks.org: do you want me to implement this, or put it in a new ticket? I'm not sure how important this is. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic62f95874a877a2f295765b807d7f23b011aeaa3 Gerrit-Change-Number: 38383 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 09:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add ubuntu 24.10
by osmith 14 Oct '24

14 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38424?usp=email ) Change subject: jobs/osmocom-obs-sync: add ubuntu 24.10 ...................................................................... jobs/osmocom-obs-sync: add ubuntu 24.10 Change-Id: I481ecf9b19b209d89fcc5dde1ffb1ad6614c5e92 --- M jobs/osmocom-obs-sync.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/38424/1 diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 7f13e02..61578ba 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -37,6 +37,7 @@ Raspbian:12 Ubuntu:22.04 Ubuntu:24.04 + Ubuntu:24.10 " ./scripts/obs/sync_obs_projects.py \ --docker \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I481ecf9b19b209d89fcc5dde1ffb1ad6614c5e92 Gerrit-Change-Number: 38424 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: add test TC_pdp4_clients_interact_with_ext_hdr
by osmith 14 Oct '24

14 Oct '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382?usp=email ) Change subject: ggsn: add test TC_pdp4_clients_interact_with_ext_hdr ...................................................................... Patch Set 2: (1 comment) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382/comment/837c633d_fe78… : PS1, Line 151: var template (omit) GTPU_Header_optional_part gtpu_hdr_opt_part := omit; > missing g_ prefix. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic767f8b50f034171d71cae16512d1d26a07b24bf Gerrit-Change-Number: 38382 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 08:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1U_Templates: support sending ext hdrs
by osmith 14 Oct '24

14 Oct '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381?usp=email ) Change subject: library/GTPv1U_Templates: support sending ext hdrs ...................................................................... Patch Set 2: (1 comment) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381/comment/ba9f4c75_502f… : PS1, Line 402: var template (omit) GTPU_Header_optional_part opt_part; > afaiu you are missing an ":= omit" here, otherwise you pass uninitialized value in line 409 when !us […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1668d45f4454f92c234054678e17145bd4fe49 Gerrit-Change-Number: 38381 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 08:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1U_Templates: support sending ext hdrs
by osmith 14 Oct '24

14 Oct '24

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: library/GTPv1U_Templates: support sending ext hdrs ...................................................................... library/GTPv1U_Templates: support sending ext hdrs Replace the seq (sequenceNumber) parameter in ts_GTP1U_PDU with opt_part (GTPU_Header_optional_part). opt_part contains seq: type record GTPU_Header_optional_part { OCT2 sequenceNumber, OCT1 npduNumber, OCT1 nextExtHeader, GTPU_ExtensionHeader_List gTPU_extensionHeader_List optional } With this change it is possible to set the extension headers too when sending GTPU packets. This is in preparation for a GGSN test case with extension headers. Related: OS#6223 Change-Id: I5b1668d45f4454f92c234054678e17145bd4fe49 --- M epdg/EPDG_Tests.ttcn M ggsn_tests/GGSN_Tests.ttcn M hnodeb/HNBGW_ConnectionHandler.ttcn M library/GTPv1U_Templates.ttcn M sgsn/BSSGP_ConnHdlr.ttcn 5 files changed, 31 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/38381/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1668d45f4454f92c234054678e17145bd4fe49 Gerrit-Change-Number: 38381 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: add test TC_pdp4_clients_interact_with_ext_hdr
by osmith 14 Oct '24

14 Oct '24

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: ggsn: add test TC_pdp4_clients_interact_with_ext_hdr ...................................................................... ggsn: add test TC_pdp4_clients_interact_with_ext_hdr Related: OS#6223 Change-Id: Ic767f8b50f034171d71cae16512d1d26a07b24bf --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 36 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/38382/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic767f8b50f034171d71cae16512d1d26a07b24bf Gerrit-Change-Number: 38382 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmo-sigtran[master]: ss7 vty: Set default route priority to 5
by osmith 14 Oct '24

14 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38390?usp=email ) Change subject: ss7 vty: Set default route priority to 5 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4e283cc07b8e9ea2124ec9da18cbce77c3d866ee Gerrit-Change-Number: 38390 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 08:37:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0