January 2024 - gerrit-log - lists.osmocom.org

[XL] Change in pysim[master]: Initial work on a SM-DP+ for GSMA consumer eSIM RSP
by Jenkins Builder 05 Jan '24

05 Jan '24

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35461?usp=email ) Change subject: Initial work on a SM-DP+ for GSMA consumer eSIM RSP ...................................................................... Patch Set 3: (1 comment) File tests/test_esim_bsp.py: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13460): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8faf1298_248eb5f2 PS3, Line 73: """This test verifies whether some fully encoded/encrypted/MACed bound profile pacakge can be properly 'pacakge' may be misspelled - perhaps 'package'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11 Gerrit-Change-Number: 35461 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Jan 2024 22:57:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in pysim[master]: Initial work on a SM-DP+ for GSMA consumer eSIM RSP
by laforge 05 Jan '24

05 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Initial work on a SM-DP+ for GSMA consumer eSIM RSP ...................................................................... Initial work on a SM-DP+ for GSMA consumer eSIM RSP This commit introduces * the osmo-smdpp.py program implementing the main procedures and the HTTP/REST based ES9+ * python modules for ES8+ and non-volatile RSP Session State storage * the ASN.1 source files required to parse/encode RSP * 3GPP test certificates from SGP.26 * an unsigned profile package (UPP) of a SAIP v2.3 TS48 test profile As I couldn't get the 'Klein' tls support to work, the SM-DP+ code currently does not support HTTPS/TLS but plan HTTP, so you either have to modify your LPA to use HTTP instead of HTTPS, or put a TLS proxy in front. The SM-DP+ is currently failing (at least with my test-eUICC) during configureIsdp with scp03tSecurityError - despite all parts (BSP, KDF, ECKA, ...) having been verified agains hexdumps from a third party implementation. Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11 --- A .checkpatch.conf A osmo-smdpp.py M pySim/esim/__init__.py A pySim/esim/asn1/rsp/PKIX1Explicit88.asn A pySim/esim/asn1/rsp/PKIX1Implicit88.asn A pySim/esim/asn1/rsp/rsp.asn A pySim/esim/es8p.py A pySim/esim/rsp.py A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_BRP.der A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_BRP.pem A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_NIST.der A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_NIST.pem A smdpp-data/certs/CertificateIssuer/CI-csr.cnf A smdpp-data/certs/DPauth/CERT_S_SM_DP2auth_ECDSA_BRP.der A smdpp-data/certs/DPauth/CERT_S_SM_DP2auth_ECDSA_NIST.der A smdpp-data/certs/DPauth/CERT_S_SM_DPauth_ECDSA_BRP.der A smdpp-data/certs/DPauth/CERT_S_SM_DPauth_ECDSA_NIST.der A smdpp-data/certs/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp-data/certs/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp-data/certs/DPauth/PK_S_SM_DPauth_ECDSA_BRP.pem A smdpp-data/certs/DPauth/PK_S_SM_DPauth_ECDSA_NIST.pem A smdpp-data/certs/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp-data/certs/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp-data/certs/DPauth/SK_S_SM_DPauth_ECDSA_BRP.pem A smdpp-data/certs/DPauth/SK_S_SM_DPauth_ECDSA_NIST.pem A smdpp-data/certs/DPauth/data_sig.der A smdpp-data/certs/DPpb/CERT_S_SM_DP2pb_ECDSA_BRP.der A smdpp-data/certs/DPpb/CERT_S_SM_DP2pb_ECDSA_NIST.der A smdpp-data/certs/DPpb/CERT_S_SM_DPpb_ECDSA_BRP.der A smdpp-data/certs/DPpb/CERT_S_SM_DPpb_ECDSA_NIST.der A smdpp-data/certs/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp-data/certs/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp-data/certs/DPpb/PK_S_SM_DPpb_ECDSA_BRP.pem A smdpp-data/certs/DPpb/PK_S_SM_DPpb_ECDSA_NIST.pem A smdpp-data/certs/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp-data/certs/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp-data/certs/DPpb/SK_S_SM_DPpb_ECDSA_BRP.pem A smdpp-data/certs/DPpb/SK_S_SM_DPpb_ECDSA_NIST.pem A smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.csr.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.der A smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.ext.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.csr.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.der A smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.ext.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.csr.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.der A smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.ext.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS.csr.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS.ext.cnf A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS_BRP.der A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS_NIST.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP2_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP4_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP8_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP_TLS_BRP.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP_TLS_NIST.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP2_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP4_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP8_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP_TLS_BRP.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP_TLS_NIST.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP2_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP4_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP8_TLS.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP_TLS_BRP.der A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP_TLS_NIST.der A smdpp-data/certs/DPtls/PK_S_SM_DP2_TLS_NIST.pem A smdpp-data/certs/DPtls/PK_S_SM_DP4_TLS.pem A smdpp-data/certs/DPtls/PK_S_SM_DP8_TLS.pem A smdpp-data/certs/DPtls/PK_S_SM_DP_TLS_BRP.pem A smdpp-data/certs/DPtls/PK_S_SM_DP_TLS_NIST.pem A smdpp-data/certs/DPtls/SK_S_SM_DP2_TLS_NIST.pem A smdpp-data/certs/DPtls/SK_S_SM_DP4_TLS.pem A smdpp-data/certs/DPtls/SK_S_SM_DP8_TLS.pem A smdpp-data/certs/DPtls/SK_S_SM_DP_TLS_BRP.pem A smdpp-data/certs/DPtls/SK_S_SM_DP_TLS_NIST.pem A smdpp-data/certs/README A smdpp-data/upp/TS48 V2 eSIM_GTP_SAIP2.3_NoBERTLV.rename2der A tests/test_esim.py M tests/test_esim_bsp.py 80 files changed, 3,083 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/35461/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11 Gerrit-Change-Number: 35461 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[XL] Change in pysim[master]: Initial work on a SM-DP+ for GSMA consumer eSIM RSP
by Jenkins Builder 05 Jan '24

05 Jan '24

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35461?usp=email ) Change subject: Initial work on a SM-DP+ for GSMA consumer eSIM RSP ...................................................................... Patch Set 2: (330 comments) File osmo-smdpp.py: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/23008b73_4b3573dd PS2, Line 329: #output['otherCertsInChain'] = b64encode2str() trailing whitespace File pySim/esim/asn1/rsp/rsp.asn: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/21601403_9f771be5 PS2, Line 6: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8588dea3_7f98404f PS2, Line 9: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a61d0940_eb6957cd PS2, Line 11: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/98f63665_63b5e482 PS2, Line 23: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1c4aa8f8_41ab405d PS2, Line 27: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4ee03d19_25cc981d PS2, Line 33: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c9a61b59_a7f03990 PS2, Line 37: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/617cdcf3_fa770312 PS2, Line 60: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/70084135_429c4cdd PS2, Line 68: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/05902ac9_dcf98f93 PS2, Line 74: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6bf81d03_8a1b39bd PS2, Line 76: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/bb3e40e8_6508c518 PS2, Line 84: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0afc95a0_034120cb PS2, Line 92: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c7dcb091_04e2269e PS2, Line 99: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fd9d5b68_95fb6360 PS2, Line 104: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1320d2fc_c13546d1 PS2, Line 107: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/674693b4_f7c53f3e PS2, Line 112: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/90b3c06b_21bcf67a PS2, Line 119: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3284df31_8a938fc9 PS2, Line 132: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7e53e815_c27cc8c3 PS2, Line 141: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/47e8fb2e_f3827c36 PS2, Line 147: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e1538261_8c849c42 PS2, Line 163: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/dd53e836_542781b3 PS2, Line 170: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/470b6374_11582e71 PS2, Line 176: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a69d4c44_db78d6c4 PS2, Line 178: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/eb3d7220_ad0095e4 PS2, Line 180: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c2cf749a_3d5aae05 PS2, Line 192: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9939be1d_8e77d34a PS2, Line 199: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e7bc6e08_300ad3f4 PS2, Line 204: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ce51eb94_14054e58 PS2, Line 208: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5a9ac628_176f168d PS2, Line 217: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b61f8f03_24b2d1a3 PS2, Line 225: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ceb824e9_98b99af5 PS2, Line 231: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8f0010f8_a8a34cf2 PS2, Line 236: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/59d99bd4_4b07928b PS2, Line 241: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2dbe2aba_7982cd25 PS2, Line 247: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c262b4a0_1672ca6b PS2, Line 252: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/675d153d_47997e1b PS2, Line 254: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/efa6b1b4_33885e6d PS2, Line 263: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fb81194a_8552d838 PS2, Line 270: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a8542b08_3d11fe70 PS2, Line 274: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/80ad855c_7492bf2b PS2, Line 279: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/19d8a976_b808c377 PS2, Line 284: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8b9237ad_71bdcdb7 PS2, Line 291: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/cb718031_6948ad8e PS2, Line 299: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/db9d1bfc_1ec27688 PS2, Line 304: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f0fc8e16_4ca98052 PS2, Line 306: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a070a01b_2567d968 PS2, Line 312: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/16b0a6f7_977c7123 PS2, Line 314: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/194889fd_4b93ef03 PS2, Line 319: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/db17df23_eb4bab5c PS2, Line 324: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a73aba01_ee85bd0b PS2, Line 330: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f3be4b6c_75740269 PS2, Line 339: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6da20596_d2177915 PS2, Line 343: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3e506edd_f001d02f PS2, Line 347: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8f7a4da9_d584e833 PS2, Line 353: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/690eda94_88961eaa PS2, Line 363: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d68b05ff_1b48734e PS2, Line 365: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b158f9f1_9407b050 PS2, Line 370: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b776e142_440ae71b PS2, Line 376: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d872e1fe_3a3fd855 PS2, Line 378: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3bd13836_460792ed PS2, Line 396: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3f12ec1e_d89ab1eb PS2, Line 400: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/32d64c2a_772dbb23 PS2, Line 405: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0caa2187_d59877be PS2, Line 412: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/42b79755_3c48f69b PS2, Line 418: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/524669da_6655ef6f PS2, Line 422: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d67acc96_08596635 PS2, Line 424: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c054e913_83f47c47 PS2, Line 426: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5d256010_ccd9e332 PS2, Line 428: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3605653c_e7062f00 PS2, Line 438: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/93e0906a_692586fd PS2, Line 447: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/20791b26_511665f3 PS2, Line 453: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e6d7e78c_34c4bf25 PS2, Line 458: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b72bf9bd_f9209e8f PS2, Line 463: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/18e21d75_7f06eb86 PS2, Line 473: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/689778bb_56c8c632 PS2, Line 481: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/93fec94e_b993d9cc PS2, Line 486: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/384eff85_9e678997 PS2, Line 491: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7b53b9f5_b09e9288 PS2, Line 498: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e1773db4_e02c00c5 PS2, Line 503: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/70fbe1e5_fa93300e PS2, Line 507: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f86e2ebf_51cf44fe PS2, Line 516: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0d4b6348_5d89573d PS2, Line 520: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f2778969_febd92ed PS2, Line 529: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/11a6bc4a_234feee7 PS2, Line 533: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b6d03245_4f85dbed PS2, Line 539: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7e045aa3_ddf0eefc PS2, Line 543: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/abd09815_706d859f PS2, Line 551: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/44c3ce7b_52835f16 PS2, Line 555: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/445920bd_ab5043e1 PS2, Line 560: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c0f37e26_c5eb843b PS2, Line 564: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/98f04655_63e44b75 PS2, Line 566: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/69c580ab_efa22beb PS2, Line 570: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ed9ad0c2_7442a352 PS2, Line 571: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b7f0716f_f53386a0 PS2, Line 575: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7a2ee936_8faeee94 PS2, Line 582: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c21131d5_c4028e81 PS2, Line 588: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/edb67073_b0b02fce PS2, Line 594: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/431fa96e_b764c55f PS2, Line 601: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/181d8316_4c602d0b PS2, Line 605: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8e695b37_91cac3f6 PS2, Line 609: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/aaf513fc_f76cb723 PS2, Line 610: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/efa856d9_798dab78 PS2, Line 614: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e8ca2114_bd6ab4fd PS2, Line 623: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a079383b_69aeec1e PS2, Line 631: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/515396d2_ed06f7d3 PS2, Line 637: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/090b2870_603a9f4b PS2, Line 646: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/cd8bc089_76d37c4f PS2, Line 654: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6d78702b_b01cd34e PS2, Line 659: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/949e768c_e2cffb79 PS2, Line 676: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6205b6d5_582e39b3 PS2, Line 682: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c78a330b_05c1615b PS2, Line 687: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/29be271d_e1bf7979 PS2, Line 699: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/bcb99591_ef44bef7 PS2, Line 704: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7104ebe8_aa2501d5 PS2, Line 708: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fb90e8db_785bf0a1 PS2, Line 713: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3832f121_7f90a6aa PS2, Line 722: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ab528dd2_a6bb154c PS2, Line 725: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5f2521e4_3bce0d26 PS2, Line 728: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/12bdae90_851e2d9e PS2, Line 733: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/04f97538_1ad46634 PS2, Line 734: ISDRProprietaryApplicationTemplate ::= [PRIVATE 0] SEQUENCE { -- Tag 'E0' trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4abc3513_d7a4c456 PS2, Line 741: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8dc11d33_3c636e4b PS2, Line 748: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/01697410_543cafd6 PS2, Line 752: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6fa11346_03638f5c PS2, Line 756: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/030af432_5bfbcee4 PS2, Line 760: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5984e98b_c0f45581 PS2, Line 774: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f984e7ed_4b03b080 PS2, Line 779: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2f77effa_9fa241ea PS2, Line 784: trailing whitespace File smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/eb45d9e5_cb1d2c47 PS2, Line 1: -----BEGIN CERTIFICATE----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d68115d7_13abd76c PS2, Line 2: MIICUTCCAfigAwIBAgIJALh086v6bETTMAoGCCqGSM49BAMCMEQxEDAOBgNVBAMM DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0872f920_7d9c9e47 PS2, Line 3: B1Rlc3QgQ0kxETAPBgNVBAsMCFRFU1RDRVJUMRAwDgYDVQQKDAdSU1BURVNUMQsw DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/24115a90_6e56ea16 PS2, Line 4: CQYDVQQGEwJJVDAgFw0yMDA0MDEwODI3NTFaGA8yMDU1MDQwMTA4Mjc1MVowRDEQ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/55dd20c2_5023bf8b PS2, Line 5: MA4GA1UEAwwHVGVzdCBDSTERMA8GA1UECwwIVEVTVENFUlQxEDAOBgNVBAoMB1JT DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f9d9c62b_063163bf PS2, Line 6: UFRFU1QxCzAJBgNVBAYTAklUMFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABCeH DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2bd8c872_29f67cf9 PS2, Line 7: tNVu2CSp5r4E4Yh/a5i6/rjHY/UoN/cBE+k2Tt2+E5vAx95+Fo8eXNDBhTT8UGTm DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3c982f98_35f05ea3 PS2, Line 8: T2htxTMnyn8dzqhaKZSjgc8wgcwwHQYDVR0OBBYEFMC8cLo2kp1DtGf/V1cFMOV6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2fdd2a69_1b525724 PS2, Line 9: uPzYMA8GA1UdEwEB/wQFMAMBAf8wFwYDVR0gAQH/BA0wCzAJBgdngRIBAgEAMA4G DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b0a65782_3085eb0b PS2, Line 10: A1UdDwEB/wQEAwIBBjAOBgNVHREEBzAFiAOINwEwYQYDVR0fBFowWDAqoCigJoYk DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a1e5f89e_e958f690 PS2, Line 11: aHR0cDovL2NpLnRlc3QuZXhhbXBsZS5jb20vQ1JMLUEuY3JsMCqgKKAmhiRodHRw DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9123f282_1e0fecb5 PS2, Line 12: Oi8vY2kudGVzdC5leGFtcGxlLmNvbS9DUkwtQi5jcmwwCgYIKoZIzj0EAwIDRwAw DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/40ca0688_693fbd9b PS2, Line 13: RAIgPYrf0CKl0FBMUaHx5xS1duTDbQ4wBZN3qKBeNniuux0CIHBek2vLfoANAdtt DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1a83871d_510f0cdb PS2, Line 14: f5u5Ce6DVC2oIfpn5UnS24F3oMqM DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1f0f80c9_157ad076 PS2, Line 15: -----END CERTIFICATE----- DOS line endings File smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f8386558_de7ef951 PS2, Line 1: -----BEGIN CERTIFICATE----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e3bcb824_cf00dda2 PS2, Line 2: MIICUDCCAfegAwIBAgIJALh086v6bETTMAoGCCqGSM49BAMCMEQxEDAOBgNVBAMM DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/36c87e56_11565788 PS2, Line 3: B1Rlc3QgQ0kxETAPBgNVBAsMCFRFU1RDRVJUMRAwDgYDVQQKDAdSU1BURVNUMQsw DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f3fdec2c_c9f0b108 PS2, Line 4: CQYDVQQGEwJJVDAgFw0yMDA0MDEwODI3NTFaGA8yMDU1MDQwMTA4Mjc1MVowRDEQ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fe919cc0_91966038 PS2, Line 5: MA4GA1UEAwwHVGVzdCBDSTERMA8GA1UECwwIVEVTVENFUlQxEDAOBgNVBAoMB1JT DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/bf772267_d1e2a00c PS2, Line 6: UFRFU1QxCzAJBgNVBAYTAklUMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAElAZX DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/14207fb1_d1d0553c PS2, Line 7: pnPcKI+J1S6opHcEmSeR+cNLADbmM+LQy6lFTWXbMusXmBeZ0vJDiO4rlcEJRUbJ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/511e8f0c_843c4a01 PS2, Line 8: eQHOrrqWUJGaLiDSKaOBzzCBzDAdBgNVHQ4EFgQU9UFyvfmKldZcvriKOKHBHYAK DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2679370e_dee4c8df PS2, Line 9: hcMwDwYDVR0TAQH/BAUwAwEB/zAXBgNVHSABAf8EDTALMAkGB2eBEgECAQAwDgYD DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/51a440b6_dc1257ce PS2, Line 10: VR0PAQH/BAQDAgEGMA4GA1UdEQQHMAWIA4g3ATBhBgNVHR8EWjBYMCqgKKAmhiRo DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ef55c406_515ada8d PS2, Line 11: dHRwOi8vY2kudGVzdC5leGFtcGxlLmNvbS9DUkwtQS5jcmwwKqAooCaGJGh0dHA6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/48101e25_d7df9201 PS2, Line 12: Ly9jaS50ZXN0LmV4YW1wbGUuY29tL0NSTC1CLmNybDAKBggqhkjOPQQDAgNHADBE DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0006050f_a91b3960 PS2, Line 13: AiBSdWqvwgIKbOy/Ll88IIklEP8pdR0pi9OwFdlgWk/mfQIgV5goNuTSBd3S5sPB DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fba35281_bd9ff306 PS2, Line 14: tFWTf2tuSTtgL9G2bDV0iak192s= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/526ff688_4394850c PS2, Line 15: -----END CERTIFICATE----- DOS line endings File smdpp-data/certs/CertificateIssuer/CI-csr.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7b4aecf5_1711a013 PS2, Line 1: #openssl x509 extfile params DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e25f5016_ac547291 PS2, Line 2: extensions = extend DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/79d41142_e0511f41 PS2, Line 3: # This prevent the user to be prompted for values DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/131da3aa_82379ab8 PS2, Line 4: prompt = no DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4bb17b12_6241069a PS2, Line 5: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/765d69f5_ea52f47a PS2, Line 6: distinguished_name = dn-param DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2c83dfcb_3f03074b PS2, Line 7: [dn-param] # DN fields DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0bf4135e_8701ff0f PS2, Line 8: CN = Test CI DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2f526434_6c6605b3 PS2, Line 9: OU = TESTCERT DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2f5e031e_0b54d4ea PS2, Line 10: O = RSPTEST DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b197a9ea_b302065b PS2, Line 11: C = IT DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3766f8a8_a9576923 PS2, Line 12: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4d73f8db_cdcb472d PS2, Line 13: # Extensions for the Test CI DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/85232d9b_3e41983b PS2, Line 14: [extend] # openssl extensions DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/82a6729c_3d2165da PS2, Line 15: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7ac3e234_ab037411 PS2, Line 16: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/eb9fffdf_035471c5 PS2, Line 17: basicConstraints = critical, CA:true DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/afc08d3b_1b28410f PS2, Line 18: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a89e2446_aaa59073 PS2, Line 19: certificatePolicies=critical,2.23.146.1.2.1.0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/98a55cfd_7e80fc9f PS2, Line 20: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/dfa6ea5a_6796d2bc PS2, Line 21: keyUsage =critical, keyCertSign, cRLSign DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/de12a95d_b12428ab PS2, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/13e2c8a2_4bea0c4c PS2, Line 23: subjectAltName = RID:2.999.1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4daa4570_738e593e PS2, Line 24: DOS line endings File smdpp-data/certs/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b684d768_347e38e3 PS2, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5c302573_6d9be1eb PS2, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABC7uB8ltAFvlGV95rR2tzR03jKMJ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0273afda_e4f1db64 PS2, Line 3: XkT3LupBDwjHVhIskGPJZbf8hSnAyk6bT2WWnCg8ZWNkV4dxGPbRFy1qI2U= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/844c52b4_d57ff656 PS2, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp-data/certs/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/910e0f1c_c14c57fa PS2, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6476ca45_7f2407a4 PS2, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEKy6bRdNRwJr0DpFDg6GQOEfyYH3m DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8258f3b9_7da70a91 PS2, Line 3: DverJcQOA/jbtlCOFFdQjCvgAXNH7Pob+fd159B+gF5S4ZiLe1hacRGuMw== DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8493bf32_3418e44c PS2, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp-data/certs/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/300f57bf_288e1fcc PS2, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b896d191_ccc9a6a0 PS2, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a9c25994_0ecdb723 PS2, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9b8fef53_3b187f90 PS2, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/60384577_284899d7 PS2, Line 5: MHgCAQEEIAwXNVwBHQ/o19rdY/GXhc9sUcvNRmroi+j4G8EFiEb2oAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2c8707f0_a50032ad PS2, Line 6: CAEBB6FEA0IABC7uB8ltAFvlGV95rR2tzR03jKMJXkT3LupBDwjHVhIskGPJZbf8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3f7ee2e9_737c47f9 PS2, Line 7: hSnAyk6bT2WWnCg8ZWNkV4dxGPbRFy1qI2U= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a99017ed_19d6e32b PS2, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp-data/certs/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fd4dc606_5f5105ee PS2, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d5291498_9b940b9c PS2, Line 2: BggqhkjOPQMBBw== DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7c2f053b_80f9a846 PS2, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/131d2916_f84cd648 PS2, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/b9d7f9a1_cbf6a8b5 PS2, Line 5: MHcCAQEEIJwyoJXUiELZ/6QE9xJRKqLFQloaJjhqtqFF1YEeA5FBoAoGCCqGSM49 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5194b932_d7241f5a PS2, Line 6: AwEHoUQDQgAEKy6bRdNRwJr0DpFDg6GQOEfyYH3mDverJcQOA/jbtlCOFFdQjCvg DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c3b1b9fa_8583bb46 PS2, Line 7: AXNH7Pob+fd159B+gF5S4ZiLe1hacRGuMw== DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0690724c_2bd2b6de PS2, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp-data/certs/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a1cefeab_56f2feba PS2, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3e29724f_66d0240c PS2, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABHNhhV5ZAmSyUscaYGKgIeJ7Rvdg DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/cb73a26b_1998df36 PS2, Line 3: uBOCBqf3RCDvi8Vai5iNFlj51w06LYSAqt9k5ixNcSfeWgorkXqUP0R0qt0= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3cf8ed6e_2262dc83 PS2, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp-data/certs/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6d195058_230221c4 PS2, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4af98df2_334b1869 PS2, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPi11oQYiEhbCruj61YT3eWM8+URo DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/bf19710b_86073b2c PS2, Line 3: G17HWpZlP19AHEdq451UbAMtMtAHCnuG5dzrqt3zHKXCdmwZa9ebwhoBgA== DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c7edfaa3_d8520e96 PS2, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp-data/certs/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6dcb9334_ad77ccae PS2, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f24c89dc_0fddbb01 PS2, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4759aac5_81720aa6 PS2, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9e6eaccf_e8c01239 PS2, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2a58fc08_002af572 PS2, Line 5: MHgCAQEEIJyuLhpWB6nVeDgu7pMuJR9SME+G7rHxcIzb08B74s09oAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/60f97e1a_e76873ee PS2, Line 6: CAEBB6FEA0IABHNhhV5ZAmSyUscaYGKgIeJ7RvdguBOCBqf3RCDvi8Vai5iNFlj5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4b47d358_fff90a95 PS2, Line 7: 1w06LYSAqt9k5ixNcSfeWgorkXqUP0R0qt0= DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/faff36db_309c8beb PS2, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp-data/certs/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/bcf75a10_c519f2f1 PS2, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/49e539a7_75ed4146 PS2, Line 2: BggqhkjOPQMBBw== DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6e258b30_3a6887ae PS2, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/49c8efd1_e4806ab4 PS2, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3a40a5c3_82ddd4e7 PS2, Line 5: MHcCAQEEIGaTEUljnbqsHcPTBsWL0t/SL3O/Y6yGMZgykLV/kJNFoAoGCCqGSM49 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7e60aee5_a9d42fb5 PS2, Line 6: AwEHoUQDQgAEPi11oQYiEhbCruj61YT3eWM8+URoG17HWpZlP19AHEdq451UbAMt DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4db73d9d_a78fda4e PS2, Line 7: MtAHCnuG5dzrqt3zHKXCdmwZa9ebwhoBgA== DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1977e034_8450722b PS2, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.csr.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f8c91b74_b2208ac5 PS2, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e16f94a6_591202cf PS2, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ac3330db_5b3724aa PS2, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/55504087_bf8f05a7 PS2, Line 4: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1ad80c83_34af06aa PS2, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/62d1540c_c685a3f5 PS2, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d02cd242_07763045 PS2, Line 7: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/52e32eec_fb67b406 PS2, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/13228a99_9c8ec3ac PS2, Line 9: CN = testsmdpplus2.example.com DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5bf5ccb2_7bc27815 PS2, Line 10: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.ext.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6ea26409_4f9c0ab7 PS2, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f7373b18_733d1a46 PS2, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/cea63256_864892de PS2, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/577e5914_4f6d504c PS2, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/973a1899_833a756c PS2, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/858f8ff0_c26bdc7d PS2, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d0863cc7_15483ede PS2, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6af01d13_7da8a2aa PS2, Line 8: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6b01902e_00688efb PS2, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a2399a61_ed8ced36 PS2, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/767b0753_91069c7c PS2, Line 11: subjectAltName = DNS:testsmdpplus2.example.com, RID:2.999.12 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ff590711_14711f0b PS2, Line 12: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/45648c2f_13052484 PS2, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/25457d13_5591446a PS2, Line 14: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.csr.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9522a42a_53288e49 PS2, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a760dc5a_816c9acd PS2, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7c71c2e0_0db91050 PS2, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/91b8f061_e491530c PS2, Line 4: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/625e20cd_8a0fa500 PS2, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/aacb51a2_2dd8f709 PS2, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a8e7fb4a_05dda66f PS2, Line 7: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a2080b60_db3c90c8 PS2, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e7943010_a14d3013 PS2, Line 9: CN = testsmdpplus4.example.com DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5173fe09_6ddcec79 PS2, Line 10: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.ext.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c604712d_2d1bc930 PS2, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/551fbcb5_77f9d438 PS2, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/09144c99_3773ea81 PS2, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9bc82b5e_00712973 PS2, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/77d7b5b7_c5c18360 PS2, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d7795a4f_b15adcdf PS2, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c01047e6_32d9ee46 PS2, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/aea86e03_97238f73 PS2, Line 8: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c4fbfed5_2521a2f4 PS2, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c1bb80a9_6ad14a00 PS2, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/0ded580a_4160dee8 PS2, Line 11: subjectAltName = DNS:testsmdpplus4.example.com, RID:2.999.14 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ceaa3571_5b872f88 PS2, Line 12: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/569fac14_8e6454af PS2, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/dd5fdb9c_686ab49d PS2, Line 14: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.csr.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8f7fc3ee_32feb7de PS2, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d591e270_ef107473 PS2, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/f4d3a4c5_4ebd2802 PS2, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/69ba95ab_3ca2829b PS2, Line 4: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/934f8dff_f3bdb021 PS2, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/70ee3278_cdceb4ee PS2, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8445642d_a46f8e43 PS2, Line 7: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3f9355bc_e6c658b3 PS2, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8832fb3e_eb667ba2 PS2, Line 9: CN = testsmdpplus8.example.com DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7334ad75_920b54af PS2, Line 10: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.ext.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4915639f_b329d6af PS2, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/1cc6f7ec_97b1441b PS2, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a2627aba_c6b94df2 PS2, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/99d9d865_1714360b PS2, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/bd17ec9b_d0c553c1 PS2, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4c108b1d_cbd8845a PS2, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3b7c12e8_4a07018b PS2, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/606a1f7f_ad65d83a PS2, Line 8: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/feb615cc_3860735e PS2, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/64a88170_9d105ad7 PS2, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/4f06a839_7111627f PS2, Line 11: subjectAltName = DNS:testsmdpplus8.example.com, RID:2.999.18 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/6c9636ec_276fbc74 PS2, Line 12: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/af560ac4_22435902 PS2, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/91ff3796_a0b90f94 PS2, Line 14: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS.csr.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/433389c8_dafab4ac PS2, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/fd4fceba_ffe0e6d0 PS2, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/2fa0ccf4_4ec8725c PS2, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8f181baa_93d438df PS2, Line 4: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d8a55c68_54eb1433 PS2, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/04c6eb24_55793a63 PS2, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/97f7711d_4bb03ed1 PS2, Line 7: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a15cce7c_4d8ee7dc PS2, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d7a1c7e7_f20b44f6 PS2, Line 9: CN = testsmdpplus1.example.com DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/9c44a237_b1f4d70a PS2, Line 10: DOS line endings File smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS.ext.cnf: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/ac02b327_a050b9bb PS2, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/81fea908_ea24a636 PS2, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/3e59759b_504349d3 PS2, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a58ea667_a002e548 PS2, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/a39e5258_b5421c98 PS2, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/e1c21f28_3ebd5f79 PS2, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/7fb32c9e_eee2fae8 PS2, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/5e8f3c70_aac60e87 PS2, Line 8: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/8eaec565_94066273 PS2, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/58a50cd2_dce55bfb PS2, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/46c4c9b5_ac5ef5e7 PS2, Line 11: subjectAltName = DNS:testsmdpplus1.example.com, RID:2.999.10 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c4603ec4_4cb93cbb PS2, Line 12: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/20fcdc53_747295f4 PS2, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/d42fe967_4a5c6d45 PS2, Line 14: DOS line endings File tests/test_esim_bsp.py: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13458): https://gerrit.osmocom.org/c/pysim/+/35461/comment/c95c4be0_521a5e5e PS2, Line 73: """This test verifies whether some fully encoded/encrypted/MACed bound profile pacakge can be properly 'pacakge' may be misspelled - perhaps 'package'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11 Gerrit-Change-Number: 35461 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Jan 2024 22:53:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in pysim[master]: Initial work on a SM-DP+ for GSMA consumer eSIM RSP
by laforge 05 Jan '24

05 Jan '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35461?usp=email ) Change subject: Initial work on a SM-DP+ for GSMA consumer eSIM RSP ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11 Gerrit-Change-Number: 35461 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Jan 2024 22:53:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in pysim[master]: Add pySim.esim.bsp module implementing BSP (BPP Protection Protocol)
by laforge 05 Jan '24

05 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35488?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add pySim.esim.bsp module implementing BSP (BPP Protection Protocol) ...................................................................... Add pySim.esim.bsp module implementing BSP (BPP Protection Protocol) This is the protocol used for the ES8+ interface between SM-DP+ and the eUICC in the GSMA eSIM system. Change-Id: Ic461936f2e68e1e6f7faab33d06acf3063e261e7 --- A pySim/esim/__init__.py A pySim/esim/bsp.py M requirements.txt A tests/test_esim_bsp.py 4 files changed, 395 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/35488/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic461936f2e68e1e6f7faab33d06acf3063e261e7 Gerrit-Change-Number: 35488 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: GTPv2_Emulation: Improve routing messages to client
by pespin 05 Jan '24

05 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35490?usp=email ) Change subject: GTPv2_Emulation: Improve routing messages to client ...................................................................... GTPv2_Emulation: Improve routing messages to client Before this patch, for instance, registering an IMSI would not necessarily mean the messaged ended up in the client registering it, due to how the code paths were being handled. Ideally the code should create a CLIENT candidate list based on all registered matches, and then remove duplicates and finally send message to each CLIENT in the resulting list. That's really not needed as of now though. Change-Id: If253a2b8991f0caf685058238df9a7c997983e27 --- M library/GTPv2_Emulation.ttcn 1 file changed, 53 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/35490/1 diff --git a/library/GTPv2_Emulation.ttcn b/library/GTPv2_Emulation.ttcn index 0b2cb4f..eb2b977 100644 --- a/library/GTPv2_Emulation.ttcn +++ b/library/GTPv2_Emulation.ttcn @@ -107,6 +107,16 @@ GTP2_ConnHdlr vc_conn }; +private function f_teid_known(OCT4 teid) runs on GTPv2_Emulation_CT return boolean { + var integer i; + for (i := 0; i < sizeof(TidTable); i := i+1) { + if (isbound(TidTable[i].teid) and TidTable[i].teid == teid) { + return true; + } + } + return false; +} + private function f_comp_by_teid(OCT4 teid) runs on GTPv2_Emulation_CT return GTP2_ConnHdlr { var integer i; for (i := 0; i < sizeof(TidTable); i := i+1) { @@ -139,6 +149,16 @@ mtc.stop; } +private function f_imsi_known(hexstring imsi) runs on GTPv2_Emulation_CT return boolean { + var integer i; + for (i := 0; i < sizeof(ImsiTable); i := i+1) { + if (isbound(ImsiTable[i].imsi) and ImsiTable[i].imsi == imsi) { + return true; + } + } + return false; +} + private function f_comp_by_imsi(hexstring imsi) runs on GTPv2_Emulation_CT return GTP2_ConnHdlr { var integer i; for (i := 0; i < sizeof(ImsiTable); i := i+1) { @@ -540,30 +560,24 @@ /* route inbound GTP2-C based on TEID, SEQ or IMSI */ [] GTP2C.receive(Gtp2cUnitdata:?) -> value g2c_ud { var template hexstring imsi_t := f_gtp2c_extract_imsi(g2c_ud.gtpc); - if (not ispresent(g2c_ud.gtpc.tEID) or g2c_ud.gtpc.tEID == int2oct(0, 4)) { - /* if this is a response, route by SEQ */ - if (match(g2c_ud.gtpc, tr_PDU_GTP2C_msgtypes(gtp2_responses)) - and f_seq_known(g2c_ud.gtpc.sequenceNumber)) { - vc_conn := f_comp_by_seq(g2c_ud.gtpc.sequenceNumber); - CLIENT.send(g2c_ud.gtpc) to vc_conn; - } else { - SendToUdMsgTable(g2c_ud); - TEID0.send(g2c_ud.gtpc); - } - } else if (ispresent(g2c_ud.gtpc.tEID) and g2c_ud.gtpc.tEID != int2oct(0, 4)) { - vc_conn := f_comp_by_teid(g2c_ud.gtpc.tEID); - CLIENT.send(g2c_ud.gtpc) to vc_conn; - } else if (isvalue(imsi_t)) { + if (isvalue(imsi_t) and f_imsi_known(valueof(imsi_t))) { vc_conn := f_comp_by_imsi(valueof(imsi_t)); CLIENT.send(g2c_ud.gtpc) to vc_conn; + } else if ((ispresent(g2c_ud.gtpc.tEID) and g2c_ud.gtpc.tEID != '00000000'O) + and f_teid_known(g2c_ud.gtpc.tEID)) { + vc_conn := f_comp_by_teid(g2c_ud.gtpc.tEID); + CLIENT.send(g2c_ud.gtpc) to vc_conn; + } else if ((not ispresent(g2c_ud.gtpc.tEID) or g2c_ud.gtpc.tEID == '00000000'O) + and f_teid_known('00000000'O)) { + vc_conn := f_comp_by_teid(g2c_ud.gtpc.tEID); + CLIENT.send(g2c_ud.gtpc) to vc_conn; + /* if this is a response, route by SEQ: */ + } else if (match(g2c_ud.gtpc, tr_PDU_GTP2C_msgtypes(gtp2_responses)) + and f_seq_known(g2c_ud.gtpc.sequenceNumber)) { + vc_conn := f_comp_by_seq(g2c_ud.gtpc.sequenceNumber); + CLIENT.send(g2c_ud.gtpc) to vc_conn; } else { - /* Send to all clients */ - var integer i; - for (i := 0; i < sizeof(TidTable); i := i+1) { - if (isbound(TidTable[i].teid) and TidTable[i].teid == teid) { - CLIENT.send(g2c_ud.gtpc) to TidTable[i].vc_conn; - } - } + SendToUdMsgTable(g2c_ud); } /* remove sequence number if response was received */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If253a2b8991f0caf685058238df9a7c997983e27 Gerrit-Change-Number: 35490 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[XL] Change in libosmocore[master]: isdn: initial implementation of the V.110 TA
by fixeria 05 Jan '24

05 Jan '24

Attention is currently required from: falconia, laforge, manawyrm, roox. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35444?usp=email ) Change subject: isdn: initial implementation of the V.110 TA ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5716bd6fd0201ee7a7a29e72f775972cd374082f Gerrit-Change-Number: 35444 Gerrit-PatchSet: 13 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Jan 2024 17:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: tests/tdef: improve test output (use OSMO_T_FMT[_ARGS])
by fixeria 05 Jan '24

05 Jan '24

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35481?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: tests/tdef: improve test output (use OSMO_T_FMT[_ARGS]) ...................................................................... tests/tdef: improve test output (use OSMO_T_FMT[_ARGS]) Change-Id: Ie216bcf93b96610c46c6e616835a6793772e2baa Related: e30d22a0 "tests/tdef: also test OSMO_TDEF_US and negative T values" --- M tests/tdef/tdef_test.c M tests/tdef/tdef_test.ok 2 files changed, 26 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/35481/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie216bcf93b96610c46c6e616835a6793772e2baa Gerrit-Change-Number: 35481 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: fsm: fix OSMO_T_FMT_ARGS: add missing braces
by fixeria 05 Jan '24

05 Jan '24

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35482?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: fsm: fix OSMO_T_FMT_ARGS: add missing braces ...................................................................... fsm: fix OSMO_T_FMT_ARGS: add missing braces Change-Id: I3ea7cbc8a51d310d9929ca5a805eb1d3d3880793 --- M include/osmocom/core/fsm.h 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/35482/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3ea7cbc8a51d310d9929ca5a805eb1d3d3880793 Gerrit-Change-Number: 35482 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision
by fixeria 05 Jan '24

05 Jan '24

Attention is currently required from: laforge, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email ) Change subject: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision ...................................................................... Patch Set 6: (1 comment) Patchset: PS4: > So if it's not a lot of work, yes, having _uS granularity would be nice. In the case of `OSMO_TDEF_MS`, I am simply migrating this tdef API to use the **existing** `osmo_fsm_..._ms()` API. There is currently no `osmo_fsm_..._us()` API, so supporting `OSMO_TDEF_US` would mean adding the missing osmo_fsm API. This is indeed more work, and I don't think I can spend even more time on this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4ee89e7e32e86f74cd215f5cbfa44ace5426c1 Gerrit-Change-Number: 35466 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jan 2024 15:48:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0