January 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: DAHDI: Log hexdump of TX at level DEBUG, not ERROR
by laforge 07 Jan '24

07 Jan '24

Attention is currently required from: laforge. laforge has uploaded a new patch set (#2) to the change originally created by keith. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35494?usp=email ) Change subject: DAHDI: Log hexdump of TX at level DEBUG, not ERROR ...................................................................... DAHDI: Log hexdump of TX at level DEBUG, not ERROR This fixes Change-Id I447a2360757fed97ed50f9db1e2efbf2f90e46a0 where log messages received more context. However, by accident, one log statement got elevated from DEBUG to ERROR level. Let's revert that accident. Change-Id: I29aa82c8586d846a861e62d90d376ff9cfaa9654 --- M src/input/dahdi.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/94/35494/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I29aa82c8586d846a861e62d90d376ff9cfaa9654 Gerrit-Change-Number: 35494 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-abis[master]: DAHDI: Log hexdump of TX at level DEBUG, not ERROR
by keith 06 Jan '24

06 Jan '24

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35494?usp=email ) Change subject: DAHDI: Log hexdump of TX at level DEBUG, not ERROR ...................................................................... DAHDI: Log hexdump of TX at level DEBUG, not ERROR Change-Id: I29aa82c8586d846a861e62d90d376ff9cfaa9654 --- M src/input/dahdi.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/94/35494/1 diff --git a/src/input/dahdi.c b/src/input/dahdi.c index efed38d..b9a3fcf 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -259,7 +259,7 @@ return 0; } - LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "TX: %s\n", osmo_hexdump(msg->data, msg->len)); + LOGPITS(e1i_ts, DLMI, LOGL_DEBUG, "TX: %s\n", osmo_hexdump(msg->data, msg->len)); lapd_transmit(e1i_ts->lapd, sign_link->tei, sign_link->sapi, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I29aa82c8586d846a861e62d90d376ff9cfaa9654 Gerrit-Change-Number: 35494 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: ctrl: Fix missing reply in set_bts_cell_reselection_offset
by matanp 06 Jan '24

06 Jan '24

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35492?usp=email ) Change subject: ctrl: Fix missing reply in set_bts_cell_reselection_offset ...................................................................... ctrl: Fix missing reply in set_bts_cell_reselection_offset Change-Id: Iacdb192dc15ab7e10e06c0dfe0984fc8a5727ecc --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 4312d9d..0c6e280 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -1040,6 +1040,7 @@ struct gsm_bts *bts = cmd->node; bts->si_common.cell_ro_sel_par.present = 1; bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value) / 2; + cmd->reply = "OK"; return CTRL_CMD_REPLY; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iacdb192dc15ab7e10e06c0dfe0984fc8a5727ecc Gerrit-Change-Number: 35492 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in pysim[master]: Add pySim.esim.bsp module implementing BSP (BPP Protection Protocol)
by fixeria 06 Jan '24

06 Jan '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35488?usp=email ) Change subject: Add pySim.esim.bsp module implementing BSP (BPP Protection Protocol) ...................................................................... Patch Set 4: (13 comments) Patchset: PS4: None of my comments are critical, mostly nitpicks. File pySim/esim/bsp.py: https://gerrit.osmocom.org/c/pysim/+/35488/comment/ba37f028_2a518555 PS4, Line 46: blocksize You can simply do a type declaration here: ``` blocksize: int ``` without assigning it to `None`. This is the usual way to declare a property, which is expected to be assigned either statically or by the `__init__()` function. https://gerrit.osmocom.org/c/pysim/+/35488/comment/827c94a6_06d8b2da PS4, Line 47: enum_name unused? https://gerrit.osmocom.org/c/pysim/+/35488/comment/ff19b899_9278e46b PS4, Line 60: __init__ can be removed? https://gerrit.osmocom.org/c/pysim/+/35488/comment/df6270e6_442a67f9 PS4, Line 95: abc.abstractmethod why commented out? https://gerrit.osmocom.org/c/pysim/+/35488/comment/63f83df4_b9453c92 PS4, Line 104: _get_padding Can we re-use the parent's implementation here? ``` return b'\x80' + super()._get_padding(in_len + 1, multiple, padding) ``` https://gerrit.osmocom.org/c/pysim/+/35488/comment/1465d984_6ced45e1 PS4, Line 124: _get_icv Can we pre-calculate the ICV once (e.g. in `__init__()`) and then just use it in `self._{en,de}crypt()`? Or is it supposed to change during the lifetime of a class instance? https://gerrit.osmocom.org/c/pysim/+/35488/comment/2ac9f9bd_96f1a281 PS4, Line 132: % (self.block_nr, b2h(data), b2h(icv JFYI: when using Python's logging, you can pass format string arguments directly to the logging function (without having to render the string using `"..." % (args...)`). This allows for lazy evaluation. https://gerrit.osmocom.org/c/pysim/+/35488/comment/53a536fa_c2a35705 PS4, Line 153: tag <= 255 This still permits negative values, maybe `assert tag in range(256)`? https://gerrit.osmocom.org/c/pysim/+/35488/comment/db5b289f_daa33ea0 PS4, Line 299: return b''.join(plaintext_list) Maybe use list-comprehension here? ``` return b''.join([self.demac_and_decrypt_one(x) for x in ciphertext_list]) ``` https://gerrit.osmocom.org/c/pysim/+/35488/comment/5575602b_efc53722 PS4, Line 310: return b''.join(plaintext_list) Maybe use list-comprehension here? ``` return b''.join([self.demac_only_one(x) for x in ciphertext_list]) ``` File tests/test_esim_bsp.py: https://gerrit.osmocom.org/c/pysim/+/35488/comment/72ff545f_1ab12b90 PS4, Line 62: segment0 = h2b('a048800102810101821a53494d616c6c69616e63652053616d706c652050726f66696c65830a89000123456789012341a506810084008b00a610060667810f010201060667810f010204b08201f8a0058000810101810667810f010201a207a105c60301020aa305a1038b010fa40c830a98001032547698103214a527a109820442210026800198831a61184f10a0000000871002ff33ff01890000010050045553494da682019ea10a8204422100258002022b831b8001019000800102a406830101950108800158a40683010a95010882010a8316800101a40683010195010880015aa40683010a95010882010f830b80015ba40683010a95010882011a830a800101900080015a970082011b8316800103a406830101950108800158a40683010a95010882010f8316800111a40683010195010880014aa40683010a95010882010f8321800103a406830101950108800158a40683010a950108840132a4068301019501088201048321800101a406830101950108800102a406830181950108800158a40683010a950108820104831b800101900080011aa406830101950108800140a40683010a95010882010a8310800101900080015aa40683010a95010882011583158001019000800118a40683010a95010880014297008201108310800101a40683010195010880015a97008201158316800113a406830101950108800148a40683010a95010882010f830b80015ea40683010a95010882011a83258001019000800102a010a406830101950108a406830102950108800158a40683010a950108a33fa0058000810102a13630118001018108303030303030303082020099300d800102810831323334353637383012800200818108313233343536373882020088a241a0058000810103a138a0363010800101810831323334ffffffff8201013010800102810830303030ffffffff820102301080010a810835363738ffffffff830101a182029ea0058000810104a18202933082028f62228202782183027ff18410a0000000871002ff33ff0189000001008b010ac60301810a62118202412183026f078b01028001098801388109082943019134876765621482044221002583026f068b010a8801b8c7022f06621a8202412183026f088b0105800121880140a507c00180c10207ff621a8202412183026f098b0105800121880148a507c00180c10207ff62168202412183026f318b0102800101880190a503c1010a62118202412183026f388b010280010e880120810d0a2e178ce73204000000000000621982044221001a83026f3b8b0108800202088800a504c10200ff62198204422100b083026f3c8b0105800206e08800a504c10200ff621282044221002683026f428b0105800126') not critical, but maybe use multi-line strings (`''' ... '''`) for those large samples? https://gerrit.osmocom.org/c/pysim/+/35488/comment/bfcba2bc_8748f3c1 PS4, Line 72: cosmetic: tabs vs spaces -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic461936f2e68e1e6f7faab33d06acf3063e261e7 Gerrit-Change-Number: 35488 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Jan 2024 19:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Fix missing reply in set_bts_cell_reselection_offset
by daniel 06 Jan '24

06 Jan '24

Attention is currently required from: matanp. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35492?usp=email ) Change subject: ctrl: Fix missing reply in set_bts_cell_reselection_offset ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iacdb192dc15ab7e10e06c0dfe0984fc8a5727ecc Gerrit-Change-Number: 35492 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Jan 2024 19:07:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in pysim[master]: pySim.saip.*: Support for parsing / operating on eSIM profiles
by laforge 06 Jan '24

06 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35491?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.saip.*: Support for parsing / operating on eSIM profiles ...................................................................... pySim.saip.*: Support for parsing / operating on eSIM profiles This commit introduces the capability to parse and encode SimAlliance/TCA "Interoperable Profiles" and apply personalization operations on them. Change-Id: I71c252a214a634e1bd6f73472107efe2688ee6d2 --- A pySim/esim/asn1/saip/PE_Definitions-3.3.1.asn A pySim/esim/saip/__init__.py A pySim/esim/saip/personalization.py A pySim/esim/saip/validation.py A tests/test_esim_saip.py 5 files changed, 1,681 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/91/35491/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71c252a214a634e1bd6f73472107efe2688ee6d2 Gerrit-Change-Number: 35491 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in pysim[master]: add contrib/unber.py utility
by laforge 06 Jan '24

06 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35493?usp=email ) Change subject: add contrib/unber.py utility ...................................................................... add contrib/unber.py utility This tool is a replacement for asn1c 'unber' program with a much more useful/readable output: * contains hexadecimal raw tag values * contains hexdump of value, rather than HTML entities in pseudo-XML Change-Id: I22c1a461ccba04c2c8caaab7ca29ea6ae76e2ea3 --- A contrib/unber.py 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/93/35493/1 diff --git a/contrib/unber.py b/contrib/unber.py new file mode 100755 index 0000000..65262e1 --- /dev/null +++ b/contrib/unber.py @@ -0,0 +1,39 @@ +#!/usr/bin/env python3 + +# A more useful verion of the 'unber' tool provided with asn1c: +# Give a hierarchical decode of BER/DER-encoded ASN.1 TLVs + +import sys +import argparse + +from pySim.utils import bertlv_parse_one, bertlv_encode_tag, b2h, h2b + +def process_one_level(content: bytes, indent: int): + remainder = content + while len(remainder): + tdict, l, v, remainder = bertlv_parse_one(remainder) + #print(tdict) + rawtag = bertlv_encode_tag(tdict) + if tdict['constructed']: + print("%s%s l=%d" % (indent*" ", b2h(rawtag), l)) + process_one_level(v, indent + 1) + else: + print("%s%s l=%d %s" % (indent*" ", b2h(rawtag), l, b2h(v))) + + +option_parser = argparse.ArgumentParser(description='BER/DER data dumper') +group = option_parser.add_mutually_exclusive_group(required=True) +group.add_argument('--file', help='Input file') +group.add_argument('--hex', help='Input hexstring') + + +if __name__ == '__main__': + opts = option_parser.parse_args() + + if opts.file: + with open(opts.file, 'rb') as f: + content = f.read() + elif opts.hex: + content = h2b(opts.hex) + + process_one_level(content, 0) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22c1a461ccba04c2c8caaab7ca29ea6ae76e2ea3 Gerrit-Change-Number: 35493 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-e1d[master]: Automatically reset RIFO on underrun/overflow
by jolly 06 Jan '24

06 Jan '24

Attention is currently required from: laforge, tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email ) Change subject: Automatically reset RIFO on underrun/overflow ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I have no idea how for a strategy when to reset the RIFO buffer. […] RX Buffer fill: 0-----50%D-----D-----150%D My current idea is to define a target delay D that is used for initial fill of the RX buffer. The buffer fill is averaged for several seconds to get the current average delay. If the average fill is below 50% of the D or if it is over 150% of D, the RX buffer fill is reset to D. This way we have a well defined strategy to reset the buffer. Outliers will not cause a reset. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id7ccbfbdb288990c01f185dec79a1022a68b4748 Gerrit-Change-Number: 34554 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sat, 06 Jan 2024 19:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: ts_102_310: Add file definitions resembling ETSI TS 102 310 (EAP)
by fixeria 06 Jan '24

06 Jan '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35486?usp=email ) Change subject: ts_102_310: Add file definitions resembling ETSI TS 102 310 (EAP) ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I532ff2c94021ab1b4520fe2b6988c8960319d208 Gerrit-Change-Number: 35486 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Jan 2024 18:52:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in pysim[master]: pySim.saip.*: Support for parsing / operating on eSIM profiles
by laforge 06 Jan '24

06 Jan '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35491?usp=email ) Change subject: pySim.saip.*: Support for parsing / operating on eSIM profiles ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71c252a214a634e1bd6f73472107efe2688ee6d2 Gerrit-Change-Number: 35491 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 06 Jan 2024 18:49:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0