September 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: oml: ipacc: Remove BSSGP value assignment being overwritten afterwards
by pespin 04 Sep '23

04 Sep '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34293?usp=email ) Change subject: oml: ipacc: Remove BSSGP value assignment being overwritten afterwards ...................................................................... oml: ipacc: Remove BSSGP value assignment being overwritten afterwards bts->gprs.cell.timer is initialized during BTS allocation from bts_cell_timer_default. Later on, during nanobts_gen_set_nse_attr(), the same default values are applied to an internal buffer and immedately later overwritten by the content of bts->gprs.cell.timer. Hence, drop the temporary assignment since it gets overwritten and is basically a NO-OP. This is only an intermediate one-step-at-a-time commit, since anyway that arrive has to be convertd to osmocom tdef, etc. Change-Id: I2a170093e62f726e594d3b9c456087f47d2b4198 --- M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 2 files changed, 36 insertions(+), 15 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index bd61501..814ba41 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -117,8 +117,20 @@ return 0; } -static const uint8_t bts_cell_timer_default[] = - { 3, 3, 3, 3, 3, 10, 3, 10, 3, 10, 3 }; +static const uint8_t bts_cell_timer_default[11] = { + 3, /* blocking timer (T1) */ + 3, /* blocking retries */ + 3, /* unblocking retries */ + 3, /* reset timer (T2) */ + 3, /* reset retries */ + 10, /* suspend timer (T3) in 100ms */ + 3, /* suspend retries */ + 10, /* resume timer (T4) in 100ms */ + 3, /* resume retries */ + 10, /* capability update timer (T5) */ + 3, /* capability update retries */ +}; + static const struct gprs_rlc_cfg rlc_cfg_default = { .parameter = { [RLC_T3142] = 20, diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 9fdbf43..62a6dfb 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -128,19 +128,6 @@ memcpy(buf, bts_sm->gprs.nse.timer, ARRAY_SIZE(bts_sm->gprs.nse.timer)); msgb_tl16v_put(msgb, NM_ATT_IPACC_NS_CFG, 7, buf); - /* all timers in seconds */ - buf[0] = 3; /* blockimg timer (T1) */ - buf[1] = 3; /* blocking retries */ - buf[2] = 3; /* unblocking retries */ - buf[3] = 3; /* reset timer (T2) */ - buf[4] = 3; /* reset retries */ - buf[5] = 10; /* suspend timer (T3) in 100ms */ - buf[6] = 3; /* suspend retries */ - buf[7] = 10; /* resume timer (T4) in 100ms */ - buf[8] = 3; /* resume retries */ - buf[9] = 10; /* capability update timer (T5) */ - buf[10] = 3; /* capability update retries */ - OSMO_ASSERT(ARRAY_SIZE(bts->gprs.cell.timer) < sizeof(buf)); memcpy(buf, bts->gprs.cell.timer, ARRAY_SIZE(bts->gprs.cell.timer)); msgb_tl16v_put(msgb, NM_ATT_IPACC_BSSGP_CFG, 11, buf); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2a170093e62f726e594d3b9c456087f47d2b4198 Gerrit-Change-Number: 34293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libo...
by osmith 04 Sep '23

04 Sep '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34296?usp=email ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libosmcore ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b4dfac9fd36378b20889fb90135be74f8968d5f Gerrit-Change-Number: 34296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 10:15:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libo...
by osmith 04 Sep '23

04 Sep '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34296?usp=email ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libosmcore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b4dfac9fd36378b20889fb90135be74f8968d5f Gerrit-Change-Number: 34296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 10:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libos...
by osmith 04 Sep '23

04 Sep '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34295?usp=email ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libosmcore ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I610ca34babc0b0ac9477622aa7b8360be8f3f59f Gerrit-Change-Number: 34295 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 10:13:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from li...
by osmith 04 Sep '23

04 Sep '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34294?usp=email ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from libosmcore ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34294?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie659879c548b29a08eeb8bf3fc023bf3d7d52aa1 Gerrit-Change-Number: 34294 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 10:12:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: oml: ipacc: Remove BSSGP value assignment being overwritten afterwards
by osmith 04 Sep '23

04 Sep '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34293?usp=email ) Change subject: oml: ipacc: Remove BSSGP value assignment being overwritten afterwards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2a170093e62f726e594d3b9c456087f47d2b4198 Gerrit-Change-Number: 34293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 10:08:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails
by fixeria 04 Sep '23

04 Sep '23

Attention is currently required from: daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: The patch looks good to me in general. Just a few cosmetic things. File src/gsup_client.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/12ce5ea0_… PS2, Line 99: cosmetic: use tabs https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/d7a63c86_… PS2, Line 99: Failed to This sentence looks incomplete: "failed to ..." do what? Not sure why this part is being changed at all, it looks good as it is to me. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 04 Sep 2023 09:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails
by pespin 04 Sep '23

04 Sep '23

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: I'm still seeing problems with tests other than 1st one in ttcn3-dia2gsup-test docker setup when running with this patch. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 04 Sep 2023 09:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: Introduce new error scenario tests
by pespin 04 Sep '23

04 Sep '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... dia2gsup: Introduce new error scenario tests Related: OS#5757 Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea --- M dia2gsup/DIA2GSUP_Tests.ttcn M library/DIAMETER_Templates.ttcn 2 files changed, 234 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/34255/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in libosmo-netif[master]: stream tests: Eliminate timestamps from output
by pespin 04 Sep '23

04 Sep '23

Attention is currently required from: arehbein, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224?usp=email ) Change subject: stream tests: Eliminate timestamps from output ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Thank you both for the input. […] I don't think ASan has anything to do with changing timestamps. In any case, I'm not even sure what's the problem after Daniel's work or even if there's any problem at all. Let me know if you have any specific questions or specific help, if possible with concise questions. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c Gerrit-Change-Number: 34224 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Sep 2023 08:25:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0