September 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA
by lynxis lazus 02 Sep '23

02 Sep '23

Attention is currently required from: daniel, fixeria, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259?usp=email ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Patch Set 2: (9 comments) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/2496ee9c_… PS1, Line 185: gsup_cause2dia(?GMM_CAUSE_ILLEGAL_MS) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]}; > I may actually want to return a Result-Code in some of this instead, I need to check what do we have […] Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/e250c90e_… PS1, Line 187: DIAMETER_ERROR_RAT_NOT_ALLOWED > DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/10339261_… PS1, Line 189: gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]}; > Maybe DIAMETER_AUTHORIZATION_REJECTED would be better. Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/256f4ee2_… PS1, Line 191: DIAMETER_ERROR_UNKOWN_SERVING_NODE > DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/1549bff0_… PS1, Line 192: DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE > 29.272 rel 17: Annex A and Annex B can be used to translate those. […] Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/5b71fda1_… PS1, Line 193: gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]}; > I would send unable to comply here, even it is not defined. Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/a1c0f9dd_… PS1, Line 194: GMM_CAUSE_GSM_AUTH_UNACCEPT > I would remove this. We should never get this error and we don't use it on the hlr so far. Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/cb45648b_… PS1, Line 195: DIAMETER_ERROR_UNKOWN_SERVING_NODE > DIAMETER_MISSING_AVP Done https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/75dedf38_… PS1, Line 196: DIAMETER_ERROR_UNKOWN_SERVING_NODE > DIAMETER_UNABLE_TO_COMPLY Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Sep 2023 15:52:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: rebar3: define a release
by lynxis lazus 02 Sep '23

02 Sep '23

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284?usp=email ) Change subject: rebar3: define a release ...................................................................... Patch Set 1: (2 comments) File README.md: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284/comment/97ab2499_… PS1, Line 37: 1> osmo_dia2gsup:start(). > That's after a new release, so when no release is done (ass seen below), this can still be used, so […] So far I tested it's enough to run rebar3 shell File contrib/systemd/osmo_dia2gsup.service: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284/comment/9dbc3798_… PS1, Line 12: ExecStart=/usr/bin/osmo-dia2gsup forground > are you sure this is correct? sounds like a typo for "foreground" Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b Gerrit-Change-Number: 34284 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Sep 2023 15:51:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: server_cb: use a define for the VENDOR_3GPP code
by lynxis lazus 02 Sep '23

02 Sep '23

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: server_cb: use a define for the VENDOR_3GPP code ...................................................................... server_cb: use a define for the VENDOR_3GPP code Also use a proper variable name Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 --- M src/server_cb.erl 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/82/34282/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 Gerrit-Change-Number: 34282 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo_dia2gsup[master]: gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY
by lynxis lazus 02 Sep '23

02 Sep '23

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY ...................................................................... gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY Change-Id: I7f19bf1fb3676a1302f0d6d7d7450a3f201ba5bb --- M src/server_cb.erl 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/83/34283/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7f19bf1fb3676a1302f0d6d7d7450a3f201ba5bb Gerrit-Change-Number: 34283 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo_dia2gsup[master]: rebar3: define a release
by lynxis lazus 02 Sep '23

02 Sep '23

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: rebar3: define a release ...................................................................... rebar3: define a release Further with the release, rebar3 will also start the application when calling `rebar3 shell`. Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b --- M README.md M contrib/systemd/osmo_dia2gsup.service M rebar.config 3 files changed, 27 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/84/34284/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b Gerrit-Change-Number: 34284 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA
by lynxis lazus 02 Sep '23

02 Sep '23

Attention is currently required from: daniel, fixeria. lynxis lazus has uploaded a new patch set (#2) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Translate GSUP Auth Info Answer error Cause in Diamater AIA Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 --- M src/server_cb.erl 1 file changed, 29 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/59/34259/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmocom-bb[master]: firmware: board: add support for TR-800 target
by fixeria 02 Sep '23

02 Sep '23

Attention is currently required from: falconia, steve-m, tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34297?usp=email ) Change subject: firmware: board: add support for TR-800 target ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I84d564f052f12a25ea3bfb9c78860e9dc6262be8 Gerrit-Change-Number: 34297 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: steve-m <steve(a)steve-m.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: steve-m <steve(a)steve-m.de> Gerrit-Comment-Date: Sat, 02 Sep 2023 14:35:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: gerrit: update to 3.6.6
by laforge 02 Sep '23

02 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34304?usp=email ) Change subject: gerrit: update to 3.6.6 ...................................................................... gerrit: update to 3.6.6 Change-Id: I3935d1c6ac671e4c2ba2db685c9ddf75d77ab7f1 --- M gerrit/Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/gerrit/Dockerfile b/gerrit/Dockerfile index eddec02..8941469 100644 --- a/gerrit/Dockerfile +++ b/gerrit/Dockerfile @@ -1,4 +1,4 @@ -FROM gerritcodereview/gerrit:3.6.3 +FROM gerritcodereview/gerrit:3.6.6 USER root RUN yum -y install zip unzip patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3935d1c6ac671e4c2ba2db685c9ddf75d77ab7f1 Gerrit-Change-Number: 34304 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: gerrit: upgrade to 3.7.4
by laforge 02 Sep '23

02 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34305?usp=email ) Change subject: gerrit: upgrade to 3.7.4 ...................................................................... gerrit: upgrade to 3.7.4 Change-Id: Ie96b0fabd39248d3f20b073b51d163004ae3dd8a --- M gerrit/Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/gerrit/Dockerfile b/gerrit/Dockerfile index 8941469..dec08da 100644 --- a/gerrit/Dockerfile +++ b/gerrit/Dockerfile @@ -1,4 +1,4 @@ -FROM gerritcodereview/gerrit:3.6.6 +FROM gerritcodereview/gerrit:3.7.4 USER root RUN yum -y install zip unzip patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie96b0fabd39248d3f20b073b51d163004ae3dd8a Gerrit-Change-Number: 34305 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: gerrit: upgrade to 3.7.4
by laforge 02 Sep '23

02 Sep '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34305?usp=email ) Change subject: gerrit: upgrade to 3.7.4 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie96b0fabd39248d3f20b073b51d163004ae3dd8a Gerrit-Change-Number: 34305 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 02 Sep 2023 13:14:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0