Attention is currently required from: daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: The patch looks good to me in general. Just a few cosmetic things. File src/gsup_client.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/12ce5ea0_1... PS2, Line 99: cosmetic: use tabs https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285/comment/d7a63c86_0... PS2, Line 99: Failed to This sentence looks incomplete: "failed to ..." do what? Not sure why this part is being changed at all, it looks good as it is to me. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 04 Sep 2023 09:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment